watchdog: rti-wdt: Fix pm_runtime_get_sync() error checking
PATCH 1/1 watchdog: rti-wdt: Fix pm_runtime_get_sync() error checking
If the device is already in a runtime PM enabled state pm_runtime_get_sync() will return 1, so a test for negative value should be used to check for errors.
Fixes 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/watchdog/rti_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/rti_wdt.c +1 -1
@@ -226,7 +226,7 @@ static int rti_wdt_probe(struct platform_device *pdev)pm_runtime_enable (dev); ret =pm_runtime_get_sync (dev); -if (ret) { +if (ret <0 ) {pm_runtime_put_noidle (dev);pm_runtime_disable (&pdev->dev);return dev_err_probe (dev, ret,"runtime pm failed\n" );
Signature · 1 line
2.17.1
Quoted 6 lines · Miaoqian Lin
If the device is already in a runtime PM enabled state
pm_runtime_get_sync()will return 1, so a test for negative value should be used to check for errors.Fixes 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support")Signed-off-by Miaoqian Lin <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 17 lines
--- drivers/watchdog/rti_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/rti_wdt.c +1
-1@@ -226,7 +226,7 @@ static int rti_wdt_probe(struct platform_device *pdev)pm_runtime_enable (dev); ret =pm_runtime_get_sync (dev); -if (ret) { +if (ret <0 ) {pm_runtime_put_noidle (dev);pm_runtime_disable (&pdev->dev);return dev_err_probe (dev, ret,"runtime pm failed\n" );