Skip to contentSkip to conversation

cmd: adc: Add support for storing ADC result in env variable

PATCH Superseded Marek Vasut 2 participants 2 messages Apr 13, 2022 – Apr 14, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: adc: Add support for storing ADC result in env variable

Add the ability to start ADC conversion result in an environment variable. This is useful for further arbitrary processing by the U-Boot scripts.

Cc Fabrice Gasnier <[email protected]>
Cc Simon Glass <[email protected]>
---
 cmd/adc.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
cmd/adc.c +12 -1
index 75739bc8eed..4f548b811ec 100644
@@ -71,6 +71,7 @@ static int do_adc_info(struct cmd_tbl *cmdtp, int flag, int argc,
 static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc,
 			 char *const argv[])
 {
+	char *varname = NULL;
 	struct udevice *dev;
 	unsigned int data;
 	int ret, uV;
@@ -78,6 +79,9 @@ static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc,
 	if (argc < 3)
 		return CMD_RET_USAGE;
 
+	if (argc >= 3)
+		varname = argv[2];
+
 	ret = adc_channel_single_shot(argv[1], simple_strtol(argv[2], NULL, 0),
 				      &data);
 	if (ret) {
@@ -92,6 +96,13 @@ static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc,
 	else
 		printf("%u\n", data);
 
+	if (varname) {
+		if (!adc_raw_to_uV(dev, data, &uV))
+			env_set_ulong(varname, uV);
+		else
+			env_set_ulong(varname, data);
+	}
+
 	return CMD_RET_SUCCESS;
 }
 
@@ -149,7 +160,7 @@ static int do_adc_scan(struct cmd_tbl *cmdtp, int flag, int argc,
 static char adc_help_text[] =
 	"list - list ADC devices\n"
 	"adc info <name> - Get ADC device info\n"
-	"adc single <name> <channel> - Get Single data of ADC device channel\n"
+	"adc single <name> <channel> [varname] - Get Single data of ADC device channel\n"
 	"adc scan <name> [channel mask] - Scan all [or masked] ADC channels";
 
 U_BOOT_CMD_WITH_SUBCMDS(adc, "ADC sub-system", adc_help_text,
Signature · 1 line
2.35.1
#1 lore raw

Hi Marek,

Quoted 1 line · Marek Vasut

Add the ability to start ADC conversion result in an environment

s/to start/to save/ ?

Quoted 33 lines

variable. This is useful for further arbitrary processing by the U-Boot scripts.

Cc Fabrice Gasnier <[email protected]>
Cc Simon Glass <[email protected]>
---
  cmd/adc.c | 13 ++++++++++++-
  1 file changed, 12 insertions(+), 1 deletion(-)
cmd/adc.c +4 -0
index 75739bc8eed..4f548b811ec 100644
@@ -71,6 +71,7 @@ static int do_adc_info(struct cmd_tbl *cmdtp, int flag, int argc,
  static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc,
  			 char *const argv[])
  {
+	char *varname = NULL;
  	struct udevice *dev;
  	unsigned int data;
  	int ret, uV;
@@ -78,6 +79,9 @@ static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc,
  	if (argc < 3)
  		return CMD_RET_USAGE;
 
+	if (argc >= 3)
+		varname = argv[2];
+
  	ret = adc_channel_single_shot(argv[1], simple_strtol(argv[2], NULL, 0),
  				      &data);
  	if (ret) {

cmd/adc.c static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc, · line 105

Quoted 10 lines
cmd/adc.c +7 -0
@@ -92,6 +96,13 @@ static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc,
  	else
  		printf("%u\n", data);
 
+	if (varname) {
+		if (!adc_raw_to_uV(dev, data, &uV))
+			env_set_ulong(varname, uV);
+		else
+			env_set_ulong(varname, data);
+	}
+

Minor remark: no need to call 2 times adc_raw_to_uV()

conversion result can be saved in a local variable

+   ulong var_value;

    ret = uclass_get_device_by_name(UCLASS_ADC, argv[1], &dev); if (!ret && !adc_raw_to_uV(dev, data, &uV)) { printf("%u, %d uV\n", data, uV);
+        var_value = uV;
    } else {
        printf("%u\n", data);
+        var_value = data;
    }

+    if (varname)
+       env_set_ulong(varname, var_value);

cmd/adc.c static int do_adc_scan(struct cmd_tbl *cmdtp, int flag, int argc, · line 166

Quoted 12 lines
cmd/adc.c +1 -1
  	return CMD_RET_SUCCESS;
  }
 
@@ -149,7 +160,7 @@ static int do_adc_scan(struct cmd_tbl *cmdtp, int flag, int argc,
  static char adc_help_text[] =
  	"list - list ADC devices\n"
  	"adc info <name> - Get ADC device info\n"
-	"adc single <name> <channel> - Get Single data of ADC device channel\n"
+	"adc single <name> <channel> [varname] - Get Single data of ADC device channel\n"
  	"adc scan <name> [channel mask] - Scan all [or masked] ADC channels";
 
  U_BOOT_CMD_WITH_SUBCMDS(adc, "ADC sub-system", adc_help_text,

Regards

Patrick