Skip to contentSkip to conversation

s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration

PATCH Applied Thomas Huth 3 participants 3 messages Apr 13, 2022 – Apr 18, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration

The vfio_ap module tries to register for the vfio_ap bus - but that's the interface that it provides itself, so this does not make much sense, thus let's simply drop this statement now.

---
See also my previous patch to register it for the "ap" bus instead:
https://lore.kernel.org/linux-s390/[email protected]/
... but since it has been decided to not auto-load the module uncondi- tionally, I'd like to suggest to rather drop this line now instead.

 drivers/s390/crypto/vfio_ap_drv.c | 2 --
 1 file changed, 2 deletions(-)
drivers/s390/crypto/vfio_ap_drv.c +0 -2
index 29ebd54f8919..4ac9c6521ec1 100644
@@ -46,8 +46,6 @@ static struct ap_device_id ap_queue_ids[] = {
 	{ /* end of sibling */ },
 };
 
-MODULE_DEVICE_TABLE(vfio_ap, ap_queue_ids);
-
 static struct ap_matrix_mdev *vfio_ap_mdev_for_queue(struct vfio_ap_queue *q)
 {
 	struct ap_matrix_mdev *matrix_mdev;
Signature · 1 line
2.27.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Thomas Huth

The vfio_ap module tries to register for the vfio_ap bus - but that's the interface that it provides itself, so this does not make much sense, thus let's simply drop this statement now.

---
See also my previous patch to register it for the "ap" bus instead:
https://lore.kernel.org/linux-s390/[email protected]/
... but since it has been decided to not auto-load the module uncondi- tionally, I'd like to suggest to rather drop this line now instead.

  drivers/s390/crypto/vfio_ap_drv.c | 2 --
  1 file changed, 2 deletions(-)
drivers/s390/crypto/vfio_ap_drv.c +0 -2
index 29ebd54f8919..4ac9c6521ec1 100644
@@ -46,8 +46,6 @@ static struct ap_device_id ap_queue_ids[] = {
  	{ /* end of sibling */ },
  };
 
-MODULE_DEVICE_TABLE(vfio_ap, ap_queue_ids);
-
  static struct ap_matrix_mdev *vfio_ap_mdev_for_queue(struct vfio_ap_queue *q)
  {
  	struct ap_matrix_mdev *matrix_mdev;
maintainer Applied
#2 lore raw
Quoted 16 lines · Tony Krowiak
Quoted 13 lines · Thomas Huth

The vfio_ap module tries to register for the vfio_ap bus - but that's the interface that it provides itself, so this does not make much sense, thus let's simply drop this statement now.

---
See also my previous patch to register it for the "ap" bus instead:
https://lore.kernel.org/linux-s390/[email protected]/
... but since it has been decided to not auto-load the module uncondi- tionally, I'd like to suggest to rather drop this line now instead.

  drivers/s390/crypto/vfio_ap_drv.c | 2 --
  1 file changed, 2 deletions(-)

...

Applied, thanks.