s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration
Subsystems (3)
PATCH 1/1 s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration
The vfio_ap module tries to register for the vfio_ap bus - but that's the interface that it provides itself, so this does not make much sense, thus let's simply drop this statement now.
---
See also my previous patch to register it for the "ap" bus instead:
https://lore.kernel.org/linux-s390/[email protected]/
... but since it has been decided to not auto-load the module uncondi- tionally, I'd like to suggest to rather drop this line now instead.
drivers/s390/crypto/vfio_ap_drv.c | 2 -- 1 file changed, 2 deletions(-)
drivers/s390/crypto/vfio_ap_drv.c +0 -2
@@ -46,8 +46,6 @@ static struct ap_device_id ap_queue_ids[] = { { /* end of sibling */ }, }; -MODULE_DEVICE_TABLE (vfio_ap, ap_queue_ids); -static struct ap_matrix_mdev *vfio_ap_mdev_for_queue (struct vfio_ap_queue *q) {struct ap_matrix_mdev *matrix_mdev;
Signature · 1 line
2.27.0
Quoted 27 lines · Thomas Huth
The
vfio_apmodule tries to register for thevfio_apbus - but that's the interface that it provides itself, so this does not make much sense, thus let's simply drop this statement now.Signed-off-by Thomas Huth <[email protected]>---
See also my previous patch to register it for the "ap" bus instead:
https://lore.kernel.org/linux-s390/[email protected]/
... but since it has been decided to not auto-load the module uncondi- tionally, I'd like to suggest to rather drop this line now instead.drivers/s390/crypto/vfio_ap_drv.c | 2 -- 1 file changed, 2 deletions(-)drivers/s390/crypto/vfio_ap_drv.c +0
-2@@ -46,8 +46,6 @@ static struct ap_device_id ap_queue_ids[] = { { /* end of sibling */ }, }; -MODULE_DEVICE_TABLE (vfio_ap, ap_queue_ids); -static struct ap_matrix_mdev *vfio_ap_mdev_for_queue (struct vfio_ap_queue *q) {struct ap_matrix_mdev *matrix_mdev;
Quoted 16 lines · Tony Krowiak
Reviewed-by Tony Krowiak <[email protected]>Quoted 13 lines · Thomas Huth
The
vfio_apmodule tries to register for thevfio_apbus - but that's the interface that it provides itself, so this does not make much sense, thus let's simply drop this statement now.Signed-off-by Thomas Huth <[email protected]>---
See also my previous patch to register it for the "ap" bus instead:
https://lore.kernel.org/linux-s390/[email protected]/
... but since it has been decided to not auto-load the module uncondi- tionally, I'd like to suggest to rather drop this line now instead.drivers/s390/crypto/vfio_ap_drv.c | 2 -- 1 file changed, 2 deletions(-)
...
Applied, thanks.