Skip to contentSkip to conversation

scsi: increase max device queue_depth to 4096

PATCH Applied Sumit Saxena 2 participants 3 messages Apr 14, 2022 – Apr 26, 2022 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: increase max device queue_depth to 4096

Maximum SCSI device queue depth limited to 1024 is not sufficient for RAID volumes configured behind Broadcom RAID controllers. For a 16 drives RAID volume with 1024 device QD, per drive 64 IOs(1024/16) can be issued which is not good enough to achieve performance target.

Cc Ming Lei <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc Bart Van Assche <[email protected]>
Cc Sumanesh Samanta <[email protected]>
---
 drivers/scsi/scsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/scsi.c +2 -2
index 211aace69c22..735b6c862b46 100644
@@ -200,11 +200,11 @@ void scsi_finish_command(struct scsi_cmnd *cmd)
 
 
 /*
- * 1024 is big enough for saturating fast SCSI LUNs.
+ * 4096 is big enough for saturating fast SCSI LUNs.
  */
 int scsi_device_max_queue_depth(struct scsi_device *sdev)
 {
-	return min_t(int, sdev->host->can_queue, 1024);
+	return min_t(int, sdev->host->can_queue, 4096);
 }
 
 /**
Signature · 1 line
2.27.0
#1 lore raw

Sumit,

Quoted 4 lines

Maximum SCSI device queue depth limited to 1024 is not sufficient for RAID volumes configured behind Broadcom RAID controllers. For a 16 drives RAID volume with 1024 device QD, per drive 64 IOs(1024/16) can be issued which is not good enough to achieve performance target.

Applied to 5.19/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Sumit Saxena
Quoted 8 lines · Sumit Saxena

Maximum SCSI device queue depth limited to 1024 is not sufficient for RAID volumes configured behind Broadcom RAID controllers. For a 16 drives RAID volume with 1024 device QD, per drive 64 IOs(1024/16) can be issued which is not good enough to achieve performance target.

[...]

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: increase max device queue_depth to 4096

      https://git.kernel.org/mkp/scsi/c/f9bdac31cf4b
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering