drm/i915: Move per-platform power well hooks to intel_display_power_well.c
Subsystems (3)
PATCH 1/18 drm/i915: Move per-platform power well hooks to intel_display_power_well.c
Move the implementation of platform specific power well hooks to intel_display_power_well.c, to reduce the clutter in intel_display_power.c.
The locking of all the power domain/power well state is handled in the power domain functions in intel_display_power.c using i915_power_domains::lock. This patch also moves the chy_phy_powergate_ch/lanes() functions to intel_display_power_well.c which borrow the same lock to protect the DISPLAY_PHY_CONTROL register state, which the HW uses both for toggling power wells and power gating PHY lanes.
No functional change.
v2:
- Clarify in the commit log why CHV functions using the i915_power_domains::lock were moved, while others locking the power domain/well state were kept in intel_display_power.c . (Jouni)
- Move forward declaration of chv_phy_powergate_ch/lanes() to intel_display_power_well.h .
--- .../drm/i915/display/intel_display_power.c | 1747 ---------------- .../drm/i915/display/intel_display_power.h | 5 - .../i915/display/intel_display_power_well.c | 1806 +++++++++++++++++ .../i915/display/intel_display_power_well.h | 62 +- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 1 + drivers/gpu/drm/i915/display/intel_pps.c | 1 + 6 files changed, 1835 insertions(+), 1787 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +0 -1747
@@ -9,24 +9,16 @@#include "i915_irq.h" #include "intel_cdclk.h" #include "intel_combo_phy.h" -#include "intel_combo_phy_regs.h" -#include "intel_crt.h" #include "intel_de.h" #include "intel_display_power.h" #include "intel_display_power_well.h" #include "intel_display_types.h" #include "intel_dmc.h" -#include "intel_dpio_phy.h" -#include "intel_dpll.h" -#include "intel_hotplug.h" #include "intel_mchbar_regs.h" #include "intel_pch_refclk.h" #include "intel_pcode.h" #include "intel_pm.h" -#include "intel_pps.h" #include "intel_snps_phy.h" -#include "intel_tc.h" -#include "intel_vga.h" #include "vlv_sideband.h" const char *
@@ -235,604 +227,6 @@ bool intel_display_power_is_enabled(struct drm_i915_private *dev_priv,return ret; } -/* -* Starting with Haswell, we have a "Power Down Well" that can be turned off -* when not needed anymore. We have 4 registers that can request the power well -* to be enabled, and it will only be disabled if none of the registers is -* requesting it to be enabled. -*/ -static void hsw_power_well_post_enable (struct drm_i915_private *dev_priv, -u8 irq_pipe_mask,bool has_vga) -{ -if (has_vga) -intel_vga_reset_io_mem (dev_priv); - -if (irq_pipe_mask) -gen8_irq_power_well_post_enable (dev_priv, irq_pipe_mask); -} - -static void hsw_power_well_pre_disable (struct drm_i915_private *dev_priv, -u8 irq_pipe_mask) -{ -if (irq_pipe_mask) -gen8_irq_power_well_pre_disable (dev_priv, irq_pipe_mask); -} - -#define ICL_AUX_PW_TO_CH (pw_idx) \ - ((pw_idx) - ICL_PW_CTL_IDX_AUX_A + AUX_CH_A) - -#define ICL_TBT_AUX_PW_TO_CH (pw_idx) \ - ((pw_idx) - ICL_PW_CTL_IDX_AUX_TBT1 + AUX_CH_C) - -static enum aux_ch icl_aux_pw_to_ch (const struct i915_power_well *power_well) -{ -int pw_idx = power_well->desc->hsw.idx; - -return power_well->desc->hsw.is_tc_tbt ?ICL_TBT_AUX_PW_TO_CH (pw_idx) : -ICL_AUX_PW_TO_CH (pw_idx); -} - -static struct intel_digital_port * -aux_ch_to_digital_port (struct drm_i915_private *dev_priv, -enum aux_ch aux_ch) -{ -struct intel_digital_port *dig_port =NULL ; -struct intel_encoder *encoder; - -for_each_intel_encoder (&dev_priv->drm, encoder) { -/* We'll check the MST primary port */ -if (encoder->type ==INTEL_OUTPUT_DP_MST ) -continue ; - - dig_port =enc_to_dig_port (encoder); -if (!dig_port) -continue ; - -if (dig_port->aux_ch != aux_ch) { - dig_port =NULL ; -continue ; - } - -break ; - } - -return dig_port; -} - -static enum phy icl_aux_pw_to_phy (struct drm_i915_private *i915, -const struct i915_power_well *power_well) -{ -enum aux_ch aux_ch =icl_aux_pw_to_ch (power_well); -struct intel_digital_port *dig_port =aux_ch_to_digital_port (i915, aux_ch); - -return intel_port_to_phy (i915, dig_port->base.port); -} - -static void hsw_wait_for_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well, -bool timeout_expected) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -int enable_delay = power_well->desc->hsw.fixed_enable_delay; - -/* -* For some power wells we're not supposed to watch the status bit for -* an ack, but rather just wait a fixed amount of time and then -* proceed. This is only used on DG2. -*/ -if (IS_DG2 (dev_priv) && enable_delay) { -usleep_range (enable_delay,2 * enable_delay); -return ; - } - -/* Timeout for PW1:10 us, AUX:not specified, other PWs:20 us. */ -if (intel_de_wait_for_set (dev_priv, regs->driver, -HSW_PWR_WELL_CTL_STATE (pw_idx),1 )) { -drm_dbg_kms (&dev_priv->drm,"%s power well enable timeout\n" , -intel_power_well_name (power_well)); - -drm_WARN_ON (&dev_priv->drm, !timeout_expected); - - } -} - -static u32 hsw_power_well_requesters (struct drm_i915_private *dev_priv, -const struct i915_power_well_regs *regs, -int pw_idx) -{ -u32 req_mask =HSW_PWR_WELL_CTL_REQ (pw_idx); -u32 ret; - - ret =intel_de_read (dev_priv, regs->bios) & req_mask ?1 :0 ; - ret |=intel_de_read (dev_priv, regs->driver) & req_mask ?2 :0 ; -if (regs->kvmr.reg) - ret |=intel_de_read (dev_priv, regs->kvmr) & req_mask ?4 :0 ; - ret |=intel_de_read (dev_priv, regs->debug) & req_mask ?8 :0 ; - -return ret; -} - -static void hsw_wait_for_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -bool disabled; -u32 reqs; - -/* -* Bspec doesn't require waiting for PWs to get disabled, but still do -* this for paranoia. The known cases where a PW will be forced on: -* - a KVMR request on any power well via the KVMR request register -* - a DMC request on PW1 and MISC_IO power wells via the BIOS and -* DEBUG request registers -* Skip the wait in case any of the request bits are set and print a -* diagnostic message. -*/ -wait_for ((disabled = !(intel_de_read (dev_priv, regs->driver) & -HSW_PWR_WELL_CTL_STATE (pw_idx))) || - (reqs =hsw_power_well_requesters (dev_priv, regs, pw_idx)),1 ); -if (disabled) -return ; - -drm_dbg_kms (&dev_priv->drm, -"%s forced on (bios:%d driver:%d kvmr:%d debug:%d)\n" , -intel_power_well_name (power_well), - !!(reqs &1 ), !!(reqs &2 ), !!(reqs &4 ), !!(reqs &8 )); -} - -static void gen9_wait_for_power_well_fuses (struct drm_i915_private *dev_priv, -enum skl_power_gate pg) -{ -/* Timeout 5us for PG#0, for other PGs 1us */ -drm_WARN_ON (&dev_priv->drm, -intel_de_wait_for_set (dev_priv,SKL_FUSE_STATUS , -SKL_FUSE_PG_DIST_STATUS (pg),1 )); -} - -static void hsw_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -u32 val; - -if (power_well->desc->hsw.has_fuses) { -enum skl_power_gate pg; - - pg =DISPLAY_VER (dev_priv) >=11 ?ICL_PW_CTL_IDX_TO_PG (pw_idx) : -SKL_PW_CTL_IDX_TO_PG (pw_idx); - -/* Wa_16013190616:adlp */ -if (IS_ALDERLAKE_P (dev_priv) && pg ==SKL_PG1 ) -intel_de_rmw (dev_priv,GEN8_CHICKEN_DCPR_1 ,0 ,DISABLE_FLR_SRC ); - -/* -* For PW1 we have to wait both for the PW0/PG0 fuse state -* before enabling the power well and PW1/PG1's own fuse -* state after the enabling. For all other power wells with -* fuses we only have to wait for that PW/PG's fuse state -* after the enabling. -*/ -if (pg ==SKL_PG1 ) -gen9_wait_for_power_well_fuses (dev_priv,SKL_PG0 ); - } - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val |HSW_PWR_WELL_CTL_REQ (pw_idx)); - -hsw_wait_for_power_well_enable (dev_priv, power_well, false); - -if (power_well->desc->hsw.has_fuses) { -enum skl_power_gate pg; - - pg =DISPLAY_VER (dev_priv) >=11 ?ICL_PW_CTL_IDX_TO_PG (pw_idx) : -SKL_PW_CTL_IDX_TO_PG (pw_idx); -gen9_wait_for_power_well_fuses (dev_priv, pg); - } - -hsw_power_well_post_enable (dev_priv, - power_well->desc->hsw.irq_pipe_mask, - power_well->desc->hsw.has_vga); -} - -static void hsw_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -u32 val; - -hsw_power_well_pre_disable (dev_priv, - power_well->desc->hsw.irq_pipe_mask); - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val & ~HSW_PWR_WELL_CTL_REQ (pw_idx)); -hsw_wait_for_power_well_disable (dev_priv, power_well); -} - -static void -icl_combo_phy_aux_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -enum phy phy =icl_aux_pw_to_phy (dev_priv, power_well); -u32 val; - -drm_WARN_ON (&dev_priv->drm, !IS_ICELAKE (dev_priv)); - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val |HSW_PWR_WELL_CTL_REQ (pw_idx)); - -if (DISPLAY_VER (dev_priv) <12 ) { - val =intel_de_read (dev_priv,ICL_PORT_CL_DW12 (phy)); -intel_de_write (dev_priv,ICL_PORT_CL_DW12 (phy), - val |ICL_LANE_ENABLE_AUX ); - } - -hsw_wait_for_power_well_enable (dev_priv, power_well, false); - -/* Display WA #1178: icl */ -if (pw_idx >=ICL_PW_CTL_IDX_AUX_A && pw_idx <=ICL_PW_CTL_IDX_AUX_B && - !intel_bios_is_port_edp (dev_priv, (enum port )phy)) { - val =intel_de_read (dev_priv,ICL_AUX_ANAOVRD1 (pw_idx)); - val |=ICL_AUX_ANAOVRD1_ENABLE |ICL_AUX_ANAOVRD1_LDO_BYPASS ; -intel_de_write (dev_priv,ICL_AUX_ANAOVRD1 (pw_idx), val); - } -} - -static void -icl_combo_phy_aux_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -enum phy phy =icl_aux_pw_to_phy (dev_priv, power_well); -u32 val; - -drm_WARN_ON (&dev_priv->drm, !IS_ICELAKE (dev_priv)); - - val =intel_de_read (dev_priv,ICL_PORT_CL_DW12 (phy)); -intel_de_write (dev_priv,ICL_PORT_CL_DW12 (phy), - val & ~ICL_LANE_ENABLE_AUX ); - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val & ~HSW_PWR_WELL_CTL_REQ (pw_idx)); - -hsw_wait_for_power_well_disable (dev_priv, power_well); -} - -#if IS_ENABLED (CONFIG_DRM_I915_DEBUG_RUNTIME_PM ) - -static void icl_tc_port_assert_ref_held (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well, -struct intel_digital_port *dig_port) -{ -if (drm_WARN_ON (&dev_priv->drm, !dig_port)) -return ; - -if (DISPLAY_VER (dev_priv) ==11 &&intel_tc_cold_requires_aux_pw (dig_port)) -return ; - -drm_WARN_ON (&dev_priv->drm, !intel_tc_port_ref_held (dig_port)); -} - -#else - -static void icl_tc_port_assert_ref_held (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well, -struct intel_digital_port *dig_port) -{ -} - -#endif - -#define TGL_AUX_PW_TO_TC_PORT (pw_idx) ((pw_idx) - TGL_PW_CTL_IDX_AUX_TC1) - -static void icl_tc_cold_exit (struct drm_i915_private *i915) -{ -int ret, tries =0 ; - -while (1 ) { - ret =snb_pcode_write_timeout (i915,ICL_PCODE_EXIT_TCCOLD ,0 , -250 ,1 ); -if (ret != -EAGAIN || ++tries ==3 ) -break ; -msleep (1 ); - } - -/* Spec states that TC cold exit can take up to 1ms to complete */ -if (!ret) -msleep (1 ); - -/* TODO: turn failure into a error as soon i915 CI updates ICL IFWI */ -drm_dbg_kms (&i915->drm,"TC cold block %s\n" , ret ?"failed" : -"succeeded" ); -} - -static void -icl_tc_phy_aux_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum aux_ch aux_ch =icl_aux_pw_to_ch (power_well); -struct intel_digital_port *dig_port =aux_ch_to_digital_port (dev_priv, aux_ch); -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -bool is_tbt = power_well->desc->hsw.is_tc_tbt; -bool timeout_expected; -u32 val; - -icl_tc_port_assert_ref_held (dev_priv, power_well, dig_port); - - val =intel_de_read (dev_priv,DP_AUX_CH_CTL (aux_ch)); - val &= ~DP_AUX_CH_CTL_TBT_IO ; -if (is_tbt) - val |=DP_AUX_CH_CTL_TBT_IO ; -intel_de_write (dev_priv,DP_AUX_CH_CTL (aux_ch), val); - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val |HSW_PWR_WELL_CTL_REQ (power_well->desc->hsw.idx)); - -/* -* An AUX timeout is expected if the TBT DP tunnel is down, -* or need to enable AUX on a legacy TypeC port as part of the TC-cold -* exit sequence. -*/ - timeout_expected = is_tbt ||intel_tc_cold_requires_aux_pw (dig_port); -if (DISPLAY_VER (dev_priv) ==11 &&intel_tc_cold_requires_aux_pw (dig_port)) -icl_tc_cold_exit (dev_priv); - -hsw_wait_for_power_well_enable (dev_priv, power_well, timeout_expected); - -if (DISPLAY_VER (dev_priv) >=12 && !is_tbt) { -enum tc_port tc_port; - - tc_port =TGL_AUX_PW_TO_TC_PORT (power_well->desc->hsw.idx); -intel_de_write (dev_priv,HIP_INDEX_REG (tc_port), -HIP_INDEX_VAL (tc_port,0x2 )); - -if (intel_de_wait_for_set (dev_priv,DKL_CMN_UC_DW_27 (tc_port), -DKL_CMN_UC_DW27_UC_HEALTH ,1 )) -drm_warn (&dev_priv->drm, -"Timeout waiting TC uC health\n" ); - } -} - -static void -icl_aux_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum phy phy =icl_aux_pw_to_phy (dev_priv, power_well); - -if (intel_phy_is_tc (dev_priv, phy)) -return icl_tc_phy_aux_power_well_enable (dev_priv, power_well); -else if (IS_ICELAKE (dev_priv)) -return icl_combo_phy_aux_power_well_enable (dev_priv, - power_well); -else -return hsw_power_well_enable (dev_priv, power_well); -} - -static void -icl_aux_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum phy phy =icl_aux_pw_to_phy (dev_priv, power_well); - -if (intel_phy_is_tc (dev_priv, phy)) -return hsw_power_well_disable (dev_priv, power_well); -else if (IS_ICELAKE (dev_priv)) -return icl_combo_phy_aux_power_well_disable (dev_priv, - power_well); -else -return hsw_power_well_disable (dev_priv, power_well); -} - -/* -* We should only use the power well if we explicitly asked the hardware to -* enable it, so check if it's enabled and also check if we've requested it to -* be enabled. -*/ -static bool hsw_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -enum i915_power_well_id id = power_well->desc->id; -int pw_idx = power_well->desc->hsw.idx; -u32 mask =HSW_PWR_WELL_CTL_REQ (pw_idx) | -HSW_PWR_WELL_CTL_STATE (pw_idx); -u32 val; - - val =intel_de_read (dev_priv, regs->driver); - -/* -* On GEN9 big core due to a DMC bug the driver's request bits for PW1 -* and the MISC_IO PW will be not restored, so check instead for the -* BIOS's own request bits, which are forced-on for these power wells -* when exiting DC5/6. -*/ -if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv) && - (id ==SKL_DISP_PW_1 || id ==SKL_DISP_PW_MISC_IO )) - val |=intel_de_read (dev_priv, regs->bios); - -return (val & mask) == mask; -} - -static void assert_can_enable_dc9 (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm, - (intel_de_read (dev_priv,DC_STATE_EN ) &DC_STATE_EN_DC9 ), -"DC9 already programmed to be enabled.\n" ); -drm_WARN_ONCE (&dev_priv->drm, -intel_de_read (dev_priv,DC_STATE_EN ) & -DC_STATE_EN_UPTO_DC5 , -"DC5 still not disabled to enable DC9.\n" ); -drm_WARN_ONCE (&dev_priv->drm, -intel_de_read (dev_priv,HSW_PWR_WELL_CTL2 ) & -HSW_PWR_WELL_CTL_REQ (SKL_PW_CTL_IDX_PW_2 ), -"Power well 2 on.\n" ); -drm_WARN_ONCE (&dev_priv->drm,intel_irqs_enabled (dev_priv), -"Interrupts not disabled yet.\n" ); - -/* -* TODO: check for the following to verify the conditions to enter DC9 -* state are satisfied: -* 1] Check relevant display engine registers to verify if mode set -* disable sequence was followed. -* 2] Check if display uninitialize sequence is initialized. -*/ -} - -static void assert_can_disable_dc9 (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm,intel_irqs_enabled (dev_priv), -"Interrupts not disabled yet.\n" ); -drm_WARN_ONCE (&dev_priv->drm, -intel_de_read (dev_priv,DC_STATE_EN ) & -DC_STATE_EN_UPTO_DC5 , -"DC5 still not disabled.\n" ); - -/* -* TODO: check for the following to verify DC9 state was indeed -* entered before programming to disable it: -* 1] Check relevant display engine registers to verify if mode -* set disable sequence was followed. -* 2] Check if display uninitialize sequence is initialized. -*/ -} - -static void gen9_write_dc_state (struct drm_i915_private *dev_priv, -u32 state) -{ -int rewrites =0 ; -int rereads =0 ; -u32 v; - -intel_de_write (dev_priv,DC_STATE_EN , state); - -/* It has been observed that disabling the dc6 state sometimes -* doesn't stick and dmc keeps returning old value. Make sure -* the write really sticks enough times and also force rewrite until -* we are confident that state is exactly what we want. -*/ -do { - v =intel_de_read (dev_priv,DC_STATE_EN ); - -if (v != state) { -intel_de_write (dev_priv,DC_STATE_EN , state); - rewrites++; - rereads =0 ; - }else if (rereads++ >5 ) { -break ; - } - - }while (rewrites <100 ); - -if (v != state) -drm_err (&dev_priv->drm, -"Writing dc state to 0x%x failed, now 0x%x\n" , - state, v); - -/* Most of the times we need one retry, avoid spam */ -if (rewrites >1 ) -drm_dbg_kms (&dev_priv->drm, -"Rewrote dc state to 0x%x %d times\n" , - state, rewrites); -} - -static u32 gen9_dc_mask (struct drm_i915_private *dev_priv) -{ -u32 mask; - - mask =DC_STATE_EN_UPTO_DC5 ; - -if (DISPLAY_VER (dev_priv) >=12 ) - mask |=DC_STATE_EN_DC3CO |DC_STATE_EN_UPTO_DC6 - |DC_STATE_EN_DC9 ; -else if (DISPLAY_VER (dev_priv) ==11 ) - mask |=DC_STATE_EN_UPTO_DC6 |DC_STATE_EN_DC9 ; -else if (IS_GEMINILAKE (dev_priv) ||IS_BROXTON (dev_priv)) - mask |=DC_STATE_EN_DC9 ; -else - mask |=DC_STATE_EN_UPTO_DC6 ; - -return mask; -} - -static void gen9_sanitize_dc_state (struct drm_i915_private *dev_priv) -{ -u32 val; - -if (!HAS_DISPLAY (dev_priv)) -return ; - - val =intel_de_read (dev_priv,DC_STATE_EN ) &gen9_dc_mask (dev_priv); - -drm_dbg_kms (&dev_priv->drm, -"Resetting DC state tracking from %02x to %02x\n" , - dev_priv->dmc.dc_state, val); - dev_priv->dmc.dc_state = val; -} - -/** -* gen9_set_dc_state - set target display C power state -* @dev_priv: i915 device instance -* @state: target DC power state -* - DC_STATE_DISABLE -* - DC_STATE_EN_UPTO_DC5 -* - DC_STATE_EN_UPTO_DC6 -* - DC_STATE_EN_DC9 -* -* Signal to DMC firmware/HW the target DC power state passed in @state. -* DMC/HW can turn off individual display clocks and power rails when entering -* a deeper DC power state (higher in number) and turns these back when exiting -* that state to a shallower power state (lower in number). The HW will decide -* when to actually enter a given state on an on-demand basis, for instance -* depending on the active state of display pipes. The state of display -* registers backed by affected power rails are saved/restored as needed. -* -* Based on the above enabling a deeper DC power state is asynchronous wrt. -* enabling it. Disabling a deeper power state is synchronous: for instance -* setting %DC_STATE_DISABLE won't complete until all HW resources are turned -* back on and register state is restored. This is guaranteed by the MMIO write -* to DC_STATE_EN blocking until the state is restored. -*/ -static void gen9_set_dc_state (struct drm_i915_private *dev_priv,u32 state) -{ -u32 val; -u32 mask; - -if (!HAS_DISPLAY (dev_priv)) -return ; - -if (drm_WARN_ON_ONCE (&dev_priv->drm, - state & ~dev_priv->dmc.allowed_dc_mask)) - state &= dev_priv->dmc.allowed_dc_mask; - - val =intel_de_read (dev_priv,DC_STATE_EN ); - mask =gen9_dc_mask (dev_priv); -drm_dbg_kms (&dev_priv->drm,"Setting DC state from %02x to %02x\n" , - val & mask, state); - -/* Check if DMC is ignoring our DC state requests */ -if ((val & mask) != dev_priv->dmc.dc_state) -drm_err (&dev_priv->drm,"DC state mismatch (0x%x -> 0x%x)\n" , - dev_priv->dmc.dc_state, val & mask); - - val &= ~mask; - val |= state; - -gen9_write_dc_state (dev_priv, val); - - dev_priv->dmc.dc_state = val & mask; -} -static u32 sanitize_target_dc_state (struct drm_i915_private *dev_priv,u32 target_dc_state)
@@ -858,53 +252,6 @@ sanitize_target_dc_state(struct drm_i915_private *dev_priv,return target_dc_state; } -static void tgl_enable_dc3co (struct drm_i915_private *dev_priv) -{ -drm_dbg_kms (&dev_priv->drm,"Enabling DC3CO\n" ); -gen9_set_dc_state (dev_priv,DC_STATE_EN_DC3CO ); -} - -static void tgl_disable_dc3co (struct drm_i915_private *dev_priv) -{ -u32 val; - -drm_dbg_kms (&dev_priv->drm,"Disabling DC3CO\n" ); - val =intel_de_read (dev_priv,DC_STATE_EN ); - val &= ~DC_STATE_DC3CO_STATUS ; -intel_de_write (dev_priv,DC_STATE_EN , val); -gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); -/* -* Delay of 200us DC3CO Exit time B.Spec 49196 -*/ -usleep_range (200 ,210 ); -} - -static void bxt_enable_dc9 (struct drm_i915_private *dev_priv) -{ -assert_can_enable_dc9 (dev_priv); - -drm_dbg_kms (&dev_priv->drm,"Enabling DC9\n" ); -/* -* Power sequencer reset is not needed on -* platforms with South Display Engine on PCH, -* because PPS registers are always on. -*/ -if (!HAS_PCH_SPLIT (dev_priv)) -intel_pps_reset_all (dev_priv); -gen9_set_dc_state (dev_priv,DC_STATE_EN_DC9 ); -} - -static void bxt_disable_dc9 (struct drm_i915_private *dev_priv) -{ -assert_can_disable_dc9 (dev_priv); - -drm_dbg_kms (&dev_priv->drm,"Disabling DC9\n" ); - -gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); - -intel_pps_unlock_regs_wa (dev_priv); -} -/** * intel_display_power_set_target_dc_state - Set target dc state. * @dev_priv: i915 device
@@ -949,912 +296,8 @@ void intel_display_power_set_target_dc_state(struct drm_i915_private *dev_priv,mutex_unlock (&power_domains->lock); } -static void assert_can_enable_dc5 (struct drm_i915_private *dev_priv) -{ -enum i915_power_well_id high_pg; - -/* Power wells at this level and above must be disabled for DC5 entry */ -if (DISPLAY_VER (dev_priv) ==12 ) - high_pg =ICL_DISP_PW_3 ; -else - high_pg =SKL_DISP_PW_2 ; - -drm_WARN_ONCE (&dev_priv->drm, -intel_display_power_well_is_enabled (dev_priv, high_pg), -"Power wells above platform's DC5 limit still enabled.\n" ); - -drm_WARN_ONCE (&dev_priv->drm, - (intel_de_read (dev_priv,DC_STATE_EN ) & -DC_STATE_EN_UPTO_DC5 ), -"DC5 already programmed to be enabled.\n" ); -assert_rpm_wakelock_held (&dev_priv->runtime_pm); - -assert_dmc_loaded (dev_priv); -} - -static void gen9_enable_dc5 (struct drm_i915_private *dev_priv) -{ -assert_can_enable_dc5 (dev_priv); - -drm_dbg_kms (&dev_priv->drm,"Enabling DC5\n" ); - -/* Wa Display #1183: skl,kbl,cfl */ -if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv)) -intel_de_write (dev_priv,GEN8_CHICKEN_DCPR_1 , -intel_de_read (dev_priv,GEN8_CHICKEN_DCPR_1 ) |SKL_SELECT_ALTERNATE_DC_EXIT ); - -gen9_set_dc_state (dev_priv,DC_STATE_EN_UPTO_DC5 ); -} - -static void assert_can_enable_dc6 (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm, -intel_de_read (dev_priv,UTIL_PIN_CTL ) &UTIL_PIN_ENABLE , -"Backlight is not disabled.\n" ); -drm_WARN_ONCE (&dev_priv->drm, - (intel_de_read (dev_priv,DC_STATE_EN ) & -DC_STATE_EN_UPTO_DC6 ), -"DC6 already programmed to be enabled.\n" ); - -assert_dmc_loaded (dev_priv); -} - -static void skl_enable_dc6 (struct drm_i915_private *dev_priv) -{ -assert_can_enable_dc6 (dev_priv); - -drm_dbg_kms (&dev_priv->drm,"Enabling DC6\n" ); - -/* Wa Display #1183: skl,kbl,cfl */ -if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv)) -intel_de_write (dev_priv,GEN8_CHICKEN_DCPR_1 , -intel_de_read (dev_priv,GEN8_CHICKEN_DCPR_1 ) |SKL_SELECT_ALTERNATE_DC_EXIT ); - -gen9_set_dc_state (dev_priv,DC_STATE_EN_UPTO_DC6 ); -} - -static void hsw_power_well_sync_hw (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -u32 mask =HSW_PWR_WELL_CTL_REQ (pw_idx); -u32 bios_req =intel_de_read (dev_priv, regs->bios); - -/* Take over the request bit if set by BIOS. */ -if (bios_req & mask) { -u32 drv_req =intel_de_read (dev_priv, regs->driver); - -if (!(drv_req & mask)) -intel_de_write (dev_priv, regs->driver, drv_req | mask); -intel_de_write (dev_priv, regs->bios, bios_req & ~mask); - } -} - -static void bxt_dpio_cmn_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -bxt_ddi_phy_init (dev_priv, power_well->desc->bxt.phy); -} - -static void bxt_dpio_cmn_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -bxt_ddi_phy_uninit (dev_priv, power_well->desc->bxt.phy); -} - -static bool bxt_dpio_cmn_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -return bxt_ddi_phy_is_enabled (dev_priv, power_well->desc->bxt.phy); -} - -static void bxt_verify_ddi_phy_power_wells (struct drm_i915_private *dev_priv) -{ -struct i915_power_well *power_well; - - power_well =lookup_power_well (dev_priv,BXT_DISP_PW_DPIO_CMN_A ); -if (intel_power_well_refcount (power_well) >0 ) -bxt_ddi_phy_verify_state (dev_priv, power_well->desc->bxt.phy); - - power_well =lookup_power_well (dev_priv,VLV_DISP_PW_DPIO_CMN_BC ); -if (intel_power_well_refcount (power_well) >0 ) -bxt_ddi_phy_verify_state (dev_priv, power_well->desc->bxt.phy); - -if (IS_GEMINILAKE (dev_priv)) { - power_well =lookup_power_well (dev_priv, -GLK_DISP_PW_DPIO_CMN_C ); -if (intel_power_well_refcount (power_well) >0 ) -bxt_ddi_phy_verify_state (dev_priv, - power_well->desc->bxt.phy); - } -} - -static bool gen9_dc_off_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -return ((intel_de_read (dev_priv,DC_STATE_EN ) &DC_STATE_EN_DC3CO ) ==0 && - (intel_de_read (dev_priv,DC_STATE_EN ) &DC_STATE_EN_UPTO_DC5_DC6_MASK ) ==0 ); -} - -static void gen9_assert_dbuf_enabled (struct drm_i915_private *dev_priv) -{ -u8 hw_enabled_dbuf_slices =intel_enabled_dbuf_slices_mask (dev_priv); -u8 enabled_dbuf_slices = dev_priv->dbuf.enabled_slices; - -drm_WARN (&dev_priv->drm, - hw_enabled_dbuf_slices != enabled_dbuf_slices, -"Unexpected DBuf power power state (0x%08x, expected 0x%08x)\n" , - hw_enabled_dbuf_slices, - enabled_dbuf_slices); -} - -static void gen9_disable_dc_states (struct drm_i915_private *dev_priv) -{ -struct intel_cdclk_config cdclk_config = {}; - -if (dev_priv->dmc.target_dc_state ==DC_STATE_EN_DC3CO ) { -tgl_disable_dc3co (dev_priv); -return ; - } - -gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); - -if (!HAS_DISPLAY (dev_priv)) -return ; - -intel_cdclk_get_cdclk (dev_priv, &cdclk_config); -/* Can't read out voltage_level so can't use intel_cdclk_changed() */ -drm_WARN_ON (&dev_priv->drm, -intel_cdclk_needs_modeset (&dev_priv->cdclk.hw, - &cdclk_config)); - -gen9_assert_dbuf_enabled (dev_priv); - -if (IS_GEMINILAKE (dev_priv) ||IS_BROXTON (dev_priv)) -bxt_verify_ddi_phy_power_wells (dev_priv); - -if (DISPLAY_VER (dev_priv) >=11 ) -/* -* DMC retains HW context only for port A, the other combo -* PHY's HW context for port B is lost after DC transitions, -* so we need to restore it manually. -*/ -intel_combo_phy_init (dev_priv); -} - -static void gen9_dc_off_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -gen9_disable_dc_states (dev_priv); -} - -static void gen9_dc_off_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -if (!intel_dmc_has_payload (dev_priv)) -return ; - -switch (dev_priv->dmc.target_dc_state) { -case DC_STATE_EN_DC3CO : -tgl_enable_dc3co (dev_priv); -break ; -case DC_STATE_EN_UPTO_DC6 : -skl_enable_dc6 (dev_priv); -break ; -case DC_STATE_EN_UPTO_DC5 : -gen9_enable_dc5 (dev_priv); -break ; - } -} - -static void i9xx_power_well_sync_hw_noop (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -} - -static void i9xx_always_on_power_well_noop (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -} - -static bool i9xx_always_on_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -return true; -} - -static void i830_pipes_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -if ((intel_de_read (dev_priv,PIPECONF (PIPE_A )) &PIPECONF_ENABLE ) ==0 ) -i830_enable_pipe (dev_priv,PIPE_A ); -if ((intel_de_read (dev_priv,PIPECONF (PIPE_B )) &PIPECONF_ENABLE ) ==0 ) -i830_enable_pipe (dev_priv,PIPE_B ); -} - -static void i830_pipes_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -i830_disable_pipe (dev_priv,PIPE_B ); -i830_disable_pipe (dev_priv,PIPE_A ); -} - -static bool i830_pipes_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -return intel_de_read (dev_priv,PIPECONF (PIPE_A )) &PIPECONF_ENABLE && -intel_de_read (dev_priv,PIPECONF (PIPE_B )) &PIPECONF_ENABLE ; -} - -static void i830_pipes_power_well_sync_hw (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -if (intel_power_well_refcount (power_well) >0 ) -i830_pipes_power_well_enable (dev_priv, power_well); -else -i830_pipes_power_well_disable (dev_priv, power_well); -} - -static void vlv_set_power_well (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well,bool enable) -{ -int pw_idx = power_well->desc->vlv.idx; -u32 mask; -u32 state; -u32 ctrl; - - mask =PUNIT_PWRGT_MASK (pw_idx); - state = enable ?PUNIT_PWRGT_PWR_ON (pw_idx) : -PUNIT_PWRGT_PWR_GATE (pw_idx); - -vlv_punit_get (dev_priv); - -#define COND \ - ((vlv_punit_read(dev_priv, PUNIT_REG_PWRGT_STATUS) & mask) == state) - -if (COND ) - goto out; - - ctrl =vlv_punit_read (dev_priv,PUNIT_REG_PWRGT_CTRL ); - ctrl &= ~mask; - ctrl |= state; -vlv_punit_write (dev_priv,PUNIT_REG_PWRGT_CTRL , ctrl); - -if (wait_for (COND ,100 )) -drm_err (&dev_priv->drm, -"timeout setting power well state %08x (%08x)\n" , - state, -vlv_punit_read (dev_priv,PUNIT_REG_PWRGT_CTRL )); - -#undef COND - -out: -vlv_punit_put (dev_priv); -} - -static void vlv_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_set_power_well (dev_priv, power_well, true); -} - -static void vlv_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_set_power_well (dev_priv, power_well, false); -} - -static bool vlv_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -int pw_idx = power_well->desc->vlv.idx; -bool enabled = false; -u32 mask; -u32 state; -u32 ctrl; - - mask =PUNIT_PWRGT_MASK (pw_idx); - ctrl =PUNIT_PWRGT_PWR_ON (pw_idx); - -vlv_punit_get (dev_priv); - - state =vlv_punit_read (dev_priv,PUNIT_REG_PWRGT_STATUS ) & mask; -/* -* We only ever set the power-on and power-gate states, anything -* else is unexpected. -*/ -drm_WARN_ON (&dev_priv->drm, state !=PUNIT_PWRGT_PWR_ON (pw_idx) && - state !=PUNIT_PWRGT_PWR_GATE (pw_idx)); -if (state == ctrl) - enabled = true; - -/* -* A transient state at this point would mean some unexpected party -* is poking at the power controls too. -*/ - ctrl =vlv_punit_read (dev_priv,PUNIT_REG_PWRGT_CTRL ) & mask; -drm_WARN_ON (&dev_priv->drm, ctrl != state); - -vlv_punit_put (dev_priv); - -return enabled; -} - -static void vlv_init_display_clock_gating (struct drm_i915_private *dev_priv) -{ -u32 val; - -/* -* On driver load, a pipe may be active and driving a DSI display. -* Preserve DPOUNIT_CLOCK_GATE_DISABLE to avoid the pipe getting stuck -* (and never recovering) in this case. intel_dsi_post_disable() will -* clear it when we turn off the display. -*/ - val =intel_de_read (dev_priv,DSPCLK_GATE_D ); - val &=DPOUNIT_CLOCK_GATE_DISABLE ; - val |=VRHUNIT_CLOCK_GATE_DISABLE ; -intel_de_write (dev_priv,DSPCLK_GATE_D , val); - -/* -* Disable trickle feed and enable pnd deadline calculation -*/ -intel_de_write (dev_priv,MI_ARB_VLV , -MI_ARB_DISPLAY_TRICKLE_FEED_DISABLE ); -intel_de_write (dev_priv,CBR1_VLV ,0 ); - -drm_WARN_ON (&dev_priv->drm,RUNTIME_INFO (dev_priv)->rawclk_freq ==0 ); -intel_de_write (dev_priv,RAWCLK_FREQ_VLV , -DIV_ROUND_CLOSEST (RUNTIME_INFO (dev_priv)->rawclk_freq, -1000 )); -} - -static void vlv_display_power_well_init (struct drm_i915_private *dev_priv) -{ -struct intel_encoder *encoder; -enum pipe pipe; - -/* -* Enable the CRI clock source so we can get at the -* display and the reference clock for VGA -* hotplug / manual detection. Supposedly DSI also -* needs the ref clock up and running. -* -* CHV DPLL B/C have some issues if VGA mode is enabled. -*/ -for_each_pipe (dev_priv, pipe) { -u32 val =intel_de_read (dev_priv,DPLL (pipe)); - - val |=DPLL_REF_CLK_ENABLE_VLV |DPLL_VGA_MODE_DIS ; -if (pipe !=PIPE_A ) - val |=DPLL_INTEGRATED_CRI_CLK_VLV ; - -intel_de_write (dev_priv,DPLL (pipe), val); - } - -vlv_init_display_clock_gating (dev_priv); - -spin_lock_irq (&dev_priv->irq_lock); -valleyview_enable_display_irqs (dev_priv); -spin_unlock_irq (&dev_priv->irq_lock); - -/* -* During driver initialization/resume we can avoid restoring the -* part of the HW/SW state that will be inited anyway explicitly. -*/ -if (dev_priv->power_domains.initializing) -return ; - -intel_hpd_init (dev_priv); -intel_hpd_poll_disable (dev_priv); - -/* Re-enable the ADPA, if we have one */ -for_each_intel_encoder (&dev_priv->drm, encoder) { -if (encoder->type ==INTEL_OUTPUT_ANALOG ) -intel_crt_reset (&encoder->base); - } - -intel_vga_redisable_power_on (dev_priv); - -intel_pps_unlock_regs_wa (dev_priv); -} - -static void vlv_display_power_well_deinit (struct drm_i915_private *dev_priv) -{ -spin_lock_irq (&dev_priv->irq_lock); -valleyview_disable_display_irqs (dev_priv); -spin_unlock_irq (&dev_priv->irq_lock); - -/* make sure we're done processing display irqs */ -intel_synchronize_irq (dev_priv); - -intel_pps_reset_all (dev_priv); - -/* Prevent us from re-enabling polling on accident in late suspend */ -if (!dev_priv->drm.dev->power.is_suspended) -intel_hpd_poll_enable (dev_priv); -} - -static void vlv_display_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_set_power_well (dev_priv, power_well, true); - -vlv_display_power_well_init (dev_priv); -} - -static void vlv_display_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_display_power_well_deinit (dev_priv); - -vlv_set_power_well (dev_priv, power_well, false); -} - -static void vlv_dpio_cmn_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -/* since ref/cri clock was enabled */ -udelay (1 );/* >10ns for cmnreset, >0ns for sidereset */ - -vlv_set_power_well (dev_priv, power_well, true); - -/* -* From VLV2A0_DP_eDP_DPIO_driver_vbios_notes_10.docx - -* 6. De-assert cmn_reset/side_reset. Same as VLV X0. -* a. GUnit 0x2110 bit[0] set to 1 (def 0) -* b. The other bits such as sfr settings / modesel may all -* be set to 0. -* -* This should only be done on init and resume from S3 with -* both PLLs disabled, or we risk losing DPIO and PLL -* synchronization. -*/ -intel_de_write (dev_priv,DPIO_CTL , -intel_de_read (dev_priv,DPIO_CTL ) |DPIO_CMNRST ); -} - -static void vlv_dpio_cmn_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum pipe pipe; - -for_each_pipe (dev_priv, pipe) -assert_pll_disabled (dev_priv, pipe); - -/* Assert common reset */ -intel_de_write (dev_priv,DPIO_CTL , -intel_de_read (dev_priv,DPIO_CTL ) & ~DPIO_CMNRST ); - -vlv_set_power_well (dev_priv, power_well, false); -} -#define POWER_DOMAIN_MASK (GENMASK_ULL(POWER_DOMAIN_NUM - 1, 0)) -#define BITS_SET (val, bits) (((val) & (bits)) == (bits)) - -static void assert_chv_phy_status (struct drm_i915_private *dev_priv) -{ -struct i915_power_well *cmn_bc = -lookup_power_well (dev_priv,VLV_DISP_PW_DPIO_CMN_BC ); -struct i915_power_well *cmn_d = -lookup_power_well (dev_priv,CHV_DISP_PW_DPIO_CMN_D ); -u32 phy_control = dev_priv->chv_phy_control; -u32 phy_status =0 ; -u32 phy_status_mask =0xffffffff ; - -/* -* The BIOS can leave the PHY is some weird state -* where it doesn't fully power down some parts. -* Disable the asserts until the PHY has been fully -* reset (ie. the power well has been disabled at -* least once). -*/ -if (!dev_priv->chv_phy_assert[DPIO_PHY0 ]) - phy_status_mask &= ~(PHY_STATUS_CMN_LDO (DPIO_PHY0 ,DPIO_CH0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH0 ,0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH0 ,1 ) | -PHY_STATUS_CMN_LDO (DPIO_PHY0 ,DPIO_CH1 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH1 ,0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH1 ,1 )); - -if (!dev_priv->chv_phy_assert[DPIO_PHY1 ]) - phy_status_mask &= ~(PHY_STATUS_CMN_LDO (DPIO_PHY1 ,DPIO_CH0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY1 ,DPIO_CH0 ,0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY1 ,DPIO_CH0 ,1 )); - -if (intel_power_well_is_enabled (dev_priv, cmn_bc)) { - phy_status |=PHY_POWERGOOD (DPIO_PHY0 ); - -/* this assumes override is only used to enable lanes */ -if ((phy_control &PHY_CH_POWER_DOWN_OVRD_EN (DPIO_PHY0 ,DPIO_CH0 )) ==0 ) - phy_control |=PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH0 ); - -if ((phy_control &PHY_CH_POWER_DOWN_OVRD_EN (DPIO_PHY0 ,DPIO_CH1 )) ==0 ) - phy_control |=PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH1 ); - -/* CL1 is on whenever anything is on in either channel */ -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH0 ) | -PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH1 ))) - phy_status |=PHY_STATUS_CMN_LDO (DPIO_PHY0 ,DPIO_CH0 ); - -/* -* The DPLLB check accounts for the pipe B + port A usage -* with CL2 powered up but all the lanes in the second channel -* powered down. -*/ -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH1 )) && - (intel_de_read (dev_priv,DPLL (PIPE_B )) &DPLL_VCO_ENABLE ) ==0 ) - phy_status |=PHY_STATUS_CMN_LDO (DPIO_PHY0 ,DPIO_CH1 ); - -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0x3 ,DPIO_PHY0 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH0 ,0 ); -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xc ,DPIO_PHY0 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH0 ,1 ); - -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0x3 ,DPIO_PHY0 ,DPIO_CH1 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH1 ,0 ); -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xc ,DPIO_PHY0 ,DPIO_CH1 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH1 ,1 ); - } - -if (intel_power_well_is_enabled (dev_priv, cmn_d)) { - phy_status |=PHY_POWERGOOD (DPIO_PHY1 ); - -/* this assumes override is only used to enable lanes */ -if ((phy_control &PHY_CH_POWER_DOWN_OVRD_EN (DPIO_PHY1 ,DPIO_CH0 )) ==0 ) - phy_control |=PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY1 ,DPIO_CH0 ); - -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY1 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_CMN_LDO (DPIO_PHY1 ,DPIO_CH0 ); - -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0x3 ,DPIO_PHY1 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY1 ,DPIO_CH0 ,0 ); -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xc ,DPIO_PHY1 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY1 ,DPIO_CH0 ,1 ); - } - - phy_status &= phy_status_mask; - -/* -* The PHY may be busy with some initial calibration and whatnot, -* so the power state can take a while to actually change. -*/ -if (intel_de_wait_for_register (dev_priv,DISPLAY_PHY_STATUS , - phy_status_mask, phy_status,10 )) -drm_err (&dev_priv->drm, -"Unexpected PHY_STATUS 0x%08x, expected 0x%08x (PHY_CONTROL=0x%08x)\n" , -intel_de_read (dev_priv,DISPLAY_PHY_STATUS ) & phy_status_mask, - phy_status, dev_priv->chv_phy_control); -} - -#undef BITS_SET - -static void chv_dpio_cmn_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum dpio_phy phy; -enum pipe pipe; -u32 tmp; - -drm_WARN_ON_ONCE (&dev_priv->drm, - power_well->desc->id !=VLV_DISP_PW_DPIO_CMN_BC && - power_well->desc->id !=CHV_DISP_PW_DPIO_CMN_D ); - -if (power_well->desc->id ==VLV_DISP_PW_DPIO_CMN_BC ) { - pipe =PIPE_A ; - phy =DPIO_PHY0 ; - }else { - pipe =PIPE_C ; - phy =DPIO_PHY1 ; - } - -/* since ref/cri clock was enabled */ -udelay (1 );/* >10ns for cmnreset, >0ns for sidereset */ -vlv_set_power_well (dev_priv, power_well, true); - -/* Poll for phypwrgood signal */ -if (intel_de_wait_for_set (dev_priv,DISPLAY_PHY_STATUS , -PHY_POWERGOOD (phy),1 )) -drm_err (&dev_priv->drm,"Display PHY %d is not power up\n" , - phy); - -vlv_dpio_get (dev_priv); - -/* Enable dynamic power down */ - tmp =vlv_dpio_read (dev_priv, pipe,CHV_CMN_DW28 ); - tmp |=DPIO_DYNPWRDOWNEN_CH0 |DPIO_CL1POWERDOWNEN | -DPIO_SUS_CLK_CONFIG_GATE_CLKREQ ; -vlv_dpio_write (dev_priv, pipe,CHV_CMN_DW28 , tmp); - -if (power_well->desc->id ==VLV_DISP_PW_DPIO_CMN_BC ) { - tmp =vlv_dpio_read (dev_priv, pipe, _CHV_CMN_DW6_CH1); - tmp |=DPIO_DYNPWRDOWNEN_CH1 ; -vlv_dpio_write (dev_priv, pipe, _CHV_CMN_DW6_CH1, tmp); - }else { -/* -* Force the non-existing CL2 off. BXT does this -* too, so maybe it saves some power even though -* CL2 doesn't exist? -*/ - tmp =vlv_dpio_read (dev_priv, pipe,CHV_CMN_DW30 ); - tmp |=DPIO_CL2_LDOFUSE_PWRENB ; -vlv_dpio_write (dev_priv, pipe,CHV_CMN_DW30 , tmp); - } - -vlv_dpio_put (dev_priv); - - dev_priv->chv_phy_control |=PHY_COM_LANE_RESET_DEASSERT (phy); -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); - -drm_dbg_kms (&dev_priv->drm, -"Enabled DPIO PHY%d (PHY_CONTROL=0x%08x)\n" , - phy, dev_priv->chv_phy_control); - -assert_chv_phy_status (dev_priv); -} - -static void chv_dpio_cmn_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum dpio_phy phy; - -drm_WARN_ON_ONCE (&dev_priv->drm, - power_well->desc->id !=VLV_DISP_PW_DPIO_CMN_BC && - power_well->desc->id !=CHV_DISP_PW_DPIO_CMN_D ); - -if (power_well->desc->id ==VLV_DISP_PW_DPIO_CMN_BC ) { - phy =DPIO_PHY0 ; -assert_pll_disabled (dev_priv,PIPE_A ); -assert_pll_disabled (dev_priv,PIPE_B ); - }else { - phy =DPIO_PHY1 ; -assert_pll_disabled (dev_priv,PIPE_C ); - } - - dev_priv->chv_phy_control &= ~PHY_COM_LANE_RESET_DEASSERT (phy); -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); - -vlv_set_power_well (dev_priv, power_well, false); - -drm_dbg_kms (&dev_priv->drm, -"Disabled DPIO PHY%d (PHY_CONTROL=0x%08x)\n" , - phy, dev_priv->chv_phy_control); - -/* PHY is fully reset now, so we can enable the PHY state asserts */ - dev_priv->chv_phy_assert[phy] = true; - -assert_chv_phy_status (dev_priv); -} - -static void assert_chv_phy_powergate (struct drm_i915_private *dev_priv,enum dpio_phy phy, -enum dpio_channel ch,bool override,unsigned int mask) -{ -enum pipe pipe = phy ==DPIO_PHY0 ?PIPE_A :PIPE_C ; -u32 reg, val, expected, actual; - -/* -* The BIOS can leave the PHY is some weird state -* where it doesn't fully power down some parts. -* Disable the asserts until the PHY has been fully -* reset (ie. the power well has been disabled at -* least once). -*/ -if (!dev_priv->chv_phy_assert[phy]) -return ; - -if (ch ==DPIO_CH0 ) - reg = _CHV_CMN_DW0_CH0; -else - reg = _CHV_CMN_DW6_CH1; - -vlv_dpio_get (dev_priv); - val =vlv_dpio_read (dev_priv, pipe, reg); -vlv_dpio_put (dev_priv); - -/* -* This assumes !override is only used when the port is disabled. -* All lanes should power down even without the override when -* the port is disabled. -*/ -if (!override || mask ==0xf ) { - expected =DPIO_ALLDL_POWERDOWN |DPIO_ANYDL_POWERDOWN ; -/* -* If CH1 common lane is not active anymore -* (eg. for pipe B DPLL) the entire channel will -* shut down, which causes the common lane registers -* to read as 0. That means we can't actually check -* the lane power down status bits, but as the entire -* register reads as 0 it's a good indication that the -* channel is indeed entirely powered down. -*/ -if (ch ==DPIO_CH1 && val ==0 ) - expected =0 ; - }else if (mask !=0x0 ) { - expected =DPIO_ANYDL_POWERDOWN ; - }else { - expected =0 ; - } - -if (ch ==DPIO_CH0 ) - actual = val >>DPIO_ANYDL_POWERDOWN_SHIFT_CH0 ; -else - actual = val >>DPIO_ANYDL_POWERDOWN_SHIFT_CH1 ; - actual &=DPIO_ALLDL_POWERDOWN |DPIO_ANYDL_POWERDOWN ; - -drm_WARN (&dev_priv->drm, actual != expected, -"Unexpected DPIO lane power down: all %d, any %d. Expected: all %d, any %d. (0x%x = 0x%08x)\n" , - !!(actual &DPIO_ALLDL_POWERDOWN ), - !!(actual &DPIO_ANYDL_POWERDOWN ), - !!(expected &DPIO_ALLDL_POWERDOWN ), - !!(expected &DPIO_ANYDL_POWERDOWN ), - reg, val); -} - -bool chv_phy_powergate_ch (struct drm_i915_private *dev_priv,enum dpio_phy phy, -enum dpio_channel ch,bool override) -{ -struct i915_power_domains *power_domains = &dev_priv->power_domains; -bool was_override; - -mutex_lock (&power_domains->lock); - - was_override = dev_priv->chv_phy_control &PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); - -if (override == was_override) - goto out; - -if (override) - dev_priv->chv_phy_control |=PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); -else - dev_priv->chv_phy_control &= ~PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); - -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); - -drm_dbg_kms (&dev_priv->drm, -"Power gating DPIO PHY%d CH%d (DPIO_PHY_CONTROL=0x%08x)\n" , - phy, ch, dev_priv->chv_phy_control); - -assert_chv_phy_status (dev_priv); - -out: -mutex_unlock (&power_domains->lock); - -return was_override; -} - -void chv_phy_powergate_lanes (struct intel_encoder *encoder, -bool override,unsigned int mask) -{ -struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); -struct i915_power_domains *power_domains = &dev_priv->power_domains; -enum dpio_phy phy =vlv_dig_port_to_phy (enc_to_dig_port (encoder)); -enum dpio_channel ch =vlv_dig_port_to_channel (enc_to_dig_port (encoder)); - -mutex_lock (&power_domains->lock); - - dev_priv->chv_phy_control &= ~PHY_CH_POWER_DOWN_OVRD (0xf , phy, ch); - dev_priv->chv_phy_control |=PHY_CH_POWER_DOWN_OVRD (mask, phy, ch); - -if (override) - dev_priv->chv_phy_control |=PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); -else - dev_priv->chv_phy_control &= ~PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); - -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); - -drm_dbg_kms (&dev_priv->drm, -"Power gating DPIO PHY%d CH%d lanes 0x%x (PHY_CONTROL=0x%08x)\n" , - phy, ch, mask, dev_priv->chv_phy_control); - -assert_chv_phy_status (dev_priv); - -assert_chv_phy_powergate (dev_priv, phy, ch, override, mask); - -mutex_unlock (&power_domains->lock); -} - -static bool chv_pipe_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum pipe pipe =PIPE_A ; -bool enabled; -u32 state, ctrl; - -vlv_punit_get (dev_priv); - - state =vlv_punit_read (dev_priv,PUNIT_REG_DSPSSPM ) &DP_SSS_MASK (pipe); -/* -* We only ever set the power-on and power-gate states, anything -* else is unexpected. -*/ -drm_WARN_ON (&dev_priv->drm, state !=DP_SSS_PWR_ON (pipe) && - state !=DP_SSS_PWR_GATE (pipe)); - enabled = state ==DP_SSS_PWR_ON (pipe); - -/* -* A transient state at this point would mean some unexpected party -* is poking at the power controls too. -*/ - ctrl =vlv_punit_read (dev_priv,PUNIT_REG_DSPSSPM ) &DP_SSC_MASK (pipe); -drm_WARN_ON (&dev_priv->drm, ctrl <<16 != state); - -vlv_punit_put (dev_priv); - -return enabled; -} - -static void chv_set_pipe_power_well (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well, -bool enable) -{ -enum pipe pipe =PIPE_A ; -u32 state; -u32 ctrl; - - state = enable ?DP_SSS_PWR_ON (pipe) :DP_SSS_PWR_GATE (pipe); - -vlv_punit_get (dev_priv); - -#define COND \ - ((vlv_punit_read(dev_priv, PUNIT_REG_DSPSSPM) & DP_SSS_MASK(pipe)) == state) - -if (COND ) - goto out; - - ctrl =vlv_punit_read (dev_priv,PUNIT_REG_DSPSSPM ); - ctrl &= ~DP_SSC_MASK (pipe); - ctrl |= enable ?DP_SSC_PWR_ON (pipe) :DP_SSC_PWR_GATE (pipe); -vlv_punit_write (dev_priv,PUNIT_REG_DSPSSPM , ctrl); - -if (wait_for (COND ,100 )) -drm_err (&dev_priv->drm, -"timeout setting power well state %08x (%08x)\n" , - state, -vlv_punit_read (dev_priv,PUNIT_REG_DSPSSPM )); - -#undef COND - -out: -vlv_punit_put (dev_priv); -} - -static void chv_pipe_power_well_sync_hw (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); -} - -static void chv_pipe_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -chv_set_pipe_power_well (dev_priv, power_well, true); - -vlv_display_power_well_init (dev_priv); -} - -static void chv_pipe_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_display_power_well_deinit (dev_priv); - -chv_set_pipe_power_well (dev_priv, power_well, false); -} -static u64 __async_put_domains_mask (struct i915_power_domains *power_domains) { return power_domains->async_put_domains[0] |
@@ -3034,27 +1477,6 @@ intel_display_power_put_mask_in_set(struct drm_i915_private *i915,#define XELPD_DDI_IO_TC3_POWER_DOMAINS BIT_ULL(POWER_DOMAIN_PORT_DDI_IO_TC3)#define XELPD_DDI_IO_TC4_POWER_DOMAINS BIT_ULL(POWER_DOMAIN_PORT_DDI_IO_TC4) -static const struct i915_power_well_ops i9xx_always_on_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = i9xx_always_on_power_well_noop, - .disable = i9xx_always_on_power_well_noop, - .is_enabled = i9xx_always_on_power_well_enabled, -}; - -static const struct i915_power_well_ops chv_pipe_power_well_ops = { - .sync_hw = chv_pipe_power_well_sync_hw, - .enable = chv_pipe_power_well_enable, - .disable = chv_pipe_power_well_disable, - .is_enabled = chv_pipe_power_well_enabled, -}; - -static const struct i915_power_well_ops chv_dpio_cmn_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = chv_dpio_cmn_power_well_enable, - .disable = chv_dpio_cmn_power_well_disable, - .is_enabled = vlv_power_well_enabled, -}; -static const struct i915_power_well_desc i9xx_always_on_power_well[] = { { .name ="always-on" ,
@@ -3065,13 +1487,6 @@ static const struct i915_power_well_desc i9xx_always_on_power_well[] = { }, }; -static const struct i915_power_well_ops i830_pipes_power_well_ops = { - .sync_hw = i830_pipes_power_well_sync_hw, - .enable = i830_pipes_power_well_enable, - .disable = i830_pipes_power_well_disable, - .is_enabled = i830_pipes_power_well_enabled, -}; -static const struct i915_power_well_desc i830_power_wells[] = { { .name ="always-on" ,
@@ -3088,35 +1503,6 @@ static const struct i915_power_well_desc i830_power_wells[] = { }, }; -static const struct i915_power_well_regs hsw_power_well_regs = { - .bios =HSW_PWR_WELL_CTL1 , - .driver =HSW_PWR_WELL_CTL2 , - .kvmr =HSW_PWR_WELL_CTL3 , - .debug =HSW_PWR_WELL_CTL4 , -}; - -static const struct i915_power_well_ops hsw_power_well_ops = { - .regs = &hsw_power_well_regs, - .sync_hw = hsw_power_well_sync_hw, - .enable = hsw_power_well_enable, - .disable = hsw_power_well_disable, - .is_enabled = hsw_power_well_enabled, -}; - -static const struct i915_power_well_ops gen9_dc_off_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = gen9_dc_off_power_well_enable, - .disable = gen9_dc_off_power_well_disable, - .is_enabled = gen9_dc_off_power_well_enabled, -}; - -static const struct i915_power_well_ops bxt_dpio_cmn_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = bxt_dpio_cmn_power_well_enable, - .disable = bxt_dpio_cmn_power_well_disable, - .is_enabled = bxt_dpio_cmn_power_well_enabled, -}; -static const struct i915_power_well_desc hsw_power_wells[] = { { .name ="always-on" ,
@@ -3158,27 +1544,6 @@ static const struct i915_power_well_desc bdw_power_wells[] = { }, }; -static const struct i915_power_well_ops vlv_display_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = vlv_display_power_well_enable, - .disable = vlv_display_power_well_disable, - .is_enabled = vlv_power_well_enabled, -}; - -static const struct i915_power_well_ops vlv_dpio_cmn_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = vlv_dpio_cmn_power_well_enable, - .disable = vlv_dpio_cmn_power_well_disable, - .is_enabled = vlv_power_well_enabled, -}; - -static const struct i915_power_well_ops vlv_dpio_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = vlv_power_well_enable, - .disable = vlv_power_well_disable, - .is_enabled = vlv_power_well_enabled, -}; -static const struct i915_power_well_desc vlv_power_wells[] = { { .name ="always-on" ,
@@ -3560,34 +1925,6 @@ static const struct i915_power_well_desc glk_power_wells[] = { }, }; -static const struct i915_power_well_regs icl_aux_power_well_regs = { - .bios =ICL_PWR_WELL_CTL_AUX1 , - .driver =ICL_PWR_WELL_CTL_AUX2 , - .debug =ICL_PWR_WELL_CTL_AUX4 , -}; - -static const struct i915_power_well_ops icl_aux_power_well_ops = { - .regs = &icl_aux_power_well_regs, - .sync_hw = hsw_power_well_sync_hw, - .enable = icl_aux_power_well_enable, - .disable = icl_aux_power_well_disable, - .is_enabled = hsw_power_well_enabled, -}; - -static const struct i915_power_well_regs icl_ddi_power_well_regs = { - .bios =ICL_PWR_WELL_CTL_DDI1 , - .driver =ICL_PWR_WELL_CTL_DDI2 , - .debug =ICL_PWR_WELL_CTL_DDI4 , -}; - -static const struct i915_power_well_ops icl_ddi_power_well_ops = { - .regs = &icl_ddi_power_well_regs, - .sync_hw = hsw_power_well_sync_hw, - .enable = hsw_power_well_enable, - .disable = hsw_power_well_disable, - .is_enabled = hsw_power_well_enabled, -}; -static const struct i915_power_well_desc icl_power_wells[] = { { .name ="always-on" ,
@@ -3801,90 +2138,6 @@ static const struct i915_power_well_desc icl_power_wells[] = { }, }; -static void -tgl_tc_cold_request (struct drm_i915_private *i915,bool block) -{ -u8 tries =0 ; -int ret; - -while (1 ) { -u32 low_val; -u32 high_val =0 ; - -if (block) - low_val =TGL_PCODE_EXIT_TCCOLD_DATA_L_BLOCK_REQ ; -else - low_val =TGL_PCODE_EXIT_TCCOLD_DATA_L_UNBLOCK_REQ ; - -/* -* Spec states that we should timeout the request after 200us -* but the function below will timeout after 500us -*/ - ret =snb_pcode_read (i915,TGL_PCODE_TCCOLD , &low_val, &high_val); -if (ret ==0 ) { -if (block && - (low_val &TGL_PCODE_EXIT_TCCOLD_DATA_L_EXIT_FAILED )) - ret = -EIO ; -else -break ; - } - -if (++tries ==3 ) -break ; - -msleep (1 ); - } - -if (ret) -drm_err (&i915->drm,"TC cold %sblock failed\n" , - block ?"" :"un" ); -else -drm_dbg_kms (&i915->drm,"TC cold %sblock succeeded\n" , - block ?"" :"un" ); -} - -static void -tgl_tc_cold_off_power_well_enable (struct drm_i915_private *i915, -struct i915_power_well *power_well) -{ -tgl_tc_cold_request (i915, true); -} - -static void -tgl_tc_cold_off_power_well_disable (struct drm_i915_private *i915, -struct i915_power_well *power_well) -{ -tgl_tc_cold_request (i915, false); -} - -static void -tgl_tc_cold_off_power_well_sync_hw (struct drm_i915_private *i915, -struct i915_power_well *power_well) -{ -if (intel_power_well_refcount (power_well) >0 ) -tgl_tc_cold_off_power_well_enable (i915, power_well); -else -tgl_tc_cold_off_power_well_disable (i915, power_well); -} - -static bool -tgl_tc_cold_off_power_well_is_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -/* -* Not the correctly implementation but there is no way to just read it -* from PCODE, so returning count to avoid state mismatch errors -*/ -return intel_power_well_refcount (power_well); -} - -static const struct i915_power_well_ops tgl_tc_cold_off_ops = { - .sync_hw = tgl_tc_cold_off_power_well_sync_hw, - .enable = tgl_tc_cold_off_power_well_enable, - .disable = tgl_tc_cold_off_power_well_disable, - .is_enabled = tgl_tc_cold_off_power_well_is_enabled, -}; -static const struct i915_power_well_desc tgl_power_wells[] = { { .name ="always-on" ,
drivers/gpu/drm/i915/display/intel_display_power.h +0 -5
@@ -305,9 +305,4 @@ void gen9_dbuf_slices_update(struct drm_i915_private *dev_priv,for ((wf) =intel_display_power_get_if_enabled ((i915), (domain)); (wf); \ intel_display_power_put_async((i915), (domain), (wf)), (wf) = 0) -void chv_phy_powergate_lanes(struct intel_encoder *encoder, - bool override, unsigned int mask); -bool chv_phy_powergate_ch (struct drm_i915_private *dev_priv,enum dpio_phy phy, -enum dpio_channel ch,bool override); -#endif /* __INTEL_DISPLAY_POWER_H__ */
drivers/gpu/drm/i915/display/intel_display_power_well.c +1806 -0
1,172 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_well.h +27 -35
62 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dpio_phy.c +1 -0
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/i915/display/intel_pps.c +1 -0
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.30.2
Part of the diff is not shown here. View the raw message.
PATCH 2/18 drm/i915: Unexport the for_each_power_well() macros
The for_each_power_well() macros are only used in intel_display_power.c and intel_display_power_well.c, so unexport them.
--- .../drm/i915/display/intel_display_power.c | 8 ++++++++ .../drm/i915/display/intel_display_power.h | 20 ------------------- .../i915/display/intel_display_power_well.h | 12 +++++++++++ 3 files changed, 20 insertions(+), 20 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +8 -0
@@ -21,6 +21,14 @@#include "intel_snps_phy.h" #include "vlv_sideband.h" +#define for_each_power_domain_well (__dev_priv, __power_well, __domain_mask) \ + for_each_power_well(__dev_priv, __power_well) \ + for_each_if((__power_well)->desc->domains & (__domain_mask)) + +#define for_each_power_domain_well_reverse (__dev_priv, __power_well, __domain_mask) \ + for_each_power_well_reverse(__dev_priv, __power_well) \ + for_each_if((__power_well)->desc->domains & (__domain_mask)) +const char *intel_display_power_domain_str (enum intel_display_power_domain domain) {
drivers/gpu/drm/i915/display/intel_display_power.h +0 -20
@@ -172,26 +172,6 @@ struct intel_display_power_domain_set {for ((domain) =0 ; (domain) <POWER_DOMAIN_NUM ; (domain)++) \ for_each_if(BIT_ULL(domain) & (mask)) -#define for_each_power_well (__dev_priv, __power_well) \ - for ((__power_well) = (__dev_priv)->power_domains.power_wells; \ - (__power_well) - (__dev_priv)->power_domains.power_wells < \ - (__dev_priv)->power_domains.power_well_count; \ - (__power_well)++) - -#define for_each_power_well_reverse (__dev_priv, __power_well) \ - for ((__power_well) = (__dev_priv)->power_domains.power_wells + \ - (__dev_priv)->power_domains.power_well_count - 1; \ - (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \ - (__power_well)--) - -#define for_each_power_domain_well (__dev_priv, __power_well, __domain_mask) \ - for_each_power_well(__dev_priv, __power_well) \ - for_each_if((__power_well)->desc->domains & (__domain_mask)) - -#define for_each_power_domain_well_reverse (__dev_priv, __power_well, __domain_mask) \ - for_each_power_well_reverse(__dev_priv, __power_well) \ - for_each_if((__power_well)->desc->domains & (__domain_mask)) -int intel_power_domains_init (struct drm_i915_private *dev_priv);void intel_power_domains_cleanup (struct drm_i915_private *dev_priv);void intel_power_domains_init_hw (struct drm_i915_private *dev_priv,bool resume);
drivers/gpu/drm/i915/display/intel_display_power_well.h +12 -0
@@ -12,6 +12,18 @@struct drm_i915_private ;struct i915_power_well ; +#define for_each_power_well (__dev_priv, __power_well) \ + for ((__power_well) = (__dev_priv)->power_domains.power_wells; \ + (__power_well) - (__dev_priv)->power_domains.power_wells < \ + (__dev_priv)->power_domains.power_well_count; \ + (__power_well)++) + +#define for_each_power_well_reverse (__dev_priv, __power_well) \ + for ((__power_well) = (__dev_priv)->power_domains.power_wells + \ + (__dev_priv)->power_domains.power_well_count - 1; \ + (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \ + (__power_well)--) +/* * i915_power_well_id: *
Signature · 1 line
2.30.2
PATCH 3/18 drm/i915: Move the power domain->well mappings to intel_display_power_map.c
In reply to Imre DeakMove the list of platform specific power domain -> power well definitions to intel_display_power_map.c. While at it group the platforms' power domain macros with the corresponding power well lists and keep all the power domain lists in the same order (matching the enum order).
No functional changes.
v2:
- s/intel_display_power_internal.h/intel_display_power_map.h/ (Jani)
- Simplify intel_cleanup_power_wells().
- Don't move intel_display_power_domain_str().
v3:
- Rename intel_init/cleanup_power_wells() to intel_display_power_map_init/cleanup().
- Add documentation to intel_display_power_map_init/cleanup().
--- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_display_power.c | 2260 +---------------- .../i915/display/intel_display_power_map.c | 2150 ++++++++++++++++ .../i915/display/intel_display_power_map.h | 14 + 4 files changed, 2168 insertions(+), 2257 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_power_map.c create mode 100644 drivers/gpu/drm/i915/display/intel_display_power_map.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -220,6 +220,7 @@ i915-y += \ display/intel_cursor.o \ display/intel_display.o \ display/intel_display_power.o \ + display/intel_display_power_map.o \ display/intel_display_power_well.o \ display/intel_dmc.o \ display/intel_dpio_phy.o \
drivers/gpu/drm/i915/display/intel_display_power.c +3 -2257
2,296 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_map.c new file +2150 -0
697 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_map.h new file +14 -0
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.30.2
Part of the diff is not shown here. View the raw message.
PATCH 4/18 drm/i915: Move the dg2 fixed_enable_delay power well param to a common bitfield
In reply to Imre DeakThe DG2 fixed delay duration is always 600usec, so save some space in the power well descriptors by converting the parameter to a flag. While at it also use a bitfield for both the always_on and fixed_enable_delay flag.
This change also lets simplifying the definiton of power wells sharing the same flags in an upcoming patch.
--- .../gpu/drm/i915/display/intel_display_power_map.c | 10 +++++----- .../drm/i915/display/intel_display_power_well.c | 5 ++--- .../drm/i915/display/intel_display_power_well.h | 14 +++++++------- 3 files changed, 14 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +5 -5
@@ -1920,37 +1920,37 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .name = "AUX A", .domains = ICL_AUX_A_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .fixed_enable_delay = true, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_A, - .hsw.fixed_enable_delay = 600, }, }, { .name = "AUX B", .domains = ICL_AUX_B_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .fixed_enable_delay = true, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_B, - .hsw.fixed_enable_delay = 600, }, }, { .name = "AUX C", .domains = TGL_AUX_C_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .fixed_enable_delay = true, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_C, - .hsw.fixed_enable_delay = 600, }, }, { .name = "AUX D_XELPD", .domains = XELPD_AUX_IO_D_XELPD_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .fixed_enable_delay = true, .id = DISP_PW_ID_NONE, { .hsw.idx = XELPD_PW_CTL_IDX_AUX_D, - .hsw.fixed_enable_delay = 600, }, }, { .name = "AUX E_XELPD",
@@ -1964,10 +1964,10 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .name = "AUX USBC1", .domains = XELPD_AUX_IO_USBC1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .fixed_enable_delay = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1, - .hsw.fixed_enable_delay = 600, }, }, { .name = "AUX USBC2",
drivers/gpu/drm/i915/display/intel_display_power_well.c +2 -3
@@ -243,15 +243,14 @@ static void hsw_wait_for_power_well_enable(struct drm_i915_private *dev_priv, {const struct i915_power_well_regs *regs = power_well->desc->ops->regs;int pw_idx = power_well->desc->hsw.idx; -int enable_delay = power_well->desc->hsw.fixed_enable_delay;/* * For some power wells we're not supposed to watch the status bit for * an ack, but rather just wait a fixed amount of time and then * proceed. This is only used on DG2. */ -if (IS_DG2 (dev_priv) && enable_delay) { -usleep_range (enable_delay,2 * enable_delay); +if (IS_DG2 (dev_priv) && power_well->desc->fixed_enable_delay) { +usleep_range (600 ,1200 );return ; }
drivers/gpu/drm/i915/display/intel_display_power_well.h +7 -7
@@ -50,8 +50,14 @@ enum i915_power_well_id {struct i915_power_well_desc {const char *name; -bool always_on;u64 domains; +u8 always_on:1 ; +/* +* Instead of waiting for the status bit to ack enables, +* just wait a specific amount of time and then consider +* the well enabled. +*/ +u8 fixed_enable_delay:1 ;/* unique identifier for this power well */ enum i915_power_well_id id;/*
@@ -77,12 +83,6 @@ struct i915_power_well_desc {u8 idx;/* Mask of pipes whose IRQ logic is backed by the pw */ u8 irq_pipe_mask; -/* -* Instead of waiting for the status bit to ack enables, -* just wait a specific amount of time and then consider -* the well enabled. -*/ -u16 fixed_enable_delay;/* The pw is backing the VGA functionality */ bool has_vga:1; bool has_fuses:1;
Signature · 1 line
2.30.2
PATCH 5/18 drm/i915: Move the HSW power well flags to a common bitfield
In reply to Imre DeakSave some space by grouping the HSW power well descriptor flags along with other flags in one bitfield.
This change also lets simplifying the definition of power well descriptors sharing the same flags in an upcoming patch.
--- .../i915/display/intel_display_power_map.c | 166 +++++++++--------- .../i915/display/intel_display_power_well.c | 16 +- .../i915/display/intel_display_power_well.h | 25 +-- 3 files changed, 104 insertions(+), 103 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +83 -83
@@ -76,10 +76,10 @@ static const struct i915_power_well_desc hsw_power_wells[] = { .name = "display", .domains = HSW_DISPLAY_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_vga = true, .id = HSW_DISP_PW_GLOBAL, { .hsw.idx = HSW_PW_CTL_IDX_GLOBAL, - .hsw.has_vga = true, }, }, };
@@ -112,11 +112,11 @@ static const struct i915_power_well_desc bdw_power_wells[] = { .name = "display", .domains = BDW_DISPLAY_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_vga = true, + .irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), .id = HSW_DISP_PW_GLOBAL, { .hsw.idx = HSW_PW_CTL_IDX_GLOBAL, - .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), - .hsw.has_vga = true, }, }, };
@@ -368,10 +368,10 @@ static const struct i915_power_well_desc skl_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .always_on = true, + .has_fuses = true, .id = SKL_DISP_PW_1, { .hsw.idx = SKL_PW_CTL_IDX_PW_1, - .hsw.has_fuses = true, }, }, { .name = "MISC IO power well",
@@ -392,12 +392,12 @@ static const struct i915_power_well_desc skl_power_wells[] = { .name = "power well 2", .domains = SKL_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_vga = true, + .irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), + .has_fuses = true, .id = SKL_DISP_PW_2, { .hsw.idx = SKL_PW_CTL_IDX_PW_2, - .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), - .hsw.has_vga = true, - .hsw.has_fuses = true, }, }, { .name = "DDI A/E IO power well",
@@ -484,10 +484,10 @@ static const struct i915_power_well_desc bxt_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .always_on = true, + .has_fuses = true, .id = SKL_DISP_PW_1, { .hsw.idx = SKL_PW_CTL_IDX_PW_1, - .hsw.has_fuses = true, }, }, { .name = "DC off",
@@ -498,12 +498,12 @@ static const struct i915_power_well_desc bxt_power_wells[] = { .name = "power well 2", .domains = BXT_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_vga = true, + .irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), + .has_fuses = true, .id = SKL_DISP_PW_2, { .hsw.idx = SKL_PW_CTL_IDX_PW_2, - .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), - .hsw.has_vga = true, - .hsw.has_fuses = true, }, }, { .name = "dpio-common-a",
@@ -594,10 +594,10 @@ static const struct i915_power_well_desc glk_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .always_on = true, + .has_fuses = true, .id = SKL_DISP_PW_1, { .hsw.idx = SKL_PW_CTL_IDX_PW_1, - .hsw.has_fuses = true, }, }, { .name = "DC off",
@@ -608,12 +608,12 @@ static const struct i915_power_well_desc glk_power_wells[] = { .name = "power well 2", .domains = GLK_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_vga = true, + .irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), + .has_fuses = true, .id = SKL_DISP_PW_2, { .hsw.idx = SKL_PW_CTL_IDX_PW_2, - .hsw.irq_pipe_mask = BIT(PIPE_B) | BIT(PIPE_C), - .hsw.has_vga = true, - .hsw.has_fuses = true, }, }, { .name = "dpio-common-a",
@@ -789,10 +789,10 @@ static const struct i915_power_well_desc icl_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .always_on = true, + .has_fuses = true, .id = SKL_DISP_PW_1, { .hsw.idx = ICL_PW_CTL_IDX_PW_1, - .hsw.has_fuses = true, }, }, { .name = "DC off",
@@ -803,21 +803,21 @@ static const struct i915_power_well_desc icl_power_wells[] = { .name = "power well 2", .domains = ICL_PW_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_fuses = true, .id = SKL_DISP_PW_2, { .hsw.idx = ICL_PW_CTL_IDX_PW_2, - .hsw.has_fuses = true, }, }, { .name = "power well 3", .domains = ICL_PW_3_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_vga = true, + .irq_pipe_mask = BIT(PIPE_B), + .has_fuses = true, .id = ICL_DISP_PW_3, { .hsw.idx = ICL_PW_CTL_IDX_PW_3, - .hsw.irq_pipe_mask = BIT(PIPE_B), - .hsw.has_vga = true, - .hsw.has_fuses = true, }, }, { .name = "DDI A IO",
@@ -887,83 +887,83 @@ static const struct i915_power_well_desc icl_power_wells[] = { .name = "AUX C TC1", .domains = ICL_AUX_C_TC1_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_C, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX D TC2", .domains = ICL_AUX_D_TC2_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_D, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX E TC3", .domains = ICL_AUX_E_TC3_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_E, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX F TC4", .domains = ICL_AUX_F_TC4_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_F, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX C TBT1", .domains = ICL_AUX_C_TBT1_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT1, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX D TBT2", .domains = ICL_AUX_D_TBT2_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT2, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX E TBT3", .domains = ICL_AUX_E_TBT3_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT3, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX F TBT4", .domains = ICL_AUX_F_TBT4_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT4, - .hsw.is_tc_tbt = true, }, }, { .name = "power well 4", .domains = ICL_PW_4_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .irq_pipe_mask = BIT(PIPE_C), + .has_fuses = true, .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_PW_4, - .hsw.has_fuses = true, - .hsw.irq_pipe_mask = BIT(PIPE_C), }, }, };
@@ -1077,10 +1077,10 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .always_on = true, + .has_fuses = true, .id = SKL_DISP_PW_1, { .hsw.idx = ICL_PW_CTL_IDX_PW_1, - .hsw.has_fuses = true, }, }, { .name = "DC off",
@@ -1091,21 +1091,21 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .name = "power well 2", .domains = TGL_PW_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_fuses = true, .id = SKL_DISP_PW_2, { .hsw.idx = ICL_PW_CTL_IDX_PW_2, - .hsw.has_fuses = true, }, }, { .name = "power well 3", .domains = TGL_PW_3_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_vga = true, + .irq_pipe_mask = BIT(PIPE_B), + .has_fuses = true, .id = ICL_DISP_PW_3, { .hsw.idx = ICL_PW_CTL_IDX_PW_3, - .hsw.irq_pipe_mask = BIT(PIPE_B), - .hsw.has_vga = true, - .hsw.has_fuses = true, }, }, { .name = "DDI A IO",
@@ -1212,129 +1212,129 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .name = "AUX USBC1", .domains = TGL_AUX_IO_USBC1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX USBC2", .domains = TGL_AUX_IO_USBC2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX USBC3", .domains = TGL_AUX_IO_USBC3_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX USBC4", .domains = TGL_AUX_IO_USBC4_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX USBC5", .domains = TGL_AUX_IO_USBC5_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC5, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX USBC6", .domains = TGL_AUX_IO_USBC6_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC6, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX TBT1", .domains = TGL_AUX_IO_TBT1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX TBT2", .domains = TGL_AUX_IO_TBT2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX TBT3", .domains = TGL_AUX_IO_TBT3_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX TBT4", .domains = TGL_AUX_IO_TBT4_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX TBT5", .domains = TGL_AUX_IO_TBT5_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT5, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX TBT6", .domains = TGL_AUX_IO_TBT6_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT6, - .hsw.is_tc_tbt = true, }, }, { .name = "power well 4", .domains = TGL_PW_4_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_fuses = true, + .irq_pipe_mask = BIT(PIPE_C), .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_PW_4, - .hsw.has_fuses = true, - .hsw.irq_pipe_mask = BIT(PIPE_C), } }, { .name = "power well 5", .domains = TGL_PW_5_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_fuses = true, + .irq_pipe_mask = BIT(PIPE_D), .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_PW_5, - .hsw.has_fuses = true, - .hsw.irq_pipe_mask = BIT(PIPE_D), }, }, };
@@ -1400,10 +1400,10 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .always_on = true, + .has_fuses = true, .id = SKL_DISP_PW_1, { .hsw.idx = ICL_PW_CTL_IDX_PW_1, - .hsw.has_fuses = true, }, }, { .name = "DC off",
@@ -1414,22 +1414,22 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .name = "power well 3", .domains = RKL_PW_3_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .irq_pipe_mask = BIT(PIPE_B), + .has_vga = true, + .has_fuses = true, .id = ICL_DISP_PW_3, { .hsw.idx = ICL_PW_CTL_IDX_PW_3, - .hsw.irq_pipe_mask = BIT(PIPE_B), - .hsw.has_vga = true, - .hsw.has_fuses = true, }, }, { .name = "power well 4", .domains = RKL_PW_4_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_fuses = true, + .irq_pipe_mask = BIT(PIPE_C), .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_PW_4, - .hsw.has_fuses = true, - .hsw.irq_pipe_mask = BIT(PIPE_C), } }, { .name = "DDI A IO",
@@ -1540,10 +1540,10 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .always_on = true, + .has_fuses = true, .id = SKL_DISP_PW_1, { .hsw.idx = ICL_PW_CTL_IDX_PW_1, - .hsw.has_fuses = true, }, }, { .name = "DC off",
@@ -1554,21 +1554,21 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .name = "power well 2", .domains = DG1_PW_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_fuses = true, .id = SKL_DISP_PW_2, { .hsw.idx = ICL_PW_CTL_IDX_PW_2, - .hsw.has_fuses = true, }, }, { .name = "power well 3", .domains = DG1_PW_3_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .irq_pipe_mask = BIT(PIPE_B), + .has_vga = true, + .has_fuses = true, .id = ICL_DISP_PW_3, { .hsw.idx = ICL_PW_CTL_IDX_PW_3, - .hsw.irq_pipe_mask = BIT(PIPE_B), - .hsw.has_vga = true, - .hsw.has_fuses = true, }, }, { .name = "DDI A IO",
@@ -1622,39 +1622,39 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .name = "AUX USBC1", .domains = TGL_AUX_IO_USBC1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1, - .hsw.is_tc_tbt = false, }, }, { .name = "AUX USBC2", .domains = TGL_AUX_IO_USBC2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = false, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2, - .hsw.is_tc_tbt = false, }, }, { .name = "power well 4", .domains = TGL_PW_4_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_fuses = true, + .irq_pipe_mask = BIT(PIPE_C), .id = DISP_PW_ID_NONE, { .hsw.idx = ICL_PW_CTL_IDX_PW_4, - .hsw.has_fuses = true, - .hsw.irq_pipe_mask = BIT(PIPE_C), } }, { .name = "power well 5", .domains = TGL_PW_5_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_fuses = true, + .irq_pipe_mask = BIT(PIPE_D), .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_PW_5, - .hsw.has_fuses = true, - .hsw.irq_pipe_mask = BIT(PIPE_D), }, }, };
@@ -1784,10 +1784,10 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .domains = 0, .ops = &hsw_power_well_ops, .always_on = true, + .has_fuses = true, .id = SKL_DISP_PW_1, { .hsw.idx = ICL_PW_CTL_IDX_PW_1, - .hsw.has_fuses = true, }, }, { .name = "DC off",
@@ -1798,51 +1798,51 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .name = "power well 2", .domains = XELPD_PW_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .has_vga = true, + .has_fuses = true, .id = SKL_DISP_PW_2, { .hsw.idx = ICL_PW_CTL_IDX_PW_2, - .hsw.has_vga = true, - .hsw.has_fuses = true, }, }, { .name = "power well A", .domains = XELPD_PW_A_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .irq_pipe_mask = BIT(PIPE_A), + .has_fuses = true, .id = DISP_PW_ID_NONE, { .hsw.idx = XELPD_PW_CTL_IDX_PW_A, - .hsw.irq_pipe_mask = BIT(PIPE_A), - .hsw.has_fuses = true, }, }, { .name = "power well B", .domains = XELPD_PW_B_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .irq_pipe_mask = BIT(PIPE_B), + .has_fuses = true, .id = DISP_PW_ID_NONE, { .hsw.idx = XELPD_PW_CTL_IDX_PW_B, - .hsw.irq_pipe_mask = BIT(PIPE_B), - .hsw.has_fuses = true, }, }, { .name = "power well C", .domains = XELPD_PW_C_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .irq_pipe_mask = BIT(PIPE_C), + .has_fuses = true, .id = DISP_PW_ID_NONE, { .hsw.idx = XELPD_PW_CTL_IDX_PW_C, - .hsw.irq_pipe_mask = BIT(PIPE_C), - .hsw.has_fuses = true, }, }, { .name = "power well D", .domains = XELPD_PW_D_POWER_DOMAINS, .ops = &hsw_power_well_ops, + .irq_pipe_mask = BIT(PIPE_D), + .has_fuses = true, .id = DISP_PW_ID_NONE, { .hsw.idx = XELPD_PW_CTL_IDX_PW_D, - .hsw.irq_pipe_mask = BIT(PIPE_D), - .hsw.has_fuses = true, }, }, { .name = "DDI A IO",
@@ -1997,37 +1997,37 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .name = "AUX TBT1", .domains = XELPD_AUX_IO_TBT1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX TBT2", .domains = XELPD_AUX_IO_TBT2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX TBT3", .domains = XELPD_AUX_IO_TBT3_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3, - .hsw.is_tc_tbt = true, }, }, { .name = "AUX TBT4", .domains = XELPD_AUX_IO_TBT4_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, + .is_tc_tbt = true, .id = DISP_PW_ID_NONE, { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4, - .hsw.is_tc_tbt = true, }, }, };
drivers/gpu/drm/i915/display/intel_display_power_well.c +8 -8
@@ -197,8 +197,8 @@ static enum aux_ch icl_aux_pw_to_ch(const struct i915_power_well *power_well) {int pw_idx = power_well->desc->hsw.idx; -return power_well->desc->hsw.is_tc_tbt ?ICL_TBT_AUX_PW_TO_CH (pw_idx) : -ICL_AUX_PW_TO_CH (pw_idx); +return power_well->desc->is_tc_tbt ?ICL_TBT_AUX_PW_TO_CH (pw_idx) : +ICL_AUX_PW_TO_CH (pw_idx); } static struct intel_digital_port *
@@ -326,7 +326,7 @@ static void hsw_power_well_enable(struct drm_i915_private *dev_priv,int pw_idx = power_well->desc->hsw.idx;u32 val; -if (power_well->desc->hsw.has_fuses) { +if (power_well->desc->has_fuses) {enum skl_power_gate pg; pg = DISPLAY_VER(dev_priv) >= 11 ? ICL_PW_CTL_IDX_TO_PG(pw_idx) :
@@ -353,7 +353,7 @@ static void hsw_power_well_enable(struct drm_i915_private *dev_priv,hsw_wait_for_power_well_enable (dev_priv, power_well, false); -if (power_well->desc->hsw.has_fuses) { +if (power_well->desc->has_fuses) {enum skl_power_gate pg; pg = DISPLAY_VER(dev_priv) >= 11 ? ICL_PW_CTL_IDX_TO_PG(pw_idx) :
@@ -362,8 +362,8 @@ static void hsw_power_well_enable(struct drm_i915_private *dev_priv, }hsw_power_well_post_enable (dev_priv, - power_well->desc->hsw.irq_pipe_mask, - power_well->desc->hsw.has_vga); + power_well->desc->irq_pipe_mask, + power_well->desc->has_vga); } static void hsw_power_well_disable(struct drm_i915_private *dev_priv,
@@ -374,7 +374,7 @@ static void hsw_power_well_disable(struct drm_i915_private *dev_priv,u32 val;hsw_power_well_pre_disable (dev_priv, - power_well->desc->hsw.irq_pipe_mask); + power_well->desc->irq_pipe_mask); val =intel_de_read (dev_priv, regs->driver); intel_de_write(dev_priv, regs->driver,
@@ -491,7 +491,7 @@ icl_tc_phy_aux_power_well_enable(struct drm_i915_private *dev_priv,enum aux_ch aux_ch =icl_aux_pw_to_ch (power_well);struct intel_digital_port *dig_port =aux_ch_to_digital_port (dev_priv, aux_ch);const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -bool is_tbt = power_well->desc->hsw.is_tc_tbt; +bool is_tbt = power_well->desc->is_tc_tbt;bool timeout_expected;u32 val;
drivers/gpu/drm/i915/display/intel_display_power_well.h +13 -12
@@ -51,13 +51,24 @@ enum i915_power_well_id {struct i915_power_well_desc {const char *name;u64 domains; -u8 always_on:1 ; +/* Mask of pipes whose IRQ logic is backed by the pw */ +u16 irq_pipe_mask:4 ; +u16 always_on:1 ;/* * Instead of waiting for the status bit to ack enables, * just wait a specific amount of time and then consider * the well enabled. */ -u8 fixed_enable_delay:1 ; +u16 fixed_enable_delay:1 ; +/* The pw is backing the VGA functionality */ +u16 has_vga:1 ; +u16 has_fuses:1 ; +/* +* The pw is for an ICL+ TypeC PHY port in +* Thunderbolt mode. +*/ +u16 is_tc_tbt:1 ; +/* unique identifier for this power well */ enum i915_power_well_id id;/*
@@ -81,16 +92,6 @@ struct i915_power_well_desc {* constrol/status registers. */ u8 idx; -/* Mask of pipes whose IRQ logic is backed by the pw */ -u8 irq_pipe_mask; -/* The pw is backing the VGA functionality */ - bool has_vga:1; - bool has_fuses:1; -/* -* The pw is for an ICL+ TypeC PHY port in -* Thunderbolt mode. -*/ - bool is_tc_tbt:1; } hsw; };const struct i915_power_well_ops *ops;
Signature · 1 line
2.30.2
PATCH 6/18 drm/i915: Rename the power domain names to end with pipes/ports
In reply to Imre DeakMake all power domain names end with the pipe/port instance for consistency.
No functional changes.
--- drivers/gpu/drm/i915/display/icl_dsi.c | 8 +- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 34 ++-- .../drm/i915/display/intel_display_power.c | 116 +++++------ .../drm/i915/display/intel_display_power.h | 66 +++---- .../i915/display/intel_display_power_map.c | 184 +++++++++--------- 6 files changed, 205 insertions(+), 205 deletions(-)
drivers/gpu/drm/i915/display/icl_dsi.c +4 -4
@@ -399,8 +399,8 @@ static void get_dsi_io_power_domains(struct drm_i915_private *dev_priv, intel_dsi->io_wakeref[port] =intel_display_power_get (dev_priv, port ==PORT_A ? -POWER_DOMAIN_PORT_DDI_A_IO : -POWER_DOMAIN_PORT_DDI_B_IO ); +POWER_DOMAIN_PORT_DDI_IO_A : +POWER_DOMAIN_PORT_DDI_IO_B ); } }
@@ -1425,8 +1425,8 @@ static void gen11_dsi_disable_io_power(struct intel_encoder *encoder) wakeref =fetch_and_zero (&intel_dsi->io_wakeref[port]);intel_display_power_put (dev_priv, port ==PORT_A ? -POWER_DOMAIN_PORT_DDI_A_IO : -POWER_DOMAIN_PORT_DDI_B_IO , +POWER_DOMAIN_PORT_DDI_IO_A : +POWER_DOMAIN_PORT_DDI_IO_B , wakeref); }
drivers/gpu/drm/i915/display/intel_ddi.c +1 -1
@@ -4492,7 +4492,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) }drm_WARN_ON (&dev_priv->drm, port >PORT_I ); - dig_port->ddi_io_power_domain =POWER_DOMAIN_PORT_DDI_A_IO + + dig_port->ddi_io_power_domain =POWER_DOMAIN_PORT_DDI_IO_A + port -PORT_A ;if (init_dp) {
drivers/gpu/drm/i915/display/intel_display.c +17 -17
@@ -2161,23 +2161,23 @@ enum intel_display_power_domain intel_port_to_power_domain(enum port port) {switch (port) {case PORT_A : -return POWER_DOMAIN_PORT_DDI_A_LANES ; +return POWER_DOMAIN_PORT_DDI_LANES_A ;case PORT_B : -return POWER_DOMAIN_PORT_DDI_B_LANES ; +return POWER_DOMAIN_PORT_DDI_LANES_B ;case PORT_C : -return POWER_DOMAIN_PORT_DDI_C_LANES ; +return POWER_DOMAIN_PORT_DDI_LANES_C ;case PORT_D : -return POWER_DOMAIN_PORT_DDI_D_LANES ; +return POWER_DOMAIN_PORT_DDI_LANES_D ;case PORT_E : -return POWER_DOMAIN_PORT_DDI_E_LANES ; +return POWER_DOMAIN_PORT_DDI_LANES_E ;case PORT_F : -return POWER_DOMAIN_PORT_DDI_F_LANES ; +return POWER_DOMAIN_PORT_DDI_LANES_F ;case PORT_G : -return POWER_DOMAIN_PORT_DDI_G_LANES ; +return POWER_DOMAIN_PORT_DDI_LANES_G ;case PORT_H : -return POWER_DOMAIN_PORT_DDI_H_LANES ; +return POWER_DOMAIN_PORT_DDI_LANES_H ;case PORT_I : -return POWER_DOMAIN_PORT_DDI_I_LANES ; +return POWER_DOMAIN_PORT_DDI_LANES_I ;default :MISSING_CASE (port);return POWER_DOMAIN_PORT_OTHER ;
@@ -2190,22 +2190,22 @@ intel_aux_power_domain(struct intel_digital_port *dig_port)if (intel_tc_port_in_tbt_alt_mode (dig_port)) {switch (dig_port->aux_ch) {case AUX_CH_C : -return POWER_DOMAIN_AUX_C_TBT ; +return POWER_DOMAIN_AUX_TBT_C ;case AUX_CH_D : -return POWER_DOMAIN_AUX_D_TBT ; +return POWER_DOMAIN_AUX_TBT_D ;case AUX_CH_E : -return POWER_DOMAIN_AUX_E_TBT ; +return POWER_DOMAIN_AUX_TBT_E ;case AUX_CH_F : -return POWER_DOMAIN_AUX_F_TBT ; +return POWER_DOMAIN_AUX_TBT_F ;case AUX_CH_G : -return POWER_DOMAIN_AUX_G_TBT ; +return POWER_DOMAIN_AUX_TBT_G ;case AUX_CH_H : -return POWER_DOMAIN_AUX_H_TBT ; +return POWER_DOMAIN_AUX_TBT_H ;case AUX_CH_I : -return POWER_DOMAIN_AUX_I_TBT ; +return POWER_DOMAIN_AUX_TBT_I ;default :MISSING_CASE (dig_port->aux_ch); -return POWER_DOMAIN_AUX_C_TBT ; +return POWER_DOMAIN_AUX_TBT_C ; } }
drivers/gpu/drm/i915/display/intel_display_power.c +58 -58
134 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power.h +33 -33
99 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_map.c +92 -92
424 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH 7/18 drm/i915: Sanitize the power well names
In reply to Imre DeakUse the shortest descriptive name for all power wells for simplicity and to use the same name for the same type of power wells on multiple platforms.
--- .../i915/display/intel_display_power_map.c | 254 +++++++++--------- 1 file changed, 127 insertions(+), 127 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +127 -127
@@ -363,7 +363,7 @@ static const struct i915_power_well_desc skl_power_wells[] = { .always_on = true, .id = DISP_PW_ID_NONE, }, { - .name = "power well 1", + .name = "PW_1", /* Handled by the DMC firmware */ .domains = 0, .ops = &hsw_power_well_ops,
@@ -374,7 +374,7 @@ static const struct i915_power_well_desc skl_power_wells[] = { .hsw.idx = SKL_PW_CTL_IDX_PW_1, }, }, { - .name = "MISC IO power well", + .name = "MISC_IO", /* Handled by the DMC firmware */ .domains = 0, .ops = &hsw_power_well_ops,
@@ -384,12 +384,12 @@ static const struct i915_power_well_desc skl_power_wells[] = { .hsw.idx = SKL_PW_CTL_IDX_MISC_IO, }, }, { - .name = "DC off", + .name = "DC_off", .domains = SKL_DISPLAY_DC_OFF_POWER_DOMAINS, .ops = &gen9_dc_off_power_well_ops, .id = SKL_DISP_DC_OFF, }, { - .name = "power well 2", + .name = "PW_2", .domains = SKL_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_vga = true,
@@ -400,7 +400,7 @@ static const struct i915_power_well_desc skl_power_wells[] = { .hsw.idx = SKL_PW_CTL_IDX_PW_2, }, }, { - .name = "DDI A/E IO power well", + .name = "DDI_IO_A_E", .domains = SKL_DISPLAY_DDI_IO_A_E_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -408,7 +408,7 @@ static const struct i915_power_well_desc skl_power_wells[] = { .hsw.idx = SKL_PW_CTL_IDX_DDI_A_E, }, }, { - .name = "DDI B IO power well", + .name = "DDI_IO_B", .domains = SKL_DISPLAY_DDI_IO_B_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -416,7 +416,7 @@ static const struct i915_power_well_desc skl_power_wells[] = { .hsw.idx = SKL_PW_CTL_IDX_DDI_B, }, }, { - .name = "DDI C IO power well", + .name = "DDI_IO_C", .domains = SKL_DISPLAY_DDI_IO_C_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -424,7 +424,7 @@ static const struct i915_power_well_desc skl_power_wells[] = { .hsw.idx = SKL_PW_CTL_IDX_DDI_C, }, }, { - .name = "DDI D IO power well", + .name = "DDI_IO_D", .domains = SKL_DISPLAY_DDI_IO_D_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -479,7 +479,7 @@ static const struct i915_power_well_desc bxt_power_wells[] = { .always_on = true, .id = DISP_PW_ID_NONE, }, { - .name = "power well 1", + .name = "PW_1", /* Handled by the DMC firmware */ .domains = 0, .ops = &hsw_power_well_ops,
@@ -490,12 +490,12 @@ static const struct i915_power_well_desc bxt_power_wells[] = { .hsw.idx = SKL_PW_CTL_IDX_PW_1, }, }, { - .name = "DC off", + .name = "DC_off", .domains = BXT_DISPLAY_DC_OFF_POWER_DOMAINS, .ops = &gen9_dc_off_power_well_ops, .id = SKL_DISP_DC_OFF, }, { - .name = "power well 2", + .name = "PW_2", .domains = BXT_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_vga = true,
@@ -589,7 +589,7 @@ static const struct i915_power_well_desc glk_power_wells[] = { .always_on = true, .id = DISP_PW_ID_NONE, }, { - .name = "power well 1", + .name = "PW_1", /* Handled by the DMC firmware */ .domains = 0, .ops = &hsw_power_well_ops,
@@ -600,12 +600,12 @@ static const struct i915_power_well_desc glk_power_wells[] = { .hsw.idx = SKL_PW_CTL_IDX_PW_1, }, }, { - .name = "DC off", + .name = "DC_off", .domains = GLK_DISPLAY_DC_OFF_POWER_DOMAINS, .ops = &gen9_dc_off_power_well_ops, .id = SKL_DISP_DC_OFF, }, { - .name = "power well 2", + .name = "PW_2", .domains = GLK_DISPLAY_POWERWELL_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_vga = true,
@@ -640,7 +640,7 @@ static const struct i915_power_well_desc glk_power_wells[] = { .bxt.phy = DPIO_PHY2, }, }, { - .name = "AUX A", + .name = "AUX_A", .domains = GLK_DISPLAY_AUX_A_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -648,7 +648,7 @@ static const struct i915_power_well_desc glk_power_wells[] = { .hsw.idx = GLK_PW_CTL_IDX_AUX_A, }, }, { - .name = "AUX B", + .name = "AUX_B", .domains = GLK_DISPLAY_AUX_B_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -656,7 +656,7 @@ static const struct i915_power_well_desc glk_power_wells[] = { .hsw.idx = GLK_PW_CTL_IDX_AUX_B, }, }, { - .name = "AUX C", + .name = "AUX_C", .domains = GLK_DISPLAY_AUX_C_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -664,7 +664,7 @@ static const struct i915_power_well_desc glk_power_wells[] = { .hsw.idx = GLK_PW_CTL_IDX_AUX_C, }, }, { - .name = "DDI A IO power well", + .name = "DDI_IO_A", .domains = GLK_DISPLAY_DDI_IO_A_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -672,7 +672,7 @@ static const struct i915_power_well_desc glk_power_wells[] = { .hsw.idx = GLK_PW_CTL_IDX_DDI_A, }, }, { - .name = "DDI B IO power well", + .name = "DDI_IO_B", .domains = GLK_DISPLAY_DDI_IO_B_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -680,7 +680,7 @@ static const struct i915_power_well_desc glk_power_wells[] = { .hsw.idx = SKL_PW_CTL_IDX_DDI_B, }, }, { - .name = "DDI C IO power well", + .name = "DDI_IO_C", .domains = GLK_DISPLAY_DDI_IO_C_POWER_DOMAINS, .ops = &hsw_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -784,7 +784,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .always_on = true, .id = DISP_PW_ID_NONE, }, { - .name = "power well 1", + .name = "PW_1", /* Handled by the DMC firmware */ .domains = 0, .ops = &hsw_power_well_ops,
@@ -795,12 +795,12 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_1, }, }, { - .name = "DC off", + .name = "DC_off", .domains = ICL_DISPLAY_DC_OFF_POWER_DOMAINS, .ops = &gen9_dc_off_power_well_ops, .id = SKL_DISP_DC_OFF, }, { - .name = "power well 2", + .name = "PW_2", .domains = ICL_PW_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_fuses = true,
@@ -809,7 +809,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_2, }, }, { - .name = "power well 3", + .name = "PW_3", .domains = ICL_PW_3_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_vga = true,
@@ -820,7 +820,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_3, }, }, { - .name = "DDI A IO", + .name = "DDI_IO_A", .domains = ICL_DDI_IO_A_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -828,7 +828,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_A, }, }, { - .name = "DDI B IO", + .name = "DDI_IO_B", .domains = ICL_DDI_IO_B_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -836,7 +836,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_B, }, }, { - .name = "DDI C IO", + .name = "DDI_IO_C", .domains = ICL_DDI_IO_C_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -844,7 +844,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_C, }, }, { - .name = "DDI D IO", + .name = "DDI_IO_D", .domains = ICL_DDI_IO_D_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -852,7 +852,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_D, }, }, { - .name = "DDI E IO", + .name = "DDI_IO_E", .domains = ICL_DDI_IO_E_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -860,7 +860,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_E, }, }, { - .name = "DDI F IO", + .name = "DDI_IO_F", .domains = ICL_DDI_IO_F_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -868,7 +868,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_F, }, }, { - .name = "AUX A", + .name = "AUX_A", .domains = ICL_AUX_A_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -876,7 +876,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_A, }, }, { - .name = "AUX B", + .name = "AUX_B", .domains = ICL_AUX_B_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -884,7 +884,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_B, }, }, { - .name = "AUX C TC1", + .name = "AUX_C", .domains = ICL_AUX_C_TC1_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -893,7 +893,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_C, }, }, { - .name = "AUX D TC2", + .name = "AUX_D", .domains = ICL_AUX_D_TC2_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -902,7 +902,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_D, }, }, { - .name = "AUX E TC3", + .name = "AUX_E", .domains = ICL_AUX_E_TC3_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -911,7 +911,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_E, }, }, { - .name = "AUX F TC4", + .name = "AUX_F", .domains = ICL_AUX_F_TC4_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -920,7 +920,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_F, }, }, { - .name = "AUX C TBT1", + .name = "AUX_TBT1", .domains = ICL_AUX_C_TBT1_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -929,7 +929,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT1, }, }, { - .name = "AUX D TBT2", + .name = "AUX_TBT2", .domains = ICL_AUX_D_TBT2_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -938,7 +938,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT2, }, }, { - .name = "AUX E TBT3", + .name = "AUX_TBT3", .domains = ICL_AUX_E_TBT3_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -947,7 +947,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT3, }, }, { - .name = "AUX F TBT4", + .name = "AUX_TBT4", .domains = ICL_AUX_F_TBT4_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -956,7 +956,7 @@ static const struct i915_power_well_desc icl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT4, }, }, { - .name = "power well 4", + .name = "PW_4", .domains = ICL_PW_4_POWER_DOMAINS, .ops = &hsw_power_well_ops, .irq_pipe_mask = BIT(PIPE_C),
@@ -1072,7 +1072,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .always_on = true, .id = DISP_PW_ID_NONE, }, { - .name = "power well 1", + .name = "PW_1", /* Handled by the DMC firmware */ .domains = 0, .ops = &hsw_power_well_ops,
@@ -1083,12 +1083,12 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_1, }, }, { - .name = "DC off", + .name = "DC_off", .domains = TGL_DISPLAY_DC_OFF_POWER_DOMAINS, .ops = &gen9_dc_off_power_well_ops, .id = SKL_DISP_DC_OFF, }, { - .name = "power well 2", + .name = "PW_2", .domains = TGL_PW_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_fuses = true,
@@ -1097,7 +1097,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_2, }, }, { - .name = "power well 3", + .name = "PW_3", .domains = TGL_PW_3_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_vga = true,
@@ -1108,7 +1108,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_3, }, }, { - .name = "DDI A IO", + .name = "DDI_IO_A", .domains = ICL_DDI_IO_A_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1116,7 +1116,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_A, } }, { - .name = "DDI B IO", + .name = "DDI_IO_B", .domains = ICL_DDI_IO_B_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1124,7 +1124,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_B, } }, { - .name = "DDI C IO", + .name = "DDI_IO_C", .domains = ICL_DDI_IO_C_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1132,7 +1132,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_C, } }, { - .name = "DDI IO TC1", + .name = "DDI_IO_TC1", .domains = TGL_DDI_IO_TC1_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1140,7 +1140,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1, }, }, { - .name = "DDI IO TC2", + .name = "DDI_IO_TC2", .domains = TGL_DDI_IO_TC2_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1148,7 +1148,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2, }, }, { - .name = "DDI IO TC3", + .name = "DDI_IO_TC3", .domains = TGL_DDI_IO_TC3_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1156,7 +1156,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3, }, }, { - .name = "DDI IO TC4", + .name = "DDI_IO_TC4", .domains = TGL_DDI_IO_TC4_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1164,7 +1164,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4, }, }, { - .name = "DDI IO TC5", + .name = "DDI_IO_TC5", .domains = TGL_DDI_IO_TC5_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1172,7 +1172,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC5, }, }, { - .name = "DDI IO TC6", + .name = "DDI_IO_TC6", .domains = TGL_DDI_IO_TC6_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1180,12 +1180,12 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC6, }, }, { - .name = "TC cold off", + .name = "TC_cold_off", .domains = TGL_TC_COLD_OFF_POWER_DOMAINS, .ops = &tgl_tc_cold_off_ops, .id = TGL_DISP_PW_TC_COLD_OFF, }, { - .name = "AUX A", + .name = "AUX_A", .domains = TGL_AUX_A_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1193,7 +1193,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_A, }, }, { - .name = "AUX B", + .name = "AUX_B", .domains = TGL_AUX_B_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1201,7 +1201,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_B, }, }, { - .name = "AUX C", + .name = "AUX_C", .domains = TGL_AUX_C_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1209,7 +1209,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_C, }, }, { - .name = "AUX USBC1", + .name = "AUX_USBC1", .domains = TGL_AUX_IO_USBC1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -1218,7 +1218,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1, }, }, { - .name = "AUX USBC2", + .name = "AUX_USBC2", .domains = TGL_AUX_IO_USBC2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -1227,7 +1227,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2, }, }, { - .name = "AUX USBC3", + .name = "AUX_USBC3", .domains = TGL_AUX_IO_USBC3_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -1236,7 +1236,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3, }, }, { - .name = "AUX USBC4", + .name = "AUX_USBC4", .domains = TGL_AUX_IO_USBC4_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -1245,7 +1245,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4, }, }, { - .name = "AUX USBC5", + .name = "AUX_USBC5", .domains = TGL_AUX_IO_USBC5_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -1254,7 +1254,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC5, }, }, { - .name = "AUX USBC6", + .name = "AUX_USBC6", .domains = TGL_AUX_IO_USBC6_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -1263,7 +1263,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC6, }, }, { - .name = "AUX TBT1", + .name = "AUX_TBT1", .domains = TGL_AUX_IO_TBT1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -1272,7 +1272,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1, }, }, { - .name = "AUX TBT2", + .name = "AUX_TBT2", .domains = TGL_AUX_IO_TBT2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -1281,7 +1281,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2, }, }, { - .name = "AUX TBT3", + .name = "AUX_TBT3", .domains = TGL_AUX_IO_TBT3_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -1290,7 +1290,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3, }, }, { - .name = "AUX TBT4", + .name = "AUX_TBT4", .domains = TGL_AUX_IO_TBT4_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -1299,7 +1299,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4, }, }, { - .name = "AUX TBT5", + .name = "AUX_TBT5", .domains = TGL_AUX_IO_TBT5_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -1308,7 +1308,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT5, }, }, { - .name = "AUX TBT6", + .name = "AUX_TBT6", .domains = TGL_AUX_IO_TBT6_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -1317,7 +1317,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT6, }, }, { - .name = "power well 4", + .name = "PW_4", .domains = TGL_PW_4_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_fuses = true,
@@ -1327,7 +1327,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_4, } }, { - .name = "power well 5", + .name = "PW_5", .domains = TGL_PW_5_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_fuses = true,
@@ -1395,7 +1395,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .always_on = true, .id = DISP_PW_ID_NONE, }, { - .name = "power well 1", + .name = "PW_1", /* Handled by the DMC firmware */ .domains = 0, .ops = &hsw_power_well_ops,
@@ -1406,12 +1406,12 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_1, }, }, { - .name = "DC off", + .name = "DC_off", .domains = RKL_DISPLAY_DC_OFF_POWER_DOMAINS, .ops = &gen9_dc_off_power_well_ops, .id = SKL_DISP_DC_OFF, }, { - .name = "power well 3", + .name = "PW_3", .domains = RKL_PW_3_POWER_DOMAINS, .ops = &hsw_power_well_ops, .irq_pipe_mask = BIT(PIPE_B),
@@ -1422,7 +1422,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_3, }, }, { - .name = "power well 4", + .name = "PW_4", .domains = RKL_PW_4_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_fuses = true,
@@ -1432,7 +1432,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_4, } }, { - .name = "DDI A IO", + .name = "DDI_IO_A", .domains = ICL_DDI_IO_A_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1440,7 +1440,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_A, } }, { - .name = "DDI B IO", + .name = "DDI_IO_B", .domains = ICL_DDI_IO_B_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1448,7 +1448,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_B, } }, { - .name = "DDI IO TC1", + .name = "DDI_IO_TC1", .domains = TGL_DDI_IO_TC1_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1456,7 +1456,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1, }, }, { - .name = "DDI IO TC2", + .name = "DDI_IO_TC2", .domains = TGL_DDI_IO_TC2_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1464,7 +1464,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2, }, }, { - .name = "AUX A", + .name = "AUX_A", .domains = ICL_AUX_A_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1472,7 +1472,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_A, }, }, { - .name = "AUX B", + .name = "AUX_B", .domains = ICL_AUX_B_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1480,7 +1480,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_B, }, }, { - .name = "AUX USBC1", + .name = "AUX_USBC1", .domains = TGL_AUX_IO_USBC1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1488,7 +1488,7 @@ static const struct i915_power_well_desc rkl_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1, }, }, { - .name = "AUX USBC2", + .name = "AUX_USBC2", .domains = TGL_AUX_IO_USBC2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1535,7 +1535,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .always_on = true, .id = DISP_PW_ID_NONE, }, { - .name = "power well 1", + .name = "PW_1", /* Handled by the DMC firmware */ .domains = 0, .ops = &hsw_power_well_ops,
@@ -1546,12 +1546,12 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_1, }, }, { - .name = "DC off", + .name = "DC_off", .domains = DG1_DISPLAY_DC_OFF_POWER_DOMAINS, .ops = &gen9_dc_off_power_well_ops, .id = SKL_DISP_DC_OFF, }, { - .name = "power well 2", + .name = "PW_2", .domains = DG1_PW_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_fuses = true,
@@ -1560,7 +1560,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_2, }, }, { - .name = "power well 3", + .name = "PW_3", .domains = DG1_PW_3_POWER_DOMAINS, .ops = &hsw_power_well_ops, .irq_pipe_mask = BIT(PIPE_B),
@@ -1571,7 +1571,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_3, }, }, { - .name = "DDI A IO", + .name = "DDI_IO_A", .domains = ICL_DDI_IO_A_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1579,7 +1579,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_A, } }, { - .name = "DDI B IO", + .name = "DDI_IO_B", .domains = ICL_DDI_IO_B_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1587,7 +1587,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_B, } }, { - .name = "DDI IO TC1", + .name = "DDI_IO_TC1", .domains = TGL_DDI_IO_TC1_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1595,7 +1595,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1, }, }, { - .name = "DDI IO TC2", + .name = "DDI_IO_TC2", .domains = TGL_DDI_IO_TC2_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1603,7 +1603,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2, }, }, { - .name = "AUX A", + .name = "AUX_A", .domains = TGL_AUX_A_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1611,7 +1611,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_A, }, }, { - .name = "AUX B", + .name = "AUX_B", .domains = TGL_AUX_B_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1619,7 +1619,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_B, }, }, { - .name = "AUX USBC1", + .name = "AUX_USBC1", .domains = TGL_AUX_IO_USBC1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -1628,7 +1628,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1, }, }, { - .name = "AUX USBC2", + .name = "AUX_USBC2", .domains = TGL_AUX_IO_USBC2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = false,
@@ -1637,7 +1637,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2, }, }, { - .name = "power well 4", + .name = "PW_4", .domains = TGL_PW_4_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_fuses = true,
@@ -1647,7 +1647,7 @@ static const struct i915_power_well_desc dg1_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_4, } }, { - .name = "power well 5", + .name = "PW_5", .domains = TGL_PW_5_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_fuses = true,
@@ -1779,7 +1779,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .always_on = true, .id = DISP_PW_ID_NONE, }, { - .name = "power well 1", + .name = "PW_1", /* Handled by the DMC firmware */ .domains = 0, .ops = &hsw_power_well_ops,
@@ -1790,12 +1790,12 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_1, }, }, { - .name = "DC off", + .name = "DC_off", .domains = XELPD_DISPLAY_DC_OFF_POWER_DOMAINS, .ops = &gen9_dc_off_power_well_ops, .id = SKL_DISP_DC_OFF, }, { - .name = "power well 2", + .name = "PW_2", .domains = XELPD_PW_2_POWER_DOMAINS, .ops = &hsw_power_well_ops, .has_vga = true,
@@ -1805,7 +1805,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_PW_2, }, }, { - .name = "power well A", + .name = "PW_A", .domains = XELPD_PW_A_POWER_DOMAINS, .ops = &hsw_power_well_ops, .irq_pipe_mask = BIT(PIPE_A),
@@ -1815,7 +1815,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = XELPD_PW_CTL_IDX_PW_A, }, }, { - .name = "power well B", + .name = "PW_B", .domains = XELPD_PW_B_POWER_DOMAINS, .ops = &hsw_power_well_ops, .irq_pipe_mask = BIT(PIPE_B),
@@ -1825,7 +1825,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = XELPD_PW_CTL_IDX_PW_B, }, }, { - .name = "power well C", + .name = "PW_C", .domains = XELPD_PW_C_POWER_DOMAINS, .ops = &hsw_power_well_ops, .irq_pipe_mask = BIT(PIPE_C),
@@ -1835,7 +1835,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = XELPD_PW_CTL_IDX_PW_C, }, }, { - .name = "power well D", + .name = "PW_D", .domains = XELPD_PW_D_POWER_DOMAINS, .ops = &hsw_power_well_ops, .irq_pipe_mask = BIT(PIPE_D),
@@ -1845,7 +1845,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = XELPD_PW_CTL_IDX_PW_D, }, }, { - .name = "DDI A IO", + .name = "DDI_IO_A", .domains = ICL_DDI_IO_A_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1853,7 +1853,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_A, } }, { - .name = "DDI B IO", + .name = "DDI_IO_B", .domains = ICL_DDI_IO_B_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1861,7 +1861,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_B, } }, { - .name = "DDI C IO", + .name = "DDI_IO_C", .domains = ICL_DDI_IO_C_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1869,7 +1869,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_DDI_C, } }, { - .name = "DDI IO D_XELPD", + .name = "DDI_IO_D_XELPD", .domains = XELPD_DDI_IO_D_XELPD_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1877,7 +1877,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = XELPD_PW_CTL_IDX_DDI_D, } }, { - .name = "DDI IO E_XELPD", + .name = "DDI_IO_E_XELPD", .domains = XELPD_DDI_IO_E_XELPD_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1885,7 +1885,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = XELPD_PW_CTL_IDX_DDI_E, } }, { - .name = "DDI IO TC1", + .name = "DDI_IO_TC1", .domains = XELPD_DDI_IO_TC1_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1893,7 +1893,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1, } }, { - .name = "DDI IO TC2", + .name = "DDI_IO_TC2", .domains = XELPD_DDI_IO_TC2_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1901,7 +1901,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2, } }, { - .name = "DDI IO TC3", + .name = "DDI_IO_TC3", .domains = XELPD_DDI_IO_TC3_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1909,7 +1909,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3, } }, { - .name = "DDI IO TC4", + .name = "DDI_IO_TC4", .domains = XELPD_DDI_IO_TC4_POWER_DOMAINS, .ops = &icl_ddi_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1917,7 +1917,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4, } }, { - .name = "AUX A", + .name = "AUX_A", .domains = ICL_AUX_A_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .fixed_enable_delay = true,
@@ -1926,7 +1926,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_A, }, }, { - .name = "AUX B", + .name = "AUX_B", .domains = ICL_AUX_B_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .fixed_enable_delay = true,
@@ -1935,7 +1935,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_B, }, }, { - .name = "AUX C", + .name = "AUX_C", .domains = TGL_AUX_C_IO_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .fixed_enable_delay = true,
@@ -1944,7 +1944,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = ICL_PW_CTL_IDX_AUX_C, }, }, { - .name = "AUX D_XELPD", + .name = "AUX_D_XELPD", .domains = XELPD_AUX_IO_D_XELPD_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .fixed_enable_delay = true,
@@ -1953,7 +1953,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = XELPD_PW_CTL_IDX_AUX_D, }, }, { - .name = "AUX E_XELPD", + .name = "AUX_E_XELPD", .domains = XELPD_AUX_IO_E_XELPD_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1961,7 +1961,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = XELPD_PW_CTL_IDX_AUX_E, }, }, { - .name = "AUX USBC1", + .name = "AUX_USBC1", .domains = XELPD_AUX_IO_USBC1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .fixed_enable_delay = true,
@@ -1970,7 +1970,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1, }, }, { - .name = "AUX USBC2", + .name = "AUX_USBC2", .domains = XELPD_AUX_IO_USBC2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1978,7 +1978,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2, }, }, { - .name = "AUX USBC3", + .name = "AUX_USBC3", .domains = XELPD_AUX_IO_USBC3_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1986,7 +1986,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3, }, }, { - .name = "AUX USBC4", + .name = "AUX_USBC4", .domains = XELPD_AUX_IO_USBC4_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .id = DISP_PW_ID_NONE,
@@ -1994,7 +1994,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4, }, }, { - .name = "AUX TBT1", + .name = "AUX_TBT1", .domains = XELPD_AUX_IO_TBT1_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -2003,7 +2003,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1, }, }, { - .name = "AUX TBT2", + .name = "AUX_TBT2", .domains = XELPD_AUX_IO_TBT2_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -2012,7 +2012,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2, }, }, { - .name = "AUX TBT3", + .name = "AUX_TBT3", .domains = XELPD_AUX_IO_TBT3_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
@@ -2021,7 +2021,7 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3, }, }, { - .name = "AUX TBT4", + .name = "AUX_TBT4", .domains = XELPD_AUX_IO_TBT4_POWER_DOMAINS, .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
Signature · 1 line
2.30.2
PATCH 8/18 drm/i915: Convert the power well descriptor domain mask to an array of domains
In reply to Imre DeakThe next patch converts the i915_power_well_desc::domain mask from a u64 mask to a bitmap. I didn't find a reasonably simple way to initialize bitmaps statically, so prepare for the next patch here by converting the masks to an array of domain enums and initing the masks from these arrays during module loading.
v2: Clarify list vs. array in the commit message. (Jani)
--- .../drm/i915/display/intel_display_power.c | 4 +- .../i915/display/intel_display_power_map.c | 1427 +++++++++-------- .../i915/display/intel_display_power_well.c | 2 +- .../i915/display/intel_display_power_well.h | 6 +- 4 files changed, 754 insertions(+), 685 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +2 -2
@@ -24,11 +24,11 @@#define for_each_power_domain_well (__dev_priv, __power_well, __domain_mask) \ for_each_power_well(__dev_priv, __power_well) \ - for_each_if((__power_well)->desc->domains & (__domain_mask)) + for_each_if((__power_well)->domains & (__domain_mask))#define for_each_power_domain_well_reverse (__dev_priv, __power_well, __domain_mask) \ for_each_power_well_reverse(__dev_priv, __power_well) \ - for_each_if((__power_well)->desc->domains & (__domain_mask)) + for_each_if((__power_well)->domains & (__domain_mask))const char *intel_display_power_domain_str (enum intel_display_power_domain domain)
drivers/gpu/drm/i915/display/intel_display_power_map.c +746 -681
2,472 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_well.c +1 -1
@@ -156,7 +156,7 @@ const char *intel_power_well_name(struct i915_power_well *power_well)u64 intel_power_well_domains (struct i915_power_well *power_well) { -return power_well->desc->domains; +return power_well->domains; }int intel_power_well_refcount (struct i915_power_well *power_well)
drivers/gpu/drm/i915/display/intel_display_power_well.h +5 -1
@@ -50,7 +50,10 @@ enum i915_power_well_id {struct i915_power_well_desc {const char *name; -u64 domains; +const struct i915_power_domain_list { +const enum intel_display_power_domain *list; +u8 count; + } *domain_list;/* Mask of pipes whose IRQ logic is backed by the pw */ u16 irq_pipe_mask:4 ;u16 always_on:1 ;
@@ -99,6 +102,7 @@ struct i915_power_well_desc {struct i915_power_well {const struct i915_power_well_desc *desc; +u64 domains;/* power well enable/disable usage count */ int count;/* cached hw enabled state */
Signature · 1 line
2.30.2
PATCH 9/18 drm/i915: Convert the u64 power well domains mask to a bitmap
In reply to Imre DeakTo remove the aliasing of the power domain enum values in a follow-up patch in this patchset (requiring a bigger mask) and allow for defining additional power domains in the future (at least some upcoming TypeC changes requires this) convert the u64 i915_power_well_desc::domains mask to a bitmap.
For simplicity I changed the for_each_power_domain_well() macros to accept one domain only instead of a mask, as there isn't any current user passing multiple domains.
v2: Don't add a typedef for the bitmap struct. (Jani)
--- drivers/gpu/drm/i915/display/intel_display.c | 65 ++++++----- .../drm/i915/display/intel_display_power.c | 108 +++++++++++------- .../drm/i915/display/intel_display_power.h | 18 +-- .../i915/display/intel_display_power_map.c | 4 +- .../i915/display/intel_display_power_well.c | 4 +- .../i915/display/intel_display_power_well.h | 5 +- 6 files changed, 116 insertions(+), 88 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +34 -31
@@ -2244,66 +2244,71 @@ intel_legacy_aux_to_power_domain(enum aux_ch aux_ch) } } -static u64 get_crtc_power_domains (struct intel_crtc_state *crtc_state) +static void get_crtc_power_domains (struct intel_crtc_state *crtc_state, +struct intel_power_domain_mask *mask) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;struct drm_encoder *encoder;enum pipe pipe = crtc->pipe; -u64 mask; + +bitmap_zero (mask->bits,POWER_DOMAIN_NUM );if (!crtc_state->hw.active) -return 0 ; +return ; - mask =BIT_ULL (POWER_DOMAIN_PIPE (pipe)); - mask |=BIT_ULL (POWER_DOMAIN_TRANSCODER (cpu_transcoder)); +set_bit (POWER_DOMAIN_PIPE (pipe), mask->bits); +set_bit (POWER_DOMAIN_TRANSCODER (cpu_transcoder), mask->bits);if (crtc_state->pch_pfit.enabled || crtc_state->pch_pfit.force_thru) - mask |=BIT_ULL (POWER_DOMAIN_PIPE_PANEL_FITTER (pipe)); +set_bit (POWER_DOMAIN_PIPE_PANEL_FITTER (pipe), mask->bits);drm_for_each_encoder_mask (encoder, &dev_priv->drm, crtc_state->uapi.encoder_mask) {struct intel_encoder *intel_encoder =to_intel_encoder (encoder); - mask |=BIT_ULL (intel_encoder->power_domain); +set_bit (intel_encoder->power_domain, mask->bits); }if (HAS_DDI (dev_priv) && crtc_state->has_audio) - mask |=BIT_ULL (POWER_DOMAIN_AUDIO_MMIO ); +set_bit (POWER_DOMAIN_AUDIO_MMIO , mask->bits);if (crtc_state->shared_dpll) - mask |=BIT_ULL (POWER_DOMAIN_DISPLAY_CORE ); +set_bit (POWER_DOMAIN_DISPLAY_CORE , mask->bits);if (crtc_state->dsc.compression_enable) - mask |=BIT_ULL (intel_dsc_power_domain (crtc, cpu_transcoder)); - -return mask; +set_bit (intel_dsc_power_domain (crtc, cpu_transcoder), mask->bits); } -static u64 -modeset_get_crtc_power_domains (struct intel_crtc_state *crtc_state) +static void +modeset_get_crtc_power_domains (struct intel_crtc_state *crtc_state, +struct intel_power_domain_mask *old_domains) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);enum intel_display_power_domain domain; -u64 domains, new_domains, old_domains; +struct intel_power_domain_mask domains, new_domains; - domains =get_crtc_power_domains (crtc_state); +get_crtc_power_domains (crtc_state, &domains); - new_domains = domains & ~crtc->enabled_power_domains.mask; - old_domains = crtc->enabled_power_domains.mask & ~domains; +bitmap_andnot (new_domains.bits, + domains.bits, + crtc->enabled_power_domains.mask.bits, +POWER_DOMAIN_NUM ); +bitmap_andnot (old_domains->bits, + crtc->enabled_power_domains.mask.bits, + domains.bits, +POWER_DOMAIN_NUM ); -for_each_power_domain (domain, new_domains) +for_each_power_domain (domain, &new_domains)intel_display_power_get_in_set (dev_priv, &crtc->enabled_power_domains, domain); - -return old_domains; }static void modeset_put_crtc_power_domains (struct intel_crtc *crtc, -u64 domains) +struct intel_power_domain_mask *domains) { intel_display_power_put_mask_in_set(to_i915(crtc->base.dev), &crtc->enabled_power_domains,
@@ -8505,7 +8510,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_crtc_state *new_crtc_state, *old_crtc_state;struct intel_crtc *crtc; -u64 put_domains[I915_MAX_PIPES ] = {}; +struct intel_power_domain_mask put_domains[I915_MAX_PIPES ] = {};intel_wakeref_t wakeref =0 ;int i;
@@ -8522,9 +8527,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state) new_crtc_state, i) {if (intel_crtc_needs_modeset (new_crtc_state) || new_crtc_state->update_pipe) { - - put_domains[crtc->pipe] = -modeset_get_crtc_power_domains (new_crtc_state); +modeset_get_crtc_power_domains (new_crtc_state, &put_domains[crtc->pipe]); } }
@@ -8624,7 +8627,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, new_crtc_state, i) {intel_post_plane_update (state, crtc); -modeset_put_crtc_power_domains (crtc, put_domains[crtc->pipe]); +modeset_put_crtc_power_domains (crtc, &put_domains[crtc->pipe]);intel_modeset_verify_crtc (crtc, state, old_crtc_state, new_crtc_state);
@@ -10465,11 +10468,11 @@ intel_modeset_setup_hw_state(struct drm_device *dev,for_each_intel_crtc (dev, crtc) {struct intel_crtc_state *crtc_state =to_intel_crtc_state (crtc->base.state); -u64 put_domains; +struct intel_power_domain_mask put_domains; - put_domains =modeset_get_crtc_power_domains (crtc_state); -if (drm_WARN_ON (dev, put_domains)) -modeset_put_crtc_power_domains (crtc, put_domains); +modeset_get_crtc_power_domains (crtc_state, &put_domains); +if (drm_WARN_ON (dev, !bitmap_empty (put_domains.bits,POWER_DOMAIN_NUM ))) +modeset_put_crtc_power_domains (crtc, &put_domains); }intel_display_power_put (dev_priv,POWER_DOMAIN_INIT , wakeref);
drivers/gpu/drm/i915/display/intel_display_power.c +64 -44
296 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power.h +11 -7
@@ -139,6 +139,10 @@ enum intel_display_power_domain { ((tran) ==TRANSCODER_EDP ?POWER_DOMAIN_TRANSCODER_EDP : \ (tran) + POWER_DOMAIN_TRANSCODER_A) +struct intel_power_domain_mask { + DECLARE_BITMAP(bits, POWER_DOMAIN_NUM); +}; +struct i915_power_domains {/* * Power wells needed for initialization at driver init and suspend
@@ -156,21 +160,21 @@ struct i915_power_domains {struct delayed_work async_put_work;intel_wakeref_t async_put_wakeref; -u64 async_put_domains[2 ]; +struct intel_power_domain_mask async_put_domains[2 ];struct i915_power_well *power_wells; };struct intel_display_power_domain_set { -u64 mask; +struct intel_power_domain_mask mask;#ifdef CONFIG_DRM_I915_DEBUG_RUNTIME_PM intel_wakeref_t wakerefs[POWER_DOMAIN_NUM ];#endif }; -#define for_each_power_domain (domain, mask) \ - for ((domain) = 0; (domain) < POWER_DOMAIN_NUM; (domain)++) \ - for_each_if(BIT_ULL(domain) & (mask)) +#define for_each_power_domain (__domain, __mask) \ + for ((__domain) = 0; (__domain) < POWER_DOMAIN_NUM; (__domain)++) \ + for_each_if(test_bit((__domain), (__mask)->bits))int intel_power_domains_init (struct drm_i915_private *dev_priv);void intel_power_domains_cleanup (struct drm_i915_private *dev_priv);
@@ -251,13 +255,13 @@ intel_display_power_get_in_set_if_enabled(struct drm_i915_private *i915,void intel_display_power_put_mask_in_set (struct drm_i915_private *i915,struct intel_display_power_domain_set *power_domain_set, -u64 mask); +struct intel_power_domain_mask *mask);static inline void intel_display_power_put_all_in_set (struct drm_i915_private *i915,struct intel_display_power_domain_set *power_domain_set) { -intel_display_power_put_mask_in_set (i915, power_domain_set, power_domain_set->mask); +intel_display_power_put_mask_in_set (i915, power_domain_set, &power_domain_set->mask); }void intel_display_power_debug (struct drm_i915_private *i915,struct seq_file *m);
drivers/gpu/drm/i915/display/intel_display_power_map.c +2 -2
@@ -2084,13 +2084,13 @@ static void init_power_well_domains(const struct i915_power_well_desc *desc,return ;if (desc->domain_list->count ==0 ) { - power_well->domains =GENMASK_ULL (POWER_DOMAIN_NUM -1 ,0 ); +bitmap_fill (power_well->domains.bits,POWER_DOMAIN_NUM );return ; }for (j =0 ; j < desc->domain_list->count; j++) - power_well->domains |=BIT_ULL (desc->domain_list->list[j]); +set_bit (desc->domain_list->list[j], power_well->domains.bits); } static int
drivers/gpu/drm/i915/display/intel_display_power_well.c +2 -2
@@ -154,9 +154,9 @@ const char *intel_power_well_name(struct i915_power_well *power_well)return power_well->desc->name; } -u64 intel_power_well_domains (struct i915_power_well *power_well) +struct intel_power_domain_mask *intel_power_well_domains (struct i915_power_well *power_well) { -return power_well->domains; +return &power_well->domains; }int intel_power_well_refcount (struct i915_power_well *power_well)
drivers/gpu/drm/i915/display/intel_display_power_well.h +3 -2
@@ -8,6 +8,7 @@#include <linux/types.h> #include "intel_display.h" +#include "intel_display_power.h" struct drm_i915_private ;struct i915_power_well ;
@@ -102,7 +103,7 @@ struct i915_power_well_desc {struct i915_power_well {const struct i915_power_well_desc *desc; -u64 domains; +struct intel_power_domain_mask domains;/* power well enable/disable usage count */ int count;/* cached hw enabled state */
@@ -129,7 +130,7 @@ bool intel_display_power_well_is_enabled(struct drm_i915_private *dev_priv, enum i915_power_well_id power_well_id);bool intel_power_well_is_always_on (struct i915_power_well *power_well);const char *intel_power_well_name (struct i915_power_well *power_well); -u64 intel_power_well_domains (struct i915_power_well *power_well); +struct intel_power_domain_mask *intel_power_well_domains (struct i915_power_well *power_well);int intel_power_well_refcount (struct i915_power_well *power_well); void chv_phy_powergate_lanes(struct intel_encoder *encoder,
Signature · 1 line
2.30.2
PATCH 10/18 drm/i915: Simplify power well definitions by adding power well instances
In reply to Imre DeakAll the port specific AUX/DDI_IO power wells share the same power well ops struct and flags, so we can save some space and simplify the definition of these by listing for all such power wells only the params specific to them (name, domains, power well register index, id). Move these params to a new i915_power_well_instance struct and convert the per-platform power well definitions accordingly.
For all power well instance the name and power domain list params must be specified, while the register index and id are optional, add the I915_PW() macro that both simplifies the definitions and ensures that the required params are set.
--- .../i915/display/intel_display_power_map.c | 1515 +++++------------ .../i915/display/intel_display_power_well.c | 72 +- .../i915/display/intel_display_power_well.h | 48 +- 3 files changed, 505 insertions(+), 1130 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +436 -1079
@@ -30,16 +30,23 @@#define I915_PW_DOMAINS_NONE NULL#define I915_PW_DOMAINS_ALL /* zero-length list */ +#define I915_PW_INSTANCES (...) \ + (const struct i915_power_well_instance_list) \ + __LIST(__LIST_INLINE_ELEMS(struct i915_power_well_instance, __VA_ARGS__)) + +#define I915_PW (_name, _domain_list, ...) \ + { .name = _name, .domain_list = _domain_list, ## __VA_ARGS__ } +I915_DECL_PW_DOMAINS (i9xx_pwdoms_always_on,I915_PW_DOMAINS_ALL );static const struct i915_power_well_desc i9xx_always_on_power_well[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, };
@@ -54,16 +61,16 @@ I915_DECL_PW_DOMAINS(i830_pwdoms_pipes,static const struct i915_power_well_desc i830_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="pipes" , - .domain_list = &i830_pwdoms_pipes, + .instances = &I915_PW_INSTANCES ( + I915_PW("pipes", &i830_pwdoms_pipes), + ), .ops = &i830_pipes_power_well_ops, - .id =DISP_PW_ID_NONE , }, };
@@ -87,20 +94,19 @@ I915_DECL_PW_DOMAINS(hsw_pwdoms_display,static const struct i915_power_well_desc hsw_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="display" , - .domain_list = &hsw_pwdoms_display, + .instances = &I915_PW_INSTANCES ( +I915_PW ("display" , &hsw_pwdoms_display, + .hsw.idx = HSW_PW_CTL_IDX_GLOBAL, + .id = HSW_DISP_PW_GLOBAL), + ), .ops = &hsw_power_well_ops, .has_vga = true, - .id =HSW_DISP_PW_GLOBAL , - { - .hsw.idx =HSW_PW_CTL_IDX_GLOBAL , - }, }, };
@@ -123,21 +129,20 @@ I915_DECL_PW_DOMAINS(bdw_pwdoms_display,static const struct i915_power_well_desc bdw_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="display" , - .domain_list = &bdw_pwdoms_display, + .instances = &I915_PW_INSTANCES ( +I915_PW ("display" , &bdw_pwdoms_display, + .hsw.idx = HSW_PW_CTL_IDX_GLOBAL, + .id = HSW_DISP_PW_GLOBAL), + ), .ops = &hsw_power_well_ops, .has_vga = true, .irq_pipe_mask =BIT (PIPE_B ) |BIT (PIPE_C ), - .id =HSW_DISP_PW_GLOBAL , - { - .hsw.idx =HSW_PW_CTL_IDX_GLOBAL , - }, }, };
@@ -178,59 +183,37 @@ I915_DECL_PW_DOMAINS(vlv_pwdoms_dpio_tx_bc_lanes,static const struct i915_power_well_desc vlv_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="display" , - .domain_list = &vlv_pwdoms_display, + .instances = &I915_PW_INSTANCES ( +I915_PW ("display" , &vlv_pwdoms_display, + .vlv.idx = PUNIT_PWGT_IDX_DISP2D, + .id = VLV_DISP_PW_DISP2D), + ), .ops = &vlv_display_power_well_ops, - .id =VLV_DISP_PW_DISP2D , - { - .vlv.idx =PUNIT_PWGT_IDX_DISP2D , - }, }, { - .name ="dpio-tx-b-01" , - .domain_list = &vlv_pwdoms_dpio_tx_bc_lanes, + .instances = &I915_PW_INSTANCES ( +I915_PW ("dpio-tx-b-01" , &vlv_pwdoms_dpio_tx_bc_lanes, + .vlv.idx = PUNIT_PWGT_IDX_DPIO_TX_B_LANES_01), +I915_PW ("dpio-tx-b-23" , &vlv_pwdoms_dpio_tx_bc_lanes, + .vlv.idx = PUNIT_PWGT_IDX_DPIO_TX_B_LANES_23), +I915_PW ("dpio-tx-c-01" , &vlv_pwdoms_dpio_tx_bc_lanes, + .vlv.idx = PUNIT_PWGT_IDX_DPIO_TX_C_LANES_01), +I915_PW ("dpio-tx-c-23" , &vlv_pwdoms_dpio_tx_bc_lanes, + .vlv.idx = PUNIT_PWGT_IDX_DPIO_TX_C_LANES_23), + ), .ops = &vlv_dpio_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .vlv.idx =PUNIT_PWGT_IDX_DPIO_TX_B_LANES_01 , - }, }, { - .name ="dpio-tx-b-23" , - .domain_list = &vlv_pwdoms_dpio_tx_bc_lanes, - .ops = &vlv_dpio_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .vlv.idx =PUNIT_PWGT_IDX_DPIO_TX_B_LANES_23 , - }, - }, { - .name ="dpio-tx-c-01" , - .domain_list = &vlv_pwdoms_dpio_tx_bc_lanes, - .ops = &vlv_dpio_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .vlv.idx =PUNIT_PWGT_IDX_DPIO_TX_C_LANES_01 , - }, - }, { - .name ="dpio-tx-c-23" , - .domain_list = &vlv_pwdoms_dpio_tx_bc_lanes, - .ops = &vlv_dpio_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .vlv.idx =PUNIT_PWGT_IDX_DPIO_TX_C_LANES_23 , - }, - }, { - .name ="dpio-common" , - .domain_list = &vlv_pwdoms_dpio_cmn_bc, + .instances = &I915_PW_INSTANCES ( +I915_PW ("dpio-common" , &vlv_pwdoms_dpio_cmn_bc, + .vlv.idx = PUNIT_PWGT_IDX_DPIO_CMN_BC, + .id = VLV_DISP_PW_DPIO_CMN_BC), + ), .ops = &vlv_dpio_cmn_power_well_ops, - .id =VLV_DISP_PW_DPIO_CMN_BC , - { - .vlv.idx =PUNIT_PWGT_IDX_DPIO_CMN_BC , - }, }, };
@@ -272,37 +255,31 @@ I915_DECL_PW_DOMAINS(chv_pwdoms_dpio_cmn_d,static const struct i915_power_well_desc chv_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="display" ,/* * Pipe A power well is the new disp2d well. Pipe B and C * power wells don't actually exist. Pipe A power well is * required for any pipe to work. */ - .domain_list = &chv_pwdoms_display, + .instances = &I915_PW_INSTANCES ( + I915_PW("display", &chv_pwdoms_display), + ), .ops = &chv_pipe_power_well_ops, - .id =DISP_PW_ID_NONE , }, { - .name ="dpio-common-bc" , - .domain_list = &chv_pwdoms_dpio_cmn_bc, + .instances = &I915_PW_INSTANCES ( +I915_PW ("dpio-common-bc" , &chv_pwdoms_dpio_cmn_bc, + .vlv.idx = PUNIT_PWGT_IDX_DPIO_CMN_BC, + .id = VLV_DISP_PW_DPIO_CMN_BC), +I915_PW ("dpio-common-d" , &chv_pwdoms_dpio_cmn_d, + .vlv.idx = PUNIT_PWGT_IDX_DPIO_CMN_D, + .id = CHV_DISP_PW_DPIO_CMN_D), + ), .ops = &chv_dpio_cmn_power_well_ops, - .id =VLV_DISP_PW_DPIO_CMN_BC , - { - .vlv.idx =PUNIT_PWGT_IDX_DPIO_CMN_BC , - }, - }, { - .name ="dpio-common-d" , - .domain_list = &chv_pwdoms_dpio_cmn_d, - .ops = &chv_dpio_cmn_power_well_ops, - .id =CHV_DISP_PW_DPIO_CMN_D , - { - .vlv.idx =PUNIT_PWGT_IDX_DPIO_CMN_D , - }, }, };
@@ -355,80 +332,54 @@ I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_d,static const struct i915_power_well_desc skl_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="PW_1" ,/* Handled by the DMC firmware */ - .domain_list =I915_PW_DOMAINS_NONE , + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , + .hsw.idx = SKL_PW_CTL_IDX_PW_1, + .id = SKL_DISP_PW_1), + ), .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - .id =SKL_DISP_PW_1 , - { - .hsw.idx =SKL_PW_CTL_IDX_PW_1 , - }, }, { - .name ="MISC_IO" ,/* Handled by the DMC firmware */ - .domain_list =I915_PW_DOMAINS_NONE , + .instances = &I915_PW_INSTANCES ( +I915_PW ("MISC_IO" ,I915_PW_DOMAINS_NONE , + .hsw.idx = SKL_PW_CTL_IDX_MISC_IO, + .id = SKL_DISP_PW_MISC_IO), + ), .ops = &hsw_power_well_ops, .always_on = true, - .id =SKL_DISP_PW_MISC_IO , - { - .hsw.idx =SKL_PW_CTL_IDX_MISC_IO , - }, }, { - .name ="DC_off" , - .domain_list = &skl_pwdoms_dc_off, + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &skl_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), .ops = &gen9_dc_off_power_well_ops, - .id =SKL_DISP_DC_OFF , }, { - .name ="PW_2" , - .domain_list = &skl_pwdoms_pw_2, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &skl_pwdoms_pw_2, + .hsw.idx = SKL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), .ops = &hsw_power_well_ops, .has_vga = true, .irq_pipe_mask =BIT (PIPE_B ) |BIT (PIPE_C ), .has_fuses = true, - .id =SKL_DISP_PW_2 , - { - .hsw.idx =SKL_PW_CTL_IDX_PW_2 , - }, }, { - .name ="DDI_IO_A_E" , - .domain_list = &skl_pwdoms_ddi_io_a_e, + .instances = &I915_PW_INSTANCES ( + I915_PW("DDI_IO_A_E", &skl_pwdoms_ddi_io_a_e, .hsw.idx = SKL_PW_CTL_IDX_DDI_A_E), + I915_PW("DDI_IO_B", &skl_pwdoms_ddi_io_b, .hsw.idx = SKL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_C", &skl_pwdoms_ddi_io_c, .hsw.idx = SKL_PW_CTL_IDX_DDI_C), + I915_PW("DDI_IO_D", &skl_pwdoms_ddi_io_d, .hsw.idx = SKL_PW_CTL_IDX_DDI_D), + ), .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =SKL_PW_CTL_IDX_DDI_A_E , - }, - }, { - .name ="DDI_IO_B" , - .domain_list = &skl_pwdoms_ddi_io_b, - .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =SKL_PW_CTL_IDX_DDI_B , - }, - }, { - .name ="DDI_IO_C" , - .domain_list = &skl_pwdoms_ddi_io_c, - .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =SKL_PW_CTL_IDX_DDI_C , - }, - }, { - .name ="DDI_IO_D" , - .domain_list = &skl_pwdoms_ddi_io_d, - .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =SKL_PW_CTL_IDX_DDI_D , - }, }, };
@@ -474,54 +425,47 @@ I915_DECL_PW_DOMAINS(bxt_pwdoms_dpio_cmn_bc,static const struct i915_power_well_desc bxt_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="PW_1" ,/* Handled by the DMC firmware */ - .domain_list =I915_PW_DOMAINS_NONE , + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , + .hsw.idx = SKL_PW_CTL_IDX_PW_1, + .id = SKL_DISP_PW_1), + ), .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - .id =SKL_DISP_PW_1 , - { - .hsw.idx =SKL_PW_CTL_IDX_PW_1 , - }, }, { - .name ="DC_off" , - .domain_list = &bxt_pwdoms_dc_off, + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &bxt_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), .ops = &gen9_dc_off_power_well_ops, - .id =SKL_DISP_DC_OFF , }, { - .name ="PW_2" , - .domain_list = &bxt_pwdoms_pw_2, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &bxt_pwdoms_pw_2, + .hsw.idx = SKL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), .ops = &hsw_power_well_ops, .has_vga = true, .irq_pipe_mask =BIT (PIPE_B ) |BIT (PIPE_C ), .has_fuses = true, - .id =SKL_DISP_PW_2 , - { - .hsw.idx =SKL_PW_CTL_IDX_PW_2 , - }, }, { - .name ="dpio-common-a" , - .domain_list = &bxt_pwdoms_dpio_cmn_a, + .instances = &I915_PW_INSTANCES ( +I915_PW ("dpio-common-a" , &bxt_pwdoms_dpio_cmn_a, + .bxt.phy = DPIO_PHY1, + .id = BXT_DISP_PW_DPIO_CMN_A), +I915_PW ("dpio-common-bc" , &bxt_pwdoms_dpio_cmn_bc, + .bxt.phy = DPIO_PHY0, + .id = VLV_DISP_PW_DPIO_CMN_BC), + ), .ops = &bxt_dpio_cmn_power_well_ops, - .id =BXT_DISP_PW_DPIO_CMN_A , - { - .bxt.phy =DPIO_PHY1 , - }, - }, { - .name ="dpio-common-bc" , - .domain_list = &bxt_pwdoms_dpio_cmn_bc, - .ops = &bxt_dpio_cmn_power_well_ops, - .id =VLV_DISP_PW_DPIO_CMN_BC , - { - .bxt.phy =DPIO_PHY0 , - }, }, };
@@ -587,110 +531,60 @@ I915_DECL_PW_DOMAINS(glk_pwdoms_aux_c,static const struct i915_power_well_desc glk_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="PW_1" ,/* Handled by the DMC firmware */ - .domain_list =I915_PW_DOMAINS_NONE , + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , + .hsw.idx = SKL_PW_CTL_IDX_PW_1, + .id = SKL_DISP_PW_1), + ), .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - .id =SKL_DISP_PW_1 , - { - .hsw.idx =SKL_PW_CTL_IDX_PW_1 , - }, }, { - .name ="DC_off" , - .domain_list = &glk_pwdoms_dc_off, + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &glk_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), .ops = &gen9_dc_off_power_well_ops, - .id =SKL_DISP_DC_OFF , }, { - .name ="PW_2" , - .domain_list = &glk_pwdoms_pw_2, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &glk_pwdoms_pw_2, + .hsw.idx = SKL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), .ops = &hsw_power_well_ops, .has_vga = true, .irq_pipe_mask =BIT (PIPE_B ) |BIT (PIPE_C ), .has_fuses = true, - .id =SKL_DISP_PW_2 , - { - .hsw.idx =SKL_PW_CTL_IDX_PW_2 , - }, }, { - .name ="dpio-common-a" , - .domain_list = &glk_pwdoms_dpio_cmn_a, + .instances = &I915_PW_INSTANCES ( +I915_PW ("dpio-common-a" , &glk_pwdoms_dpio_cmn_a, + .bxt.phy = DPIO_PHY1, + .id = BXT_DISP_PW_DPIO_CMN_A), +I915_PW ("dpio-common-b" , &glk_pwdoms_dpio_cmn_b, + .bxt.phy = DPIO_PHY0, + .id = VLV_DISP_PW_DPIO_CMN_BC), +I915_PW ("dpio-common-c" , &glk_pwdoms_dpio_cmn_c, + .bxt.phy = DPIO_PHY2, + .id = GLK_DISP_PW_DPIO_CMN_C), + ), .ops = &bxt_dpio_cmn_power_well_ops, - .id =BXT_DISP_PW_DPIO_CMN_A , - { - .bxt.phy =DPIO_PHY1 , - }, }, { - .name ="dpio-common-b" , - .domain_list = &glk_pwdoms_dpio_cmn_b, - .ops = &bxt_dpio_cmn_power_well_ops, - .id =VLV_DISP_PW_DPIO_CMN_BC , - { - .bxt.phy =DPIO_PHY0 , - }, - }, { - .name ="dpio-common-c" , - .domain_list = &glk_pwdoms_dpio_cmn_c, - .ops = &bxt_dpio_cmn_power_well_ops, - .id =GLK_DISP_PW_DPIO_CMN_C , - { - .bxt.phy =DPIO_PHY2 , - }, - }, { - .name ="AUX_A" , - .domain_list = &glk_pwdoms_aux_a, - .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =GLK_PW_CTL_IDX_AUX_A , - }, - }, { - .name ="AUX_B" , - .domain_list = &glk_pwdoms_aux_b, - .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =GLK_PW_CTL_IDX_AUX_B , - }, - }, { - .name ="AUX_C" , - .domain_list = &glk_pwdoms_aux_c, - .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =GLK_PW_CTL_IDX_AUX_C , - }, - }, { - .name ="DDI_IO_A" , - .domain_list = &glk_pwdoms_ddi_io_a, - .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =GLK_PW_CTL_IDX_DDI_A , - }, - }, { - .name ="DDI_IO_B" , - .domain_list = &glk_pwdoms_ddi_io_b, - .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =SKL_PW_CTL_IDX_DDI_B , - }, - }, { - .name ="DDI_IO_C" , - .domain_list = &glk_pwdoms_ddi_io_c, + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_A", &glk_pwdoms_aux_a, .hsw.idx = GLK_PW_CTL_IDX_AUX_A), + I915_PW("AUX_B", &glk_pwdoms_aux_b, .hsw.idx = GLK_PW_CTL_IDX_AUX_B), + I915_PW("AUX_C", &glk_pwdoms_aux_c, .hsw.idx = GLK_PW_CTL_IDX_AUX_C), + I915_PW("DDI_IO_A", &glk_pwdoms_ddi_io_a, .hsw.idx = GLK_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &glk_pwdoms_ddi_io_b, .hsw.idx = SKL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_C", &glk_pwdoms_ddi_io_c, .hsw.idx = SKL_PW_CTL_IDX_DDI_C), + ), .ops = &hsw_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =SKL_PW_CTL_IDX_DDI_C , - }, }, };
@@ -790,193 +684,82 @@ I915_DECL_PW_DOMAINS(icl_pwdoms_aux_tbt4, POWER_DOMAIN_AUX_TBT_F);static const struct i915_power_well_desc icl_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="PW_1" ,/* Handled by the DMC firmware */ - .domain_list =I915_PW_DOMAINS_NONE , + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , + .hsw.idx = ICL_PW_CTL_IDX_PW_1, + .id = SKL_DISP_PW_1), + ), .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - .id =SKL_DISP_PW_1 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_1 , - }, }, { - .name ="DC_off" , - .domain_list = &icl_pwdoms_dc_off, + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &icl_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), .ops = &gen9_dc_off_power_well_ops, - .id =SKL_DISP_DC_OFF , }, { - .name ="PW_2" , - .domain_list = &icl_pwdoms_pw_2, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &icl_pwdoms_pw_2, + .hsw.idx = ICL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), .ops = &hsw_power_well_ops, .has_fuses = true, - .id =SKL_DISP_PW_2 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_2 , - }, }, { - .name ="PW_3" , - .domain_list = &icl_pwdoms_pw_3, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_3" , &icl_pwdoms_pw_3, + .hsw.idx = ICL_PW_CTL_IDX_PW_3, + .id = ICL_DISP_PW_3), + ), .ops = &hsw_power_well_ops, .has_vga = true, .irq_pipe_mask =BIT (PIPE_B ), .has_fuses = true, - .id =ICL_DISP_PW_3 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_3 , - }, }, { - .name ="DDI_IO_A" , - .domain_list = &icl_pwdoms_ddi_io_a, + .instances = &I915_PW_INSTANCES ( + I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_C", &icl_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), + I915_PW("DDI_IO_D", &icl_pwdoms_ddi_io_d, .hsw.idx = ICL_PW_CTL_IDX_DDI_D), + I915_PW("DDI_IO_E", &icl_pwdoms_ddi_io_e, .hsw.idx = ICL_PW_CTL_IDX_DDI_E), + I915_PW("DDI_IO_F", &icl_pwdoms_ddi_io_f, .hsw.idx = ICL_PW_CTL_IDX_DDI_F), + ), .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_A , - }, }, { - .name ="DDI_IO_B" , - .domain_list = &icl_pwdoms_ddi_io_b, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_B , - }, - }, { - .name ="DDI_IO_C" , - .domain_list = &icl_pwdoms_ddi_io_c, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_C , - }, - }, { - .name ="DDI_IO_D" , - .domain_list = &icl_pwdoms_ddi_io_d, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_D , - }, - }, { - .name ="DDI_IO_E" , - .domain_list = &icl_pwdoms_ddi_io_e, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_E , - }, - }, { - .name ="DDI_IO_F" , - .domain_list = &icl_pwdoms_ddi_io_f, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_F , - }, - }, { - .name ="AUX_A" , - .domain_list = &icl_pwdoms_aux_a, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_A , - }, - }, { - .name ="AUX_B" , - .domain_list = &icl_pwdoms_aux_b, + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_A", &icl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), + I915_PW("AUX_B", &icl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), + I915_PW("AUX_C", &icl_pwdoms_aux_c, .hsw.idx = ICL_PW_CTL_IDX_AUX_C), + I915_PW("AUX_D", &icl_pwdoms_aux_d, .hsw.idx = ICL_PW_CTL_IDX_AUX_D), + I915_PW("AUX_E", &icl_pwdoms_aux_e, .hsw.idx = ICL_PW_CTL_IDX_AUX_E), + I915_PW("AUX_F", &icl_pwdoms_aux_f, .hsw.idx = ICL_PW_CTL_IDX_AUX_F), + ), .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_B , - }, - }, { - .name ="AUX_C" , - .domain_list = &icl_pwdoms_aux_c, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_C , - }, - }, { - .name ="AUX_D" , - .domain_list = &icl_pwdoms_aux_d, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_D , - }, - }, { - .name ="AUX_E" , - .domain_list = &icl_pwdoms_aux_e, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_E , - }, - }, { - .name ="AUX_F" , - .domain_list = &icl_pwdoms_aux_f, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_F , - }, - }, { - .name ="AUX_TBT1" , - .domain_list = &icl_pwdoms_aux_tbt1, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_TBT1 , - }, - }, { - .name ="AUX_TBT2" , - .domain_list = &icl_pwdoms_aux_tbt2, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_TBT2 , - }, - }, { - .name ="AUX_TBT3" , - .domain_list = &icl_pwdoms_aux_tbt3, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_TBT3 , - }, }, { - .name ="AUX_TBT4" , - .domain_list = &icl_pwdoms_aux_tbt4, + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT1), + I915_PW("AUX_TBT2", &icl_pwdoms_aux_tbt2, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT2), + I915_PW("AUX_TBT3", &icl_pwdoms_aux_tbt3, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT3), + I915_PW("AUX_TBT4", &icl_pwdoms_aux_tbt4, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT4), + ), .ops = &icl_aux_power_well_ops, .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_TBT4 , - }, }, { - .name ="PW_4" , - .domain_list = &icl_pwdoms_pw_4, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_4" , &icl_pwdoms_pw_4, + .hsw.idx = ICL_PW_CTL_IDX_PW_4), + ), .ops = &hsw_power_well_ops, .irq_pipe_mask =BIT (PIPE_C ), .has_fuses = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_4 , - }, }, };
@@ -1087,276 +870,104 @@ I915_DECL_PW_DOMAINS(tgl_pwdoms_tc_cold_off,static const struct i915_power_well_desc tgl_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="PW_1" ,/* Handled by the DMC firmware */ - .domain_list =I915_PW_DOMAINS_NONE , + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , + .hsw.idx = ICL_PW_CTL_IDX_PW_1, + .id = SKL_DISP_PW_1), + ), .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - .id =SKL_DISP_PW_1 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_1 , - }, }, { - .name ="DC_off" , - .domain_list = &tgl_pwdoms_dc_off, + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &tgl_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), .ops = &gen9_dc_off_power_well_ops, - .id =SKL_DISP_DC_OFF , }, { - .name ="PW_2" , - .domain_list = &tgl_pwdoms_pw_2, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &tgl_pwdoms_pw_2, + .hsw.idx = ICL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), .ops = &hsw_power_well_ops, .has_fuses = true, - .id =SKL_DISP_PW_2 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_2 , - }, }, { - .name ="PW_3" , - .domain_list = &tgl_pwdoms_pw_3, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_3" , &tgl_pwdoms_pw_3, + .hsw.idx = ICL_PW_CTL_IDX_PW_3, + .id = ICL_DISP_PW_3), + ), .ops = &hsw_power_well_ops, .has_vga = true, .irq_pipe_mask =BIT (PIPE_B ), .has_fuses = true, - .id =ICL_DISP_PW_3 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_3 , - }, }, { - .name ="DDI_IO_A" , - .domain_list = &icl_pwdoms_ddi_io_a, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_A , - } - }, { - .name ="DDI_IO_B" , - .domain_list = &icl_pwdoms_ddi_io_b, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_B , - } - }, { - .name ="DDI_IO_C" , - .domain_list = &icl_pwdoms_ddi_io_c, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_C , - } - }, { - .name ="DDI_IO_TC1" , - .domain_list = &tgl_pwdoms_ddi_io_tc1, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC1 , - }, - }, { - .name ="DDI_IO_TC2" , - .domain_list = &tgl_pwdoms_ddi_io_tc2, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC2 , - }, - }, { - .name ="DDI_IO_TC3" , - .domain_list = &tgl_pwdoms_ddi_io_tc3, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC3 , - }, - }, { - .name ="DDI_IO_TC4" , - .domain_list = &tgl_pwdoms_ddi_io_tc4, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC4 , - }, - }, { - .name ="DDI_IO_TC5" , - .domain_list = &tgl_pwdoms_ddi_io_tc5, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC5 , - }, - }, { - .name ="DDI_IO_TC6" , - .domain_list = &tgl_pwdoms_ddi_io_tc6, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC6 , - }, - }, { - .name ="TC_cold_off" , - .domain_list = &tgl_pwdoms_tc_cold_off, + .instances = &I915_PW_INSTANCES ( + I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_C", &icl_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), + I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), + I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), + I915_PW("DDI_IO_TC3", &tgl_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3), + I915_PW("DDI_IO_TC4", &tgl_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4), + I915_PW("DDI_IO_TC5", &tgl_pwdoms_ddi_io_tc5, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC5), + I915_PW("DDI_IO_TC6", &tgl_pwdoms_ddi_io_tc6, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC6), + ), + .ops = &icl_ddi_power_well_ops, + }, { + .instances = &I915_PW_INSTANCES ( +I915_PW ("TC_cold_off" , &tgl_pwdoms_tc_cold_off, + .id = TGL_DISP_PW_TC_COLD_OFF), + ), .ops = &tgl_tc_cold_off_ops, - .id =TGL_DISP_PW_TC_COLD_OFF , }, { - .name ="AUX_A" , - .domain_list = &tgl_pwdoms_aux_a, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_A , - }, - }, { - .name ="AUX_B" , - .domain_list = &tgl_pwdoms_aux_b, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_B , - }, - }, { - .name ="AUX_C" , - .domain_list = &tgl_pwdoms_aux_c, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_C , - }, - }, { - .name ="AUX_USBC1" , - .domain_list = &tgl_pwdoms_aux_usbc1, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC1 , - }, - }, { - .name ="AUX_USBC2" , - .domain_list = &tgl_pwdoms_aux_usbc2, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC2 , - }, - }, { - .name ="AUX_USBC3" , - .domain_list = &tgl_pwdoms_aux_usbc3, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC3 , - }, - }, { - .name ="AUX_USBC4" , - .domain_list = &tgl_pwdoms_aux_usbc4, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC4 , - }, - }, { - .name ="AUX_USBC5" , - .domain_list = &tgl_pwdoms_aux_usbc5, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC5 , - }, - }, { - .name ="AUX_USBC6" , - .domain_list = &tgl_pwdoms_aux_usbc6, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC6 , - }, - }, { - .name ="AUX_TBT1" , - .domain_list = &tgl_pwdoms_aux_tbt1, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT1 , - }, - }, { - .name ="AUX_TBT2" , - .domain_list = &tgl_pwdoms_aux_tbt2, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT2 , - }, - }, { - .name ="AUX_TBT3" , - .domain_list = &tgl_pwdoms_aux_tbt3, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT3 , - }, - }, { - .name ="AUX_TBT4" , - .domain_list = &tgl_pwdoms_aux_tbt4, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT4 , - }, - }, { - .name ="AUX_TBT5" , - .domain_list = &tgl_pwdoms_aux_tbt5, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT5 , - }, - }, { - .name ="AUX_TBT6" , - .domain_list = &tgl_pwdoms_aux_tbt6, + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_A", &tgl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), + I915_PW("AUX_B", &tgl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), + I915_PW("AUX_C", &tgl_pwdoms_aux_c, .hsw.idx = ICL_PW_CTL_IDX_AUX_C), + I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1), + I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2), + I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3), + I915_PW("AUX_USBC4", &tgl_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4), + I915_PW("AUX_USBC5", &tgl_pwdoms_aux_usbc5, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC5), + I915_PW("AUX_USBC6", &tgl_pwdoms_aux_usbc6, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC6), + ), + .ops = &icl_aux_power_well_ops, + }, { + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_TBT1", &tgl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1), + I915_PW("AUX_TBT2", &tgl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2), + I915_PW("AUX_TBT3", &tgl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3), + I915_PW("AUX_TBT4", &tgl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4), + I915_PW("AUX_TBT5", &tgl_pwdoms_aux_tbt5, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT5), + I915_PW("AUX_TBT6", &tgl_pwdoms_aux_tbt6, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT6), + ), .ops = &icl_aux_power_well_ops, .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT6 , - }, }, { - .name ="PW_4" , - .domain_list = &tgl_pwdoms_pw_4, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_4" , &tgl_pwdoms_pw_4, + .hsw.idx = ICL_PW_CTL_IDX_PW_4), + ), .ops = &hsw_power_well_ops, .has_fuses = true, .irq_pipe_mask =BIT (PIPE_C ), - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_4 , - } }, { - .name ="PW_5" , - .domain_list = &tgl_pwdoms_pw_5, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_5" , &tgl_pwdoms_pw_5, + .hsw.idx = TGL_PW_CTL_IDX_PW_5), + ), .ops = &hsw_power_well_ops, .has_fuses = true, .irq_pipe_mask =BIT (PIPE_D ), - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_PW_5 , - }, }, };
@@ -1416,112 +1027,61 @@ I915_DECL_PW_DOMAINS(rkl_pwdoms_dc_off,static const struct i915_power_well_desc rkl_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="PW_1" ,/* Handled by the DMC firmware */ - .domain_list =I915_PW_DOMAINS_NONE , + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , + .hsw.idx = ICL_PW_CTL_IDX_PW_1, + .id = SKL_DISP_PW_1), + ), .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - .id =SKL_DISP_PW_1 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_1 , - }, }, { - .name ="DC_off" , - .domain_list = &rkl_pwdoms_dc_off, + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &rkl_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), .ops = &gen9_dc_off_power_well_ops, - .id =SKL_DISP_DC_OFF , }, { - .name ="PW_3" , - .domain_list = &rkl_pwdoms_pw_3, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_3" , &rkl_pwdoms_pw_3, + .hsw.idx = ICL_PW_CTL_IDX_PW_3, + .id = ICL_DISP_PW_3), + ), .ops = &hsw_power_well_ops, .irq_pipe_mask =BIT (PIPE_B ), .has_vga = true, .has_fuses = true, - .id =ICL_DISP_PW_3 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_3 , - }, }, { - .name ="PW_4" , - .domain_list = &rkl_pwdoms_pw_4, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_4" , &rkl_pwdoms_pw_4, + .hsw.idx = ICL_PW_CTL_IDX_PW_4), + ), .ops = &hsw_power_well_ops, .has_fuses = true, .irq_pipe_mask =BIT (PIPE_C ), - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_4 , - } }, { - .name ="DDI_IO_A" , - .domain_list = &icl_pwdoms_ddi_io_a, + .instances = &I915_PW_INSTANCES ( + I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), + I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), + ), .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_A , - } }, { - .name ="DDI_IO_B" , - .domain_list = &icl_pwdoms_ddi_io_b, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_B , - } - }, { - .name ="DDI_IO_TC1" , - .domain_list = &tgl_pwdoms_ddi_io_tc1, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC1 , - }, - }, { - .name ="DDI_IO_TC2" , - .domain_list = &tgl_pwdoms_ddi_io_tc2, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC2 , - }, - }, { - .name ="AUX_A" , - .domain_list = &icl_pwdoms_aux_a, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_A , - }, - }, { - .name ="AUX_B" , - .domain_list = &icl_pwdoms_aux_b, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_B , - }, - }, { - .name ="AUX_USBC1" , - .domain_list = &tgl_pwdoms_aux_usbc1, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC1 , - }, - }, { - .name ="AUX_USBC2" , - .domain_list = &tgl_pwdoms_aux_usbc2, + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_A", &icl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), + I915_PW("AUX_B", &icl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), + I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1), + I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2), + ), .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC2 , - }, }, };
@@ -1559,133 +1119,77 @@ I915_DECL_PW_DOMAINS(dg1_pwdoms_pw_2,static const struct i915_power_well_desc dg1_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="PW_1" ,/* Handled by the DMC firmware */ - .domain_list =I915_PW_DOMAINS_NONE , + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , + .hsw.idx = ICL_PW_CTL_IDX_PW_1, + .id = SKL_DISP_PW_1), + ), .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - .id =SKL_DISP_PW_1 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_1 , - }, }, { - .name ="DC_off" , - .domain_list = &dg1_pwdoms_dc_off, + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &dg1_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), .ops = &gen9_dc_off_power_well_ops, - .id =SKL_DISP_DC_OFF , }, { - .name ="PW_2" , - .domain_list = &dg1_pwdoms_pw_2, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &dg1_pwdoms_pw_2, + .hsw.idx = ICL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), .ops = &hsw_power_well_ops, .has_fuses = true, - .id =SKL_DISP_PW_2 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_2 , - }, }, { - .name ="PW_3" , - .domain_list = &dg1_pwdoms_pw_3, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_3" , &dg1_pwdoms_pw_3, + .hsw.idx = ICL_PW_CTL_IDX_PW_3, + .id = ICL_DISP_PW_3), + ), .ops = &hsw_power_well_ops, .irq_pipe_mask =BIT (PIPE_B ), .has_vga = true, .has_fuses = true, - .id =ICL_DISP_PW_3 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_3 , - }, }, { - .name ="DDI_IO_A" , - .domain_list = &icl_pwdoms_ddi_io_a, + .instances = &I915_PW_INSTANCES ( + I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), + I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), + ), .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_A , - } }, { - .name ="DDI_IO_B" , - .domain_list = &icl_pwdoms_ddi_io_b, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_B , - } - }, { - .name ="DDI_IO_TC1" , - .domain_list = &tgl_pwdoms_ddi_io_tc1, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC1 , - }, - }, { - .name ="DDI_IO_TC2" , - .domain_list = &tgl_pwdoms_ddi_io_tc2, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC2 , - }, - }, { - .name ="AUX_A" , - .domain_list = &tgl_pwdoms_aux_a, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_A , - }, - }, { - .name ="AUX_B" , - .domain_list = &tgl_pwdoms_aux_b, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_B , - }, - }, { - .name ="AUX_USBC1" , - .domain_list = &tgl_pwdoms_aux_usbc1, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC1 , - }, - }, { - .name ="AUX_USBC2" , - .domain_list = &tgl_pwdoms_aux_usbc2, + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_A", &tgl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), + I915_PW("AUX_B", &tgl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), + I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1), + I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2), + ), .ops = &icl_aux_power_well_ops, - .is_tc_tbt = false, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC2 , - }, }, { - .name ="PW_4" , - .domain_list = &tgl_pwdoms_pw_4, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_4" , &tgl_pwdoms_pw_4, + .hsw.idx = ICL_PW_CTL_IDX_PW_4), + ), .ops = &hsw_power_well_ops, .has_fuses = true, .irq_pipe_mask =BIT (PIPE_C ), - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_4 , - } }, { - .name ="PW_5" , - .domain_list = &tgl_pwdoms_pw_5, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_5" , &tgl_pwdoms_pw_5, + .hsw.idx = TGL_PW_CTL_IDX_PW_5), + ), .ops = &hsw_power_well_ops, .has_fuses = true, .irq_pipe_mask =BIT (PIPE_D ), - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_PW_5 , - }, }, };
@@ -1816,283 +1320,131 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_ddi_io_tc4, POWER_DOMAIN_PORT_DDI_IO_TC4);static const struct i915_power_well_desc xelpd_power_wells[] = { { - .name ="always-on" , - .domain_list = &i9xx_pwdoms_always_on, + .instances = &I915_PW_INSTANCES ( + I915_PW("always-on", &i9xx_pwdoms_always_on), + ), .ops = &i9xx_always_on_power_well_ops, .always_on = true, - .id =DISP_PW_ID_NONE , }, { - .name ="PW_1" ,/* Handled by the DMC firmware */ - .domain_list =I915_PW_DOMAINS_NONE , + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , + .hsw.idx = ICL_PW_CTL_IDX_PW_1, + .id = SKL_DISP_PW_1), + ), .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - .id =SKL_DISP_PW_1 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_1 , - }, }, { - .name ="DC_off" , - .domain_list = &xelpd_pwdoms_dc_off, + .instances = &I915_PW_INSTANCES ( +I915_PW ("DC_off" , &xelpd_pwdoms_dc_off, + .id = SKL_DISP_DC_OFF), + ), .ops = &gen9_dc_off_power_well_ops, - .id =SKL_DISP_DC_OFF , }, { - .name ="PW_2" , - .domain_list = &xelpd_pwdoms_pw_2, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_2" , &xelpd_pwdoms_pw_2, + .hsw.idx = ICL_PW_CTL_IDX_PW_2, + .id = SKL_DISP_PW_2), + ), .ops = &hsw_power_well_ops, .has_vga = true, .has_fuses = true, - .id =SKL_DISP_PW_2 , - { - .hsw.idx =ICL_PW_CTL_IDX_PW_2 , - }, }, { - .name ="PW_A" , - .domain_list = &xelpd_pwdoms_pw_a, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_A" , &xelpd_pwdoms_pw_a, + .hsw.idx = XELPD_PW_CTL_IDX_PW_A), + ), .ops = &hsw_power_well_ops, .irq_pipe_mask =BIT (PIPE_A ), .has_fuses = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =XELPD_PW_CTL_IDX_PW_A , - }, }, { - .name ="PW_B" , - .domain_list = &xelpd_pwdoms_pw_b, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_B" , &xelpd_pwdoms_pw_b, + .hsw.idx = XELPD_PW_CTL_IDX_PW_B), + ), .ops = &hsw_power_well_ops, .irq_pipe_mask =BIT (PIPE_B ), .has_fuses = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =XELPD_PW_CTL_IDX_PW_B , - }, }, { - .name ="PW_C" , - .domain_list = &xelpd_pwdoms_pw_c, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_C" , &xelpd_pwdoms_pw_c, + .hsw.idx = XELPD_PW_CTL_IDX_PW_C), + ), .ops = &hsw_power_well_ops, .irq_pipe_mask =BIT (PIPE_C ), .has_fuses = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =XELPD_PW_CTL_IDX_PW_C , - }, }, { - .name ="PW_D" , - .domain_list = &xelpd_pwdoms_pw_d, + .instances = &I915_PW_INSTANCES ( +I915_PW ("PW_D" , &xelpd_pwdoms_pw_d, + .hsw.idx = XELPD_PW_CTL_IDX_PW_D), + ), .ops = &hsw_power_well_ops, .irq_pipe_mask =BIT (PIPE_D ), .has_fuses = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =XELPD_PW_CTL_IDX_PW_D , - }, }, { - .name ="DDI_IO_A" , - .domain_list = &icl_pwdoms_ddi_io_a, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_A , - } - }, { - .name ="DDI_IO_B" , - .domain_list = &icl_pwdoms_ddi_io_b, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_B , - } - }, { - .name ="DDI_IO_C" , - .domain_list = &icl_pwdoms_ddi_io_c, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_DDI_C , - } - }, { - .name ="DDI_IO_D_XELPD" , - .domain_list = &xelpd_pwdoms_ddi_io_d_xelpd, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =XELPD_PW_CTL_IDX_DDI_D , - } - }, { - .name ="DDI_IO_E_XELPD" , - .domain_list = &xelpd_pwdoms_ddi_io_e_xelpd, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =XELPD_PW_CTL_IDX_DDI_E , - } - }, { - .name ="DDI_IO_TC1" , - .domain_list = &xelpd_pwdoms_ddi_io_tc1, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC1 , - } - }, { - .name ="DDI_IO_TC2" , - .domain_list = &xelpd_pwdoms_ddi_io_tc2, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC2 , - } - }, { - .name ="DDI_IO_TC3" , - .domain_list = &xelpd_pwdoms_ddi_io_tc3, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC3 , - } - }, { - .name ="DDI_IO_TC4" , - .domain_list = &xelpd_pwdoms_ddi_io_tc4, - .ops = &icl_ddi_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_DDI_TC4 , - } - }, { - .name ="AUX_A" , - .domain_list = &icl_pwdoms_aux_a, - .ops = &icl_aux_power_well_ops, - .fixed_enable_delay = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_A , - }, - }, { - .name ="AUX_B" , - .domain_list = &icl_pwdoms_aux_b, - .ops = &icl_aux_power_well_ops, - .fixed_enable_delay = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_B , - }, - }, { - .name ="AUX_C" , - .domain_list = &tgl_pwdoms_aux_c, + .instances = &I915_PW_INSTANCES ( + I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_C", &icl_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), + I915_PW("DDI_IO_D_XELPD", &xelpd_pwdoms_ddi_io_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_D), + I915_PW("DDI_IO_E_XELPD", &xelpd_pwdoms_ddi_io_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_E), + I915_PW("DDI_IO_TC1", &xelpd_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), + I915_PW("DDI_IO_TC2", &xelpd_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), + I915_PW("DDI_IO_TC3", &xelpd_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3), + I915_PW("DDI_IO_TC4", &xelpd_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4), + ), + .ops = &icl_ddi_power_well_ops, + }, { + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_A", &icl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), + I915_PW("AUX_B", &icl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), + I915_PW("AUX_C", &tgl_pwdoms_aux_c, .hsw.idx = ICL_PW_CTL_IDX_AUX_C), + I915_PW("AUX_D_XELPD", &xelpd_pwdoms_aux_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_D), + I915_PW("AUX_E_XELPD", &xelpd_pwdoms_aux_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_E), + I915_PW("AUX_USBC1", &xelpd_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1), + I915_PW("AUX_USBC2", &xelpd_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2), + I915_PW("AUX_USBC3", &xelpd_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3), + I915_PW("AUX_USBC4", &xelpd_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4), + ), .ops = &icl_aux_power_well_ops, .fixed_enable_delay = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =ICL_PW_CTL_IDX_AUX_C , - }, - }, { - .name ="AUX_D_XELPD" , - .domain_list = &xelpd_pwdoms_aux_d_xelpd, - .ops = &icl_aux_power_well_ops, - .fixed_enable_delay = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =XELPD_PW_CTL_IDX_AUX_D , - }, - }, { - .name ="AUX_E_XELPD" , - .domain_list = &xelpd_pwdoms_aux_e_xelpd, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =XELPD_PW_CTL_IDX_AUX_E , - }, - }, { - .name ="AUX_USBC1" , - .domain_list = &xelpd_pwdoms_aux_usbc1, - .ops = &icl_aux_power_well_ops, - .fixed_enable_delay = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC1 , - }, - }, { - .name ="AUX_USBC2" , - .domain_list = &xelpd_pwdoms_aux_usbc2, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC2 , - }, - }, { - .name ="AUX_USBC3" , - .domain_list = &xelpd_pwdoms_aux_usbc3, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC3 , - }, - }, { - .name ="AUX_USBC4" , - .domain_list = &xelpd_pwdoms_aux_usbc4, - .ops = &icl_aux_power_well_ops, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TC4 , - }, - }, { - .name ="AUX_TBT1" , - .domain_list = &xelpd_pwdoms_aux_tbt1, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT1 , - }, - }, { - .name ="AUX_TBT2" , - .domain_list = &xelpd_pwdoms_aux_tbt2, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT2 , - }, - }, { - .name ="AUX_TBT3" , - .domain_list = &xelpd_pwdoms_aux_tbt3, - .ops = &icl_aux_power_well_ops, - .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT3 , - }, }, { - .name ="AUX_TBT4" , - .domain_list = &xelpd_pwdoms_aux_tbt4, + .instances = &I915_PW_INSTANCES ( + I915_PW("AUX_TBT1", &xelpd_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1), + I915_PW("AUX_TBT2", &xelpd_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2), + I915_PW("AUX_TBT3", &xelpd_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3), + I915_PW("AUX_TBT4", &xelpd_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4), + ), .ops = &icl_aux_power_well_ops, .is_tc_tbt = true, - .id =DISP_PW_ID_NONE , - { - .hsw.idx =TGL_PW_CTL_IDX_AUX_TBT4 , - }, }, }; -static void init_power_well_domains (const struct i915_power_well_desc *desc, +static void init_power_well_domains (const struct i915_power_well_instance *inst,struct i915_power_well *power_well) {int j; -if (!desc->domain_list) +if (!inst->domain_list)return ; -if (desc->domain_list->count ==0 ) { +if (inst->domain_list->count ==0 ) {bitmap_fill (power_well->domains.bits,POWER_DOMAIN_NUM );return ; } -for (j =0 ; j < desc->domain_list->count; j++) -set_bit (desc->domain_list->list[j], power_well->domains.bits); +for (j =0 ; j < inst->domain_list->count; j++) +set_bit (inst->domain_list->list[j], power_well->domains.bits); } +#define for_each_power_well_instance (_desc_list, _desc_count, _desc, _inst) \ + for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \ + for ((_inst) = (_desc)->instances->list; \ + (_inst) - (_desc)->instances->list < (_desc)->instances->count; \ + (_inst)++) + static int __set_power_wells(struct i915_power_domains *power_domains, const struct i915_power_well_desc *power_well_descs,
@@ -2102,11 +1454,13 @@ __set_power_wells(struct i915_power_domains *power_domains, struct drm_i915_private, power_domains);u64 power_well_ids =0 ; +const struct i915_power_well_desc *desc; +const struct i915_power_well_instance *inst;int power_well_count =0 ; -int i, plt_idx =0 ; +int plt_idx =0 ; -for (i =0 ; i < power_well_descs_sz; i++) -if (!(BIT_ULL (power_well_descs[i].id) & skip_mask)) +for_each_power_well_instance (power_well_descs, power_well_descs_sz, desc, inst) +if (!(BIT_ULL (inst->id) & skip_mask)) power_well_count++; power_domains->power_well_count = power_well_count;
@@ -2117,16 +1471,19 @@ __set_power_wells(struct i915_power_domains *power_domains,if (!power_domains->power_wells)return -ENOMEM ; -for (i =0 ; i < power_well_descs_sz; i++) { -enum i915_power_well_id id = power_well_descs[i].id; +for_each_power_well_instance (power_well_descs, power_well_descs_sz, desc, inst) { +struct i915_power_well *pw = &power_domains->power_wells[plt_idx]; +enum i915_power_well_id id = inst->id;if (BIT_ULL (id) & skip_mask)continue ; - power_domains->power_wells[plt_idx].desc = - &power_well_descs[i]; + pw->desc = desc; +drm_WARN_ON (&i915->drm, +overflows_type (inst - desc->instances->list, pw->instance_idx)); + pw->instance_idx = inst - desc->instances->list; -init_power_well_domains (&power_well_descs[i], &power_domains->power_wells[plt_idx]); +init_power_well_domains (inst, pw); plt_idx++;
drivers/gpu/drm/i915/display/intel_display_power_well.c +40 -32
245 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_well.h +29 -19
78 lines not on this page · raw message
Signature · 1 line
2.30.2
PATCH 11/18 drm/i915: Allow platforms to share power well descriptors
In reply to Imre DeakSome power wells - like always-on and skl+/icl+ PW_1 - with the same name, domain list, flags, ops are used by multiple platforms, so allow platforms to reuse the descriptors of such power wells.
This change also lets the follow up patches to simplify the DG1/RKL power well definitions, and remove the ADL-S skip_mask special casing.
--- .../i915/display/intel_display_power_map.c | 281 ++++++++---------- 1 file changed, 122 insertions(+), 159 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +122 -159
@@ -38,9 +38,17 @@ { .name = _name, .domain_list = _domain_list, ## __VA_ARGS__ } +struct i915_power_well_desc_list { +const struct i915_power_well_desc *list; +u8 count; +}; + +#define I915_PW_DESCRIPTORS (x) __LIST(x) + +I915_DECL_PW_DOMAINS (i9xx_pwdoms_always_on,I915_PW_DOMAINS_ALL ); -static const struct i915_power_well_desc i9xx_always_on_power_well[] = { +static const struct i915_power_well_desc i9xx_power_wells_always_on[] = { { .instances = &I915_PW_INSTANCES( I915_PW("always-on", &i9xx_pwdoms_always_on),
@@ -50,6 +58,10 @@ static const struct i915_power_well_desc i9xx_always_on_power_well[] = { }, }; +static const struct i915_power_well_desc_list i9xx_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +}; + I915_DECL_PW_DOMAINS(i830_pwdoms_pipes, POWER_DOMAIN_PIPE_A, POWER_DOMAIN_PIPE_B,
@@ -59,14 +71,8 @@ I915_DECL_PW_DOMAINS(i830_pwdoms_pipes,POWER_DOMAIN_TRANSCODER_B , POWER_DOMAIN_INIT); -static const struct i915_power_well_desc i830_power_wells[] = { +static const struct i915_power_well_desc i830_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { .instances = &I915_PW_INSTANCES ( I915_PW("pipes", &i830_pwdoms_pipes), ),
@@ -74,6 +80,11 @@ static const struct i915_power_well_desc i830_power_wells[] = { }, }; +static const struct i915_power_well_desc_list i830_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (i830_power_wells_main), +}; + I915_DECL_PW_DOMAINS(hsw_pwdoms_display, POWER_DOMAIN_PIPE_B, POWER_DOMAIN_PIPE_C,
@@ -92,14 +103,8 @@ I915_DECL_PW_DOMAINS(hsw_pwdoms_display, POWER_DOMAIN_AUDIO_PLAYBACK, POWER_DOMAIN_INIT); -static const struct i915_power_well_desc hsw_power_wells[] = { +static const struct i915_power_well_desc hsw_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { .instances = &I915_PW_INSTANCES( I915_PW("display", &hsw_pwdoms_display, .hsw.idx = HSW_PW_CTL_IDX_GLOBAL,
@@ -110,6 +115,11 @@ static const struct i915_power_well_desc hsw_power_wells[] = { }, }; +static const struct i915_power_well_desc_list hsw_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (hsw_power_wells_main), +}; + I915_DECL_PW_DOMAINS(bdw_pwdoms_display, POWER_DOMAIN_PIPE_B, POWER_DOMAIN_PIPE_C,
@@ -127,14 +137,8 @@ I915_DECL_PW_DOMAINS(bdw_pwdoms_display, POWER_DOMAIN_AUDIO_PLAYBACK, POWER_DOMAIN_INIT); -static const struct i915_power_well_desc bdw_power_wells[] = { +static const struct i915_power_well_desc bdw_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { .instances = &I915_PW_INSTANCES( I915_PW("display", &bdw_pwdoms_display, .hsw.idx = HSW_PW_CTL_IDX_GLOBAL,
@@ -146,6 +150,11 @@ static const struct i915_power_well_desc bdw_power_wells[] = { }, }; +static const struct i915_power_well_desc_list bdw_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (bdw_power_wells_main), +}; + I915_DECL_PW_DOMAINS(vlv_pwdoms_display, POWER_DOMAIN_DISPLAY_CORE, POWER_DOMAIN_PIPE_A,
@@ -181,14 +190,8 @@ I915_DECL_PW_DOMAINS(vlv_pwdoms_dpio_tx_bc_lanes, POWER_DOMAIN_AUX_C, POWER_DOMAIN_INIT); -static const struct i915_power_well_desc vlv_power_wells[] = { +static const struct i915_power_well_desc vlv_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { .instances = &I915_PW_INSTANCES( I915_PW("display", &vlv_pwdoms_display, .vlv.idx = PUNIT_PWGT_IDX_DISP2D,
@@ -217,6 +220,11 @@ static const struct i915_power_well_desc vlv_power_wells[] = { }, }; +static const struct i915_power_well_desc_list vlv_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (vlv_power_wells_main), +}; + I915_DECL_PW_DOMAINS(chv_pwdoms_display, POWER_DOMAIN_DISPLAY_CORE, POWER_DOMAIN_PIPE_A,
@@ -253,14 +261,8 @@ I915_DECL_PW_DOMAINS(chv_pwdoms_dpio_cmn_d,POWER_DOMAIN_AUX_D , POWER_DOMAIN_INIT); -static const struct i915_power_well_desc chv_power_wells[] = { +static const struct i915_power_well_desc chv_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, {/* * Pipe A power well is the new disp2d well. Pipe B and C * power wells don't actually exist. Pipe A power well is
@@ -283,6 +285,11 @@ static const struct i915_power_well_desc chv_power_wells[] = { }, }; +static const struct i915_power_well_desc_list chv_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (chv_power_wells_main), +}; +#define SKL_PW_2_POWER_DOMAINS \ POWER_DOMAIN_PIPE_B, \ POWER_DOMAIN_PIPE_C, \
@@ -330,14 +337,8 @@ I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_d, POWER_DOMAIN_PORT_DDI_IO_D, POWER_DOMAIN_INIT); -static const struct i915_power_well_desc skl_power_wells[] = { +static const struct i915_power_well_desc skl_power_wells_pw_1[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, {/* Handled by the DMC firmware */ .instances = &I915_PW_INSTANCES( I915_PW("PW_1", I915_PW_DOMAINS_NONE,
@@ -347,7 +348,11 @@ static const struct i915_power_well_desc skl_power_wells[] = { .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - }, { + }, +}; + +static const struct i915_power_well_desc skl_power_wells_main[] = { + {/* Handled by the DMC firmware */ .instances = &I915_PW_INSTANCES( I915_PW("MISC_IO", I915_PW_DOMAINS_NONE,
@@ -383,6 +388,12 @@ static const struct i915_power_well_desc skl_power_wells[] = { }, }; +static const struct i915_power_well_desc_list skl_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (skl_power_wells_pw_1), +I915_PW_DESCRIPTORS (skl_power_wells_main), +}; +#define BXT_PW_2_POWER_DOMAINS \ POWER_DOMAIN_PIPE_B, \ POWER_DOMAIN_PIPE_C, \
@@ -423,24 +434,8 @@ I915_DECL_PW_DOMAINS(bxt_pwdoms_dpio_cmn_bc, POWER_DOMAIN_AUX_C, POWER_DOMAIN_INIT); -static const struct i915_power_well_desc bxt_power_wells[] = { +static const struct i915_power_well_desc bxt_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { -/* Handled by the DMC firmware */ - .instances = &I915_PW_INSTANCES ( -I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , - .hsw.idx = SKL_PW_CTL_IDX_PW_1, - .id = SKL_DISP_PW_1), - ), - .ops = &hsw_power_well_ops, - .always_on = true, - .has_fuses = true, - }, { .instances = &I915_PW_INSTANCES( I915_PW("DC_off", &bxt_pwdoms_dc_off, .id = SKL_DISP_DC_OFF),
@@ -469,6 +464,12 @@ static const struct i915_power_well_desc bxt_power_wells[] = { }, }; +static const struct i915_power_well_desc_list bxt_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (skl_power_wells_pw_1), +I915_PW_DESCRIPTORS (bxt_power_wells_main), +}; +#define GLK_PW_2_POWER_DOMAINS \ POWER_DOMAIN_PIPE_B, \ POWER_DOMAIN_PIPE_C, \
@@ -529,24 +530,8 @@ I915_DECL_PW_DOMAINS(glk_pwdoms_aux_c, POWER_DOMAIN_AUX_C, POWER_DOMAIN_INIT); -static const struct i915_power_well_desc glk_power_wells[] = { +static const struct i915_power_well_desc glk_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { -/* Handled by the DMC firmware */ - .instances = &I915_PW_INSTANCES ( -I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , - .hsw.idx = SKL_PW_CTL_IDX_PW_1, - .id = SKL_DISP_PW_1), - ), - .ops = &hsw_power_well_ops, - .always_on = true, - .has_fuses = true, - }, { .instances = &I915_PW_INSTANCES( I915_PW("DC_off", &glk_pwdoms_dc_off, .id = SKL_DISP_DC_OFF),
@@ -588,6 +573,12 @@ static const struct i915_power_well_desc glk_power_wells[] = { }, }; +static const struct i915_power_well_desc_list glk_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (skl_power_wells_pw_1), +I915_PW_DESCRIPTORS (glk_power_wells_main), +}; +/* * ICL PW_0/PG_0 domains (HW/DMC control): * - PCI
@@ -682,14 +673,8 @@ I915_DECL_PW_DOMAINS(icl_pwdoms_aux_tbt2, POWER_DOMAIN_AUX_TBT_D);I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt3,POWER_DOMAIN_AUX_TBT_E );I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt4,POWER_DOMAIN_AUX_TBT_F ); -static const struct i915_power_well_desc icl_power_wells[] = { +static const struct i915_power_well_desc icl_power_wells_pw_1[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, {/* Handled by the DMC firmware */ .instances = &I915_PW_INSTANCES( I915_PW("PW_1", I915_PW_DOMAINS_NONE,
@@ -699,7 +684,11 @@ static const struct i915_power_well_desc icl_power_wells[] = { .ops = &hsw_power_well_ops, .always_on = true, .has_fuses = true, - }, { + }, +}; + +static const struct i915_power_well_desc icl_power_wells_main[] = { + { .instances = &I915_PW_INSTANCES( I915_PW("DC_off", &icl_pwdoms_dc_off, .id = SKL_DISP_DC_OFF),
@@ -763,6 +752,12 @@ static const struct i915_power_well_desc icl_power_wells[] = { }, }; +static const struct i915_power_well_desc_list icl_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (icl_power_wells_main), +}; +#define TGL_PW_5_POWER_DOMAINS \ POWER_DOMAIN_PIPE_D, \ POWER_DOMAIN_PIPE_PANEL_FITTER_D, \
@@ -868,24 +863,8 @@ I915_DECL_PW_DOMAINS(tgl_pwdoms_tc_cold_off, POWER_DOMAIN_AUX_TBT6, POWER_DOMAIN_TC_COLD_OFF); -static const struct i915_power_well_desc tgl_power_wells[] = { +static const struct i915_power_well_desc tgl_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { -/* Handled by the DMC firmware */ - .instances = &I915_PW_INSTANCES ( -I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , - .hsw.idx = ICL_PW_CTL_IDX_PW_1, - .id = SKL_DISP_PW_1), - ), - .ops = &hsw_power_well_ops, - .always_on = true, - .has_fuses = true, - }, { .instances = &I915_PW_INSTANCES( I915_PW("DC_off", &tgl_pwdoms_dc_off, .id = SKL_DISP_DC_OFF),
@@ -971,6 +950,12 @@ static const struct i915_power_well_desc tgl_power_wells[] = { }, }; +static const struct i915_power_well_desc_list tgl_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (tgl_power_wells_main), +}; +#define RKL_PW_4_POWER_DOMAINS \ POWER_DOMAIN_PIPE_C, \ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
@@ -1025,24 +1010,8 @@ I915_DECL_PW_DOMAINS(rkl_pwdoms_dc_off, POWER_DOMAIN_MODESET, POWER_DOMAIN_INIT); -static const struct i915_power_well_desc rkl_power_wells[] = { +static const struct i915_power_well_desc rkl_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { -/* Handled by the DMC firmware */ - .instances = &I915_PW_INSTANCES ( -I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , - .hsw.idx = ICL_PW_CTL_IDX_PW_1, - .id = SKL_DISP_PW_1), - ), - .ops = &hsw_power_well_ops, - .always_on = true, - .has_fuses = true, - }, { .instances = &I915_PW_INSTANCES( I915_PW("DC_off", &rkl_pwdoms_dc_off, .id = SKL_DISP_DC_OFF),
@@ -1085,6 +1054,12 @@ static const struct i915_power_well_desc rkl_power_wells[] = { }, }; +static const struct i915_power_well_desc_list rkl_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (rkl_power_wells_main), +}; +/* * DG1 onwards Audio MMIO/VERBS lies in PG0 power well. */
@@ -1117,24 +1092,8 @@ I915_DECL_PW_DOMAINS(dg1_pwdoms_pw_2, POWER_DOMAIN_TRANSCODER_VDSC_PW2, POWER_DOMAIN_INIT); -static const struct i915_power_well_desc dg1_power_wells[] = { +static const struct i915_power_well_desc dg1_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { -/* Handled by the DMC firmware */ - .instances = &I915_PW_INSTANCES ( -I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , - .hsw.idx = ICL_PW_CTL_IDX_PW_1, - .id = SKL_DISP_PW_1), - ), - .ops = &hsw_power_well_ops, - .always_on = true, - .has_fuses = true, - }, { .instances = &I915_PW_INSTANCES( I915_PW("DC_off", &dg1_pwdoms_dc_off, .id = SKL_DISP_DC_OFF),
@@ -1193,6 +1152,12 @@ static const struct i915_power_well_desc dg1_power_wells[] = { }, }; +static const struct i915_power_well_desc_list dg1_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (dg1_power_wells_main), +}; +/* * XE_LPD Power Domains *
@@ -1318,24 +1283,8 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_ddi_io_tc2, POWER_DOMAIN_PORT_DDI_IO_TC2);I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_tc3,POWER_DOMAIN_PORT_DDI_IO_TC3 );I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_tc4,POWER_DOMAIN_PORT_DDI_IO_TC4 ); -static const struct i915_power_well_desc xelpd_power_wells[] = { +static const struct i915_power_well_desc xelpd_power_wells_main[] = { { - .instances = &I915_PW_INSTANCES ( - I915_PW("always-on", &i9xx_pwdoms_always_on), - ), - .ops = &i9xx_always_on_power_well_ops, - .always_on = true, - }, { -/* Handled by the DMC firmware */ - .instances = &I915_PW_INSTANCES ( -I915_PW ("PW_1" ,I915_PW_DOMAINS_NONE , - .hsw.idx = ICL_PW_CTL_IDX_PW_1, - .id = SKL_DISP_PW_1), - ), - .ops = &hsw_power_well_ops, - .always_on = true, - .has_fuses = true, - }, { .instances = &I915_PW_INSTANCES( I915_PW("DC_off", &xelpd_pwdoms_dc_off, .id = SKL_DISP_DC_OFF),
@@ -1421,6 +1370,12 @@ static const struct i915_power_well_desc xelpd_power_wells[] = { }, }; +static const struct i915_power_well_desc_list xelpd_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (xelpd_power_wells_main), +}; +static void init_power_well_domains (const struct i915_power_well_instance *inst,struct i915_power_well *power_well) {
@@ -1439,27 +1394,35 @@ static void init_power_well_domains(const struct i915_power_well_instance *inst,set_bit (inst->domain_list->list[j], power_well->domains.bits); } -#define for_each_power_well_instance (_desc_list, _desc_count, _desc, _inst) \ +#define for_each_power_well_instance_in_desc_list (_desc_list, _desc_count, _desc, _inst) \ for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \ for ((_inst) = (_desc)->instances->list; \ (_inst) - (_desc)->instances->list < (_desc)->instances->count; \ (_inst)++) +#define for_each_power_well_instance (_desc_list, _desc_count, _descs, _desc, _inst) \ + for ((_descs) = (_desc_list); \ + (_descs) - (_desc_list) < (_desc_count); \ + (_descs)++) \ + for_each_power_well_instance_in_desc_list((_descs)->list, (_descs)->count, \ + (_desc), (_inst)) +static int __set_power_wells (struct i915_power_domains *power_domains, -const struct i915_power_well_desc *power_well_descs, +const struct i915_power_well_desc_list *power_well_descs,int power_well_descs_sz,u64 skip_mask) {struct drm_i915_private *i915 =container_of (power_domains, struct drm_i915_private, power_domains);u64 power_well_ids =0 ; +const struct i915_power_well_desc_list *desc_list;const struct i915_power_well_desc *desc;const struct i915_power_well_instance *inst;int power_well_count =0 ;int plt_idx =0 ; -for_each_power_well_instance (power_well_descs, power_well_descs_sz, desc, inst) +for_each_power_well_instance (power_well_descs, power_well_descs_sz, desc_list, desc, inst)if (!(BIT_ULL (inst->id) & skip_mask)) power_well_count++;
@@ -1471,7 +1434,7 @@ __set_power_wells(struct i915_power_domains *power_domains,if (!power_domains->power_wells)return -ENOMEM ; -for_each_power_well_instance (power_well_descs, power_well_descs_sz, desc, inst) { +for_each_power_well_instance (power_well_descs, power_well_descs_sz, desc_list, desc, inst) {struct i915_power_well *pw = &power_domains->power_wells[plt_idx];enum i915_power_well_id id = inst->id;
@@ -1557,7 +1520,7 @@ int intel_display_power_map_init(struct i915_power_domains *power_domains)else if (IS_I830 (i915))return set_power_wells (power_domains, i830_power_wells);else -return set_power_wells (power_domains, i9xx_always_on_power_well); +return set_power_wells (power_domains, i9xx_power_wells); }/**
Signature · 1 line
2.30.2
PATCH 12/18 drm/i915: Simplify the DG1 power well descriptors
In reply to Imre DeakSimplify the definition of DG1 power wells by reusing the identical RKL DDI/AUX descriptors.
This reorders the DG1 DDI/AUX vs. PW4/5 power wells, but this shouldn't make a difference (it is the order on RKL and the DDI/AUX power wells don't have a dependency on PW4/5).
--- .../i915/display/intel_display_power_map.c | 24 ++++++------------- 1 file changed, 7 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +7 -17
@@ -1035,7 +1035,11 @@ static const struct i915_power_well_desc rkl_power_wells_main[] = { .ops = &hsw_power_well_ops, .has_fuses = true, .irq_pipe_mask = BIT(PIPE_C), - }, { + }, +}; + +static const struct i915_power_well_desc rkl_power_wells_ddi_aux[] = { + { .instances = &I915_PW_INSTANCES( I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B),
@@ -1058,6 +1062,7 @@ static const struct i915_power_well_desc_list rkl_power_wells[] = {I915_PW_DESCRIPTORS (i9xx_power_wells_always_on),I915_PW_DESCRIPTORS (icl_power_wells_pw_1),I915_PW_DESCRIPTORS (rkl_power_wells_main), + I915_PW_DESCRIPTORS(rkl_power_wells_ddi_aux), };/*
@@ -1117,22 +1122,6 @@ static const struct i915_power_well_desc dg1_power_wells_main[] = { .irq_pipe_mask = BIT(PIPE_B), .has_vga = true, .has_fuses = true, - }, { - .instances = &I915_PW_INSTANCES( - I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), - I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), - I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), - I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), - ), - .ops = &icl_ddi_power_well_ops, - }, { - .instances = &I915_PW_INSTANCES ( - I915_PW("AUX_A", &tgl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), - I915_PW("AUX_B", &tgl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), - I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1), - I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2), - ), - .ops = &icl_aux_power_well_ops, }, { .instances = &I915_PW_INSTANCES( I915_PW("PW_4", &tgl_pwdoms_pw_4,
@@ -1156,6 +1145,7 @@ static const struct i915_power_well_desc_list dg1_power_wells[] = {I915_PW_DESCRIPTORS (i9xx_power_wells_always_on),I915_PW_DESCRIPTORS (icl_power_wells_pw_1),I915_PW_DESCRIPTORS (dg1_power_wells_main), + I915_PW_DESCRIPTORS(rkl_power_wells_ddi_aux), };/*
Signature · 1 line
2.30.2
PATCH 13/18 drm/i915: Sanitize the ADL-S power well definition
In reply to Imre DeakInstead of the skip_mask special casing of the ADL-S power well descriptors, add a power well descriptor list for ADL-S as well reusing the TGL descriptors, w/o the TC-cold power well. ADL-S doesn't have TypeC PHYs, so a better way would be having ADL-S specific AUX descriptors, but I left changing this for a follow-up.
This changes the ordering of the AUX and TC-cold vs. PW_4/5 power wells on TGL and ADL-S, but this shouldn't make a difference (PW_4/5 don't depend on the AUX/TC-cold power wells).
--- .../i915/display/intel_display_power_map.c | 69 +++++++++++-------- 1 file changed, 39 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +39 -30
@@ -902,12 +902,36 @@ static const struct i915_power_well_desc tgl_power_wells_main[] = { ), .ops = &icl_ddi_power_well_ops, }, { + .instances = &I915_PW_INSTANCES( + I915_PW("PW_4", &tgl_pwdoms_pw_4, + .hsw.idx = ICL_PW_CTL_IDX_PW_4), + ), + .ops = &hsw_power_well_ops, + .has_fuses = true, + .irq_pipe_mask = BIT(PIPE_C), + }, { + .instances = &I915_PW_INSTANCES( + I915_PW("PW_5", &tgl_pwdoms_pw_5, + .hsw.idx = TGL_PW_CTL_IDX_PW_5), + ), + .ops = &hsw_power_well_ops, + .has_fuses = true, + .irq_pipe_mask = BIT(PIPE_D), + }, +}; + +static const struct i915_power_well_desc tgl_power_wells_tc_cold_off[] = { + { .instances = &I915_PW_INSTANCES( I915_PW("TC_cold_off", &tgl_pwdoms_tc_cold_off, .id = TGL_DISP_PW_TC_COLD_OFF), ), .ops = &tgl_tc_cold_off_ops, - }, { + }, +}; + +static const struct i915_power_well_desc tgl_power_wells_aux[] = { + { .instances = &I915_PW_INSTANCES( I915_PW("AUX_A", &tgl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), I915_PW("AUX_B", &tgl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B),
@@ -931,22 +955,6 @@ static const struct i915_power_well_desc tgl_power_wells_main[] = { ), .ops = &icl_aux_power_well_ops, .is_tc_tbt = true, - }, { - .instances = &I915_PW_INSTANCES( -I915_PW ("PW_4" , &tgl_pwdoms_pw_4, - .hsw.idx = ICL_PW_CTL_IDX_PW_4), - ), - .ops = &hsw_power_well_ops, - .has_fuses = true, - .irq_pipe_mask = BIT(PIPE_C), - }, { - .instances = &I915_PW_INSTANCES ( -I915_PW ("PW_5" , &tgl_pwdoms_pw_5, - .hsw.idx = TGL_PW_CTL_IDX_PW_5), - ), - .ops = &hsw_power_well_ops, - .has_fuses = true, - .irq_pipe_mask = BIT(PIPE_D), }, };
@@ -954,6 +962,15 @@ static const struct i915_power_well_desc_list tgl_power_wells[] = {I915_PW_DESCRIPTORS (i9xx_power_wells_always_on),I915_PW_DESCRIPTORS (icl_power_wells_pw_1),I915_PW_DESCRIPTORS (tgl_power_wells_main), +I915_PW_DESCRIPTORS (tgl_power_wells_tc_cold_off), + I915_PW_DESCRIPTORS(tgl_power_wells_aux), +}; + +static const struct i915_power_well_desc_list adls_power_wells[] = { +I915_PW_DESCRIPTORS (i9xx_power_wells_always_on), +I915_PW_DESCRIPTORS (icl_power_wells_pw_1), +I915_PW_DESCRIPTORS (tgl_power_wells_main), +I915_PW_DESCRIPTORS (tgl_power_wells_aux), };#define RKL_PW_4_POWER_DOMAINS \
@@ -1400,7 +1417,7 @@ static void init_power_well_domains(const struct i915_power_well_instance *inst,static int __set_power_wells (struct i915_power_domains *power_domains,const struct i915_power_well_desc_list *power_well_descs, -int power_well_descs_sz,u64 skip_mask) +int power_well_descs_sz) { struct drm_i915_private *i915 = container_of(power_domains, struct drm_i915_private,
@@ -1413,8 +1430,7 @@ __set_power_wells(struct i915_power_domains *power_domains,int plt_idx =0 ;for_each_power_well_instance (power_well_descs, power_well_descs_sz, desc_list, desc, inst) -if (!(BIT_ULL (inst->id) & skip_mask)) - power_well_count++; + power_well_count++; power_domains->power_well_count = power_well_count; power_domains->power_wells =
@@ -1428,9 +1444,6 @@ __set_power_wells(struct i915_power_domains *power_domains,struct i915_power_well *pw = &power_domains->power_wells[plt_idx];enum i915_power_well_id id = inst->id; -if (BIT_ULL (id) & skip_mask) -continue ; - pw->desc = desc;drm_WARN_ON (&i915->drm,overflows_type (inst - desc->instances->list, pw->instance_idx));
@@ -1451,12 +1464,9 @@ __set_power_wells(struct i915_power_domains *power_domains,return 0 ; } -#define set_power_wells_mask (power_domains, __power_well_descs, skip_mask) \ - __set_power_wells(power_domains, __power_well_descs, \ - ARRAY_SIZE(__power_well_descs), skip_mask) -#define set_power_wells (power_domains, __power_well_descs) \ - set_power_wells_mask(power_domains, __power_well_descs, 0) + __set_power_wells(power_domains, __power_well_descs, \ + ARRAY_SIZE(__power_well_descs))/** * intel_display_power_map_init - initialize power domain -> power well mappings
@@ -1485,8 +1495,7 @@ int intel_display_power_map_init(struct i915_power_domains *power_domains)else if (IS_DG1 (i915))return set_power_wells (power_domains, dg1_power_wells);else if (IS_ALDERLAKE_S (i915)) -return set_power_wells_mask (power_domains, tgl_power_wells, -BIT_ULL (TGL_DISP_PW_TC_COLD_OFF )); +return set_power_wells (power_domains, adls_power_wells);else if (IS_ROCKETLAKE (i915))return set_power_wells (power_domains, rkl_power_wells);else if (DISPLAY_VER (i915) ==12 )
Signature · 1 line
2.30.2
PATCH 14/18 drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform
In reply to Imre DeakAtm the port -> DDI and AUX power domain mapping is specified by relying on the aliasing of the platform specific intel_display_power_domain enum values. For instance D12+ platforms refer to the 'D' port and power domain instances, which doesn't match the bspec terminology, on these platforms the corresponding port is TC1. To make it clear what port/domain the code refers to add a mapping between them which matches the bspec terms on different display versions.
This also allows for removing the aliasing in enum values in a follow-up patch.
v2: Add the functions to intel_display_power.c, use
intel_display_power_ prefix.
--- drivers/gpu/drm/i915/display/g4x_dp.c | 3 +- drivers/gpu/drm/i915/display/g4x_hdmi.c | 3 +- drivers/gpu/drm/i915/display/intel_ddi.c | 6 +- drivers/gpu/drm/i915/display/intel_display.c | 85 +------- drivers/gpu/drm/i915/display/intel_display.h | 4 +- .../drm/i915/display/intel_display_power.c | 206 ++++++++++++++++++ .../drm/i915/display/intel_display_power.h | 12 + drivers/gpu/drm/i915/display/intel_tc.c | 5 +- 8 files changed, 235 insertions(+), 89 deletions(-)
drivers/gpu/drm/i915/display/g4x_dp.c +2 -1
@@ -13,6 +13,7 @@#include "intel_connector.h" #include "intel_crtc.h" #include "intel_de.h" +#include "intel_display_power.h" #include "intel_display_types.h" #include "intel_dp.h" #include "intel_dp_link_training.h"
@@ -1375,7 +1376,7 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv, dig_port->max_lanes =4 ; intel_encoder->type =INTEL_OUTPUT_DP ; - intel_encoder->power_domain =intel_port_to_power_domain (port); + intel_encoder->power_domain =intel_display_power_ddi_lanes_domain (dev_priv, port);if (IS_CHERRYVIEW (dev_priv)) {if (port ==PORT_D ) intel_encoder->pipe_mask =BIT (PIPE_C );
drivers/gpu/drm/i915/display/g4x_hdmi.c +2 -1
@@ -10,6 +10,7 @@#include "intel_connector.h" #include "intel_crtc.h" #include "intel_de.h" +#include "intel_display_power.h" #include "intel_display_types.h" #include "intel_dpio_phy.h" #include "intel_fifo_underrun.h"
@@ -574,7 +575,7 @@ void g4x_hdmi_init(struct drm_i915_private *dev_priv, intel_encoder->shutdown = intel_hdmi_encoder_shutdown; intel_encoder->type =INTEL_OUTPUT_HDMI ; - intel_encoder->power_domain =intel_port_to_power_domain (port); + intel_encoder->power_domain =intel_display_power_ddi_lanes_domain (dev_priv, port); intel_encoder->port = port;if (IS_CHERRYVIEW (dev_priv)) {if (port ==PORT_D )
drivers/gpu/drm/i915/display/intel_ddi.c +3 -3
@@ -40,6 +40,7 @@#include "intel_ddi.h" #include "intel_ddi_buf_trans.h" #include "intel_de.h" +#include "intel_display_power.h" #include "intel_display_types.h" #include "intel_dp.h" #include "intel_dp_link_training.h"
@@ -4364,7 +4365,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) encoder->get_power_domains = intel_ddi_get_power_domains; encoder->type =INTEL_OUTPUT_DDI ; - encoder->power_domain =intel_port_to_power_domain (port); + encoder->power_domain =intel_display_power_ddi_lanes_domain (dev_priv, port); encoder->port = port; encoder->cloneable =0 ; encoder->pipe_mask = ~0 ;
@@ -4492,8 +4493,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) }drm_WARN_ON (&dev_priv->drm, port >PORT_I ); - dig_port->ddi_io_power_domain =POWER_DOMAIN_PORT_DDI_IO_A + - port -PORT_A ; + dig_port->ddi_io_power_domain =intel_display_power_ddi_io_domain (dev_priv, port);if (init_dp) {if (!intel_ddi_init_dp_connector (dig_port))
drivers/gpu/drm/i915/display/intel_display.c +5 -80
102 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display.h +1 -3
@@ -635,11 +635,9 @@ void intel_cpu_transcoder_get_m2_n2(struct intel_crtc *crtc,void i9xx_crtc_clock_get (struct intel_crtc *crtc,struct intel_crtc_state *pipe_config);int intel_dotclock_calculate (int link_freq,const struct intel_link_m_n *m_n); -enum intel_display_power_domain intel_port_to_power_domain (enum port port); +enum intel_display_power_domain intel_port_to_power_domain (struct intel_digital_port *dig_port);enum intel_display_power_domain intel_aux_power_domain (struct intel_digital_port *dig_port); -enum intel_display_power_domain -intel_legacy_aux_to_power_domain (enum aux_ch aux_ch);void intel_crtc_arm_fifo_underrun (struct intel_crtc *crtc,struct intel_crtc_state *crtc_state);void ilk_pfit_disable (const struct intel_crtc_state *old_crtc_state);
drivers/gpu/drm/i915/display/intel_display_power.c +206 -0
209 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power.h +12 -0
@@ -8,8 +8,10 @@#include "intel_runtime_pm.h" +enum aux_ch ;enum dpio_channel ;enum dpio_phy ; +enum port ;struct drm_i915_private ;struct i915_power_well ;struct intel_encoder ;
@@ -130,6 +132,7 @@ enum intel_display_power_domain {POWER_DOMAIN_INIT ,POWER_DOMAIN_NUM , + POWER_DOMAIN_INVALID = POWER_DOMAIN_NUM, };#define POWER_DOMAIN_PIPE (pipe) ((pipe) + POWER_DOMAIN_PIPE_A)
@@ -266,6 +269,15 @@ intel_display_power_put_all_in_set(struct drm_i915_private *i915,void intel_display_power_debug (struct drm_i915_private *i915,struct seq_file *m); +enum intel_display_power_domain +intel_display_power_ddi_lanes_domain (struct drm_i915_private *i915,enum port port); +enum intel_display_power_domain +intel_display_power_ddi_io_domain (struct drm_i915_private *i915,enum port port); +enum intel_display_power_domain +intel_display_power_legacy_aux_domain (struct drm_i915_private *i915,enum aux_ch aux_ch); +enum intel_display_power_domain +intel_display_power_tbt_aux_domain (struct drm_i915_private *i915,enum aux_ch aux_ch); +/* * FIXME: We should probably switch this to a 0-based scheme to be consistent * with how we now name/number DBUF_CTL instances.
drivers/gpu/drm/i915/display/intel_tc.c +4 -1
@@ -6,6 +6,7 @@#include "i915_drv.h" #include "i915_reg.h" #include "intel_display.h" +#include "intel_display_power_map.h" #include "intel_display_types.h" #include "intel_dp_mst.h" #include "intel_tc.h"
@@ -61,10 +62,12 @@ bool intel_tc_cold_requires_aux_pw(struct intel_digital_port *dig_port)static enum intel_display_power_domain tc_cold_get_power_domain (struct intel_digital_port *dig_port,enum tc_port_mode mode) { +struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev); +if (mode ==TC_PORT_TBT_ALT || !intel_tc_cold_requires_aux_pw (dig_port))return POWER_DOMAIN_TC_COLD_OFF ; -return intel_legacy_aux_to_power_domain (dig_port->aux_ch); +return intel_display_power_legacy_aux_domain (i915, dig_port->aux_ch); } static intel_wakeref_t
Signature · 1 line
2.30.2
Jani Nikula
maintainerRe: [Intel-gfx] [CI 14/18] drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform
Quoted 391 lines · Imre Deak
Atm the port -> DDI and AUX power domain mapping is specified by relying on the aliasing of the platform specific
intel_display_power_domainenum values. For instance D12+ platforms refer to the 'D' port and power domain instances, which doesn't match the bspec terminology, on these platforms the corresponding port is TC1. To make it clear what port/domain the code refers to add a mapping between them which matches the bspec terms on different display versions.This also allows for removing the aliasing in enum values in a follow-up patch.
v2: Add the functions to
intel_display_power.c, use
intel_display_power_prefix.Signed-off-by Imre Deak <[email protected]>Reviewed-by Jouni Högander <[email protected]>--- drivers/gpu/drm/i915/display/g4x_dp.c | 3 +- drivers/gpu/drm/i915/display/g4x_hdmi.c | 3 +- drivers/gpu/drm/i915/display/intel_ddi.c | 6 +- drivers/gpu/drm/i915/display/intel_display.c | 85 +------- drivers/gpu/drm/i915/display/intel_display.h | 4 +- .../drm/i915/display/intel_display_power.c | 206 ++++++++++++++++++ .../drm/i915/display/intel_display_power.h | 12 + drivers/gpu/drm/i915/display/intel_tc.c | 5 +- 8 files changed, 235 insertions(+), 89 deletions(-)drivers/gpu/drm/i915/display/g4x_dp.c +2
-1@@ -13,6 +13,7 @@#include "intel_connector.h" #include "intel_crtc.h" #include "intel_de.h" +#include "intel_display_power.h" #include "intel_display_types.h" #include "intel_dp.h" #include "intel_dp_link_training.h" @@ -1375,7 +1376,7 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv, dig_port->max_lanes =4 ; intel_encoder->type =INTEL_OUTPUT_DP ; - intel_encoder->power_domain =intel_port_to_power_domain (port); + intel_encoder->power_domain =intel_display_power_ddi_lanes_domain (dev_priv, port);if (IS_CHERRYVIEW (dev_priv)) {if (port ==PORT_D ) intel_encoder->pipe_mask =BIT (PIPE_C );drivers/gpu/drm/i915/display/g4x_hdmi.c +2
-1@@ -10,6 +10,7 @@#include "intel_connector.h" #include "intel_crtc.h" #include "intel_de.h" +#include "intel_display_power.h" #include "intel_display_types.h" #include "intel_dpio_phy.h" #include "intel_fifo_underrun.h" @@ -574,7 +575,7 @@ void g4x_hdmi_init(struct drm_i915_private *dev_priv, intel_encoder->shutdown = intel_hdmi_encoder_shutdown; intel_encoder->type =INTEL_OUTPUT_HDMI ; - intel_encoder->power_domain =intel_port_to_power_domain (port); + intel_encoder->power_domain =intel_display_power_ddi_lanes_domain (dev_priv, port); intel_encoder->port = port;if (IS_CHERRYVIEW (dev_priv)) {if (port ==PORT_D )drivers/gpu/drm/i915/display/intel_ddi.c +3
-3@@ -40,6 +40,7 @@#include "intel_ddi.h" #include "intel_ddi_buf_trans.h" #include "intel_de.h" +#include "intel_display_power.h" #include "intel_display_types.h" #include "intel_dp.h" #include "intel_dp_link_training.h" @@ -4364,7 +4365,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) encoder->get_power_domains = intel_ddi_get_power_domains; encoder->type =INTEL_OUTPUT_DDI ; - encoder->power_domain =intel_port_to_power_domain (port); + encoder->power_domain =intel_display_power_ddi_lanes_domain (dev_priv, port); encoder->port = port; encoder->cloneable =0 ; encoder->pipe_mask = ~0 ;@@ -4492,8 +4493,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) }drm_WARN_ON (&dev_priv->drm, port >PORT_I ); - dig_port->ddi_io_power_domain =POWER_DOMAIN_PORT_DDI_IO_A + - port -PORT_A ; + dig_port->ddi_io_power_domain =intel_display_power_ddi_io_domain (dev_priv, port);if (init_dp) {if (!intel_ddi_init_dp_connector (dig_port))drivers/gpu/drm/i915/display/intel_display.c +5
-80@@ -51,6 +51,7 @@#include "display/intel_crt.h" #include "display/intel_ddi.h" #include "display/intel_display_debugfs.h" +#include "display/intel_display_power.h" #include "display/intel_dp.h" #include "display/intel_dp_mst.h" #include "display/intel_dpll.h" @@ -2157,91 +2158,15 @@ enum tc_port intel_port_to_tc(struct drm_i915_private *dev_priv, enum port port)return TC_PORT_1 + port -PORT_C ; } -enum intel_display_power_domain intel_port_to_power_domain (enum port port) -{ -switch (port) { -case PORT_A : -return POWER_DOMAIN_PORT_DDI_LANES_A ; -case PORT_B : -return POWER_DOMAIN_PORT_DDI_LANES_B ; -case PORT_C : -return POWER_DOMAIN_PORT_DDI_LANES_C ; -case PORT_D : -return POWER_DOMAIN_PORT_DDI_LANES_D ; -case PORT_E : -return POWER_DOMAIN_PORT_DDI_LANES_E ; -case PORT_F : -return POWER_DOMAIN_PORT_DDI_LANES_F ; -case PORT_G : -return POWER_DOMAIN_PORT_DDI_LANES_G ; -case PORT_H : -return POWER_DOMAIN_PORT_DDI_LANES_H ; -case PORT_I : -return POWER_DOMAIN_PORT_DDI_LANES_I ; -default : -MISSING_CASE (port); -return POWER_DOMAIN_PORT_OTHER ; - } -} -enum intel_display_power_domain intel_aux_power_domain (struct intel_digital_port *dig_port) { -if (intel_tc_port_in_tbt_alt_mode (dig_port)) { -switch (dig_port->aux_ch) { -case AUX_CH_C : -return POWER_DOMAIN_AUX_TBT_C ; -case AUX_CH_D : -return POWER_DOMAIN_AUX_TBT_D ; -case AUX_CH_E : -return POWER_DOMAIN_AUX_TBT_E ; -case AUX_CH_F : -return POWER_DOMAIN_AUX_TBT_F ; -case AUX_CH_G : -return POWER_DOMAIN_AUX_TBT_G ; -case AUX_CH_H : -return POWER_DOMAIN_AUX_TBT_H ; -case AUX_CH_I : -return POWER_DOMAIN_AUX_TBT_I ; -default : -MISSING_CASE (dig_port->aux_ch); -return POWER_DOMAIN_AUX_TBT_C ; - } - } +struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev); -return intel_legacy_aux_to_power_domain (dig_port->aux_ch); -} +if (intel_tc_port_in_tbt_alt_mode (dig_port)) +return intel_display_power_tbt_aux_domain (i915, dig_port->aux_ch); -/* -* Converts aux_ch to power_domain without caring about TBT ports for that use -* intel_aux_power_domain() -*/ -enum intel_display_power_domain -intel_legacy_aux_to_power_domain (enum aux_ch aux_ch) -{ -switch (aux_ch) { -case AUX_CH_A : -return POWER_DOMAIN_AUX_A ; -case AUX_CH_B : -return POWER_DOMAIN_AUX_B ; -case AUX_CH_C : -return POWER_DOMAIN_AUX_C ; -case AUX_CH_D : -return POWER_DOMAIN_AUX_D ; -case AUX_CH_E : -return POWER_DOMAIN_AUX_E ; -case AUX_CH_F : -return POWER_DOMAIN_AUX_F ; -case AUX_CH_G : -return POWER_DOMAIN_AUX_G ; -case AUX_CH_H : -return POWER_DOMAIN_AUX_H ; -case AUX_CH_I : -return POWER_DOMAIN_AUX_I ; -default : -MISSING_CASE (aux_ch); -return POWER_DOMAIN_AUX_A ; - } +return intel_display_power_legacy_aux_domain (i915, dig_port->aux_ch); } static void get_crtc_power_domains(struct intel_crtc_state *crtc_state,drivers/gpu/drm/i915/display/intel_display.h +1
-3@@ -635,11 +635,9 @@ void intel_cpu_transcoder_get_m2_n2(struct intel_crtc *crtc,void i9xx_crtc_clock_get (struct intel_crtc *crtc,struct intel_crtc_state *pipe_config);int intel_dotclock_calculate (int link_freq,const struct intel_link_m_n *m_n); -enum intel_display_power_domain intel_port_to_power_domain (enum port port); +enum intel_display_power_domain intel_port_to_power_domain (struct intel_digital_port *dig_port);enum intel_display_power_domain intel_aux_power_domain (struct intel_digital_port *dig_port); -enum intel_display_power_domain -intel_legacy_aux_to_power_domain (enum aux_ch aux_ch);void intel_crtc_arm_fifo_underrun (struct intel_crtc *crtc,struct intel_crtc_state *crtc_state);void ilk_pfit_disable (const struct intel_crtc_state *old_crtc_state);drivers/gpu/drm/i915/display/intel_display_power.c +158
-0@@ -2256,3 +2256,209 @@ void intel_display_power_debug(struct drm_i915_private *i915, struct seq_file *mmutex_unlock (&power_domains->lock); } + +struct intel_ddi_port_domains { +enum port port_start; +enum port port_end; +enum aux_ch aux_ch_start; +enum aux_ch aux_ch_end; + +enum intel_display_power_domain ddi_lanes; +enum intel_display_power_domain ddi_io; +enum intel_display_power_domain aux_legacy_usbc; +enum intel_display_power_domain aux_tbt; +}; + +static const struct intel_ddi_port_domains +i9xx_port_domains[] = { + { + .port_start =PORT_A , + .port_end =PORT_F , + .aux_ch_start =AUX_CH_A , + .aux_ch_end =AUX_CH_F , + + .ddi_lanes =POWER_DOMAIN_PORT_DDI_LANES_A , + .ddi_io =POWER_DOMAIN_PORT_DDI_IO_A , + .aux_legacy_usbc =POWER_DOMAIN_AUX_A , + .aux_tbt =POWER_DOMAIN_INVALID , + }, +}; + +static const struct intel_ddi_port_domains +d11_port_domains[] = { + { + .port_start =PORT_A , + .port_end =PORT_B , + .aux_ch_start =AUX_CH_A , + .aux_ch_end =AUX_CH_B , + + .ddi_lanes =POWER_DOMAIN_PORT_DDI_LANES_A , + .ddi_io =POWER_DOMAIN_PORT_DDI_IO_A , + .aux_legacy_usbc =POWER_DOMAIN_AUX_A , + .aux_tbt =POWER_DOMAIN_INVALID , + }, { + .port_start =PORT_C , + .port_end =PORT_F , + .aux_ch_start =AUX_CH_C , + .aux_ch_end =AUX_CH_F , + + .ddi_lanes =POWER_DOMAIN_PORT_DDI_LANES_C , + .ddi_io =POWER_DOMAIN_PORT_DDI_IO_C , + .aux_legacy_usbc =POWER_DOMAIN_AUX_C , + .aux_tbt =POWER_DOMAIN_AUX_TBT_C , + }, +}; + +static const struct intel_ddi_port_domains +d12_port_domains[] = { + { + .port_start =PORT_A , + .port_end =PORT_C , + .aux_ch_start =AUX_CH_A , + .aux_ch_end =AUX_CH_C , + + .ddi_lanes =POWER_DOMAIN_PORT_DDI_LANES_A , + .ddi_io =POWER_DOMAIN_PORT_DDI_IO_A , + .aux_legacy_usbc =POWER_DOMAIN_AUX_A , + .aux_tbt =POWER_DOMAIN_INVALID , + }, { + .port_start =PORT_TC1 , + .port_end =PORT_TC6 , + .aux_ch_start =AUX_CH_USBC1 , + .aux_ch_end =AUX_CH_USBC6 , + + .ddi_lanes =POWER_DOMAIN_PORT_DDI_LANES_TC1 , + .ddi_io =POWER_DOMAIN_PORT_DDI_IO_TC1 , + .aux_legacy_usbc =POWER_DOMAIN_AUX_USBC1 , + .aux_tbt =POWER_DOMAIN_AUX_TBT1 , + }, +}; + +static const struct intel_ddi_port_domains +d13_port_domains[] = { + { + .port_start =PORT_A , + .port_end =PORT_C , + .aux_ch_start =AUX_CH_A , + .aux_ch_end =AUX_CH_C , + + .ddi_lanes =POWER_DOMAIN_PORT_DDI_LANES_A , + .ddi_io =POWER_DOMAIN_PORT_DDI_IO_A , + .aux_legacy_usbc =POWER_DOMAIN_AUX_A , + .aux_tbt =POWER_DOMAIN_INVALID , + }, { + .port_start =PORT_TC1 , + .port_end =PORT_TC4 , + .aux_ch_start =AUX_CH_USBC1 , + .aux_ch_end =AUX_CH_USBC4 , + + .ddi_lanes =POWER_DOMAIN_PORT_DDI_LANES_TC1 , + .ddi_io =POWER_DOMAIN_PORT_DDI_IO_TC1 , + .aux_legacy_usbc =POWER_DOMAIN_AUX_USBC1 , + .aux_tbt =POWER_DOMAIN_AUX_TBT1 , + }, { + .port_start =PORT_D_XELPD , + .port_end =PORT_E_XELPD , + .aux_ch_start =AUX_CH_D_XELPD , + .aux_ch_end =AUX_CH_E_XELPD , + + .ddi_lanes =POWER_DOMAIN_PORT_DDI_LANES_D_XELPD , + .ddi_io =POWER_DOMAIN_PORT_DDI_IO_D_XELPD , + .aux_legacy_usbc =POWER_DOMAIN_AUX_D_XELPD , + .aux_tbt =POWER_DOMAIN_INVALID , + }, +}; + +static void +intel_port_domains_for_platform (struct drm_i915_private *i915, +const struct intel_ddi_port_domains **domains, +int *domains_size) +{ +if (DISPLAY_VER (i915) >=13 ) { + *domains = d13_port_domains; + *domains_size =ARRAY_SIZE (d13_port_domains); + }else if (DISPLAY_VER (i915) >=12 ) { + *domains = d12_port_domains; + *domains_size =ARRAY_SIZE (d12_port_domains); + }else if (DISPLAY_VER (i915) >=11 ) { + *domains = d11_port_domains; + *domains_size =ARRAY_SIZE (d11_port_domains); + }else { + *domains = i9xx_port_domains; + *domains_size =ARRAY_SIZE (i9xx_port_domains); + } +} + +static const struct intel_ddi_port_domains * +intel_port_domains_for_port (struct drm_i915_private *i915,enum port port) +{ +const struct intel_ddi_port_domains *domains; +int domains_size; +int i; + +intel_port_domains_for_platform (i915, &domains, &domains_size); +for (i =0 ; i < domains_size; i++) +if (port >= domains[i].port_start && port <= domains[i].port_end) +return &domains[i]; + +return NULL ; +} + +enum intel_display_power_domain +intel_display_power_ddi_io_domain (struct drm_i915_private *i915,enum port port) +{ +const struct intel_ddi_port_domains *domains =intel_port_domains_for_port (i915, port); + +if (drm_WARN_ON (&i915->drm, !domains) || domains->ddi_io ==POWER_DOMAIN_INVALID ) +return POWER_DOMAIN_PORT_DDI_IO_A ; + +return domains->ddi_io + port - domains->port_start; +}
drivers/gpu/drm/i915/display/intel_display_power.c void intel_display_power_debug(struct drm_i915_private *i915, struct seq_file *m · line 2426
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_power.c +10
-0+ +enum intel_display_power_domain +intel_display_power_ddi_lanes_domain (struct drm_i915_private *i915,enum port port) +{ +const struct intel_ddi_port_domains *domains =intel_port_domains_for_port (i915, port); + +if (drm_WARN_ON (&i915->drm, !domains) || domains->ddi_lanes ==POWER_DOMAIN_INVALID ) +return POWER_DOMAIN_PORT_DDI_LANES_A ; + +return domains->ddi_lanes + port - domains->port_start;
The above two functions lead to some sparse warnings:
drivers/gpu/drm/i915/display/intel_display_power.c:2431:34: warning: mixing different enum types:drivers/gpu/drm/i915/display/intel_display_power.c:2431:34: unsigned int enum intel_display_power_domaindrivers/gpu/drm/i915/display/intel_display_power.c:2431:34: int enum portdrivers/gpu/drm/i915/display/intel_display_power.c:2442:37: warning: mixing different enum types:drivers/gpu/drm/i915/display/intel_display_power.c:2442:37: unsigned int enum intel_display_power_domaindrivers/gpu/drm/i915/display/intel_display_power.c:2442:37: int enum portdrivers/gpu/drm/i915/display/intel_display_power.c:2468:43: warning: mixing different enum types:drivers/gpu/drm/i915/display/intel_display_power.c:2468:43: unsigned int enum intel_display_power_domaindrivers/gpu/drm/i915/display/intel_display_power.c:2468:43: unsigned int enum aux_chdrivers/gpu/drm/i915/display/intel_display_power.c:2479:35: warning: mixing different enum types:drivers/gpu/drm/i915/display/intel_display_power.c:2479:35: unsigned int enum intel_display_power_domaindrivers/gpu/drm/i915/display/intel_display_power.c:2479:35: unsigned int enum aux_ch
BR,
Jani.
Quoted 103 lines
drivers/gpu/drm/i915/display/intel_display_power.c +38
-0+} + +static const struct intel_ddi_port_domains * +intel_port_domains_for_aux_ch (struct drm_i915_private *i915,enum aux_ch aux_ch) +{ +const struct intel_ddi_port_domains *domains; +int domains_size; +int i; + +intel_port_domains_for_platform (i915, &domains, &domains_size); +for (i =0 ; i < domains_size; i++) +if (aux_ch >= domains[i].aux_ch_start && aux_ch <= domains[i].aux_ch_end) +return &domains[i]; + +return NULL ; +} + +enum intel_display_power_domain +intel_display_power_legacy_aux_domain (struct drm_i915_private *i915,enum aux_ch aux_ch) +{ +const struct intel_ddi_port_domains *domains =intel_port_domains_for_aux_ch (i915, aux_ch); + +if (drm_WARN_ON (&i915->drm, !domains) || domains->aux_legacy_usbc ==POWER_DOMAIN_INVALID ) +return POWER_DOMAIN_AUX_A ; + +return domains->aux_legacy_usbc + aux_ch - domains->aux_ch_start; +} + +enum intel_display_power_domain +intel_display_power_tbt_aux_domain (struct drm_i915_private *i915,enum aux_ch aux_ch) +{ +const struct intel_ddi_port_domains *domains =intel_port_domains_for_aux_ch (i915, aux_ch); + +if (drm_WARN_ON (&i915->drm, !domains) || domains->aux_tbt ==POWER_DOMAIN_INVALID ) +return POWER_DOMAIN_AUX_TBT1 ; + +return domains->aux_tbt + aux_ch - domains->aux_ch_start; +}drivers/gpu/drm/i915/display/intel_display_power.h +12
-0@@ -8,8 +8,10 @@#include "intel_runtime_pm.h" +enum aux_ch ;enum dpio_channel ;enum dpio_phy ; +enum port ;struct drm_i915_private ;struct i915_power_well ;struct intel_encoder ;@@ -130,6 +132,7 @@ enum intel_display_power_domain {POWER_DOMAIN_INIT ,POWER_DOMAIN_NUM , + POWER_DOMAIN_INVALID = POWER_DOMAIN_NUM, };#define POWER_DOMAIN_PIPE (pipe) ((pipe) + POWER_DOMAIN_PIPE_A)@@ -266,6 +269,15 @@ intel_display_power_put_all_in_set(struct drm_i915_private *i915,void intel_display_power_debug (struct drm_i915_private *i915,struct seq_file *m); +enum intel_display_power_domain +intel_display_power_ddi_lanes_domain (struct drm_i915_private *i915,enum port port); +enum intel_display_power_domain +intel_display_power_ddi_io_domain (struct drm_i915_private *i915,enum port port); +enum intel_display_power_domain +intel_display_power_legacy_aux_domain (struct drm_i915_private *i915,enum aux_ch aux_ch); +enum intel_display_power_domain +intel_display_power_tbt_aux_domain (struct drm_i915_private *i915,enum aux_ch aux_ch); +/* * FIXME: We should probably switch this to a 0-based scheme to be consistent * with how we now name/number DBUF_CTL instances. drivers/gpu/drm/i915/display/intel_tc.c +4
-1@@ -6,6 +6,7 @@#include "i915_drv.h" #include "i915_reg.h" #include "intel_display.h" +#include "intel_display_power_map.h" #include "intel_display_types.h" #include "intel_dp_mst.h" #include "intel_tc.h" @@ -61,10 +62,12 @@ bool intel_tc_cold_requires_aux_pw(struct intel_digital_port *dig_port)static enum intel_display_power_domain tc_cold_get_power_domain (struct intel_digital_port *dig_port,enum tc_port_mode mode) { +struct drm_i915_private *i915 =to_i915 (dig_port->base.base.dev); +if (mode ==TC_PORT_TBT_ALT || !intel_tc_cold_requires_aux_pw (dig_port))return POWER_DOMAIN_TC_COLD_OFF ; -return intel_legacy_aux_to_power_domain (dig_port->aux_ch); +return intel_display_power_legacy_aux_domain (i915, dig_port->aux_ch); } static intel_wakeref_t
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
PATCH 15/18 drm/i915: Remove the aliasing of power domain enum values
In reply to Imre DeakAliasing the intel_display_power_domain enum values was required because of the u64 power domain mask size limit. This makes the dmesg/debugfs printouts of the domain names somewhat unclear, for instance domain names for port D are shown on D12+ platforms where the corresponding port is called TC1. Make this clearer by removing the aliasing which is possible after a previous patch converting the mask to a bitmap.
--- .../drm/i915/display/intel_display_power.c | 84 +++++++++++++------ .../drm/i915/display/intel_display_power.h | 26 ++---- 2 files changed, 67 insertions(+), 43 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +60 -24
@@ -80,12 +80,22 @@ intel_display_power_domain_str(enum intel_display_power_domain domain)return "PORT_DDI_LANES_E" ;case POWER_DOMAIN_PORT_DDI_LANES_F :return "PORT_DDI_LANES_F" ; -case POWER_DOMAIN_PORT_DDI_LANES_G : -return "PORT_DDI_LANES_G" ; -case POWER_DOMAIN_PORT_DDI_LANES_H : -return "PORT_DDI_LANES_H" ; -case POWER_DOMAIN_PORT_DDI_LANES_I : -return "PORT_DDI_LANES_I" ; +case POWER_DOMAIN_PORT_DDI_LANES_TC1 : +return "PORT_DDI_LANES_TC1" ; +case POWER_DOMAIN_PORT_DDI_LANES_TC2 : +return "PORT_DDI_LANES_TC2" ; +case POWER_DOMAIN_PORT_DDI_LANES_TC3 : +return "PORT_DDI_LANES_TC3" ; +case POWER_DOMAIN_PORT_DDI_LANES_TC4 : +return "PORT_DDI_LANES_TC4" ; +case POWER_DOMAIN_PORT_DDI_LANES_TC5 : +return "PORT_DDI_LANES_TC5" ; +case POWER_DOMAIN_PORT_DDI_LANES_TC6 : +return "PORT_DDI_LANES_TC6" ; +case POWER_DOMAIN_PORT_DDI_LANES_D_XELPD : +return "PORT_DDI_LANES_D_XELPD" ; +case POWER_DOMAIN_PORT_DDI_LANES_E_XELPD : +return "PORT_DDI_LANES_E_XELPD" ;case POWER_DOMAIN_PORT_DDI_IO_A :return "PORT_DDI_IO_A" ;case POWER_DOMAIN_PORT_DDI_IO_B :
@@ -98,12 +108,22 @@ intel_display_power_domain_str(enum intel_display_power_domain domain)return "PORT_DDI_IO_E" ;case POWER_DOMAIN_PORT_DDI_IO_F :return "PORT_DDI_IO_F" ; -case POWER_DOMAIN_PORT_DDI_IO_G : -return "PORT_DDI_IO_G" ; -case POWER_DOMAIN_PORT_DDI_IO_H : -return "PORT_DDI_IO_H" ; -case POWER_DOMAIN_PORT_DDI_IO_I : -return "PORT_DDI_IO_I" ; +case POWER_DOMAIN_PORT_DDI_IO_TC1 : +return "PORT_DDI_IO_TC1" ; +case POWER_DOMAIN_PORT_DDI_IO_TC2 : +return "PORT_DDI_IO_TC2" ; +case POWER_DOMAIN_PORT_DDI_IO_TC3 : +return "PORT_DDI_IO_TC3" ; +case POWER_DOMAIN_PORT_DDI_IO_TC4 : +return "PORT_DDI_IO_TC4" ; +case POWER_DOMAIN_PORT_DDI_IO_TC5 : +return "PORT_DDI_IO_TC5" ; +case POWER_DOMAIN_PORT_DDI_IO_TC6 : +return "PORT_DDI_IO_TC6" ; +case POWER_DOMAIN_PORT_DDI_IO_D_XELPD : +return "PORT_DDI_IO_D_XELPD" ; +case POWER_DOMAIN_PORT_DDI_IO_E_XELPD : +return "PORT_DDI_IO_E_XELPD" ;case POWER_DOMAIN_PORT_DSI :return "PORT_DSI" ;case POWER_DOMAIN_PORT_CRT :
@@ -128,12 +148,22 @@ intel_display_power_domain_str(enum intel_display_power_domain domain)return "AUX_E" ;case POWER_DOMAIN_AUX_F :return "AUX_F" ; -case POWER_DOMAIN_AUX_G : -return "AUX_G" ; -case POWER_DOMAIN_AUX_H : -return "AUX_H" ; -case POWER_DOMAIN_AUX_I : -return "AUX_I" ; +case POWER_DOMAIN_AUX_USBC1 : +return "AUX_USBC1" ; +case POWER_DOMAIN_AUX_USBC2 : +return "AUX_USBC2" ; +case POWER_DOMAIN_AUX_USBC3 : +return "AUX_USBC3" ; +case POWER_DOMAIN_AUX_USBC4 : +return "AUX_USBC4" ; +case POWER_DOMAIN_AUX_USBC5 : +return "AUX_USBC5" ; +case POWER_DOMAIN_AUX_USBC6 : +return "AUX_USBC6" ; +case POWER_DOMAIN_AUX_D_XELPD : +return "AUX_D_XELPD" ; +case POWER_DOMAIN_AUX_E_XELPD : +return "AUX_E_XELPD" ;case POWER_DOMAIN_AUX_IO_A :return "AUX_IO_A" ;case POWER_DOMAIN_AUX_TBT_C :
@@ -144,12 +174,18 @@ intel_display_power_domain_str(enum intel_display_power_domain domain)return "AUX_TBT_E" ;case POWER_DOMAIN_AUX_TBT_F :return "AUX_TBT_F" ; -case POWER_DOMAIN_AUX_TBT_G : -return "AUX_TBT_G" ; -case POWER_DOMAIN_AUX_TBT_H : -return "AUX_TBT_H" ; -case POWER_DOMAIN_AUX_TBT_I : -return "AUX_TBT_I" ; +case POWER_DOMAIN_AUX_TBT1 : +return "AUX_TBT1" ; +case POWER_DOMAIN_AUX_TBT2 : +return "AUX_TBT2" ; +case POWER_DOMAIN_AUX_TBT3 : +return "AUX_TBT3" ; +case POWER_DOMAIN_AUX_TBT4 : +return "AUX_TBT4" ; +case POWER_DOMAIN_AUX_TBT5 : +return "AUX_TBT5" ; +case POWER_DOMAIN_AUX_TBT6 : +return "AUX_TBT6" ;case POWER_DOMAIN_GMBUS :return "GMBUS" ;case POWER_DOMAIN_INIT :
drivers/gpu/drm/i915/display/intel_display_power.h +7 -19
@@ -48,18 +48,15 @@ enum intel_display_power_domain {POWER_DOMAIN_PORT_DDI_LANES_D ,POWER_DOMAIN_PORT_DDI_LANES_E ,POWER_DOMAIN_PORT_DDI_LANES_F , -POWER_DOMAIN_PORT_DDI_LANES_G , -POWER_DOMAIN_PORT_DDI_LANES_H , -POWER_DOMAIN_PORT_DDI_LANES_I , -POWER_DOMAIN_PORT_DDI_LANES_TC1 =POWER_DOMAIN_PORT_DDI_LANES_D ,/* tgl+ */ +POWER_DOMAIN_PORT_DDI_LANES_TC1 ,POWER_DOMAIN_PORT_DDI_LANES_TC2 ,POWER_DOMAIN_PORT_DDI_LANES_TC3 ,POWER_DOMAIN_PORT_DDI_LANES_TC4 ,POWER_DOMAIN_PORT_DDI_LANES_TC5 ,POWER_DOMAIN_PORT_DDI_LANES_TC6 , -POWER_DOMAIN_PORT_DDI_LANES_D_XELPD =POWER_DOMAIN_PORT_DDI_LANES_TC5 ,/* XELPD */ +POWER_DOMAIN_PORT_DDI_LANES_D_XELPD ,POWER_DOMAIN_PORT_DDI_LANES_E_XELPD , POWER_DOMAIN_PORT_DDI_IO_A,
@@ -68,18 +65,15 @@ enum intel_display_power_domain {POWER_DOMAIN_PORT_DDI_IO_D ,POWER_DOMAIN_PORT_DDI_IO_E ,POWER_DOMAIN_PORT_DDI_IO_F , -POWER_DOMAIN_PORT_DDI_IO_G , -POWER_DOMAIN_PORT_DDI_IO_H , -POWER_DOMAIN_PORT_DDI_IO_I , -POWER_DOMAIN_PORT_DDI_IO_TC1 =POWER_DOMAIN_PORT_DDI_IO_D ,/* tgl+ */ +POWER_DOMAIN_PORT_DDI_IO_TC1 ,POWER_DOMAIN_PORT_DDI_IO_TC2 ,POWER_DOMAIN_PORT_DDI_IO_TC3 ,POWER_DOMAIN_PORT_DDI_IO_TC4 ,POWER_DOMAIN_PORT_DDI_IO_TC5 ,POWER_DOMAIN_PORT_DDI_IO_TC6 , -POWER_DOMAIN_PORT_DDI_IO_D_XELPD =POWER_DOMAIN_PORT_DDI_IO_TC5 ,/* XELPD */ +POWER_DOMAIN_PORT_DDI_IO_D_XELPD ,POWER_DOMAIN_PORT_DDI_IO_E_XELPD , POWER_DOMAIN_PORT_DSI,
@@ -94,18 +88,15 @@ enum intel_display_power_domain {POWER_DOMAIN_AUX_D ,POWER_DOMAIN_AUX_E ,POWER_DOMAIN_AUX_F , -POWER_DOMAIN_AUX_G , -POWER_DOMAIN_AUX_H , -POWER_DOMAIN_AUX_I , -POWER_DOMAIN_AUX_USBC1 =POWER_DOMAIN_AUX_D ,/* tgl+ */ +POWER_DOMAIN_AUX_USBC1 ,POWER_DOMAIN_AUX_USBC2 ,POWER_DOMAIN_AUX_USBC3 ,POWER_DOMAIN_AUX_USBC4 ,POWER_DOMAIN_AUX_USBC5 ,POWER_DOMAIN_AUX_USBC6 , -POWER_DOMAIN_AUX_D_XELPD =POWER_DOMAIN_AUX_USBC5 ,/* XELPD */ +POWER_DOMAIN_AUX_D_XELPD ,POWER_DOMAIN_AUX_E_XELPD , POWER_DOMAIN_AUX_IO_A,
@@ -113,11 +104,8 @@ enum intel_display_power_domain {POWER_DOMAIN_AUX_TBT_D ,POWER_DOMAIN_AUX_TBT_E ,POWER_DOMAIN_AUX_TBT_F , -POWER_DOMAIN_AUX_TBT_G , -POWER_DOMAIN_AUX_TBT_H , -POWER_DOMAIN_AUX_TBT_I , -POWER_DOMAIN_AUX_TBT1 =POWER_DOMAIN_AUX_TBT_D ,/* tgl+ */ +POWER_DOMAIN_AUX_TBT1 ,POWER_DOMAIN_AUX_TBT2 ,POWER_DOMAIN_AUX_TBT3 , POWER_DOMAIN_AUX_TBT4,
Signature · 1 line
2.30.2
PATCH 16/18 drm/i915: Remove the ICL specific TBT power domains
In reply to Imre DeakThe spec calls the ICL TBT AUX power well instances TBT1-4 (similarly to all later platforms), align the power domain names with the spec.
--- .../gpu/drm/i915/display/intel_display_power.c | 10 +--------- .../gpu/drm/i915/display/intel_display_power.h | 4 ---- .../drm/i915/display/intel_display_power_map.c | 16 ++++++++-------- 3 files changed, 9 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +1 -9
@@ -166,14 +166,6 @@ intel_display_power_domain_str(enum intel_display_power_domain domain)return "AUX_E_XELPD" ;case POWER_DOMAIN_AUX_IO_A :return "AUX_IO_A" ; -case POWER_DOMAIN_AUX_TBT_C : -return "AUX_TBT_C" ; -case POWER_DOMAIN_AUX_TBT_D : -return "AUX_TBT_D" ; -case POWER_DOMAIN_AUX_TBT_E : -return "AUX_TBT_E" ; -case POWER_DOMAIN_AUX_TBT_F : -return "AUX_TBT_F" ;case POWER_DOMAIN_AUX_TBT1 :return "AUX_TBT1" ;case POWER_DOMAIN_AUX_TBT2 :
@@ -2341,7 +2333,7 @@ d11_port_domains[] = { .ddi_lanes = POWER_DOMAIN_PORT_DDI_LANES_C, .ddi_io = POWER_DOMAIN_PORT_DDI_IO_C, .aux_legacy_usbc = POWER_DOMAIN_AUX_C, - .aux_tbt = POWER_DOMAIN_AUX_TBT_C, + .aux_tbt = POWER_DOMAIN_AUX_TBT1, }, };
drivers/gpu/drm/i915/display/intel_display_power.h +0 -4
@@ -100,10 +100,6 @@ enum intel_display_power_domain {POWER_DOMAIN_AUX_E_XELPD ,POWER_DOMAIN_AUX_IO_A , -POWER_DOMAIN_AUX_TBT_C , -POWER_DOMAIN_AUX_TBT_D , -POWER_DOMAIN_AUX_TBT_E , -POWER_DOMAIN_AUX_TBT_F ,POWER_DOMAIN_AUX_TBT1 , POWER_DOMAIN_AUX_TBT2,
drivers/gpu/drm/i915/display/intel_display_power_map.c +8 -8
@@ -622,10 +622,10 @@ I915_DECL_PW_DOMAINS(icl_pwdoms_pw_4,POWER_DOMAIN_AUX_D , \POWER_DOMAIN_AUX_E , \POWER_DOMAIN_AUX_F , \ -POWER_DOMAIN_AUX_TBT_C , \ -POWER_DOMAIN_AUX_TBT_D , \ -POWER_DOMAIN_AUX_TBT_E , \ - POWER_DOMAIN_AUX_TBT_F +POWER_DOMAIN_AUX_TBT1 , \ +POWER_DOMAIN_AUX_TBT2 , \ +POWER_DOMAIN_AUX_TBT3 , \ + POWER_DOMAIN_AUX_TBT4 I915_DECL_PW_DOMAINS(icl_pwdoms_pw_3, ICL_PW_3_POWER_DOMAINS,
@@ -668,10 +668,10 @@ I915_DECL_PW_DOMAINS(icl_pwdoms_aux_c, POWER_DOMAIN_AUX_C);I915_DECL_PW_DOMAINS (icl_pwdoms_aux_d,POWER_DOMAIN_AUX_D );I915_DECL_PW_DOMAINS (icl_pwdoms_aux_e,POWER_DOMAIN_AUX_E );I915_DECL_PW_DOMAINS (icl_pwdoms_aux_f,POWER_DOMAIN_AUX_F ); -I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt1,POWER_DOMAIN_AUX_TBT_C ); -I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt2,POWER_DOMAIN_AUX_TBT_D ); -I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt3,POWER_DOMAIN_AUX_TBT_E ); -I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt4,POWER_DOMAIN_AUX_TBT_F ); +I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt1,POWER_DOMAIN_AUX_TBT1 ); +I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt2,POWER_DOMAIN_AUX_TBT2 ); +I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt3,POWER_DOMAIN_AUX_TBT3 ); +I915_DECL_PW_DOMAINS (icl_pwdoms_aux_tbt4,POWER_DOMAIN_AUX_TBT4 );static const struct i915_power_well_desc icl_power_wells_pw_1[] = { {
Signature · 1 line
2.30.2
PATCH 17/18 drm/i915: Remove duplicate DDI/AUX power domain mappings
In reply to Imre DeakThe DDI and AUX domain -> power well mappings are identical for a few platforms/power well instances, reuse the mappings of earlier platforms for these removing the duplicate mapping of new platforms.
--- .../i915/display/intel_display_power_map.c | 89 +++++++------------ 1 file changed, 31 insertions(+), 58 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_map.c +31 -58
@@ -653,9 +653,6 @@ I915_DECL_PW_DOMAINS(icl_pwdoms_dc_off,POWER_DOMAIN_DC_OFF , POWER_DOMAIN_INIT); -I915_DECL_PW_DOMAINS (icl_pwdoms_ddi_io_a,POWER_DOMAIN_PORT_DDI_IO_A ); -I915_DECL_PW_DOMAINS (icl_pwdoms_ddi_io_b,POWER_DOMAIN_PORT_DDI_IO_B ); -I915_DECL_PW_DOMAINS (icl_pwdoms_ddi_io_c,POWER_DOMAIN_PORT_DDI_IO_C );I915_DECL_PW_DOMAINS (icl_pwdoms_ddi_io_d,POWER_DOMAIN_PORT_DDI_IO_D );I915_DECL_PW_DOMAINS (icl_pwdoms_ddi_io_e,POWER_DOMAIN_PORT_DDI_IO_E );I915_DECL_PW_DOMAINS (icl_pwdoms_ddi_io_f,POWER_DOMAIN_PORT_DDI_IO_F );
@@ -714,9 +711,9 @@ static const struct i915_power_well_desc icl_power_wells_main[] = { .has_fuses = true, }, { .instances = &I915_PW_INSTANCES( - I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), - I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), - I915_PW("DDI_IO_C", &icl_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), + I915_PW("DDI_IO_A", &glk_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &glk_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_C", &glk_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), I915_PW("DDI_IO_D", &icl_pwdoms_ddi_io_d, .hsw.idx = ICL_PW_CTL_IDX_DDI_D), I915_PW("DDI_IO_E", &icl_pwdoms_ddi_io_e, .hsw.idx = ICL_PW_CTL_IDX_DDI_E), I915_PW("DDI_IO_F", &icl_pwdoms_ddi_io_f, .hsw.idx = ICL_PW_CTL_IDX_DDI_F),
@@ -828,12 +825,6 @@ I915_DECL_PW_DOMAINS(tgl_pwdoms_ddi_io_tc4, POWER_DOMAIN_PORT_DDI_IO_TC4);I915_DECL_PW_DOMAINS (tgl_pwdoms_ddi_io_tc5,POWER_DOMAIN_PORT_DDI_IO_TC5 );I915_DECL_PW_DOMAINS (tgl_pwdoms_ddi_io_tc6,POWER_DOMAIN_PORT_DDI_IO_TC6 ); -I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_a, -POWER_DOMAIN_AUX_A , -POWER_DOMAIN_AUX_IO_A ); -I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_b,POWER_DOMAIN_AUX_B ); -I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_c,POWER_DOMAIN_AUX_C ); -I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_usbc1,POWER_DOMAIN_AUX_USBC1 );I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_usbc2,POWER_DOMAIN_AUX_USBC2 );I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_usbc3,POWER_DOMAIN_AUX_USBC3 );
@@ -841,10 +832,6 @@ I915_DECL_PW_DOMAINS(tgl_pwdoms_aux_usbc4, POWER_DOMAIN_AUX_USBC4);I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_usbc5,POWER_DOMAIN_AUX_USBC5 );I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_usbc6,POWER_DOMAIN_AUX_USBC6 ); -I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_tbt1,POWER_DOMAIN_AUX_TBT1 ); -I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_tbt2,POWER_DOMAIN_AUX_TBT2 ); -I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_tbt3,POWER_DOMAIN_AUX_TBT3 ); -I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_tbt4,POWER_DOMAIN_AUX_TBT4 );I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_tbt5,POWER_DOMAIN_AUX_TBT5 );I915_DECL_PW_DOMAINS (tgl_pwdoms_aux_tbt6,POWER_DOMAIN_AUX_TBT6 );
@@ -890,9 +877,9 @@ static const struct i915_power_well_desc tgl_power_wells_main[] = { .has_fuses = true, }, { .instances = &I915_PW_INSTANCES( - I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), - I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), - I915_PW("DDI_IO_C", &icl_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), + I915_PW("DDI_IO_A", &glk_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &glk_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_C", &glk_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), I915_PW("DDI_IO_TC3", &tgl_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3),
@@ -933,9 +920,9 @@ static const struct i915_power_well_desc tgl_power_wells_tc_cold_off[] = {static const struct i915_power_well_desc tgl_power_wells_aux[] = { { .instances = &I915_PW_INSTANCES( - I915_PW("AUX_A", &tgl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), - I915_PW("AUX_B", &tgl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), - I915_PW("AUX_C", &tgl_pwdoms_aux_c, .hsw.idx = ICL_PW_CTL_IDX_AUX_C), + I915_PW("AUX_A", &icl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), + I915_PW("AUX_B", &icl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), + I915_PW("AUX_C", &icl_pwdoms_aux_c, .hsw.idx = ICL_PW_CTL_IDX_AUX_C), I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1), I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2), I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
@@ -946,10 +933,10 @@ static const struct i915_power_well_desc tgl_power_wells_aux[] = { .ops = &icl_aux_power_well_ops, }, { .instances = &I915_PW_INSTANCES( - I915_PW("AUX_TBT1", &tgl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1), - I915_PW("AUX_TBT2", &tgl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2), - I915_PW("AUX_TBT3", &tgl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3), - I915_PW("AUX_TBT4", &tgl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4), + I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1), + I915_PW("AUX_TBT2", &icl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2), + I915_PW("AUX_TBT3", &icl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3), + I915_PW("AUX_TBT4", &icl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4), I915_PW("AUX_TBT5", &tgl_pwdoms_aux_tbt5, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT5), I915_PW("AUX_TBT6", &tgl_pwdoms_aux_tbt6, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT6), ),
@@ -1058,8 +1045,8 @@ static const struct i915_power_well_desc rkl_power_wells_main[] = {static const struct i915_power_well_desc rkl_power_wells_ddi_aux[] = { { .instances = &I915_PW_INSTANCES ( - I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), - I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_A", &glk_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &glk_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), ),
@@ -1273,22 +1260,8 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_dc_off,I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_d_xelpd,POWER_DOMAIN_AUX_D_XELPD );I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_e_xelpd,POWER_DOMAIN_AUX_E_XELPD ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_usbc1,POWER_DOMAIN_AUX_USBC1 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_usbc2,POWER_DOMAIN_AUX_USBC2 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_usbc3,POWER_DOMAIN_AUX_USBC3 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_usbc4,POWER_DOMAIN_AUX_USBC4 ); - -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_tbt1,POWER_DOMAIN_AUX_TBT1 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_tbt2,POWER_DOMAIN_AUX_TBT2 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_tbt3,POWER_DOMAIN_AUX_TBT3 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_tbt4,POWER_DOMAIN_AUX_TBT4 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_d_xelpd,POWER_DOMAIN_PORT_DDI_IO_D_XELPD );I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_e_xelpd,POWER_DOMAIN_PORT_DDI_IO_E_XELPD ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_tc1,POWER_DOMAIN_PORT_DDI_IO_TC1 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_tc2,POWER_DOMAIN_PORT_DDI_IO_TC2 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_tc3,POWER_DOMAIN_PORT_DDI_IO_TC3 ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_tc4,POWER_DOMAIN_PORT_DDI_IO_TC4 );static const struct i915_power_well_desc xelpd_power_wells_main[] = { {
@@ -1340,37 +1313,37 @@ static const struct i915_power_well_desc xelpd_power_wells_main[] = { .has_fuses = true, }, { .instances = &I915_PW_INSTANCES( - I915_PW("DDI_IO_A", &icl_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), - I915_PW("DDI_IO_B", &icl_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), - I915_PW("DDI_IO_C", &icl_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), + I915_PW("DDI_IO_A", &glk_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), + I915_PW("DDI_IO_B", &glk_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), + I915_PW("DDI_IO_C", &glk_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), I915_PW("DDI_IO_D_XELPD", &xelpd_pwdoms_ddi_io_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_D), I915_PW("DDI_IO_E_XELPD", &xelpd_pwdoms_ddi_io_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_E), - I915_PW("DDI_IO_TC1", &xelpd_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), - I915_PW("DDI_IO_TC2", &xelpd_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), - I915_PW("DDI_IO_TC3", &xelpd_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3), - I915_PW("DDI_IO_TC4", &xelpd_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4), + I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), + I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), + I915_PW("DDI_IO_TC3", &tgl_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3), + I915_PW("DDI_IO_TC4", &tgl_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4), ), .ops = &icl_ddi_power_well_ops, }, { .instances = &I915_PW_INSTANCES ( I915_PW("AUX_A", &icl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), I915_PW("AUX_B", &icl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), - I915_PW("AUX_C", &tgl_pwdoms_aux_c, .hsw.idx = ICL_PW_CTL_IDX_AUX_C), + I915_PW("AUX_C", &icl_pwdoms_aux_c, .hsw.idx = ICL_PW_CTL_IDX_AUX_C), I915_PW("AUX_D_XELPD", &xelpd_pwdoms_aux_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_D), I915_PW("AUX_E_XELPD", &xelpd_pwdoms_aux_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_E), - I915_PW("AUX_USBC1", &xelpd_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1), - I915_PW("AUX_USBC2", &xelpd_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2), - I915_PW("AUX_USBC3", &xelpd_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3), - I915_PW("AUX_USBC4", &xelpd_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4), + I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1), + I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2), + I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3), + I915_PW("AUX_USBC4", &tgl_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4), ), .ops = &icl_aux_power_well_ops, .fixed_enable_delay = true, }, { .instances = &I915_PW_INSTANCES ( - I915_PW("AUX_TBT1", &xelpd_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1), - I915_PW("AUX_TBT2", &xelpd_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2), - I915_PW("AUX_TBT3", &xelpd_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3), - I915_PW("AUX_TBT4", &xelpd_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4), + I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1), + I915_PW("AUX_TBT2", &icl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2), + I915_PW("AUX_TBT3", &icl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3), + I915_PW("AUX_TBT4", &icl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4), ), .ops = &icl_aux_power_well_ops, .is_tc_tbt = true,
Signature · 1 line
2.30.2
PATCH 18/18 drm/i915: Remove the XELPD specific AUX and DDI power domains
In reply to Imre DeakThe spec calls the XELPD_D/E ports just D/E, the platform prefix in the domain names was only needed by the port->domain mapping relying on matching enum values for the whole port/domain range (and the corresponding aliasing between the platform specific domain enums). Since a previous patch we can define the port->domain mapping explicitly so do this by reusing the already existing D/E power domain names.
--- .../drm/i915/display/intel_display_power.c | 18 +++------------ .../drm/i915/display/intel_display_power.h | 9 -------- .../i915/display/intel_display_power_map.c | 22 +++++++------------ 3 files changed, 11 insertions(+), 38 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +3 -15
@@ -92,10 +92,6 @@ intel_display_power_domain_str(enum intel_display_power_domain domain)return "PORT_DDI_LANES_TC5" ;case POWER_DOMAIN_PORT_DDI_LANES_TC6 :return "PORT_DDI_LANES_TC6" ; -case POWER_DOMAIN_PORT_DDI_LANES_D_XELPD : -return "PORT_DDI_LANES_D_XELPD" ; -case POWER_DOMAIN_PORT_DDI_LANES_E_XELPD : -return "PORT_DDI_LANES_E_XELPD" ;case POWER_DOMAIN_PORT_DDI_IO_A :return "PORT_DDI_IO_A" ;case POWER_DOMAIN_PORT_DDI_IO_B :
@@ -120,10 +116,6 @@ intel_display_power_domain_str(enum intel_display_power_domain domain)return "PORT_DDI_IO_TC5" ;case POWER_DOMAIN_PORT_DDI_IO_TC6 :return "PORT_DDI_IO_TC6" ; -case POWER_DOMAIN_PORT_DDI_IO_D_XELPD : -return "PORT_DDI_IO_D_XELPD" ; -case POWER_DOMAIN_PORT_DDI_IO_E_XELPD : -return "PORT_DDI_IO_E_XELPD" ;case POWER_DOMAIN_PORT_DSI :return "PORT_DSI" ;case POWER_DOMAIN_PORT_CRT :
@@ -160,10 +152,6 @@ intel_display_power_domain_str(enum intel_display_power_domain domain)return "AUX_USBC5" ;case POWER_DOMAIN_AUX_USBC6 :return "AUX_USBC6" ; -case POWER_DOMAIN_AUX_D_XELPD : -return "AUX_D_XELPD" ; -case POWER_DOMAIN_AUX_E_XELPD : -return "AUX_E_XELPD" ;case POWER_DOMAIN_AUX_IO_A :return "AUX_IO_A" ;case POWER_DOMAIN_AUX_TBT1 :
@@ -2390,9 +2378,9 @@ d13_port_domains[] = { .aux_ch_start = AUX_CH_D_XELPD, .aux_ch_end = AUX_CH_E_XELPD, - .ddi_lanes = POWER_DOMAIN_PORT_DDI_LANES_D_XELPD, - .ddi_io = POWER_DOMAIN_PORT_DDI_IO_D_XELPD, - .aux_legacy_usbc = POWER_DOMAIN_AUX_D_XELPD, + .ddi_lanes = POWER_DOMAIN_PORT_DDI_LANES_D, + .ddi_io = POWER_DOMAIN_PORT_DDI_IO_D, + .aux_legacy_usbc = POWER_DOMAIN_AUX_D, .aux_tbt = POWER_DOMAIN_INVALID, }, };
drivers/gpu/drm/i915/display/intel_display_power.h +0 -9
@@ -56,9 +56,6 @@ enum intel_display_power_domain {POWER_DOMAIN_PORT_DDI_LANES_TC5 ,POWER_DOMAIN_PORT_DDI_LANES_TC6 , -POWER_DOMAIN_PORT_DDI_LANES_D_XELPD , -POWER_DOMAIN_PORT_DDI_LANES_E_XELPD , -POWER_DOMAIN_PORT_DDI_IO_A ,POWER_DOMAIN_PORT_DDI_IO_B , POWER_DOMAIN_PORT_DDI_IO_C,
@@ -73,9 +70,6 @@ enum intel_display_power_domain {POWER_DOMAIN_PORT_DDI_IO_TC5 ,POWER_DOMAIN_PORT_DDI_IO_TC6 , -POWER_DOMAIN_PORT_DDI_IO_D_XELPD , -POWER_DOMAIN_PORT_DDI_IO_E_XELPD , -POWER_DOMAIN_PORT_DSI ,POWER_DOMAIN_PORT_CRT , POWER_DOMAIN_PORT_OTHER,
@@ -96,9 +90,6 @@ enum intel_display_power_domain {POWER_DOMAIN_AUX_USBC5 ,POWER_DOMAIN_AUX_USBC6 , -POWER_DOMAIN_AUX_D_XELPD , -POWER_DOMAIN_AUX_E_XELPD , -POWER_DOMAIN_AUX_IO_A , POWER_DOMAIN_AUX_TBT1,
drivers/gpu/drm/i915/display/intel_display_power_map.c +8 -14
@@ -1207,8 +1207,8 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_a,XELPD_PW_C_POWER_DOMAINS , \XELPD_PW_D_POWER_DOMAINS , \POWER_DOMAIN_PORT_DDI_LANES_C , \ -POWER_DOMAIN_PORT_DDI_LANES_D_XELPD , \ -POWER_DOMAIN_PORT_DDI_LANES_E_XELPD , \ +POWER_DOMAIN_PORT_DDI_LANES_D , \ +POWER_DOMAIN_PORT_DDI_LANES_E , \POWER_DOMAIN_PORT_DDI_LANES_TC1 , \POWER_DOMAIN_PORT_DDI_LANES_TC2 , \ POWER_DOMAIN_PORT_DDI_LANES_TC3, \
@@ -1216,8 +1216,8 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_a,POWER_DOMAIN_VGA , \POWER_DOMAIN_AUDIO_PLAYBACK , \POWER_DOMAIN_AUX_C , \ -POWER_DOMAIN_AUX_D_XELPD , \ -POWER_DOMAIN_AUX_E_XELPD , \ +POWER_DOMAIN_AUX_D , \ +POWER_DOMAIN_AUX_E , \POWER_DOMAIN_AUX_USBC1 , \POWER_DOMAIN_AUX_USBC2 , \ POWER_DOMAIN_AUX_USBC3, \
@@ -1257,12 +1257,6 @@ I915_DECL_PW_DOMAINS(xelpd_pwdoms_dc_off,POWER_DOMAIN_MODESET , POWER_DOMAIN_INIT); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_d_xelpd,POWER_DOMAIN_AUX_D_XELPD ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_aux_e_xelpd,POWER_DOMAIN_AUX_E_XELPD ); - -I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_d_xelpd,POWER_DOMAIN_PORT_DDI_IO_D_XELPD ); -I915_DECL_PW_DOMAINS (xelpd_pwdoms_ddi_io_e_xelpd,POWER_DOMAIN_PORT_DDI_IO_E_XELPD ); -static const struct i915_power_well_desc xelpd_power_wells_main[] = { { .instances = &I915_PW_INSTANCES(
@@ -1316,8 +1310,8 @@ static const struct i915_power_well_desc xelpd_power_wells_main[] = { I915_PW("DDI_IO_A", &glk_pwdoms_ddi_io_a, .hsw.idx = ICL_PW_CTL_IDX_DDI_A), I915_PW("DDI_IO_B", &glk_pwdoms_ddi_io_b, .hsw.idx = ICL_PW_CTL_IDX_DDI_B), I915_PW("DDI_IO_C", &glk_pwdoms_ddi_io_c, .hsw.idx = ICL_PW_CTL_IDX_DDI_C), - I915_PW("DDI_IO_D_XELPD", &xelpd_pwdoms_ddi_io_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_D), - I915_PW("DDI_IO_E_XELPD", &xelpd_pwdoms_ddi_io_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_E), + I915_PW("DDI_IO_D", &icl_pwdoms_ddi_io_d, .hsw.idx = XELPD_PW_CTL_IDX_DDI_D), + I915_PW("DDI_IO_E", &icl_pwdoms_ddi_io_e, .hsw.idx = XELPD_PW_CTL_IDX_DDI_E), I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1), I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2), I915_PW("DDI_IO_TC3", &tgl_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3),
@@ -1329,8 +1323,8 @@ static const struct i915_power_well_desc xelpd_power_wells_main[] = { I915_PW("AUX_A", &icl_pwdoms_aux_a, .hsw.idx = ICL_PW_CTL_IDX_AUX_A), I915_PW("AUX_B", &icl_pwdoms_aux_b, .hsw.idx = ICL_PW_CTL_IDX_AUX_B), I915_PW("AUX_C", &icl_pwdoms_aux_c, .hsw.idx = ICL_PW_CTL_IDX_AUX_C), - I915_PW("AUX_D_XELPD", &xelpd_pwdoms_aux_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_D), - I915_PW("AUX_E_XELPD", &xelpd_pwdoms_aux_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_E), + I915_PW("AUX_D", &icl_pwdoms_aux_d, .hsw.idx = XELPD_PW_CTL_IDX_AUX_D), + I915_PW("AUX_E", &icl_pwdoms_aux_e, .hsw.idx = XELPD_PW_CTL_IDX_AUX_E), I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1), I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2), I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
Signature · 1 line
2.30.2
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c
URL : https://patchwork.freedesktop.org/series/102719/
State : warning
== Summary ==
Error: dim checkpatch failedc5b4984a0598 drm/i915: Move per-platform power well hooks to intel_display_power_well.c -:2150: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #2150: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:266:
+
+ }
-:2360: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #2360: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:476:
+ msleep(1);
-:2365: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #2365: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:481:
+ msleep(1);
-:2714: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #2714: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:830:
+ intel_de_read(dev_priv, GEN8_CHICKEN_DCPR_1) | SKL_SELECT_ALTERNATE_DC_EXIT);
-:2741: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #2741: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:857:
+ intel_de_read(dev_priv, GEN8_CHICKEN_DCPR_1) | SKL_SELECT_ALTERNATE_DC_EXIT);
-:2843: WARNING:REPEATED_WORD: Possible repeated word: 'power' #2843: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:959:
+ "Unexpected DBuf power power state (0x%08x, expected 0x%08x)\n",
-:2918: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2918: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:1034:
+static bool i9xx_always_on_power_well_enabled(struct drm_i915_private *dev_priv,
+ struct i915_power_well *power_well)
-:3190: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'bits' - possible side-effects? #3190: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:1306:
+#define BITS_SET(val, bits) (((val) & (bits)) == (bits))
-:3645: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #3645: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:1761:
+ msleep(1);
-:3691: CHECK:LINE_SPACING: Please don't use multiple blank lines #3691: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:1807:
+
+
total: 0 errors, 6 warnings, 4 checks, 3833 lines checkedf92dd5251d2e drm/i915: Unexport the for_each_power_well() macros
-:23: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #23: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:24:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well(__dev_priv, __power_well) \
+ for_each_if((__power_well)->desc->domains & (__domain_mask))
-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #23: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:24:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well(__dev_priv, __power_well) \
+ for_each_if((__power_well)->desc->domains & (__domain_mask))
-:27: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #27: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:28:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well_reverse(__dev_priv, __power_well) \
+ for_each_if((__power_well)->desc->domains & (__domain_mask))
-:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #27: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:28:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well_reverse(__dev_priv, __power_well) \
+ for_each_if((__power_well)->desc->domains & (__domain_mask))
-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects? #73: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.h:15:
+#define for_each_power_well(__dev_priv, __power_well) \
+ for ((__power_well) = (__dev_priv)->power_domains.power_wells; \
+ (__power_well) - (__dev_priv)->power_domains.power_wells < \
+ (__dev_priv)->power_domains.power_well_count; \
+ (__power_well)++)
-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #73: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.h:15:
+#define for_each_power_well(__dev_priv, __power_well) \
+ for ((__power_well) = (__dev_priv)->power_domains.power_wells; \
+ (__power_well) - (__dev_priv)->power_domains.power_wells < \
+ (__dev_priv)->power_domains.power_well_count; \
+ (__power_well)++)
-:79: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects? #79: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.h:21:
+#define for_each_power_well_reverse(__dev_priv, __power_well) \
+ for ((__power_well) = (__dev_priv)->power_domains.power_wells + \
+ (__dev_priv)->power_domains.power_well_count - 1; \
+ (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \
+ (__power_well)--)
-:79: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #79: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.h:21:
+#define for_each_power_well_reverse(__dev_priv, __power_well) \
+ for ((__power_well) = (__dev_priv)->power_domains.power_wells + \
+ (__dev_priv)->power_domains.power_well_count - 1; \
+ (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \
+ (__power_well)--)
total: 2 errors, 0 warnings, 6 checks, 58 lines checked5d9272b7e832 drm/i915: Move the power domain->well mappings to intel_display_power_map.c Traceback (most recent call last):
File "scripts/spdxcheck.py", line 10, in <module>
import git
ModuleNotFoundError: No module named 'git'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 10, in <module>
import git
ModuleNotFoundError: No module named 'git'
-:2350: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #2350:
new file mode 100644
-:4433: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well_descs' - possible side-effects? #4433: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:2079:
+#define set_power_wells_mask(power_domains, __power_well_descs, skip_mask) \
+ __set_power_wells(power_domains, __power_well_descs, \
+ ARRAY_SIZE(__power_well_descs), skip_mask)
total: 0 errors, 1 warnings, 1 checks, 4467 lines checkeddf0e1c788a1c drm/i915: Move the dg2 fixed_enable_delay power well param to a common bitfield 0c5123daf423 drm/i915: Move the HSW power well flags to a common bitfield e425e99994b0 drm/i915: Rename the power domain names to end with pipes/ports 1960d3c53e8c drm/i915: Sanitize the power well namesa07c810823ad drm/i915: Convert the power well descriptor domain mask to an array of domains -:52: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__elems' - possible side-effects? #52: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:17:
+#define __LIST(__elems) { \
+ .list = __elems, \
+ .count = ARRAY_SIZE(__elems), \
+}
-:57: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #57: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:22:
+#define I915_PW_DOMAINS(...) \
+ (const struct i915_power_domain_list) \
+ __LIST(__LIST_INLINE_ELEMS(enum intel_display_power_domain, __VA_ARGS__))
-:68: CHECK:LINE_SPACING: Please don't use multiple blank lines #68: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:33:
+
+
-:91: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #91: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:47:
+I915_DECL_PW_DOMAINS(i830_pwdoms_pipes,
+ POWER_DOMAIN_PIPE_A,
-:134: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #134: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:71:
+I915_DECL_PW_DOMAINS(hsw_pwdoms_display,
+ POWER_DOMAIN_PIPE_B,
-:187: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #187: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:108:
+I915_DECL_PW_DOMAINS(bdw_pwdoms_display,
+ POWER_DOMAIN_PIPE_B,
-:270: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #270: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:145:
+I915_DECL_PW_DOMAINS(vlv_pwdoms_display,
+ POWER_DOMAIN_DISPLAY_CORE,
-:290: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #290: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:165:
+I915_DECL_PW_DOMAINS(vlv_pwdoms_dpio_cmn_bc,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:298: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #298: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:173:
+I915_DECL_PW_DOMAINS(vlv_pwdoms_dpio_tx_bc_lanes,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:416: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #416: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:238:
+I915_DECL_PW_DOMAINS(chv_pwdoms_display,
+ POWER_DOMAIN_DISPLAY_CORE,
-:440: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #440: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:262:
+I915_DECL_PW_DOMAINS(chv_pwdoms_dpio_cmn_bc,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:447: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #447: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:269:
+I915_DECL_PW_DOMAINS(chv_pwdoms_dpio_cmn_d,
+ POWER_DOMAIN_PORT_DDI_LANES_D,
-:530: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #530: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:309:
+#define SKL_PW_2_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_A, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_TRANSCODER_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_D, \
+ POWER_DOMAIN_PORT_DDI_LANES_E, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_B, \
+ POWER_DOMAIN_AUX_C, \
+ POWER_DOMAIN_AUX_D
-:550: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #550: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:329:
+I915_DECL_PW_DOMAINS(skl_pwdoms_pw_2,
+ SKL_PW_2_POWER_DOMAINS,
-:554: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #554: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:333:
+I915_DECL_PW_DOMAINS(skl_pwdoms_dc_off,
+ SKL_PW_2_POWER_DOMAINS,
-:561: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #561: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:340:
+I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_a_e,
+ POWER_DOMAIN_PORT_DDI_IO_A,
-:566: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #566: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:345:
+I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_b,
+ POWER_DOMAIN_PORT_DDI_IO_B,
-:570: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #570: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:349:
+I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_c,
+ POWER_DOMAIN_PORT_DDI_IO_C,
-:574: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #574: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:353:
+I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_d,
+ POWER_DOMAIN_PORT_DDI_IO_D,
-:693: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #693: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:435:
+#define BXT_PW_2_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_A, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_TRANSCODER_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_B, \
+ POWER_DOMAIN_AUX_C
-:710: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #710: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:452:
+I915_DECL_PW_DOMAINS(bxt_pwdoms_pw_2,
+ BXT_PW_2_POWER_DOMAINS,
-:714: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #714: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:456:
+I915_DECL_PW_DOMAINS(bxt_pwdoms_dc_off,
+ BXT_PW_2_POWER_DOMAINS,
-:722: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #722: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:464:
+I915_DECL_PW_DOMAINS(bxt_pwdoms_dpio_cmn_a,
+ POWER_DOMAIN_PORT_DDI_LANES_A,
-:727: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #727: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:469:
+I915_DECL_PW_DOMAINS(bxt_pwdoms_dpio_cmn_bc,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:842: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #842: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:528:
+#define GLK_PW_2_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_A, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_TRANSCODER_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_B, \
+ POWER_DOMAIN_AUX_C
-:859: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #859: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:545:
+I915_DECL_PW_DOMAINS(glk_pwdoms_pw_2,
+ GLK_PW_2_POWER_DOMAINS,
-:863: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #863: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:549:
+I915_DECL_PW_DOMAINS(glk_pwdoms_dc_off,
+ GLK_PW_2_POWER_DOMAINS,
-:875: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #875: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:561:
+I915_DECL_PW_DOMAINS(glk_pwdoms_dpio_cmn_a,
+ POWER_DOMAIN_PORT_DDI_LANES_A,
-:880: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #880: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:566:
+I915_DECL_PW_DOMAINS(glk_pwdoms_dpio_cmn_b,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:885: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #885: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:571:
+I915_DECL_PW_DOMAINS(glk_pwdoms_dpio_cmn_c,
+ POWER_DOMAIN_PORT_DDI_LANES_C,
-:890: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #890: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:576:
+I915_DECL_PW_DOMAINS(glk_pwdoms_aux_a,
+ POWER_DOMAIN_AUX_A,
-:895: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #895: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:581:
+I915_DECL_PW_DOMAINS(glk_pwdoms_aux_b,
+ POWER_DOMAIN_AUX_B,
-:899: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #899: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:585:
+I915_DECL_PW_DOMAINS(glk_pwdoms_aux_c,
+ POWER_DOMAIN_AUX_C,
-:1022: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1022: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:711:
+#define ICL_PW_4_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C
-:1027: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1027: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:716:
+I915_DECL_PW_DOMAINS(icl_pwdoms_pw_4,
+ ICL_PW_4_POWER_DOMAINS,
-:1056: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1056: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:720:
+#define ICL_PW_3_POWER_DOMAINS \
+ ICL_PW_4_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_A, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_TRANSCODER_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_D, \
+ POWER_DOMAIN_PORT_DDI_LANES_E, \
+ POWER_DOMAIN_PORT_DDI_LANES_F, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_B, \
+ POWER_DOMAIN_AUX_C, \
+ POWER_DOMAIN_AUX_D, \
+ POWER_DOMAIN_AUX_E, \
+ POWER_DOMAIN_AUX_F, \
+ POWER_DOMAIN_AUX_TBT_C, \
+ POWER_DOMAIN_AUX_TBT_D, \
+ POWER_DOMAIN_AUX_TBT_E, \
+ POWER_DOMAIN_AUX_TBT_F
-:1082: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1082: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:746:
+I915_DECL_PW_DOMAINS(icl_pwdoms_pw_3,
+ ICL_PW_3_POWER_DOMAINS,
-:1093: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1093: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:753:
+#define ICL_PW_2_POWER_DOMAINS \
+ ICL_PW_3_POWER_DOMAINS, \
+ POWER_DOMAIN_TRANSCODER_VDSC_PW2
-:1098: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1098: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:758:
+I915_DECL_PW_DOMAINS(icl_pwdoms_pw_2,
+ ICL_PW_2_POWER_DOMAINS,
-:1132: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1132: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:765:
+I915_DECL_PW_DOMAINS(icl_pwdoms_dc_off,
+ ICL_PW_2_POWER_DOMAINS,
-:1146: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1146: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:779:
+I915_DECL_PW_DOMAINS(icl_pwdoms_aux_a,
+ POWER_DOMAIN_AUX_A,
-:1450: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1450: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:983:
+#define TGL_PW_5_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_D, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_D, \
+ POWER_DOMAIN_TRANSCODER_D
-:1456: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1456: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:989:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_pw_5,
+ TGL_PW_5_POWER_DOMAINS,
-:1459: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1459: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:992:
+#define TGL_PW_4_POWER_DOMAINS \
+ TGL_PW_5_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_C
-:1466: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1466: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:999:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_pw_4,
+ TGL_PW_4_POWER_DOMAINS,
-:1469: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1469: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1002:
+#define TGL_PW_3_POWER_DOMAINS \
+ TGL_PW_4_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC3, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC4, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC5, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC6, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_USBC1, \
+ POWER_DOMAIN_AUX_USBC2, \
+ POWER_DOMAIN_AUX_USBC3, \
+ POWER_DOMAIN_AUX_USBC4, \
+ POWER_DOMAIN_AUX_USBC5, \
+ POWER_DOMAIN_AUX_USBC6, \
+ POWER_DOMAIN_AUX_TBT1, \
+ POWER_DOMAIN_AUX_TBT2, \
+ POWER_DOMAIN_AUX_TBT3, \
+ POWER_DOMAIN_AUX_TBT4, \
+ POWER_DOMAIN_AUX_TBT5, \
+ POWER_DOMAIN_AUX_TBT6
-:1497: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1497: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1030:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_pw_3,
+ TGL_PW_3_POWER_DOMAINS,
-:1501: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1501: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1034:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_pw_2,
+ TGL_PW_3_POWER_DOMAINS,
-:1506: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1506: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1039:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_dc_off,
+ TGL_PW_3_POWER_DOMAINS,
-:1521: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1521: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1054:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_aux_a,
+ POWER_DOMAIN_AUX_A,
-:1541: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1541: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1074:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_tc_cold_off,
+ POWER_DOMAIN_AUX_USBC1,
-:1858: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1858: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1363:
+#define RKL_PW_4_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_C
-:1864: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1864: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1369:
+I915_DECL_PW_DOMAINS(rkl_pwdoms_pw_4,
+ RKL_PW_4_POWER_DOMAINS,
-:1867: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1867: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1372:
+#define RKL_PW_3_POWER_DOMAINS \
+ RKL_PW_4_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_USBC1, \
+ POWER_DOMAIN_AUX_USBC2
-:1881: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1881: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1386:
+I915_DECL_PW_DOMAINS(rkl_pwdoms_pw_3,
+ RKL_PW_3_POWER_DOMAINS,
-:1897: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1897: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1411:
+I915_DECL_PW_DOMAINS(rkl_pwdoms_dc_off,
+ RKL_PW_3_POWER_DOMAINS,
-:2044: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2044: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1531:
+#define DG1_PW_3_POWER_DOMAINS \
+ TGL_PW_4_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_USBC1, \
+ POWER_DOMAIN_AUX_USBC2
-:2057: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2057: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1544:
+I915_DECL_PW_DOMAINS(dg1_pwdoms_pw_3,
+ DG1_PW_3_POWER_DOMAINS,
-:2061: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2061: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1548:
+I915_DECL_PW_DOMAINS(dg1_pwdoms_dc_off,
+ DG1_PW_3_POWER_DOMAINS,
-:2069: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2069: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1556:
+I915_DECL_PW_DOMAINS(dg1_pwdoms_pw_2,
+ DG1_PW_3_POWER_DOMAINS,
-:2255: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2255: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1710:
+#define XELPD_PW_D_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_D, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_D, \
+ POWER_DOMAIN_TRANSCODER_D
-:2261: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2261: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1716:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_d,
+ XELPD_PW_D_POWER_DOMAINS,
-:2264: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2264: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1719:
+#define XELPD_PW_C_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_C
-:2270: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2270: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1725:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_c,
+ XELPD_PW_C_POWER_DOMAINS,
-:2273: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2273: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1728:
+#define XELPD_PW_B_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_B
-:2279: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2279: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1734:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_b,
+ XELPD_PW_B_POWER_DOMAINS,
-:2283: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2283: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1738:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_a,
+ POWER_DOMAIN_PIPE_A,
-:2287: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2287: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1742:
+#define XELPD_PW_2_POWER_DOMAINS \
+ XELPD_PW_B_POWER_DOMAINS, \
+ XELPD_PW_C_POWER_DOMAINS, \
+ XELPD_PW_D_POWER_DOMAINS, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_D_XELPD, \
+ POWER_DOMAIN_PORT_DDI_LANES_E_XELPD, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC3, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC4, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_C, \
+ POWER_DOMAIN_AUX_D_XELPD, \
+ POWER_DOMAIN_AUX_E_XELPD, \
+ POWER_DOMAIN_AUX_USBC1, \
+ POWER_DOMAIN_AUX_USBC2, \
+ POWER_DOMAIN_AUX_USBC3, \
+ POWER_DOMAIN_AUX_USBC4, \
+ POWER_DOMAIN_AUX_TBT1, \
+ POWER_DOMAIN_AUX_TBT2, \
+ POWER_DOMAIN_AUX_TBT3, \
+ POWER_DOMAIN_AUX_TBT4
-:2313: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2313: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1768:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_2,
+ XELPD_PW_2_POWER_DOMAINS,
-:2350: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2350: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1789:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_dc_off,
+ XELPD_PW_2_POWER_DOMAINS,
total: 17 errors, 0 warnings, 53 checks, 2540 lines checked11af7f881081 drm/i915: Convert the u64 power well domains mask to a bitmap -:177: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #177: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:25:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain) \
for_each_power_well(__dev_priv, __power_well) \
+ for_each_if(test_bit((__domain), (__power_well)->domains.bits))
-:177: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #177: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:25:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain) \
for_each_power_well(__dev_priv, __power_well) \
+ for_each_if(test_bit((__domain), (__power_well)->domains.bits))
-:183: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #183: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:29:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain) \
for_each_power_well_reverse(__dev_priv, __power_well) \
+ for_each_if(test_bit((__domain), (__power_well)->domains.bits))
-:183: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #183: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:29:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain) \
for_each_power_well_reverse(__dev_priv, __power_well) \
+ for_each_if(test_bit((__domain), (__power_well)->domains.bits))
-:527: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__domain' - possible side-effects? #527: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:175:
+#define for_each_power_domain(__domain, __mask) \
+ for ((__domain) = 0; (__domain) < POWER_DOMAIN_NUM; (__domain)++) \
+ for_each_if(test_bit((__domain), (__mask)->bits))
total: 2 errors, 0 warnings, 3 checks, 530 lines checkedc31d83cbdf2d drm/i915: Simplify power well definitions by adding power well instances -:33: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #33: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:33:
+#define I915_PW_INSTANCES(...) \
+ (const struct i915_power_well_instance_list) \
+ __LIST(__LIST_INLINE_ELEMS(struct i915_power_well_instance, __VA_ARGS__))
-:47: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #47: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:45:
+ .instances = &I915_PW_INSTANCES(
-:62: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #62: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:64:
+ .instances = &I915_PW_INSTANCES(
-:71: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #71: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:70:
+ .instances = &I915_PW_INSTANCES(
-:85: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #85: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:97:
+ .instances = &I915_PW_INSTANCES(
-:94: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #94: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:103:
+ .instances = &I915_PW_INSTANCES(
-:114: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #114: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:132:
+ .instances = &I915_PW_INSTANCES(
-:123: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #123: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:138:
+ .instances = &I915_PW_INSTANCES(
-:144: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #144: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:186:
+ .instances = &I915_PW_INSTANCES(
-:153: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #153: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:192:
+ .instances = &I915_PW_INSTANCES(
-:182: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #182: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:199:
+ .instances = &I915_PW_INSTANCES(
-:208: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #208: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:211:
+ .instances = &I915_PW_INSTANCES(
-:227: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #227: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:258:
+ .instances = &I915_PW_INSTANCES(
-:241: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #241: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:269:
+ .instances = &I915_PW_INSTANCES(
-:249: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #249: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:274:
+ .instances = &I915_PW_INSTANCES(
-:279: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #279: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:335:
+ .instances = &I915_PW_INSTANCES(
-:289: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #289: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:342:
+ .instances = &I915_PW_INSTANCES(
-:305: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #305: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:352:
+ .instances = &I915_PW_INSTANCES(
-:319: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #319: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:360:
+ .instances = &I915_PW_INSTANCES(
-:328: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #328: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:366:
+ .instances = &I915_PW_INSTANCES(
-:344: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #344: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:376:
+ .instances = &I915_PW_INSTANCES(
-:345: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #345: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:377:
+ I915_PW("DDI_IO_A_E", &skl_pwdoms_ddi_io_a_e, .hsw.idx = SKL_PW_CTL_IDX_DDI_A_E),
-:388: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #388: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:428:
+ .instances = &I915_PW_INSTANCES(
-:398: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #398: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:435:
+ .instances = &I915_PW_INSTANCES(
-:413: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #413: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:444:
+ .instances = &I915_PW_INSTANCES(
-:422: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #422: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:450:
+ .instances = &I915_PW_INSTANCES(
-:438: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #438: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:460:
+ .instances = &I915_PW_INSTANCES(
-:468: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #468: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:534:
+ .instances = &I915_PW_INSTANCES(
-:478: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #478: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:541:
+ .instances = &I915_PW_INSTANCES(
-:493: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #493: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:550:
+ .instances = &I915_PW_INSTANCES(
-:502: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #502: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:556:
+ .instances = &I915_PW_INSTANCES(
-:534: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #534: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:566:
+ .instances = &I915_PW_INSTANCES(
-:593: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #593: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:579:
+ .instances = &I915_PW_INSTANCES(
-:615: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #615: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:687:
+ .instances = &I915_PW_INSTANCES(
-:625: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #625: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:694:
+ .instances = &I915_PW_INSTANCES(
-:640: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #640: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:703:
+ .instances = &I915_PW_INSTANCES(
-:649: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #649: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:709:
+ .instances = &I915_PW_INSTANCES(
-:663: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #663: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:717:
+ .instances = &I915_PW_INSTANCES(
-:719: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #719: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:727:
+ .instances = &I915_PW_INSTANCES(
-:735: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #735: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:737:
+ .instances = &I915_PW_INSTANCES(
-:795: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #795: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:747:
+ .instances = &I915_PW_INSTANCES(
-:796: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #796: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:748:
+ I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT1),
-:797: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #797: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:749:
+ I915_PW("AUX_TBT2", &icl_pwdoms_aux_tbt2, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT2),
-:798: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #798: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:750:
+ I915_PW("AUX_TBT3", &icl_pwdoms_aux_tbt3, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT3),
-:799: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #799: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:751:
+ I915_PW("AUX_TBT4", &icl_pwdoms_aux_tbt4, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT4),
-:837: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #837: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:756:
+ .instances = &I915_PW_INSTANCES(
-:857: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #857: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:873:
+ .instances = &I915_PW_INSTANCES(
-:867: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #867: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:880:
+ .instances = &I915_PW_INSTANCES(
-:882: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #882: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:889:
+ .instances = &I915_PW_INSTANCES(
-:891: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #891: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:895:
+ .instances = &I915_PW_INSTANCES(
-:905: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #905: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:903:
+ .instances = &I915_PW_INSTANCES(
-:945: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #945: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:913:
+ .instances = &I915_PW_INSTANCES(
-:949: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #949: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:917:
+ I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:950: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #950: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:918:
+ I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:951: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #951: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:919:
+ I915_PW("DDI_IO_TC3", &tgl_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3),
-:952: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #952: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:920:
+ I915_PW("DDI_IO_TC4", &tgl_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4),
-:953: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #953: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:921:
+ I915_PW("DDI_IO_TC5", &tgl_pwdoms_ddi_io_tc5, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC5),
-:954: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #954: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:922:
+ I915_PW("DDI_IO_TC6", &tgl_pwdoms_ddi_io_tc6, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC6),
-:1004: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1004: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:926:
+ .instances = &I915_PW_INSTANCES(
-:1100: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1100: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:932:
+ .instances = &I915_PW_INSTANCES(
-:1104: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1104: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:936:
+ I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:1105: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1105: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:937:
+ I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:1106: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1106: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:938:
+ I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
-:1107: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1107: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:939:
+ I915_PW("AUX_USBC4", &tgl_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4),
-:1108: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1108: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:940:
+ I915_PW("AUX_USBC5", &tgl_pwdoms_aux_usbc5, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC5),
-:1109: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1109: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:941:
+ I915_PW("AUX_USBC6", &tgl_pwdoms_aux_usbc6, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC6),
-:1120: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1120: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:945:
+ .instances = &I915_PW_INSTANCES(
-:1121: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1121: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:946:
+ I915_PW("AUX_TBT1", &tgl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1),
-:1122: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1122: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:947:
+ I915_PW("AUX_TBT2", &tgl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2),
-:1123: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1123: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:948:
+ I915_PW("AUX_TBT3", &tgl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3),
-:1124: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1124: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:949:
+ I915_PW("AUX_TBT4", &tgl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4),
-:1125: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1125: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:950:
+ I915_PW("AUX_TBT5", &tgl_pwdoms_aux_tbt5, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT5),
-:1126: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1126: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:951:
+ I915_PW("AUX_TBT6", &tgl_pwdoms_aux_tbt6, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT6),
-:1164: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1164: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:956:
+ .instances = &I915_PW_INSTANCES(
-:1178: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1178: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:964:
+ .instances = &I915_PW_INSTANCES(
-:1198: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1198: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1030:
+ .instances = &I915_PW_INSTANCES(
-:1208: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1208: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1037:
+ .instances = &I915_PW_INSTANCES(
-:1223: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1223: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1046:
+ .instances = &I915_PW_INSTANCES(
-:1232: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1232: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1052:
+ .instances = &I915_PW_INSTANCES(
-:1248: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1248: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1062:
+ .instances = &I915_PW_INSTANCES(
-:1286: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1286: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1070:
+ .instances = &I915_PW_INSTANCES(
-:1289: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1289: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1073:
+ I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:1290: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1290: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1074:
+ I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:1300: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1300: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1078:
+ .instances = &I915_PW_INSTANCES(
-:1303: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1303: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1081:
+ I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:1304: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1304: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1082:
+ I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:1344: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1344: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1122:
+ .instances = &I915_PW_INSTANCES(
-:1354: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1354: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1129:
+ .instances = &I915_PW_INSTANCES(
-:1369: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1369: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1138:
+ .instances = &I915_PW_INSTANCES(
-:1378: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1378: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1144:
+ .instances = &I915_PW_INSTANCES(
-:1392: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1392: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1152:
+ .instances = &I915_PW_INSTANCES(
-:1408: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1408: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1162:
+ .instances = &I915_PW_INSTANCES(
-:1411: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1411: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1165:
+ I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:1412: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1412: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1166:
+ I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:1454: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1454: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1170:
+ .instances = &I915_PW_INSTANCES(
-:1457: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1457: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1173:
+ I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:1458: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1458: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1174:
+ I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:1486: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1486: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1178:
+ .instances = &I915_PW_INSTANCES(
-:1500: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1500: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1186:
+ .instances = &I915_PW_INSTANCES(
-:1520: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1520: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1323:
+ .instances = &I915_PW_INSTANCES(
-:1530: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1530: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1330:
+ .instances = &I915_PW_INSTANCES(
-:1545: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1545: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1339:
+ .instances = &I915_PW_INSTANCES(
-:1554: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1554: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1345:
+ .instances = &I915_PW_INSTANCES(
-:1569: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1569: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1354:
+ .instances = &I915_PW_INSTANCES(
-:1583: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1583: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1362:
+ .instances = &I915_PW_INSTANCES(
-:1597: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1597: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1370:
+ .instances = &I915_PW_INSTANCES(
-:1611: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1611: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1378:
+ .instances = &I915_PW_INSTANCES(
-:1625: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1625: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1386:
+ .instances = &I915_PW_INSTANCES(
-:1629: WARNING:LONG_LINE: line length of 115 exceeds 100 columns #1629: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1390:
+ I915_PW("DDI_IO_D_XELPD", &xelpd_pwdoms_ddi_io_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_D),
-:1630: WARNING:LONG_LINE: line length of 115 exceeds 100 columns #1630: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1391:
+ I915_PW("DDI_IO_E_XELPD", &xelpd_pwdoms_ddi_io_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_E),
-:1631: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #1631: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1392:
+ I915_PW("DDI_IO_TC1", &xelpd_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:1632: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #1632: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1393:
+ I915_PW("DDI_IO_TC2", &xelpd_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:1633: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #1633: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1394:
+ I915_PW("DDI_IO_TC3", &xelpd_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3),
-:1634: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #1634: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1395:
+ I915_PW("DDI_IO_TC4", &xelpd_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4),
-:1708: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1708: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1399:
+ .instances = &I915_PW_INSTANCES(
-:1712: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #1712: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1403:
+ I915_PW("AUX_D_XELPD", &xelpd_pwdoms_aux_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_D),
-:1713: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #1713: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1404:
+ I915_PW("AUX_E_XELPD", &xelpd_pwdoms_aux_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_E),
-:1714: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1714: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1405:
+ I915_PW("AUX_USBC1", &xelpd_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:1715: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1715: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1406:
+ I915_PW("AUX_USBC2", &xelpd_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:1716: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1716: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1407:
+ I915_PW("AUX_USBC3", &xelpd_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
-:1717: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1717: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1408:
+ I915_PW("AUX_USBC4", &xelpd_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4),
-:1796: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1796: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1413:
+ .instances = &I915_PW_INSTANCES(
-:1797: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #1797: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1414:
+ I915_PW("AUX_TBT1", &xelpd_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1),
-:1798: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #1798: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1415:
+ I915_PW("AUX_TBT2", &xelpd_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2),
-:1799: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #1799: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1416:
+ I915_PW("AUX_TBT3", &xelpd_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3),
-:1800: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #1800: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1417:
+ I915_PW("AUX_TBT4", &xelpd_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4),
-:1861: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1861: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1442:
+#define for_each_power_well_instance(_desc_list, _desc_count, _desc, _inst) \
+ for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
+ for ((_inst) = (_desc)->instances->list; \
+ (_inst) - (_desc)->instances->list < (_desc)->instances->count; \
+ (_inst)++)
-:1861: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc_list' - possible side-effects? #1861: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1442:
+#define for_each_power_well_instance(_desc_list, _desc_count, _desc, _inst) \
+ for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
+ for ((_inst) = (_desc)->instances->list; \
+ (_inst) - (_desc)->instances->list < (_desc)->instances->count; \
+ (_inst)++)
-:1861: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc' - possible side-effects? #1861: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1442:
+#define for_each_power_well_instance(_desc_list, _desc_count, _desc, _inst) \
+ for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
+ for ((_inst) = (_desc)->instances->list; \
+ (_inst) - (_desc)->instances->list < (_desc)->instances->count; \
+ (_inst)++)
-:1861: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_inst' - possible side-effects? #1861: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1442:
+#define for_each_power_well_instance(_desc_list, _desc_count, _desc, _inst) \
+ for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
+ for ((_inst) = (_desc)->instances->list; \
+ (_inst) - (_desc)->instances->list < (_desc)->instances->count; \
+ (_inst)++)
total: 2 errors, 47 warnings, 81 checks, 2190 lines checked 3eec26a8953e drm/i915: Allow platforms to share power well descriptors -:34: CHECK:LINE_SPACING: Please don't use multiple blank lines #34: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:48:
+
+
-:516: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #516: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1397:
+#define for_each_power_well_instance_in_desc_list(_desc_list, _desc_count, _desc, _inst) \
for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
for ((_inst) = (_desc)->instances->list; \
(_inst) - (_desc)->instances->list < (_desc)->instances->count; \
(_inst)++)
-:516: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc_list' - possible side-effects? #516: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1397:
+#define for_each_power_well_instance_in_desc_list(_desc_list, _desc_count, _desc, _inst) \
for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
for ((_inst) = (_desc)->instances->list; \
(_inst) - (_desc)->instances->list < (_desc)->instances->count; \
(_inst)++)
-:516: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc' - possible side-effects? #516: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1397:
+#define for_each_power_well_instance_in_desc_list(_desc_list, _desc_count, _desc, _inst) \
for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
for ((_inst) = (_desc)->instances->list; \
(_inst) - (_desc)->instances->list < (_desc)->instances->count; \
(_inst)++)
-:516: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_inst' - possible side-effects? #516: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1397:
+#define for_each_power_well_instance_in_desc_list(_desc_list, _desc_count, _desc, _inst) \
for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
for ((_inst) = (_desc)->instances->list; \
(_inst) - (_desc)->instances->list < (_desc)->instances->count; \
(_inst)++)
-:522: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc_list' - possible side-effects? #522: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1403:
+#define for_each_power_well_instance(_desc_list, _desc_count, _descs, _desc, _inst) \
+ for ((_descs) = (_desc_list); \
+ (_descs) - (_desc_list) < (_desc_count); \
+ (_descs)++) \
+ for_each_power_well_instance_in_desc_list((_descs)->list, (_descs)->count, \
+ (_desc), (_inst))
-:522: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_descs' - possible side-effects? #522: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1403:
+#define for_each_power_well_instance(_desc_list, _desc_count, _descs, _desc, _inst) \
+ for ((_descs) = (_desc_list); \
+ (_descs) - (_desc_list) < (_desc_count); \
+ (_descs)++) \
+ for_each_power_well_instance_in_desc_list((_descs)->list, (_descs)->count, \
+ (_desc), (_inst))
total: 1 errors, 0 warnings, 6 checks, 512 lines checked ff43e7ff616f drm/i915: Simplify the DG1 power well descriptors 52f2a4794327 drm/i915: Sanitize the ADL-S power well definition -:30: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #30: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:905:
+ .instances = &I915_PW_INSTANCES(
-:38: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #38: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:913:
+ .instances = &I915_PW_INSTANCES(
total: 0 errors, 0 warnings, 2 checks, 123 lines checked4b8354edd893 drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform 435a47c6ff05 drm/i915: Remove the aliasing of power domain enum values 4ef3375d182a drm/i915: Remove the ICL specific TBT power domains b4ebb81064ee drm/i915: Remove duplicate DDI/AUX power domain mappings -:101: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#101: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:936:
+ I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1),
-:102: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #102: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:937:
+ I915_PW("AUX_TBT2", &icl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2),
-:103: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #103: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:938:
+ I915_PW("AUX_TBT3", &icl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3),
-:104: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #104: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:939:
+ I915_PW("AUX_TBT4", &icl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4),
-:158: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #158: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1321:
+ I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:159: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #159: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1322:
+ I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:160: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #160: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1323:
+ I915_PW("DDI_IO_TC3", &tgl_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3),
-:161: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #161: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1324:
+ I915_PW("DDI_IO_TC4", &tgl_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4),
-:176: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #176: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1334:
+ I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:177: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #177: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1335:
+ I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:178: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #178: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1336:
+ I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
-:179: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #179: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1337:
+ I915_PW("AUX_USBC4", &tgl_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4),
-:189: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #189: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1343:
+ I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1),
-:190: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #190: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1344:
+ I915_PW("AUX_TBT2", &icl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2),
-:191: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #191: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1345:
+ I915_PW("AUX_TBT3", &icl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3),
-:192: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #192: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1346:
+ I915_PW("AUX_TBT4", &icl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4),
total: 0 errors, 16 warnings, 0 checks, 166 lines checked 0e7e778b30ae drm/i915: Remove the XELPD specific AUX and DDI power domains -:148: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #148: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1313:
+ I915_PW("DDI_IO_D", &icl_pwdoms_ddi_io_d, .hsw.idx = XELPD_PW_CTL_IDX_DDI_D),
-:149: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #149: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1314:
+ I915_PW("DDI_IO_E", &icl_pwdoms_ddi_io_e, .hsw.idx = XELPD_PW_CTL_IDX_DDI_E),
total: 0 errors, 2 warnings, 0 checks, 121 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c
URL : https://patchwork.freedesktop.org/series/102719/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c
URL : https://patchwork.freedesktop.org/series/102719/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11503 -> Patchwork_102719v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/index.html
Participating hosts (49 -> 45)
------------------------------
Missing (4): fi-kbl-soraka fi-bsw-cyan fi-icl-u2 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102719v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_suspend@basic-s0@lmem0:
- {bat-dg2-8}: [DMESG-WARN][1] ([i915#5193]) -> [DMESG-WARN][2] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/bat-dg2-8/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/bat-dg2-8/igt@gem_exec_suspend@[email protected]
* igt@gem_lmem_swapping@basic:
- {bat-rpls-2}: NOTRUN -> [FAIL][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/bat-rpls-2/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- {fi-ehl-2}: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/fi-ehl-2/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/fi-ehl-2/igt@i915_selftest@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- {bat-dg2-9}: [DMESG-WARN][6] ([i915#5193]) -> [DMESG-WARN][7] +4 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/bat-dg2-9/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/bat-dg2-9/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_102719v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-n3050: [PASS][8] -> [DMESG-FAIL][9] ([i915#2927] / [i915#3428])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
* igt@kms_psr@primary_page_flip:
- fi-tgl-u2: [PASS][10] -> [SKIP][11] ([i915#668]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/fi-tgl-u2/igt@kms_psr@primary_page_flip.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/fi-tgl-u2/igt@kms_psr@primary_page_flip.html
* igt@runner@aborted:
- fi-tgl-1115g4: NOTRUN -> [FAIL][12] ([i915#5257])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/fi-tgl-1115g4/igt@[email protected]
- fi-bsw-n3050: NOTRUN -> [FAIL][13] ([fdo#109271] / [i915#3428] / [i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/fi-bsw-n3050/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rps@basic-api:
- bat-dg1-6: [FAIL][14] ([i915#4032]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/bat-dg1-6/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/bat-dg1-6/igt@[email protected]
* igt@i915_suspend@system-suspend-without-i915:
- {fi-tgl-dsi}: [DMESG-WARN][16] ([i915#1982]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/fi-tgl-dsi/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/fi-tgl-dsi/igt@[email protected]
* igt@kms_busy@basic@flip:
- fi-tgl-u2: [DMESG-WARN][18] ([i915#402]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/fi-tgl-u2/igt@kms_busy@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/fi-tgl-u2/igt@kms_busy@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4032]: https://gitlab.freedesktop.org/drm/intel/issues/4032
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5193]: https://gitlab.freedesktop.org/drm/intel/issues/5193
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5329]: https://gitlab.freedesktop.org/drm/intel/issues/5329
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
Build changes
-------------
* Linux: CI_DRM_11503 -> Patchwork_102719v1
CI-20190529: 20190529
CI_DRM_11503: 000a595e443e99065d0ea00993a60eef24276e5f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6437: ea0144ed6ccb66b977f204b4d53b6062ed1cc8bc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102719v1: 000a595e443e99065d0ea00993a60eef24276e5f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a625a16fab17 drm/i915: Remove the XELPD specific AUX and DDI power domains 92b76ed6ceab drm/i915: Remove duplicate DDI/AUX power domain mappings ac0adc30cda4 drm/i915: Remove the ICL specific TBT power domains225c3b5206bf drm/i915: Remove the aliasing of power domain enum values c702d1a0ff55 drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform 159639939876 drm/i915: Sanitize the ADL-S power well definitionddedb363d1a0 drm/i915: Simplify the DG1 power well descriptors0821f4dbd749 drm/i915: Allow platforms to share power well descriptors c4abee7bb33a drm/i915: Simplify power well definitions by adding power well instances 53e0bb63ce8d drm/i915: Convert the u64 power well domains mask to a bitmap 218e6faf3ce5 drm/i915: Convert the power well descriptor domain mask to an array of domains 8ec6e7e3fa12 drm/i915: Sanitize the power well namesaadf5d31e8cd drm/i915: Rename the power domain names to end with pipes/ports 559c2343691e drm/i915: Move the HSW power well flags to a common bitfield a297d86467e6 drm/i915: Move the dg2 fixed_enable_delay power well param to a common bitfield b660e526b23e drm/i915: Move the power domain->well mappings to intel_display_power_map.c 3bd5e1124cef drm/i915: Unexport the for_each_power_well() macrosa631555836f1 drm/i915: Move per-platform power well hooks to intel_display_power_well.c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [CI,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c
URL : https://patchwork.freedesktop.org/series/102719/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11503_full -> Patchwork_102719v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_102719v1_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_102719v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 12)
------------------------------
Missing (1): shard-dg1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102719v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_dp_aux_dev:
- shard-iclb: [PASS][1] -> [DMESG-WARN][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb6/igt@kms_dp_aux_dev.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb1/igt@kms_dp_aux_dev.html
- shard-tglb: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-tglb7/igt@kms_dp_aux_dev.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb8/igt@kms_dp_aux_dev.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_balancer@noheartbeat:
- {shard-rkl}: [PASS][5] -> [INCOMPLETE][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_rpm@i2c:
- {shard-tglu}: NOTRUN -> [DMESG-WARN][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglu-2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_102719v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@chamelium:
- shard-iclb: NOTRUN -> [SKIP][8] ([fdo#111827])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb8/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#232])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-tglb7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][11] ([i915#2846])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl9/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][12] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-tglb6/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-uc-set-default:
- shard-snb: [PASS][15] -> [SKIP][16] ([fdo#109271]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-snb7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-snb6/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][17] -> [SKIP][18] ([i915#2190])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-tglb8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb6/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#2190])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl1/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl1/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-kbl: NOTRUN -> [WARN][21] ([i915#2658])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl7/igt@[email protected]
* igt@gen7_exec_parse@basic-allowed:
- shard-tglb: NOTRUN -> [SKIP][22] ([fdo#109289])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@[email protected]
* igt@gen9_exec_parse@bb-start-cmd:
- shard-tglb: NOTRUN -> [SKIP][23] ([i915#2527] / [i915#2856])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][24] -> [FAIL][25] ([i915#454])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb7/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb3/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][26] ([i915#454])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl9/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#1937])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl7/igt@i915_pm_lpsp@[email protected]
* igt@i915_pm_rpm@i2c:
- shard-tglb: [PASS][28] -> [DMESG-WARN][29] ([i915#2411])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-tglb7/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb1/igt@[email protected]
* igt@i915_pm_rpm@pc8-residency:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109506] / [i915#2411])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@4-tiled-16bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#5286])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-iclb: NOTRUN -> [SKIP][32] ([i915#5286])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@[email protected]
* igt@kms_big_fb@linear-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][33] ([fdo#111614])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3777]) +3 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl1/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][35] ([i915#3763])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl1/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3777]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl5/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-addfb:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111615]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][38] ([i915#3743]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl9/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#110723])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl1/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#3689]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#3689] / [i915#3886]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3886]) +10 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl1/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#109278] / [i915#3886])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-random-ccs-data-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][45] ([fdo#111615] / [i915#3689]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@kms_ccs@pipe-d-random-ccs-data-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-audio-edid:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#109284] / [fdo#111827]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-iclb: NOTRUN -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@[email protected]
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +16 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl1/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +6 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl1/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#1063])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109279] / [i915#3359])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][52] ([i915#3319])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109278] / [fdo#109279]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-32x10-random:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#3359])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x170-random:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109278])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb8/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-skl: NOTRUN -> [SKIP][56] ([fdo#109271]) +256 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl9/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-skl: [PASS][57] -> [FAIL][58] ([i915#2346])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-skl7/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl3/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
- shard-tglb: NOTRUN -> [SKIP][59] ([i915#4103]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-4tiled:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271]) +63 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#5287]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][62] -> [INCOMPLETE][63] ([i915#180])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl3/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl4/igt@[email protected]
* igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][64] -> [FAIL][65] ([i915#2122])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-glk6/igt@kms_flip@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][66] -> [DMESG-WARN][67] ([i915#180]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-apl8/igt@kms_flip@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][68] -> [DMESG-WARN][69] ([i915#180])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl4/igt@kms_flip@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl4/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-skl: NOTRUN -> [INCOMPLETE][70] ([i915#3701])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][71] -> [SKIP][72] ([i915#3701])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109280]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109280] / [fdo#111825]) +7 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb1/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-edp-1-pipe-a:
- shard-skl: NOTRUN -> [FAIL][75] ([i915#1188])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl5/igt@kms_hdr@[email protected]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#533]) +4 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-skl: NOTRUN -> [FAIL][77] ([fdo#108145] / [i915#265])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl5/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][78] -> [FAIL][79] ([fdo#108145] / [i915#265]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-skl8/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl10/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][80] ([fdo#111615] / [fdo#112054])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@[email protected]
* igt@kms_plane_lowres@pipe-d-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#3536])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#658]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl1/igt@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-kbl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#658])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl1/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][84] -> [SKIP][85] ([fdo#109441]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][86] ([i915#132] / [i915#3467]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb1/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: NOTRUN -> [SKIP][87] ([fdo#109441])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@kms_psr@psr2_sprite_render.html
* igt@kms_setmode@clone-exclusive-crtc:
- shard-tglb: NOTRUN -> [SKIP][88] ([i915#3555])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb1/igt@[email protected]
* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#112283])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@perf_pmu@[email protected]
* igt@prime_nv_api@i915_self_import:
- shard-tglb: NOTRUN -> [SKIP][90] ([fdo#109291])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@prime_nv_api@i915_self_import.html
* igt@prime_udl:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109291])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@prime_udl.html
* igt@sysfs_clients@fair-1:
- shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2994])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl5/igt@[email protected]
* igt@sysfs_clients@sema-10:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#2994]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb5/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][94] ([i915#4525]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb6/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][96] ([i915#2842]) -> [PASS][97] +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-apl3/igt@gem_exec_fair@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-apl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [FAIL][98] ([i915#2842]) -> [PASS][99] +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl1/igt@gem_exec_fair@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-batch-kernel-default-wb:
- shard-snb: [SKIP][100] ([fdo#109271]) -> [PASS][101] +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-snb6/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-snb2/igt@[email protected]
* igt@gem_mmap_gtt@flink-race:
- {shard-rkl}: [INCOMPLETE][102] ([i915#5080]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-5/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-2/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][104] ([i915#4939] / [i915#5230]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-skl1/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl6/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][106] ([i915#180]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl4/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl7/igt@[email protected]
* igt@i915_pm_rpm@gem-pread:
- {shard-rkl}: [SKIP][108] ([fdo#109308]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-2/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][110] ([i915#2521]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-skl8/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl10/igt@[email protected]
* igt@kms_atomic@test-only:
- {shard-rkl}: [SKIP][112] ([i915#1845] / [i915#4098]) -> [PASS][113] +26 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-5/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@linear-16bpp-rotate-0:
- {shard-tglu}: [DMESG-WARN][114] ([i915#402]) -> [PASS][115] +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-tglu-5/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglu-3/igt@[email protected]
* igt@kms_color@pipe-a-ctm-max:
- {shard-rkl}: [SKIP][116] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][117] +2 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-2/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement:
- {shard-rkl}: [SKIP][118] ([fdo#112022] / [i915#4070]) -> [PASS][119] +7 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-5/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge:
- {shard-rkl}: [SKIP][120] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][121] +5 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-5/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [FAIL][122] ([i915#2346] / [i915#533]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-skl: [FAIL][124] ([i915#2346]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-skl4/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl10/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- {shard-rkl}: [SKIP][126] ([fdo#111825] / [i915#4070]) -> [PASS][127] +3 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-5/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@[email protected]
* igt@kms_dp_aux_dev:
- {shard-rkl}: [SKIP][128] ([i915#1257]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-2/igt@kms_dp_aux_dev.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@kms_dp_aux_dev.html
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-ytiled:
- {shard-rkl}: [SKIP][130] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][131] +5 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-2/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][132] ([i915#4767]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-apl6/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-apl1/igt@[email protected]
* igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset@d-edp1:
- shard-tglb: [INCOMPLETE][134] -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-tglb6/igt@kms_flip@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-tglb3/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling:
- {shard-rkl}: [INCOMPLETE][136] ([i915#3701]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc:
- {shard-rkl}: [SKIP][138] ([i915#1849] / [i915#4098]) -> [PASS][139] +24 similar issues
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_plane@plane-panning-top-left@pipe-b-planes:
- {shard-rkl}: [SKIP][140] ([i915#1849] / [i915#3558]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-2/igt@kms_plane@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-75@pipe-b-edp-1-downscale-with-pixel-format:
- shard-iclb: [INCOMPLETE][142] ([i915#5293]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-75@pipe-b-edp-1-downscale-with-pixel-format.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-75@pipe-b-edp-1-downscale-with-pixel-format.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping:
- shard-iclb: [SKIP][144] ([i915#5176]) -> [PASS][145] +1 similar issue
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb4/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping.html
* igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format:
- shard-iclb: [INCOMPLETE][146] ([i915#5395]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb2/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb3/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [SKIP][148] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][149]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb6/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb2/igt@[email protected]
* igt@kms_psr@cursor_render:
- {shard-rkl}: [SKIP][150] ([i915#1072]) -> [PASS][151]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-rkl-2/igt@kms_psr@cursor_render.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-rkl-6/igt@kms_psr@cursor_render.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][152] ([fdo#109441]) -> [PASS][153] +2 similar issues
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb3/igt@kms_psr@psr2_dpms.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb2/igt@kms_psr@psr2_dpms.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [DMESG-WARN][154] ([i915#5614]) -> [SKIP][155] ([i915#4525])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb2/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb6/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][156] ([i915#4525]) -> [DMESG-WARN][157] ([i915#5614])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb3/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb4/igt@[email protected]
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][158] ([i915#2842]) -> [FAIL][159] ([i915#2852])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-iclb5/igt@gem_exec_fair@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-iclb5/igt@gem_exec_fair@[email protected]
* igt@kms_flip@2x-flip-vs-fences:
- shard-skl: [SKIP][160] ([fdo#109271] / [i915#1888]) -> [SKIP][161] ([fdo#109271]) +1 similar issue
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-skl2/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-skl8/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][162], [FAIL][163], [FAIL][164], [FAIL][165], [FAIL][166], [FAIL][167], [FAIL][168], [FAIL][169], [FAIL][170], [FAIL][171], [FAIL][172], [FAIL][173]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][174], [FAIL][175], [FAIL][176], [FAIL][177], [FAIL][178], [FAIL][179], [FAIL][180], [FAIL][181], [FAIL][182], [FAIL][183], [FAIL][184]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl4/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl1/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl4/igt@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl1/igt@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl6/igt@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl1/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl4/igt@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl1/igt@[email protected]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl4/igt@[email protected]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl4/igt@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl6/igt@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11503/shard-kbl4/igt@[email protected]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl4/igt@[email protected]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl4/igt@[email protected]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl4/igt@[email protected]
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl7/igt@[email protected]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl7/igt@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl3/igt@[email protected]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl4/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl3/igt@[email protected]
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl1/igt@[email protected]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl3/igt@[email protected]
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/shard-kbl3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#5080]: https://gitlab.freedesktop.org/drm/intel/issues/5080
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5230]: https://gitlab.freedesktop.org/drm/intel/issues/5230
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5293]: https://gitlab.freedesktop.org/drm/intel/issues/5293
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5395]: https://gitlab.freedesktop.org/drm/intel/issues/5395
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* CI: None -> CI-20190529
* Linux: CI_DRM_11503 -> Patchwork_102719v1
CI-20190529: 20190529
CI_DRM_11503: 000a595e443e99065d0ea00993a60eef24276e5f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6437: ea0144ed6ccb66b977f204b4d53b6062ed1cc8bc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102719v1: 000a595e443e99065d0ea00993a60eef24276e5f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v1/index.html
PATCH v2 1/18 drm/i915: Move per-platform power well hooks to intel_display_power_well.c
In reply to Imre DeakMove the implementation of platform specific power well hooks to intel_display_power_well.c, to reduce the clutter in intel_display_power.c.
The locking of all the power domain/power well state is handled in the power domain functions in intel_display_power.c using i915_power_domains::lock. This patch also moves the chy_phy_powergate_ch/lanes() functions to intel_display_power_well.c which borrow the same lock to protect the DISPLAY_PHY_CONTROL register state, which the HW uses both for toggling power wells and power gating PHY lanes.
No functional change.
v2:
- Clarify in the commit log why CHV functions using the i915_power_domains::lock were moved, while others locking the power domain/well state were kept in intel_display_power.c . (Jouni)
- Move forward declaration of chv_phy_powergate_ch/lanes() to intel_display_power_well.h .
v3:
- Rebase on drm-tip.
--- .../drm/i915/display/intel_display_power.c | 1747 ---------------- .../drm/i915/display/intel_display_power.h | 5 - .../i915/display/intel_display_power_well.c | 1792 +++++++++++++++++ .../i915/display/intel_display_power_well.h | 62 +- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 1 + drivers/gpu/drm/i915/display/intel_pps.c | 1 + 6 files changed, 1821 insertions(+), 1787 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +0 -1747
@@ -9,24 +9,16 @@#include "i915_irq.h" #include "intel_cdclk.h" #include "intel_combo_phy.h" -#include "intel_combo_phy_regs.h" -#include "intel_crt.h" #include "intel_de.h" #include "intel_display_power.h" #include "intel_display_power_well.h" #include "intel_display_types.h" #include "intel_dmc.h" -#include "intel_dpio_phy.h" -#include "intel_dpll.h" -#include "intel_hotplug.h" #include "intel_mchbar_regs.h" #include "intel_pch_refclk.h" #include "intel_pcode.h" #include "intel_pm.h" -#include "intel_pps.h" #include "intel_snps_phy.h" -#include "intel_tc.h" -#include "intel_vga.h" #include "vlv_sideband.h" const char *
@@ -235,604 +227,6 @@ bool intel_display_power_is_enabled(struct drm_i915_private *dev_priv,return ret; } -/* -* Starting with Haswell, we have a "Power Down Well" that can be turned off -* when not needed anymore. We have 4 registers that can request the power well -* to be enabled, and it will only be disabled if none of the registers is -* requesting it to be enabled. -*/ -static void hsw_power_well_post_enable (struct drm_i915_private *dev_priv, -u8 irq_pipe_mask,bool has_vga) -{ -if (has_vga) -intel_vga_reset_io_mem (dev_priv); - -if (irq_pipe_mask) -gen8_irq_power_well_post_enable (dev_priv, irq_pipe_mask); -} - -static void hsw_power_well_pre_disable (struct drm_i915_private *dev_priv, -u8 irq_pipe_mask) -{ -if (irq_pipe_mask) -gen8_irq_power_well_pre_disable (dev_priv, irq_pipe_mask); -} - -#define ICL_AUX_PW_TO_CH (pw_idx) \ - ((pw_idx) - ICL_PW_CTL_IDX_AUX_A + AUX_CH_A) - -#define ICL_TBT_AUX_PW_TO_CH (pw_idx) \ - ((pw_idx) - ICL_PW_CTL_IDX_AUX_TBT1 + AUX_CH_C) - -static enum aux_ch icl_aux_pw_to_ch (const struct i915_power_well *power_well) -{ -int pw_idx = power_well->desc->hsw.idx; - -return power_well->desc->hsw.is_tc_tbt ?ICL_TBT_AUX_PW_TO_CH (pw_idx) : -ICL_AUX_PW_TO_CH (pw_idx); -} - -static struct intel_digital_port * -aux_ch_to_digital_port (struct drm_i915_private *dev_priv, -enum aux_ch aux_ch) -{ -struct intel_digital_port *dig_port =NULL ; -struct intel_encoder *encoder; - -for_each_intel_encoder (&dev_priv->drm, encoder) { -/* We'll check the MST primary port */ -if (encoder->type ==INTEL_OUTPUT_DP_MST ) -continue ; - - dig_port =enc_to_dig_port (encoder); -if (!dig_port) -continue ; - -if (dig_port->aux_ch != aux_ch) { - dig_port =NULL ; -continue ; - } - -break ; - } - -return dig_port; -} - -static enum phy icl_aux_pw_to_phy (struct drm_i915_private *i915, -const struct i915_power_well *power_well) -{ -enum aux_ch aux_ch =icl_aux_pw_to_ch (power_well); -struct intel_digital_port *dig_port =aux_ch_to_digital_port (i915, aux_ch); - -return intel_port_to_phy (i915, dig_port->base.port); -} - -static void hsw_wait_for_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well, -bool timeout_expected) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -int enable_delay = power_well->desc->hsw.fixed_enable_delay; - -/* -* For some power wells we're not supposed to watch the status bit for -* an ack, but rather just wait a fixed amount of time and then -* proceed. This is only used on DG2. -*/ -if (IS_DG2 (dev_priv) && enable_delay) { -usleep_range (enable_delay,2 * enable_delay); -return ; - } - -/* Timeout for PW1:10 us, AUX:not specified, other PWs:20 us. */ -if (intel_de_wait_for_set (dev_priv, regs->driver, -HSW_PWR_WELL_CTL_STATE (pw_idx),1 )) { -drm_dbg_kms (&dev_priv->drm,"%s power well enable timeout\n" , -intel_power_well_name (power_well)); - -drm_WARN_ON (&dev_priv->drm, !timeout_expected); - - } -} - -static u32 hsw_power_well_requesters (struct drm_i915_private *dev_priv, -const struct i915_power_well_regs *regs, -int pw_idx) -{ -u32 req_mask =HSW_PWR_WELL_CTL_REQ (pw_idx); -u32 ret; - - ret =intel_de_read (dev_priv, regs->bios) & req_mask ?1 :0 ; - ret |=intel_de_read (dev_priv, regs->driver) & req_mask ?2 :0 ; -if (regs->kvmr.reg) - ret |=intel_de_read (dev_priv, regs->kvmr) & req_mask ?4 :0 ; - ret |=intel_de_read (dev_priv, regs->debug) & req_mask ?8 :0 ; - -return ret; -} - -static void hsw_wait_for_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -bool disabled; -u32 reqs; - -/* -* Bspec doesn't require waiting for PWs to get disabled, but still do -* this for paranoia. The known cases where a PW will be forced on: -* - a KVMR request on any power well via the KVMR request register -* - a DMC request on PW1 and MISC_IO power wells via the BIOS and -* DEBUG request registers -* Skip the wait in case any of the request bits are set and print a -* diagnostic message. -*/ -wait_for ((disabled = !(intel_de_read (dev_priv, regs->driver) & -HSW_PWR_WELL_CTL_STATE (pw_idx))) || - (reqs =hsw_power_well_requesters (dev_priv, regs, pw_idx)),1 ); -if (disabled) -return ; - -drm_dbg_kms (&dev_priv->drm, -"%s forced on (bios:%d driver:%d kvmr:%d debug:%d)\n" , -intel_power_well_name (power_well), - !!(reqs &1 ), !!(reqs &2 ), !!(reqs &4 ), !!(reqs &8 )); -} - -static void gen9_wait_for_power_well_fuses (struct drm_i915_private *dev_priv, -enum skl_power_gate pg) -{ -/* Timeout 5us for PG#0, for other PGs 1us */ -drm_WARN_ON (&dev_priv->drm, -intel_de_wait_for_set (dev_priv,SKL_FUSE_STATUS , -SKL_FUSE_PG_DIST_STATUS (pg),1 )); -} - -static void hsw_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -u32 val; - -if (power_well->desc->hsw.has_fuses) { -enum skl_power_gate pg; - - pg =DISPLAY_VER (dev_priv) >=11 ?ICL_PW_CTL_IDX_TO_PG (pw_idx) : -SKL_PW_CTL_IDX_TO_PG (pw_idx); - -/* Wa_16013190616:adlp */ -if (IS_ALDERLAKE_P (dev_priv) && pg ==SKL_PG1 ) -intel_de_rmw (dev_priv,GEN8_CHICKEN_DCPR_1 ,0 ,DISABLE_FLR_SRC ); - -/* -* For PW1 we have to wait both for the PW0/PG0 fuse state -* before enabling the power well and PW1/PG1's own fuse -* state after the enabling. For all other power wells with -* fuses we only have to wait for that PW/PG's fuse state -* after the enabling. -*/ -if (pg ==SKL_PG1 ) -gen9_wait_for_power_well_fuses (dev_priv,SKL_PG0 ); - } - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val |HSW_PWR_WELL_CTL_REQ (pw_idx)); - -hsw_wait_for_power_well_enable (dev_priv, power_well, false); - -if (power_well->desc->hsw.has_fuses) { -enum skl_power_gate pg; - - pg =DISPLAY_VER (dev_priv) >=11 ?ICL_PW_CTL_IDX_TO_PG (pw_idx) : -SKL_PW_CTL_IDX_TO_PG (pw_idx); -gen9_wait_for_power_well_fuses (dev_priv, pg); - } - -hsw_power_well_post_enable (dev_priv, - power_well->desc->hsw.irq_pipe_mask, - power_well->desc->hsw.has_vga); -} - -static void hsw_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -u32 val; - -hsw_power_well_pre_disable (dev_priv, - power_well->desc->hsw.irq_pipe_mask); - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val & ~HSW_PWR_WELL_CTL_REQ (pw_idx)); -hsw_wait_for_power_well_disable (dev_priv, power_well); -} - -static void -icl_combo_phy_aux_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -enum phy phy =icl_aux_pw_to_phy (dev_priv, power_well); -u32 val; - -drm_WARN_ON (&dev_priv->drm, !IS_ICELAKE (dev_priv)); - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val |HSW_PWR_WELL_CTL_REQ (pw_idx)); - -if (DISPLAY_VER (dev_priv) <12 ) { - val =intel_de_read (dev_priv,ICL_PORT_CL_DW12 (phy)); -intel_de_write (dev_priv,ICL_PORT_CL_DW12 (phy), - val |ICL_LANE_ENABLE_AUX ); - } - -hsw_wait_for_power_well_enable (dev_priv, power_well, false); - -/* Display WA #1178: icl */ -if (pw_idx >=ICL_PW_CTL_IDX_AUX_A && pw_idx <=ICL_PW_CTL_IDX_AUX_B && - !intel_bios_is_port_edp (dev_priv, (enum port )phy)) { - val =intel_de_read (dev_priv,ICL_AUX_ANAOVRD1 (pw_idx)); - val |=ICL_AUX_ANAOVRD1_ENABLE |ICL_AUX_ANAOVRD1_LDO_BYPASS ; -intel_de_write (dev_priv,ICL_AUX_ANAOVRD1 (pw_idx), val); - } -} - -static void -icl_combo_phy_aux_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -enum phy phy =icl_aux_pw_to_phy (dev_priv, power_well); -u32 val; - -drm_WARN_ON (&dev_priv->drm, !IS_ICELAKE (dev_priv)); - - val =intel_de_read (dev_priv,ICL_PORT_CL_DW12 (phy)); -intel_de_write (dev_priv,ICL_PORT_CL_DW12 (phy), - val & ~ICL_LANE_ENABLE_AUX ); - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val & ~HSW_PWR_WELL_CTL_REQ (pw_idx)); - -hsw_wait_for_power_well_disable (dev_priv, power_well); -} - -#if IS_ENABLED (CONFIG_DRM_I915_DEBUG_RUNTIME_PM ) - -static void icl_tc_port_assert_ref_held (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well, -struct intel_digital_port *dig_port) -{ -if (drm_WARN_ON (&dev_priv->drm, !dig_port)) -return ; - -if (DISPLAY_VER (dev_priv) ==11 &&intel_tc_cold_requires_aux_pw (dig_port)) -return ; - -drm_WARN_ON (&dev_priv->drm, !intel_tc_port_ref_held (dig_port)); -} - -#else - -static void icl_tc_port_assert_ref_held (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well, -struct intel_digital_port *dig_port) -{ -} - -#endif - -#define TGL_AUX_PW_TO_TC_PORT (pw_idx) ((pw_idx) - TGL_PW_CTL_IDX_AUX_TC1) - -static void icl_tc_cold_exit (struct drm_i915_private *i915) -{ -int ret, tries =0 ; - -while (1 ) { - ret =snb_pcode_write_timeout (i915,ICL_PCODE_EXIT_TCCOLD ,0 , -250 ,1 ); -if (ret != -EAGAIN || ++tries ==3 ) -break ; -msleep (1 ); - } - -/* Spec states that TC cold exit can take up to 1ms to complete */ -if (!ret) -msleep (1 ); - -/* TODO: turn failure into a error as soon i915 CI updates ICL IFWI */ -drm_dbg_kms (&i915->drm,"TC cold block %s\n" , ret ?"failed" : -"succeeded" ); -} - -static void -icl_tc_phy_aux_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum aux_ch aux_ch =icl_aux_pw_to_ch (power_well); -struct intel_digital_port *dig_port =aux_ch_to_digital_port (dev_priv, aux_ch); -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -bool is_tbt = power_well->desc->hsw.is_tc_tbt; -bool timeout_expected; -u32 val; - -icl_tc_port_assert_ref_held (dev_priv, power_well, dig_port); - - val =intel_de_read (dev_priv,DP_AUX_CH_CTL (aux_ch)); - val &= ~DP_AUX_CH_CTL_TBT_IO ; -if (is_tbt) - val |=DP_AUX_CH_CTL_TBT_IO ; -intel_de_write (dev_priv,DP_AUX_CH_CTL (aux_ch), val); - - val =intel_de_read (dev_priv, regs->driver); -intel_de_write (dev_priv, regs->driver, - val |HSW_PWR_WELL_CTL_REQ (power_well->desc->hsw.idx)); - -/* -* An AUX timeout is expected if the TBT DP tunnel is down, -* or need to enable AUX on a legacy TypeC port as part of the TC-cold -* exit sequence. -*/ - timeout_expected = is_tbt ||intel_tc_cold_requires_aux_pw (dig_port); -if (DISPLAY_VER (dev_priv) ==11 &&intel_tc_cold_requires_aux_pw (dig_port)) -icl_tc_cold_exit (dev_priv); - -hsw_wait_for_power_well_enable (dev_priv, power_well, timeout_expected); - -if (DISPLAY_VER (dev_priv) >=12 && !is_tbt) { -enum tc_port tc_port; - - tc_port =TGL_AUX_PW_TO_TC_PORT (power_well->desc->hsw.idx); -intel_de_write (dev_priv,HIP_INDEX_REG (tc_port), -HIP_INDEX_VAL (tc_port,0x2 )); - -if (intel_de_wait_for_set (dev_priv,DKL_CMN_UC_DW_27 (tc_port), -DKL_CMN_UC_DW27_UC_HEALTH ,1 )) -drm_warn (&dev_priv->drm, -"Timeout waiting TC uC health\n" ); - } -} - -static void -icl_aux_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum phy phy =icl_aux_pw_to_phy (dev_priv, power_well); - -if (intel_phy_is_tc (dev_priv, phy)) -return icl_tc_phy_aux_power_well_enable (dev_priv, power_well); -else if (IS_ICELAKE (dev_priv)) -return icl_combo_phy_aux_power_well_enable (dev_priv, - power_well); -else -return hsw_power_well_enable (dev_priv, power_well); -} - -static void -icl_aux_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum phy phy =icl_aux_pw_to_phy (dev_priv, power_well); - -if (intel_phy_is_tc (dev_priv, phy)) -return hsw_power_well_disable (dev_priv, power_well); -else if (IS_ICELAKE (dev_priv)) -return icl_combo_phy_aux_power_well_disable (dev_priv, - power_well); -else -return hsw_power_well_disable (dev_priv, power_well); -} - -/* -* We should only use the power well if we explicitly asked the hardware to -* enable it, so check if it's enabled and also check if we've requested it to -* be enabled. -*/ -static bool hsw_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -enum i915_power_well_id id = power_well->desc->id; -int pw_idx = power_well->desc->hsw.idx; -u32 mask =HSW_PWR_WELL_CTL_REQ (pw_idx) | -HSW_PWR_WELL_CTL_STATE (pw_idx); -u32 val; - - val =intel_de_read (dev_priv, regs->driver); - -/* -* On GEN9 big core due to a DMC bug the driver's request bits for PW1 -* and the MISC_IO PW will be not restored, so check instead for the -* BIOS's own request bits, which are forced-on for these power wells -* when exiting DC5/6. -*/ -if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv) && - (id ==SKL_DISP_PW_1 || id ==SKL_DISP_PW_MISC_IO )) - val |=intel_de_read (dev_priv, regs->bios); - -return (val & mask) == mask; -} - -static void assert_can_enable_dc9 (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm, - (intel_de_read (dev_priv,DC_STATE_EN ) &DC_STATE_EN_DC9 ), -"DC9 already programmed to be enabled.\n" ); -drm_WARN_ONCE (&dev_priv->drm, -intel_de_read (dev_priv,DC_STATE_EN ) & -DC_STATE_EN_UPTO_DC5 , -"DC5 still not disabled to enable DC9.\n" ); -drm_WARN_ONCE (&dev_priv->drm, -intel_de_read (dev_priv,HSW_PWR_WELL_CTL2 ) & -HSW_PWR_WELL_CTL_REQ (SKL_PW_CTL_IDX_PW_2 ), -"Power well 2 on.\n" ); -drm_WARN_ONCE (&dev_priv->drm,intel_irqs_enabled (dev_priv), -"Interrupts not disabled yet.\n" ); - -/* -* TODO: check for the following to verify the conditions to enter DC9 -* state are satisfied: -* 1] Check relevant display engine registers to verify if mode set -* disable sequence was followed. -* 2] Check if display uninitialize sequence is initialized. -*/ -} - -static void assert_can_disable_dc9 (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm,intel_irqs_enabled (dev_priv), -"Interrupts not disabled yet.\n" ); -drm_WARN_ONCE (&dev_priv->drm, -intel_de_read (dev_priv,DC_STATE_EN ) & -DC_STATE_EN_UPTO_DC5 , -"DC5 still not disabled.\n" ); - -/* -* TODO: check for the following to verify DC9 state was indeed -* entered before programming to disable it: -* 1] Check relevant display engine registers to verify if mode -* set disable sequence was followed. -* 2] Check if display uninitialize sequence is initialized. -*/ -} - -static void gen9_write_dc_state (struct drm_i915_private *dev_priv, -u32 state) -{ -int rewrites =0 ; -int rereads =0 ; -u32 v; - -intel_de_write (dev_priv,DC_STATE_EN , state); - -/* It has been observed that disabling the dc6 state sometimes -* doesn't stick and dmc keeps returning old value. Make sure -* the write really sticks enough times and also force rewrite until -* we are confident that state is exactly what we want. -*/ -do { - v =intel_de_read (dev_priv,DC_STATE_EN ); - -if (v != state) { -intel_de_write (dev_priv,DC_STATE_EN , state); - rewrites++; - rereads =0 ; - }else if (rereads++ >5 ) { -break ; - } - - }while (rewrites <100 ); - -if (v != state) -drm_err (&dev_priv->drm, -"Writing dc state to 0x%x failed, now 0x%x\n" , - state, v); - -/* Most of the times we need one retry, avoid spam */ -if (rewrites >1 ) -drm_dbg_kms (&dev_priv->drm, -"Rewrote dc state to 0x%x %d times\n" , - state, rewrites); -} - -static u32 gen9_dc_mask (struct drm_i915_private *dev_priv) -{ -u32 mask; - - mask =DC_STATE_EN_UPTO_DC5 ; - -if (DISPLAY_VER (dev_priv) >=12 ) - mask |=DC_STATE_EN_DC3CO |DC_STATE_EN_UPTO_DC6 - |DC_STATE_EN_DC9 ; -else if (DISPLAY_VER (dev_priv) ==11 ) - mask |=DC_STATE_EN_UPTO_DC6 |DC_STATE_EN_DC9 ; -else if (IS_GEMINILAKE (dev_priv) ||IS_BROXTON (dev_priv)) - mask |=DC_STATE_EN_DC9 ; -else - mask |=DC_STATE_EN_UPTO_DC6 ; - -return mask; -} - -static void gen9_sanitize_dc_state (struct drm_i915_private *dev_priv) -{ -u32 val; - -if (!HAS_DISPLAY (dev_priv)) -return ; - - val =intel_de_read (dev_priv,DC_STATE_EN ) &gen9_dc_mask (dev_priv); - -drm_dbg_kms (&dev_priv->drm, -"Resetting DC state tracking from %02x to %02x\n" , - dev_priv->dmc.dc_state, val); - dev_priv->dmc.dc_state = val; -} - -/** -* gen9_set_dc_state - set target display C power state -* @dev_priv: i915 device instance -* @state: target DC power state -* - DC_STATE_DISABLE -* - DC_STATE_EN_UPTO_DC5 -* - DC_STATE_EN_UPTO_DC6 -* - DC_STATE_EN_DC9 -* -* Signal to DMC firmware/HW the target DC power state passed in @state. -* DMC/HW can turn off individual display clocks and power rails when entering -* a deeper DC power state (higher in number) and turns these back when exiting -* that state to a shallower power state (lower in number). The HW will decide -* when to actually enter a given state on an on-demand basis, for instance -* depending on the active state of display pipes. The state of display -* registers backed by affected power rails are saved/restored as needed. -* -* Based on the above enabling a deeper DC power state is asynchronous wrt. -* enabling it. Disabling a deeper power state is synchronous: for instance -* setting %DC_STATE_DISABLE won't complete until all HW resources are turned -* back on and register state is restored. This is guaranteed by the MMIO write -* to DC_STATE_EN blocking until the state is restored. -*/ -static void gen9_set_dc_state (struct drm_i915_private *dev_priv,u32 state) -{ -u32 val; -u32 mask; - -if (!HAS_DISPLAY (dev_priv)) -return ; - -if (drm_WARN_ON_ONCE (&dev_priv->drm, - state & ~dev_priv->dmc.allowed_dc_mask)) - state &= dev_priv->dmc.allowed_dc_mask; - - val =intel_de_read (dev_priv,DC_STATE_EN ); - mask =gen9_dc_mask (dev_priv); -drm_dbg_kms (&dev_priv->drm,"Setting DC state from %02x to %02x\n" , - val & mask, state); - -/* Check if DMC is ignoring our DC state requests */ -if ((val & mask) != dev_priv->dmc.dc_state) -drm_err (&dev_priv->drm,"DC state mismatch (0x%x -> 0x%x)\n" , - dev_priv->dmc.dc_state, val & mask); - - val &= ~mask; - val |= state; - -gen9_write_dc_state (dev_priv, val); - - dev_priv->dmc.dc_state = val & mask; -} -static u32 sanitize_target_dc_state (struct drm_i915_private *dev_priv,u32 target_dc_state)
@@ -858,53 +252,6 @@ sanitize_target_dc_state(struct drm_i915_private *dev_priv,return target_dc_state; } -static void tgl_enable_dc3co (struct drm_i915_private *dev_priv) -{ -drm_dbg_kms (&dev_priv->drm,"Enabling DC3CO\n" ); -gen9_set_dc_state (dev_priv,DC_STATE_EN_DC3CO ); -} - -static void tgl_disable_dc3co (struct drm_i915_private *dev_priv) -{ -u32 val; - -drm_dbg_kms (&dev_priv->drm,"Disabling DC3CO\n" ); - val =intel_de_read (dev_priv,DC_STATE_EN ); - val &= ~DC_STATE_DC3CO_STATUS ; -intel_de_write (dev_priv,DC_STATE_EN , val); -gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); -/* -* Delay of 200us DC3CO Exit time B.Spec 49196 -*/ -usleep_range (200 ,210 ); -} - -static void bxt_enable_dc9 (struct drm_i915_private *dev_priv) -{ -assert_can_enable_dc9 (dev_priv); - -drm_dbg_kms (&dev_priv->drm,"Enabling DC9\n" ); -/* -* Power sequencer reset is not needed on -* platforms with South Display Engine on PCH, -* because PPS registers are always on. -*/ -if (!HAS_PCH_SPLIT (dev_priv)) -intel_pps_reset_all (dev_priv); -gen9_set_dc_state (dev_priv,DC_STATE_EN_DC9 ); -} - -static void bxt_disable_dc9 (struct drm_i915_private *dev_priv) -{ -assert_can_disable_dc9 (dev_priv); - -drm_dbg_kms (&dev_priv->drm,"Disabling DC9\n" ); - -gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); - -intel_pps_unlock_regs_wa (dev_priv); -} -/** * intel_display_power_set_target_dc_state - Set target dc state. * @dev_priv: i915 device
@@ -949,912 +296,8 @@ void intel_display_power_set_target_dc_state(struct drm_i915_private *dev_priv,mutex_unlock (&power_domains->lock); } -static void assert_can_enable_dc5 (struct drm_i915_private *dev_priv) -{ -enum i915_power_well_id high_pg; - -/* Power wells at this level and above must be disabled for DC5 entry */ -if (DISPLAY_VER (dev_priv) ==12 ) - high_pg =ICL_DISP_PW_3 ; -else - high_pg =SKL_DISP_PW_2 ; - -drm_WARN_ONCE (&dev_priv->drm, -intel_display_power_well_is_enabled (dev_priv, high_pg), -"Power wells above platform's DC5 limit still enabled.\n" ); - -drm_WARN_ONCE (&dev_priv->drm, - (intel_de_read (dev_priv,DC_STATE_EN ) & -DC_STATE_EN_UPTO_DC5 ), -"DC5 already programmed to be enabled.\n" ); -assert_rpm_wakelock_held (&dev_priv->runtime_pm); - -assert_dmc_loaded (dev_priv); -} - -static void gen9_enable_dc5 (struct drm_i915_private *dev_priv) -{ -assert_can_enable_dc5 (dev_priv); - -drm_dbg_kms (&dev_priv->drm,"Enabling DC5\n" ); - -/* Wa Display #1183: skl,kbl,cfl */ -if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv)) -intel_de_write (dev_priv,GEN8_CHICKEN_DCPR_1 , -intel_de_read (dev_priv,GEN8_CHICKEN_DCPR_1 ) |SKL_SELECT_ALTERNATE_DC_EXIT ); - -gen9_set_dc_state (dev_priv,DC_STATE_EN_UPTO_DC5 ); -} - -static void assert_can_enable_dc6 (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm, -intel_de_read (dev_priv,UTIL_PIN_CTL ) &UTIL_PIN_ENABLE , -"Backlight is not disabled.\n" ); -drm_WARN_ONCE (&dev_priv->drm, - (intel_de_read (dev_priv,DC_STATE_EN ) & -DC_STATE_EN_UPTO_DC6 ), -"DC6 already programmed to be enabled.\n" ); - -assert_dmc_loaded (dev_priv); -} - -static void skl_enable_dc6 (struct drm_i915_private *dev_priv) -{ -assert_can_enable_dc6 (dev_priv); - -drm_dbg_kms (&dev_priv->drm,"Enabling DC6\n" ); - -/* Wa Display #1183: skl,kbl,cfl */ -if (DISPLAY_VER (dev_priv) ==9 && !IS_BROXTON (dev_priv)) -intel_de_write (dev_priv,GEN8_CHICKEN_DCPR_1 , -intel_de_read (dev_priv,GEN8_CHICKEN_DCPR_1 ) |SKL_SELECT_ALTERNATE_DC_EXIT ); - -gen9_set_dc_state (dev_priv,DC_STATE_EN_UPTO_DC6 ); -} - -static void hsw_power_well_sync_hw (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -const struct i915_power_well_regs *regs = power_well->desc->ops->regs; -int pw_idx = power_well->desc->hsw.idx; -u32 mask =HSW_PWR_WELL_CTL_REQ (pw_idx); -u32 bios_req =intel_de_read (dev_priv, regs->bios); - -/* Take over the request bit if set by BIOS. */ -if (bios_req & mask) { -u32 drv_req =intel_de_read (dev_priv, regs->driver); - -if (!(drv_req & mask)) -intel_de_write (dev_priv, regs->driver, drv_req | mask); -intel_de_write (dev_priv, regs->bios, bios_req & ~mask); - } -} - -static void bxt_dpio_cmn_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -bxt_ddi_phy_init (dev_priv, power_well->desc->bxt.phy); -} - -static void bxt_dpio_cmn_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -bxt_ddi_phy_uninit (dev_priv, power_well->desc->bxt.phy); -} - -static bool bxt_dpio_cmn_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -return bxt_ddi_phy_is_enabled (dev_priv, power_well->desc->bxt.phy); -} - -static void bxt_verify_ddi_phy_power_wells (struct drm_i915_private *dev_priv) -{ -struct i915_power_well *power_well; - - power_well =lookup_power_well (dev_priv,BXT_DISP_PW_DPIO_CMN_A ); -if (intel_power_well_refcount (power_well) >0 ) -bxt_ddi_phy_verify_state (dev_priv, power_well->desc->bxt.phy); - - power_well =lookup_power_well (dev_priv,VLV_DISP_PW_DPIO_CMN_BC ); -if (intel_power_well_refcount (power_well) >0 ) -bxt_ddi_phy_verify_state (dev_priv, power_well->desc->bxt.phy); - -if (IS_GEMINILAKE (dev_priv)) { - power_well =lookup_power_well (dev_priv, -GLK_DISP_PW_DPIO_CMN_C ); -if (intel_power_well_refcount (power_well) >0 ) -bxt_ddi_phy_verify_state (dev_priv, - power_well->desc->bxt.phy); - } -} - -static bool gen9_dc_off_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -return ((intel_de_read (dev_priv,DC_STATE_EN ) &DC_STATE_EN_DC3CO ) ==0 && - (intel_de_read (dev_priv,DC_STATE_EN ) &DC_STATE_EN_UPTO_DC5_DC6_MASK ) ==0 ); -} - -static void gen9_assert_dbuf_enabled (struct drm_i915_private *dev_priv) -{ -u8 hw_enabled_dbuf_slices =intel_enabled_dbuf_slices_mask (dev_priv); -u8 enabled_dbuf_slices = dev_priv->dbuf.enabled_slices; - -drm_WARN (&dev_priv->drm, - hw_enabled_dbuf_slices != enabled_dbuf_slices, -"Unexpected DBuf power power state (0x%08x, expected 0x%08x)\n" , - hw_enabled_dbuf_slices, - enabled_dbuf_slices); -} - -static void gen9_disable_dc_states (struct drm_i915_private *dev_priv) -{ -struct intel_cdclk_config cdclk_config = {}; - -if (dev_priv->dmc.target_dc_state ==DC_STATE_EN_DC3CO ) { -tgl_disable_dc3co (dev_priv); -return ; - } - -gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); - -if (!HAS_DISPLAY (dev_priv)) -return ; - -intel_cdclk_get_cdclk (dev_priv, &cdclk_config); -/* Can't read out voltage_level so can't use intel_cdclk_changed() */ -drm_WARN_ON (&dev_priv->drm, -intel_cdclk_needs_modeset (&dev_priv->cdclk.hw, - &cdclk_config)); - -gen9_assert_dbuf_enabled (dev_priv); - -if (IS_GEMINILAKE (dev_priv) ||IS_BROXTON (dev_priv)) -bxt_verify_ddi_phy_power_wells (dev_priv); - -if (DISPLAY_VER (dev_priv) >=11 ) -/* -* DMC retains HW context only for port A, the other combo -* PHY's HW context for port B is lost after DC transitions, -* so we need to restore it manually. -*/ -intel_combo_phy_init (dev_priv); -} - -static void gen9_dc_off_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -gen9_disable_dc_states (dev_priv); -} - -static void gen9_dc_off_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -if (!intel_dmc_has_payload (dev_priv)) -return ; - -switch (dev_priv->dmc.target_dc_state) { -case DC_STATE_EN_DC3CO : -tgl_enable_dc3co (dev_priv); -break ; -case DC_STATE_EN_UPTO_DC6 : -skl_enable_dc6 (dev_priv); -break ; -case DC_STATE_EN_UPTO_DC5 : -gen9_enable_dc5 (dev_priv); -break ; - } -} - -static void i9xx_power_well_sync_hw_noop (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -} - -static void i9xx_always_on_power_well_noop (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -} - -static bool i9xx_always_on_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -return true; -} - -static void i830_pipes_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -if ((intel_de_read (dev_priv,PIPECONF (PIPE_A )) &PIPECONF_ENABLE ) ==0 ) -i830_enable_pipe (dev_priv,PIPE_A ); -if ((intel_de_read (dev_priv,PIPECONF (PIPE_B )) &PIPECONF_ENABLE ) ==0 ) -i830_enable_pipe (dev_priv,PIPE_B ); -} - -static void i830_pipes_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -i830_disable_pipe (dev_priv,PIPE_B ); -i830_disable_pipe (dev_priv,PIPE_A ); -} - -static bool i830_pipes_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -return intel_de_read (dev_priv,PIPECONF (PIPE_A )) &PIPECONF_ENABLE && -intel_de_read (dev_priv,PIPECONF (PIPE_B )) &PIPECONF_ENABLE ; -} - -static void i830_pipes_power_well_sync_hw (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -if (intel_power_well_refcount (power_well) >0 ) -i830_pipes_power_well_enable (dev_priv, power_well); -else -i830_pipes_power_well_disable (dev_priv, power_well); -} - -static void vlv_set_power_well (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well,bool enable) -{ -int pw_idx = power_well->desc->vlv.idx; -u32 mask; -u32 state; -u32 ctrl; - - mask =PUNIT_PWRGT_MASK (pw_idx); - state = enable ?PUNIT_PWRGT_PWR_ON (pw_idx) : -PUNIT_PWRGT_PWR_GATE (pw_idx); - -vlv_punit_get (dev_priv); - -#define COND \ - ((vlv_punit_read(dev_priv, PUNIT_REG_PWRGT_STATUS) & mask) == state) - -if (COND ) - goto out; - - ctrl =vlv_punit_read (dev_priv,PUNIT_REG_PWRGT_CTRL ); - ctrl &= ~mask; - ctrl |= state; -vlv_punit_write (dev_priv,PUNIT_REG_PWRGT_CTRL , ctrl); - -if (wait_for (COND ,100 )) -drm_err (&dev_priv->drm, -"timeout setting power well state %08x (%08x)\n" , - state, -vlv_punit_read (dev_priv,PUNIT_REG_PWRGT_CTRL )); - -#undef COND - -out: -vlv_punit_put (dev_priv); -} - -static void vlv_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_set_power_well (dev_priv, power_well, true); -} - -static void vlv_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_set_power_well (dev_priv, power_well, false); -} - -static bool vlv_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -int pw_idx = power_well->desc->vlv.idx; -bool enabled = false; -u32 mask; -u32 state; -u32 ctrl; - - mask =PUNIT_PWRGT_MASK (pw_idx); - ctrl =PUNIT_PWRGT_PWR_ON (pw_idx); - -vlv_punit_get (dev_priv); - - state =vlv_punit_read (dev_priv,PUNIT_REG_PWRGT_STATUS ) & mask; -/* -* We only ever set the power-on and power-gate states, anything -* else is unexpected. -*/ -drm_WARN_ON (&dev_priv->drm, state !=PUNIT_PWRGT_PWR_ON (pw_idx) && - state !=PUNIT_PWRGT_PWR_GATE (pw_idx)); -if (state == ctrl) - enabled = true; - -/* -* A transient state at this point would mean some unexpected party -* is poking at the power controls too. -*/ - ctrl =vlv_punit_read (dev_priv,PUNIT_REG_PWRGT_CTRL ) & mask; -drm_WARN_ON (&dev_priv->drm, ctrl != state); - -vlv_punit_put (dev_priv); - -return enabled; -} - -static void vlv_init_display_clock_gating (struct drm_i915_private *dev_priv) -{ -u32 val; - -/* -* On driver load, a pipe may be active and driving a DSI display. -* Preserve DPOUNIT_CLOCK_GATE_DISABLE to avoid the pipe getting stuck -* (and never recovering) in this case. intel_dsi_post_disable() will -* clear it when we turn off the display. -*/ - val =intel_de_read (dev_priv,DSPCLK_GATE_D ); - val &=DPOUNIT_CLOCK_GATE_DISABLE ; - val |=VRHUNIT_CLOCK_GATE_DISABLE ; -intel_de_write (dev_priv,DSPCLK_GATE_D , val); - -/* -* Disable trickle feed and enable pnd deadline calculation -*/ -intel_de_write (dev_priv,MI_ARB_VLV , -MI_ARB_DISPLAY_TRICKLE_FEED_DISABLE ); -intel_de_write (dev_priv,CBR1_VLV ,0 ); - -drm_WARN_ON (&dev_priv->drm,RUNTIME_INFO (dev_priv)->rawclk_freq ==0 ); -intel_de_write (dev_priv,RAWCLK_FREQ_VLV , -DIV_ROUND_CLOSEST (RUNTIME_INFO (dev_priv)->rawclk_freq, -1000 )); -} - -static void vlv_display_power_well_init (struct drm_i915_private *dev_priv) -{ -struct intel_encoder *encoder; -enum pipe pipe; - -/* -* Enable the CRI clock source so we can get at the -* display and the reference clock for VGA -* hotplug / manual detection. Supposedly DSI also -* needs the ref clock up and running. -* -* CHV DPLL B/C have some issues if VGA mode is enabled. -*/ -for_each_pipe (dev_priv, pipe) { -u32 val =intel_de_read (dev_priv,DPLL (pipe)); - - val |=DPLL_REF_CLK_ENABLE_VLV |DPLL_VGA_MODE_DIS ; -if (pipe !=PIPE_A ) - val |=DPLL_INTEGRATED_CRI_CLK_VLV ; - -intel_de_write (dev_priv,DPLL (pipe), val); - } - -vlv_init_display_clock_gating (dev_priv); - -spin_lock_irq (&dev_priv->irq_lock); -valleyview_enable_display_irqs (dev_priv); -spin_unlock_irq (&dev_priv->irq_lock); - -/* -* During driver initialization/resume we can avoid restoring the -* part of the HW/SW state that will be inited anyway explicitly. -*/ -if (dev_priv->power_domains.initializing) -return ; - -intel_hpd_init (dev_priv); -intel_hpd_poll_disable (dev_priv); - -/* Re-enable the ADPA, if we have one */ -for_each_intel_encoder (&dev_priv->drm, encoder) { -if (encoder->type ==INTEL_OUTPUT_ANALOG ) -intel_crt_reset (&encoder->base); - } - -intel_vga_redisable_power_on (dev_priv); - -intel_pps_unlock_regs_wa (dev_priv); -} - -static void vlv_display_power_well_deinit (struct drm_i915_private *dev_priv) -{ -spin_lock_irq (&dev_priv->irq_lock); -valleyview_disable_display_irqs (dev_priv); -spin_unlock_irq (&dev_priv->irq_lock); - -/* make sure we're done processing display irqs */ -intel_synchronize_irq (dev_priv); - -intel_pps_reset_all (dev_priv); - -/* Prevent us from re-enabling polling on accident in late suspend */ -if (!dev_priv->drm.dev->power.is_suspended) -intel_hpd_poll_enable (dev_priv); -} - -static void vlv_display_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_set_power_well (dev_priv, power_well, true); - -vlv_display_power_well_init (dev_priv); -} - -static void vlv_display_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_display_power_well_deinit (dev_priv); - -vlv_set_power_well (dev_priv, power_well, false); -} - -static void vlv_dpio_cmn_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -/* since ref/cri clock was enabled */ -udelay (1 );/* >10ns for cmnreset, >0ns for sidereset */ - -vlv_set_power_well (dev_priv, power_well, true); - -/* -* From VLV2A0_DP_eDP_DPIO_driver_vbios_notes_10.docx - -* 6. De-assert cmn_reset/side_reset. Same as VLV X0. -* a. GUnit 0x2110 bit[0] set to 1 (def 0) -* b. The other bits such as sfr settings / modesel may all -* be set to 0. -* -* This should only be done on init and resume from S3 with -* both PLLs disabled, or we risk losing DPIO and PLL -* synchronization. -*/ -intel_de_write (dev_priv,DPIO_CTL , -intel_de_read (dev_priv,DPIO_CTL ) |DPIO_CMNRST ); -} - -static void vlv_dpio_cmn_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum pipe pipe; - -for_each_pipe (dev_priv, pipe) -assert_pll_disabled (dev_priv, pipe); - -/* Assert common reset */ -intel_de_write (dev_priv,DPIO_CTL , -intel_de_read (dev_priv,DPIO_CTL ) & ~DPIO_CMNRST ); - -vlv_set_power_well (dev_priv, power_well, false); -} -#define POWER_DOMAIN_MASK (GENMASK_ULL(POWER_DOMAIN_NUM - 1, 0)) -#define BITS_SET (val, bits) (((val) & (bits)) == (bits)) - -static void assert_chv_phy_status (struct drm_i915_private *dev_priv) -{ -struct i915_power_well *cmn_bc = -lookup_power_well (dev_priv,VLV_DISP_PW_DPIO_CMN_BC ); -struct i915_power_well *cmn_d = -lookup_power_well (dev_priv,CHV_DISP_PW_DPIO_CMN_D ); -u32 phy_control = dev_priv->chv_phy_control; -u32 phy_status =0 ; -u32 phy_status_mask =0xffffffff ; - -/* -* The BIOS can leave the PHY is some weird state -* where it doesn't fully power down some parts. -* Disable the asserts until the PHY has been fully -* reset (ie. the power well has been disabled at -* least once). -*/ -if (!dev_priv->chv_phy_assert[DPIO_PHY0 ]) - phy_status_mask &= ~(PHY_STATUS_CMN_LDO (DPIO_PHY0 ,DPIO_CH0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH0 ,0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH0 ,1 ) | -PHY_STATUS_CMN_LDO (DPIO_PHY0 ,DPIO_CH1 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH1 ,0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH1 ,1 )); - -if (!dev_priv->chv_phy_assert[DPIO_PHY1 ]) - phy_status_mask &= ~(PHY_STATUS_CMN_LDO (DPIO_PHY1 ,DPIO_CH0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY1 ,DPIO_CH0 ,0 ) | -PHY_STATUS_SPLINE_LDO (DPIO_PHY1 ,DPIO_CH0 ,1 )); - -if (intel_power_well_is_enabled (dev_priv, cmn_bc)) { - phy_status |=PHY_POWERGOOD (DPIO_PHY0 ); - -/* this assumes override is only used to enable lanes */ -if ((phy_control &PHY_CH_POWER_DOWN_OVRD_EN (DPIO_PHY0 ,DPIO_CH0 )) ==0 ) - phy_control |=PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH0 ); - -if ((phy_control &PHY_CH_POWER_DOWN_OVRD_EN (DPIO_PHY0 ,DPIO_CH1 )) ==0 ) - phy_control |=PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH1 ); - -/* CL1 is on whenever anything is on in either channel */ -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH0 ) | -PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH1 ))) - phy_status |=PHY_STATUS_CMN_LDO (DPIO_PHY0 ,DPIO_CH0 ); - -/* -* The DPLLB check accounts for the pipe B + port A usage -* with CL2 powered up but all the lanes in the second channel -* powered down. -*/ -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY0 ,DPIO_CH1 )) && - (intel_de_read (dev_priv,DPLL (PIPE_B )) &DPLL_VCO_ENABLE ) ==0 ) - phy_status |=PHY_STATUS_CMN_LDO (DPIO_PHY0 ,DPIO_CH1 ); - -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0x3 ,DPIO_PHY0 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH0 ,0 ); -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xc ,DPIO_PHY0 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH0 ,1 ); - -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0x3 ,DPIO_PHY0 ,DPIO_CH1 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH1 ,0 ); -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xc ,DPIO_PHY0 ,DPIO_CH1 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY0 ,DPIO_CH1 ,1 ); - } - -if (intel_power_well_is_enabled (dev_priv, cmn_d)) { - phy_status |=PHY_POWERGOOD (DPIO_PHY1 ); - -/* this assumes override is only used to enable lanes */ -if ((phy_control &PHY_CH_POWER_DOWN_OVRD_EN (DPIO_PHY1 ,DPIO_CH0 )) ==0 ) - phy_control |=PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY1 ,DPIO_CH0 ); - -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xf ,DPIO_PHY1 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_CMN_LDO (DPIO_PHY1 ,DPIO_CH0 ); - -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0x3 ,DPIO_PHY1 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY1 ,DPIO_CH0 ,0 ); -if (BITS_SET (phy_control, -PHY_CH_POWER_DOWN_OVRD (0xc ,DPIO_PHY1 ,DPIO_CH0 ))) - phy_status |=PHY_STATUS_SPLINE_LDO (DPIO_PHY1 ,DPIO_CH0 ,1 ); - } - - phy_status &= phy_status_mask; - -/* -* The PHY may be busy with some initial calibration and whatnot, -* so the power state can take a while to actually change. -*/ -if (intel_de_wait_for_register (dev_priv,DISPLAY_PHY_STATUS , - phy_status_mask, phy_status,10 )) -drm_err (&dev_priv->drm, -"Unexpected PHY_STATUS 0x%08x, expected 0x%08x (PHY_CONTROL=0x%08x)\n" , -intel_de_read (dev_priv,DISPLAY_PHY_STATUS ) & phy_status_mask, - phy_status, dev_priv->chv_phy_control); -} - -#undef BITS_SET - -static void chv_dpio_cmn_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum dpio_phy phy; -enum pipe pipe; -u32 tmp; - -drm_WARN_ON_ONCE (&dev_priv->drm, - power_well->desc->id !=VLV_DISP_PW_DPIO_CMN_BC && - power_well->desc->id !=CHV_DISP_PW_DPIO_CMN_D ); - -if (power_well->desc->id ==VLV_DISP_PW_DPIO_CMN_BC ) { - pipe =PIPE_A ; - phy =DPIO_PHY0 ; - }else { - pipe =PIPE_C ; - phy =DPIO_PHY1 ; - } - -/* since ref/cri clock was enabled */ -udelay (1 );/* >10ns for cmnreset, >0ns for sidereset */ -vlv_set_power_well (dev_priv, power_well, true); - -/* Poll for phypwrgood signal */ -if (intel_de_wait_for_set (dev_priv,DISPLAY_PHY_STATUS , -PHY_POWERGOOD (phy),1 )) -drm_err (&dev_priv->drm,"Display PHY %d is not power up\n" , - phy); - -vlv_dpio_get (dev_priv); - -/* Enable dynamic power down */ - tmp =vlv_dpio_read (dev_priv, pipe,CHV_CMN_DW28 ); - tmp |=DPIO_DYNPWRDOWNEN_CH0 |DPIO_CL1POWERDOWNEN | -DPIO_SUS_CLK_CONFIG_GATE_CLKREQ ; -vlv_dpio_write (dev_priv, pipe,CHV_CMN_DW28 , tmp); - -if (power_well->desc->id ==VLV_DISP_PW_DPIO_CMN_BC ) { - tmp =vlv_dpio_read (dev_priv, pipe, _CHV_CMN_DW6_CH1); - tmp |=DPIO_DYNPWRDOWNEN_CH1 ; -vlv_dpio_write (dev_priv, pipe, _CHV_CMN_DW6_CH1, tmp); - }else { -/* -* Force the non-existing CL2 off. BXT does this -* too, so maybe it saves some power even though -* CL2 doesn't exist? -*/ - tmp =vlv_dpio_read (dev_priv, pipe,CHV_CMN_DW30 ); - tmp |=DPIO_CL2_LDOFUSE_PWRENB ; -vlv_dpio_write (dev_priv, pipe,CHV_CMN_DW30 , tmp); - } - -vlv_dpio_put (dev_priv); - - dev_priv->chv_phy_control |=PHY_COM_LANE_RESET_DEASSERT (phy); -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); - -drm_dbg_kms (&dev_priv->drm, -"Enabled DPIO PHY%d (PHY_CONTROL=0x%08x)\n" , - phy, dev_priv->chv_phy_control); - -assert_chv_phy_status (dev_priv); -} - -static void chv_dpio_cmn_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum dpio_phy phy; - -drm_WARN_ON_ONCE (&dev_priv->drm, - power_well->desc->id !=VLV_DISP_PW_DPIO_CMN_BC && - power_well->desc->id !=CHV_DISP_PW_DPIO_CMN_D ); - -if (power_well->desc->id ==VLV_DISP_PW_DPIO_CMN_BC ) { - phy =DPIO_PHY0 ; -assert_pll_disabled (dev_priv,PIPE_A ); -assert_pll_disabled (dev_priv,PIPE_B ); - }else { - phy =DPIO_PHY1 ; -assert_pll_disabled (dev_priv,PIPE_C ); - } - - dev_priv->chv_phy_control &= ~PHY_COM_LANE_RESET_DEASSERT (phy); -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); - -vlv_set_power_well (dev_priv, power_well, false); - -drm_dbg_kms (&dev_priv->drm, -"Disabled DPIO PHY%d (PHY_CONTROL=0x%08x)\n" , - phy, dev_priv->chv_phy_control); - -/* PHY is fully reset now, so we can enable the PHY state asserts */ - dev_priv->chv_phy_assert[phy] = true; - -assert_chv_phy_status (dev_priv); -} - -static void assert_chv_phy_powergate (struct drm_i915_private *dev_priv,enum dpio_phy phy, -enum dpio_channel ch,bool override,unsigned int mask) -{ -enum pipe pipe = phy ==DPIO_PHY0 ?PIPE_A :PIPE_C ; -u32 reg, val, expected, actual; - -/* -* The BIOS can leave the PHY is some weird state -* where it doesn't fully power down some parts. -* Disable the asserts until the PHY has been fully -* reset (ie. the power well has been disabled at -* least once). -*/ -if (!dev_priv->chv_phy_assert[phy]) -return ; - -if (ch ==DPIO_CH0 ) - reg = _CHV_CMN_DW0_CH0; -else - reg = _CHV_CMN_DW6_CH1; - -vlv_dpio_get (dev_priv); - val =vlv_dpio_read (dev_priv, pipe, reg); -vlv_dpio_put (dev_priv); - -/* -* This assumes !override is only used when the port is disabled. -* All lanes should power down even without the override when -* the port is disabled. -*/ -if (!override || mask ==0xf ) { - expected =DPIO_ALLDL_POWERDOWN |DPIO_ANYDL_POWERDOWN ; -/* -* If CH1 common lane is not active anymore -* (eg. for pipe B DPLL) the entire channel will -* shut down, which causes the common lane registers -* to read as 0. That means we can't actually check -* the lane power down status bits, but as the entire -* register reads as 0 it's a good indication that the -* channel is indeed entirely powered down. -*/ -if (ch ==DPIO_CH1 && val ==0 ) - expected =0 ; - }else if (mask !=0x0 ) { - expected =DPIO_ANYDL_POWERDOWN ; - }else { - expected =0 ; - } - -if (ch ==DPIO_CH0 ) - actual = val >>DPIO_ANYDL_POWERDOWN_SHIFT_CH0 ; -else - actual = val >>DPIO_ANYDL_POWERDOWN_SHIFT_CH1 ; - actual &=DPIO_ALLDL_POWERDOWN |DPIO_ANYDL_POWERDOWN ; - -drm_WARN (&dev_priv->drm, actual != expected, -"Unexpected DPIO lane power down: all %d, any %d. Expected: all %d, any %d. (0x%x = 0x%08x)\n" , - !!(actual &DPIO_ALLDL_POWERDOWN ), - !!(actual &DPIO_ANYDL_POWERDOWN ), - !!(expected &DPIO_ALLDL_POWERDOWN ), - !!(expected &DPIO_ANYDL_POWERDOWN ), - reg, val); -} - -bool chv_phy_powergate_ch (struct drm_i915_private *dev_priv,enum dpio_phy phy, -enum dpio_channel ch,bool override) -{ -struct i915_power_domains *power_domains = &dev_priv->power_domains; -bool was_override; - -mutex_lock (&power_domains->lock); - - was_override = dev_priv->chv_phy_control &PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); - -if (override == was_override) - goto out; - -if (override) - dev_priv->chv_phy_control |=PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); -else - dev_priv->chv_phy_control &= ~PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); - -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); - -drm_dbg_kms (&dev_priv->drm, -"Power gating DPIO PHY%d CH%d (DPIO_PHY_CONTROL=0x%08x)\n" , - phy, ch, dev_priv->chv_phy_control); - -assert_chv_phy_status (dev_priv); - -out: -mutex_unlock (&power_domains->lock); - -return was_override; -} - -void chv_phy_powergate_lanes (struct intel_encoder *encoder, -bool override,unsigned int mask) -{ -struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); -struct i915_power_domains *power_domains = &dev_priv->power_domains; -enum dpio_phy phy =vlv_dig_port_to_phy (enc_to_dig_port (encoder)); -enum dpio_channel ch =vlv_dig_port_to_channel (enc_to_dig_port (encoder)); - -mutex_lock (&power_domains->lock); - - dev_priv->chv_phy_control &= ~PHY_CH_POWER_DOWN_OVRD (0xf , phy, ch); - dev_priv->chv_phy_control |=PHY_CH_POWER_DOWN_OVRD (mask, phy, ch); - -if (override) - dev_priv->chv_phy_control |=PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); -else - dev_priv->chv_phy_control &= ~PHY_CH_POWER_DOWN_OVRD_EN (phy, ch); - -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); - -drm_dbg_kms (&dev_priv->drm, -"Power gating DPIO PHY%d CH%d lanes 0x%x (PHY_CONTROL=0x%08x)\n" , - phy, ch, mask, dev_priv->chv_phy_control); - -assert_chv_phy_status (dev_priv); - -assert_chv_phy_powergate (dev_priv, phy, ch, override, mask); - -mutex_unlock (&power_domains->lock); -} - -static bool chv_pipe_power_well_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -enum pipe pipe =PIPE_A ; -bool enabled; -u32 state, ctrl; - -vlv_punit_get (dev_priv); - - state =vlv_punit_read (dev_priv,PUNIT_REG_DSPSSPM ) &DP_SSS_MASK (pipe); -/* -* We only ever set the power-on and power-gate states, anything -* else is unexpected. -*/ -drm_WARN_ON (&dev_priv->drm, state !=DP_SSS_PWR_ON (pipe) && - state !=DP_SSS_PWR_GATE (pipe)); - enabled = state ==DP_SSS_PWR_ON (pipe); - -/* -* A transient state at this point would mean some unexpected party -* is poking at the power controls too. -*/ - ctrl =vlv_punit_read (dev_priv,PUNIT_REG_DSPSSPM ) &DP_SSC_MASK (pipe); -drm_WARN_ON (&dev_priv->drm, ctrl <<16 != state); - -vlv_punit_put (dev_priv); - -return enabled; -} - -static void chv_set_pipe_power_well (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well, -bool enable) -{ -enum pipe pipe =PIPE_A ; -u32 state; -u32 ctrl; - - state = enable ?DP_SSS_PWR_ON (pipe) :DP_SSS_PWR_GATE (pipe); - -vlv_punit_get (dev_priv); - -#define COND \ - ((vlv_punit_read(dev_priv, PUNIT_REG_DSPSSPM) & DP_SSS_MASK(pipe)) == state) - -if (COND ) - goto out; - - ctrl =vlv_punit_read (dev_priv,PUNIT_REG_DSPSSPM ); - ctrl &= ~DP_SSC_MASK (pipe); - ctrl |= enable ?DP_SSC_PWR_ON (pipe) :DP_SSC_PWR_GATE (pipe); -vlv_punit_write (dev_priv,PUNIT_REG_DSPSSPM , ctrl); - -if (wait_for (COND ,100 )) -drm_err (&dev_priv->drm, -"timeout setting power well state %08x (%08x)\n" , - state, -vlv_punit_read (dev_priv,PUNIT_REG_DSPSSPM )); - -#undef COND - -out: -vlv_punit_put (dev_priv); -} - -static void chv_pipe_power_well_sync_hw (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -intel_de_write (dev_priv,DISPLAY_PHY_CONTROL , - dev_priv->chv_phy_control); -} - -static void chv_pipe_power_well_enable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -chv_set_pipe_power_well (dev_priv, power_well, true); - -vlv_display_power_well_init (dev_priv); -} - -static void chv_pipe_power_well_disable (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -vlv_display_power_well_deinit (dev_priv); - -chv_set_pipe_power_well (dev_priv, power_well, false); -} -static u64 __async_put_domains_mask (struct i915_power_domains *power_domains) { return power_domains->async_put_domains[0] |
@@ -3034,27 +1477,6 @@ intel_display_power_put_mask_in_set(struct drm_i915_private *i915,#define XELPD_DDI_IO_TC3_POWER_DOMAINS BIT_ULL(POWER_DOMAIN_PORT_DDI_IO_TC3)#define XELPD_DDI_IO_TC4_POWER_DOMAINS BIT_ULL(POWER_DOMAIN_PORT_DDI_IO_TC4) -static const struct i915_power_well_ops i9xx_always_on_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = i9xx_always_on_power_well_noop, - .disable = i9xx_always_on_power_well_noop, - .is_enabled = i9xx_always_on_power_well_enabled, -}; - -static const struct i915_power_well_ops chv_pipe_power_well_ops = { - .sync_hw = chv_pipe_power_well_sync_hw, - .enable = chv_pipe_power_well_enable, - .disable = chv_pipe_power_well_disable, - .is_enabled = chv_pipe_power_well_enabled, -}; - -static const struct i915_power_well_ops chv_dpio_cmn_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = chv_dpio_cmn_power_well_enable, - .disable = chv_dpio_cmn_power_well_disable, - .is_enabled = vlv_power_well_enabled, -}; -static const struct i915_power_well_desc i9xx_always_on_power_well[] = { { .name ="always-on" ,
@@ -3065,13 +1487,6 @@ static const struct i915_power_well_desc i9xx_always_on_power_well[] = { }, }; -static const struct i915_power_well_ops i830_pipes_power_well_ops = { - .sync_hw = i830_pipes_power_well_sync_hw, - .enable = i830_pipes_power_well_enable, - .disable = i830_pipes_power_well_disable, - .is_enabled = i830_pipes_power_well_enabled, -}; -static const struct i915_power_well_desc i830_power_wells[] = { { .name ="always-on" ,
@@ -3088,35 +1503,6 @@ static const struct i915_power_well_desc i830_power_wells[] = { }, }; -static const struct i915_power_well_regs hsw_power_well_regs = { - .bios =HSW_PWR_WELL_CTL1 , - .driver =HSW_PWR_WELL_CTL2 , - .kvmr =HSW_PWR_WELL_CTL3 , - .debug =HSW_PWR_WELL_CTL4 , -}; - -static const struct i915_power_well_ops hsw_power_well_ops = { - .regs = &hsw_power_well_regs, - .sync_hw = hsw_power_well_sync_hw, - .enable = hsw_power_well_enable, - .disable = hsw_power_well_disable, - .is_enabled = hsw_power_well_enabled, -}; - -static const struct i915_power_well_ops gen9_dc_off_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = gen9_dc_off_power_well_enable, - .disable = gen9_dc_off_power_well_disable, - .is_enabled = gen9_dc_off_power_well_enabled, -}; - -static const struct i915_power_well_ops bxt_dpio_cmn_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = bxt_dpio_cmn_power_well_enable, - .disable = bxt_dpio_cmn_power_well_disable, - .is_enabled = bxt_dpio_cmn_power_well_enabled, -}; -static const struct i915_power_well_desc hsw_power_wells[] = { { .name ="always-on" ,
@@ -3158,27 +1544,6 @@ static const struct i915_power_well_desc bdw_power_wells[] = { }, }; -static const struct i915_power_well_ops vlv_display_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = vlv_display_power_well_enable, - .disable = vlv_display_power_well_disable, - .is_enabled = vlv_power_well_enabled, -}; - -static const struct i915_power_well_ops vlv_dpio_cmn_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = vlv_dpio_cmn_power_well_enable, - .disable = vlv_dpio_cmn_power_well_disable, - .is_enabled = vlv_power_well_enabled, -}; - -static const struct i915_power_well_ops vlv_dpio_power_well_ops = { - .sync_hw = i9xx_power_well_sync_hw_noop, - .enable = vlv_power_well_enable, - .disable = vlv_power_well_disable, - .is_enabled = vlv_power_well_enabled, -}; -static const struct i915_power_well_desc vlv_power_wells[] = { { .name ="always-on" ,
@@ -3560,34 +1925,6 @@ static const struct i915_power_well_desc glk_power_wells[] = { }, }; -static const struct i915_power_well_regs icl_aux_power_well_regs = { - .bios =ICL_PWR_WELL_CTL_AUX1 , - .driver =ICL_PWR_WELL_CTL_AUX2 , - .debug =ICL_PWR_WELL_CTL_AUX4 , -}; - -static const struct i915_power_well_ops icl_aux_power_well_ops = { - .regs = &icl_aux_power_well_regs, - .sync_hw = hsw_power_well_sync_hw, - .enable = icl_aux_power_well_enable, - .disable = icl_aux_power_well_disable, - .is_enabled = hsw_power_well_enabled, -}; - -static const struct i915_power_well_regs icl_ddi_power_well_regs = { - .bios =ICL_PWR_WELL_CTL_DDI1 , - .driver =ICL_PWR_WELL_CTL_DDI2 , - .debug =ICL_PWR_WELL_CTL_DDI4 , -}; - -static const struct i915_power_well_ops icl_ddi_power_well_ops = { - .regs = &icl_ddi_power_well_regs, - .sync_hw = hsw_power_well_sync_hw, - .enable = hsw_power_well_enable, - .disable = hsw_power_well_disable, - .is_enabled = hsw_power_well_enabled, -}; -static const struct i915_power_well_desc icl_power_wells[] = { { .name ="always-on" ,
@@ -3801,90 +2138,6 @@ static const struct i915_power_well_desc icl_power_wells[] = { }, }; -static void -tgl_tc_cold_request (struct drm_i915_private *i915,bool block) -{ -u8 tries =0 ; -int ret; - -while (1 ) { -u32 low_val; -u32 high_val =0 ; - -if (block) - low_val =TGL_PCODE_EXIT_TCCOLD_DATA_L_BLOCK_REQ ; -else - low_val =TGL_PCODE_EXIT_TCCOLD_DATA_L_UNBLOCK_REQ ; - -/* -* Spec states that we should timeout the request after 200us -* but the function below will timeout after 500us -*/ - ret =snb_pcode_read (i915,TGL_PCODE_TCCOLD , &low_val, &high_val); -if (ret ==0 ) { -if (block && - (low_val &TGL_PCODE_EXIT_TCCOLD_DATA_L_EXIT_FAILED )) - ret = -EIO ; -else -break ; - } - -if (++tries ==3 ) -break ; - -msleep (1 ); - } - -if (ret) -drm_err (&i915->drm,"TC cold %sblock failed\n" , - block ?"" :"un" ); -else -drm_dbg_kms (&i915->drm,"TC cold %sblock succeeded\n" , - block ?"" :"un" ); -} - -static void -tgl_tc_cold_off_power_well_enable (struct drm_i915_private *i915, -struct i915_power_well *power_well) -{ -tgl_tc_cold_request (i915, true); -} - -static void -tgl_tc_cold_off_power_well_disable (struct drm_i915_private *i915, -struct i915_power_well *power_well) -{ -tgl_tc_cold_request (i915, false); -} - -static void -tgl_tc_cold_off_power_well_sync_hw (struct drm_i915_private *i915, -struct i915_power_well *power_well) -{ -if (intel_power_well_refcount (power_well) >0 ) -tgl_tc_cold_off_power_well_enable (i915, power_well); -else -tgl_tc_cold_off_power_well_disable (i915, power_well); -} - -static bool -tgl_tc_cold_off_power_well_is_enabled (struct drm_i915_private *dev_priv, -struct i915_power_well *power_well) -{ -/* -* Not the correctly implementation but there is no way to just read it -* from PCODE, so returning count to avoid state mismatch errors -*/ -return intel_power_well_refcount (power_well); -} - -static const struct i915_power_well_ops tgl_tc_cold_off_ops = { - .sync_hw = tgl_tc_cold_off_power_well_sync_hw, - .enable = tgl_tc_cold_off_power_well_enable, - .disable = tgl_tc_cold_off_power_well_disable, - .is_enabled = tgl_tc_cold_off_power_well_is_enabled, -}; -static const struct i915_power_well_desc tgl_power_wells[] = { { .name ="always-on" ,
drivers/gpu/drm/i915/display/intel_display_power.h +0 -5
@@ -305,9 +305,4 @@ void gen9_dbuf_slices_update(struct drm_i915_private *dev_priv,for ((wf) =intel_display_power_get_if_enabled ((i915), (domain)); (wf); \ intel_display_power_put_async((i915), (domain), (wf)), (wf) = 0) -void chv_phy_powergate_lanes(struct intel_encoder *encoder, - bool override, unsigned int mask); -bool chv_phy_powergate_ch (struct drm_i915_private *dev_priv,enum dpio_phy phy, -enum dpio_channel ch,bool override); -#endif /* __INTEL_DISPLAY_POWER_H__ */
drivers/gpu/drm/i915/display/intel_display_power_well.c +1792 -0
1,172 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_well.h +27 -35
62 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dpio_phy.c +1 -0
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/i915/display/intel_pps.c +1 -0
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.30.2
Part of the diff is not shown here. View the raw message.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c (rev2)
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c (rev2)
URL : https://patchwork.freedesktop.org/series/102719/
State : warning
== Summary ==
Error: dim checkpatch failed11b6a776e8b5 drm/i915: Move per-platform power well hooks to intel_display_power_well.c -:2152: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #2152: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:266:
+
+ }
-:2362: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #2362: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:476:
+ msleep(1);
-:2367: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #2367: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:481:
+ msleep(1);
-:2704: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #2704: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:818:
+ intel_de_read(dev_priv, GEN8_CHICKEN_DCPR_1) | SKL_SELECT_ALTERNATE_DC_EXIT);
-:2731: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #2731: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:845:
+ intel_de_read(dev_priv, GEN8_CHICKEN_DCPR_1) | SKL_SELECT_ALTERNATE_DC_EXIT);
-:2833: WARNING:REPEATED_WORD: Possible repeated word: 'power' #2833: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:947:
+ "Unexpected DBuf power power state (0x%08x, expected 0x%08x)\n",
-:2908: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2908: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:1022:
+static bool i9xx_always_on_power_well_enabled(struct drm_i915_private *dev_priv,
+ struct i915_power_well *power_well)
-:3178: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'bits' - possible side-effects? #3178: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:1292:
+#define BITS_SET(val, bits) (((val) & (bits)) == (bits))
-:3633: WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst #3633: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:1747:
+ msleep(1);
-:3679: CHECK:LINE_SPACING: Please don't use multiple blank lines #3679: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.c:1793:
+
+
total: 0 errors, 6 warnings, 4 checks, 3819 lines checked
034184825192 drm/i915: Unexport the for_each_power_well() macros
-:23: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #23: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:24:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well(__dev_priv, __power_well) \
+ for_each_if((__power_well)->desc->domains & (__domain_mask))
-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #23: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:24:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well(__dev_priv, __power_well) \
+ for_each_if((__power_well)->desc->domains & (__domain_mask))
-:27: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #27: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:28:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well_reverse(__dev_priv, __power_well) \
+ for_each_if((__power_well)->desc->domains & (__domain_mask))
-:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #27: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:28:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain_mask) \
+ for_each_power_well_reverse(__dev_priv, __power_well) \
+ for_each_if((__power_well)->desc->domains & (__domain_mask))
-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects? #73: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.h:15:
+#define for_each_power_well(__dev_priv, __power_well) \
+ for ((__power_well) = (__dev_priv)->power_domains.power_wells; \
+ (__power_well) - (__dev_priv)->power_domains.power_wells < \
+ (__dev_priv)->power_domains.power_well_count; \
+ (__power_well)++)
-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #73: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.h:15:
+#define for_each_power_well(__dev_priv, __power_well) \
+ for ((__power_well) = (__dev_priv)->power_domains.power_wells; \
+ (__power_well) - (__dev_priv)->power_domains.power_wells < \
+ (__dev_priv)->power_domains.power_well_count; \
+ (__power_well)++)
-:79: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects? #79: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.h:21:
+#define for_each_power_well_reverse(__dev_priv, __power_well) \
+ for ((__power_well) = (__dev_priv)->power_domains.power_wells + \
+ (__dev_priv)->power_domains.power_well_count - 1; \
+ (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \
+ (__power_well)--)
-:79: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #79: FILE: drivers/gpu/drm/i915/display/intel_display_power_well.h:21:
+#define for_each_power_well_reverse(__dev_priv, __power_well) \
+ for ((__power_well) = (__dev_priv)->power_domains.power_wells + \
+ (__dev_priv)->power_domains.power_well_count - 1; \
+ (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \
+ (__power_well)--)
total: 2 errors, 0 warnings, 6 checks, 58 lines checkedbef1f76cfc0a drm/i915: Move the power domain->well mappings to intel_display_power_map.c Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:2350: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #2350:
new file mode 100644
-:4433: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well_descs' - possible side-effects? #4433: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:2079:
+#define set_power_wells_mask(power_domains, __power_well_descs, skip_mask) \
+ __set_power_wells(power_domains, __power_well_descs, \
+ ARRAY_SIZE(__power_well_descs), skip_mask)
total: 0 errors, 1 warnings, 1 checks, 4467 lines checkeda429dee1abb3 drm/i915: Move the dg2 fixed_enable_delay power well param to a common bitfield d7bca70ac0cd drm/i915: Move the HSW power well flags to a common bitfield 324a6629fac9 drm/i915: Rename the power domain names to end with pipes/ports 44c716efd783 drm/i915: Sanitize the power well namescb056f0e82ea drm/i915: Convert the power well descriptor domain mask to an array of domains -:52: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__elems' - possible side-effects? #52: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:17:
+#define __LIST(__elems) { \
+ .list = __elems, \
+ .count = ARRAY_SIZE(__elems), \
+}
-:57: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #57: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:22:
+#define I915_PW_DOMAINS(...) \
+ (const struct i915_power_domain_list) \
+ __LIST(__LIST_INLINE_ELEMS(enum intel_display_power_domain, __VA_ARGS__))
-:68: CHECK:LINE_SPACING: Please don't use multiple blank lines #68: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:33:
+
+
-:91: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #91: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:47:
+I915_DECL_PW_DOMAINS(i830_pwdoms_pipes,
+ POWER_DOMAIN_PIPE_A,
-:134: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #134: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:71:
+I915_DECL_PW_DOMAINS(hsw_pwdoms_display,
+ POWER_DOMAIN_PIPE_B,
-:187: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #187: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:108:
+I915_DECL_PW_DOMAINS(bdw_pwdoms_display,
+ POWER_DOMAIN_PIPE_B,
-:270: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #270: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:145:
+I915_DECL_PW_DOMAINS(vlv_pwdoms_display,
+ POWER_DOMAIN_DISPLAY_CORE,
-:290: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #290: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:165:
+I915_DECL_PW_DOMAINS(vlv_pwdoms_dpio_cmn_bc,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:298: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #298: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:173:
+I915_DECL_PW_DOMAINS(vlv_pwdoms_dpio_tx_bc_lanes,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:416: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #416: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:238:
+I915_DECL_PW_DOMAINS(chv_pwdoms_display,
+ POWER_DOMAIN_DISPLAY_CORE,
-:440: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #440: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:262:
+I915_DECL_PW_DOMAINS(chv_pwdoms_dpio_cmn_bc,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:447: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #447: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:269:
+I915_DECL_PW_DOMAINS(chv_pwdoms_dpio_cmn_d,
+ POWER_DOMAIN_PORT_DDI_LANES_D,
-:530: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #530: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:309:
+#define SKL_PW_2_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_A, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_TRANSCODER_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_D, \
+ POWER_DOMAIN_PORT_DDI_LANES_E, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_B, \
+ POWER_DOMAIN_AUX_C, \
+ POWER_DOMAIN_AUX_D
-:550: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #550: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:329:
+I915_DECL_PW_DOMAINS(skl_pwdoms_pw_2,
+ SKL_PW_2_POWER_DOMAINS,
-:554: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #554: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:333:
+I915_DECL_PW_DOMAINS(skl_pwdoms_dc_off,
+ SKL_PW_2_POWER_DOMAINS,
-:561: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #561: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:340:
+I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_a_e,
+ POWER_DOMAIN_PORT_DDI_IO_A,
-:566: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #566: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:345:
+I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_b,
+ POWER_DOMAIN_PORT_DDI_IO_B,
-:570: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #570: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:349:
+I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_c,
+ POWER_DOMAIN_PORT_DDI_IO_C,
-:574: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #574: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:353:
+I915_DECL_PW_DOMAINS(skl_pwdoms_ddi_io_d,
+ POWER_DOMAIN_PORT_DDI_IO_D,
-:693: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #693: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:435:
+#define BXT_PW_2_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_A, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_TRANSCODER_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_B, \
+ POWER_DOMAIN_AUX_C
-:710: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #710: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:452:
+I915_DECL_PW_DOMAINS(bxt_pwdoms_pw_2,
+ BXT_PW_2_POWER_DOMAINS,
-:714: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #714: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:456:
+I915_DECL_PW_DOMAINS(bxt_pwdoms_dc_off,
+ BXT_PW_2_POWER_DOMAINS,
-:722: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #722: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:464:
+I915_DECL_PW_DOMAINS(bxt_pwdoms_dpio_cmn_a,
+ POWER_DOMAIN_PORT_DDI_LANES_A,
-:727: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #727: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:469:
+I915_DECL_PW_DOMAINS(bxt_pwdoms_dpio_cmn_bc,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:842: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #842: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:528:
+#define GLK_PW_2_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_A, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_TRANSCODER_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_B, \
+ POWER_DOMAIN_AUX_C
-:859: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #859: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:545:
+I915_DECL_PW_DOMAINS(glk_pwdoms_pw_2,
+ GLK_PW_2_POWER_DOMAINS,
-:863: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #863: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:549:
+I915_DECL_PW_DOMAINS(glk_pwdoms_dc_off,
+ GLK_PW_2_POWER_DOMAINS,
-:875: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #875: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:561:
+I915_DECL_PW_DOMAINS(glk_pwdoms_dpio_cmn_a,
+ POWER_DOMAIN_PORT_DDI_LANES_A,
-:880: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #880: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:566:
+I915_DECL_PW_DOMAINS(glk_pwdoms_dpio_cmn_b,
+ POWER_DOMAIN_PORT_DDI_LANES_B,
-:885: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #885: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:571:
+I915_DECL_PW_DOMAINS(glk_pwdoms_dpio_cmn_c,
+ POWER_DOMAIN_PORT_DDI_LANES_C,
-:890: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #890: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:576:
+I915_DECL_PW_DOMAINS(glk_pwdoms_aux_a,
+ POWER_DOMAIN_AUX_A,
-:895: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #895: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:581:
+I915_DECL_PW_DOMAINS(glk_pwdoms_aux_b,
+ POWER_DOMAIN_AUX_B,
-:899: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #899: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:585:
+I915_DECL_PW_DOMAINS(glk_pwdoms_aux_c,
+ POWER_DOMAIN_AUX_C,
-:1022: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1022: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:711:
+#define ICL_PW_4_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C
-:1027: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1027: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:716:
+I915_DECL_PW_DOMAINS(icl_pwdoms_pw_4,
+ ICL_PW_4_POWER_DOMAINS,
-:1056: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1056: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:720:
+#define ICL_PW_3_POWER_DOMAINS \
+ ICL_PW_4_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_A, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_TRANSCODER_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_D, \
+ POWER_DOMAIN_PORT_DDI_LANES_E, \
+ POWER_DOMAIN_PORT_DDI_LANES_F, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_B, \
+ POWER_DOMAIN_AUX_C, \
+ POWER_DOMAIN_AUX_D, \
+ POWER_DOMAIN_AUX_E, \
+ POWER_DOMAIN_AUX_F, \
+ POWER_DOMAIN_AUX_TBT_C, \
+ POWER_DOMAIN_AUX_TBT_D, \
+ POWER_DOMAIN_AUX_TBT_E, \
+ POWER_DOMAIN_AUX_TBT_F
-:1082: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1082: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:746:
+I915_DECL_PW_DOMAINS(icl_pwdoms_pw_3,
+ ICL_PW_3_POWER_DOMAINS,
-:1093: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1093: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:753:
+#define ICL_PW_2_POWER_DOMAINS \
+ ICL_PW_3_POWER_DOMAINS, \
+ POWER_DOMAIN_TRANSCODER_VDSC_PW2
-:1098: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1098: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:758:
+I915_DECL_PW_DOMAINS(icl_pwdoms_pw_2,
+ ICL_PW_2_POWER_DOMAINS,
-:1132: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1132: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:765:
+I915_DECL_PW_DOMAINS(icl_pwdoms_dc_off,
+ ICL_PW_2_POWER_DOMAINS,
-:1146: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1146: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:779:
+I915_DECL_PW_DOMAINS(icl_pwdoms_aux_a,
+ POWER_DOMAIN_AUX_A,
-:1450: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1450: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:983:
+#define TGL_PW_5_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_D, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_D, \
+ POWER_DOMAIN_TRANSCODER_D
-:1456: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1456: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:989:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_pw_5,
+ TGL_PW_5_POWER_DOMAINS,
-:1459: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1459: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:992:
+#define TGL_PW_4_POWER_DOMAINS \
+ TGL_PW_5_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_C
-:1466: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1466: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:999:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_pw_4,
+ TGL_PW_4_POWER_DOMAINS,
-:1469: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1469: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1002:
+#define TGL_PW_3_POWER_DOMAINS \
+ TGL_PW_4_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC3, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC4, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC5, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC6, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_USBC1, \
+ POWER_DOMAIN_AUX_USBC2, \
+ POWER_DOMAIN_AUX_USBC3, \
+ POWER_DOMAIN_AUX_USBC4, \
+ POWER_DOMAIN_AUX_USBC5, \
+ POWER_DOMAIN_AUX_USBC6, \
+ POWER_DOMAIN_AUX_TBT1, \
+ POWER_DOMAIN_AUX_TBT2, \
+ POWER_DOMAIN_AUX_TBT3, \
+ POWER_DOMAIN_AUX_TBT4, \
+ POWER_DOMAIN_AUX_TBT5, \
+ POWER_DOMAIN_AUX_TBT6
-:1497: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1497: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1030:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_pw_3,
+ TGL_PW_3_POWER_DOMAINS,
-:1501: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1501: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1034:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_pw_2,
+ TGL_PW_3_POWER_DOMAINS,
-:1506: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1506: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1039:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_dc_off,
+ TGL_PW_3_POWER_DOMAINS,
-:1521: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1521: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1054:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_aux_a,
+ POWER_DOMAIN_AUX_A,
-:1541: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1541: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1074:
+I915_DECL_PW_DOMAINS(tgl_pwdoms_tc_cold_off,
+ POWER_DOMAIN_AUX_USBC1,
-:1858: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1858: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1363:
+#define RKL_PW_4_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_C
-:1864: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1864: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1369:
+I915_DECL_PW_DOMAINS(rkl_pwdoms_pw_4,
+ RKL_PW_4_POWER_DOMAINS,
-:1867: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1867: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1372:
+#define RKL_PW_3_POWER_DOMAINS \
+ RKL_PW_4_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_MMIO, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_USBC1, \
+ POWER_DOMAIN_AUX_USBC2
-:1881: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1881: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1386:
+I915_DECL_PW_DOMAINS(rkl_pwdoms_pw_3,
+ RKL_PW_3_POWER_DOMAINS,
-:1897: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1897: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1411:
+I915_DECL_PW_DOMAINS(rkl_pwdoms_dc_off,
+ RKL_PW_3_POWER_DOMAINS,
-:2044: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2044: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1531:
+#define DG1_PW_3_POWER_DOMAINS \
+ TGL_PW_4_POWER_DOMAINS, \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_B, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_USBC1, \
+ POWER_DOMAIN_AUX_USBC2
-:2057: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2057: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1544:
+I915_DECL_PW_DOMAINS(dg1_pwdoms_pw_3,
+ DG1_PW_3_POWER_DOMAINS,
-:2061: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2061: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1548:
+I915_DECL_PW_DOMAINS(dg1_pwdoms_dc_off,
+ DG1_PW_3_POWER_DOMAINS,
-:2069: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2069: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1556:
+I915_DECL_PW_DOMAINS(dg1_pwdoms_pw_2,
+ DG1_PW_3_POWER_DOMAINS,
-:2255: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2255: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1710:
+#define XELPD_PW_D_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_D, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_D, \
+ POWER_DOMAIN_TRANSCODER_D
-:2261: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2261: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1716:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_d,
+ XELPD_PW_D_POWER_DOMAINS,
-:2264: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2264: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1719:
+#define XELPD_PW_C_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_C, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_C, \
+ POWER_DOMAIN_TRANSCODER_C
-:2270: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2270: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1725:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_c,
+ XELPD_PW_C_POWER_DOMAINS,
-:2273: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2273: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1728:
+#define XELPD_PW_B_POWER_DOMAINS \
+ POWER_DOMAIN_PIPE_B, \
+ POWER_DOMAIN_PIPE_PANEL_FITTER_B, \
+ POWER_DOMAIN_TRANSCODER_B
-:2279: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2279: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1734:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_b,
+ XELPD_PW_B_POWER_DOMAINS,
-:2283: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2283: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1738:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_a,
+ POWER_DOMAIN_PIPE_A,
-:2287: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2287: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1742:
+#define XELPD_PW_2_POWER_DOMAINS \
+ XELPD_PW_B_POWER_DOMAINS, \
+ XELPD_PW_C_POWER_DOMAINS, \
+ XELPD_PW_D_POWER_DOMAINS, \
+ POWER_DOMAIN_PORT_DDI_LANES_C, \
+ POWER_DOMAIN_PORT_DDI_LANES_D_XELPD, \
+ POWER_DOMAIN_PORT_DDI_LANES_E_XELPD, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC1, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC2, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC3, \
+ POWER_DOMAIN_PORT_DDI_LANES_TC4, \
+ POWER_DOMAIN_VGA, \
+ POWER_DOMAIN_AUDIO_PLAYBACK, \
+ POWER_DOMAIN_AUX_C, \
+ POWER_DOMAIN_AUX_D_XELPD, \
+ POWER_DOMAIN_AUX_E_XELPD, \
+ POWER_DOMAIN_AUX_USBC1, \
+ POWER_DOMAIN_AUX_USBC2, \
+ POWER_DOMAIN_AUX_USBC3, \
+ POWER_DOMAIN_AUX_USBC4, \
+ POWER_DOMAIN_AUX_TBT1, \
+ POWER_DOMAIN_AUX_TBT2, \
+ POWER_DOMAIN_AUX_TBT3, \
+ POWER_DOMAIN_AUX_TBT4
-:2313: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2313: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1768:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_pw_2,
+ XELPD_PW_2_POWER_DOMAINS,
-:2350: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2350: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1789:
+I915_DECL_PW_DOMAINS(xelpd_pwdoms_dc_off,
+ XELPD_PW_2_POWER_DOMAINS,
total: 17 errors, 0 warnings, 53 checks, 2540 lines checkede82986adcd08 drm/i915: Convert the u64 power well domains mask to a bitmap -:177: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #177: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:25:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain) \
for_each_power_well(__dev_priv, __power_well) \
+ for_each_if(test_bit((__domain), (__power_well)->domains.bits))
-:177: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #177: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:25:
+#define for_each_power_domain_well(__dev_priv, __power_well, __domain) \
for_each_power_well(__dev_priv, __power_well) \
+ for_each_if(test_bit((__domain), (__power_well)->domains.bits))
-:183: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #183: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:29:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain) \
for_each_power_well_reverse(__dev_priv, __power_well) \
+ for_each_if(test_bit((__domain), (__power_well)->domains.bits))
-:183: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__power_well' - possible side-effects? #183: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:29:
+#define for_each_power_domain_well_reverse(__dev_priv, __power_well, __domain) \
for_each_power_well_reverse(__dev_priv, __power_well) \
+ for_each_if(test_bit((__domain), (__power_well)->domains.bits))
-:527: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__domain' - possible side-effects? #527: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:175:
+#define for_each_power_domain(__domain, __mask) \
+ for ((__domain) = 0; (__domain) < POWER_DOMAIN_NUM; (__domain)++) \
+ for_each_if(test_bit((__domain), (__mask)->bits))
total: 2 errors, 0 warnings, 3 checks, 530 lines checkedb6caf688dc67 drm/i915: Simplify power well definitions by adding power well instances -:33: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #33: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:33:
+#define I915_PW_INSTANCES(...) \
+ (const struct i915_power_well_instance_list) \
+ __LIST(__LIST_INLINE_ELEMS(struct i915_power_well_instance, __VA_ARGS__))
-:47: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #47: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:45:
+ .instances = &I915_PW_INSTANCES(
-:62: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #62: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:64:
+ .instances = &I915_PW_INSTANCES(
-:71: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #71: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:70:
+ .instances = &I915_PW_INSTANCES(
-:85: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #85: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:97:
+ .instances = &I915_PW_INSTANCES(
-:94: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #94: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:103:
+ .instances = &I915_PW_INSTANCES(
-:114: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #114: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:132:
+ .instances = &I915_PW_INSTANCES(
-:123: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #123: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:138:
+ .instances = &I915_PW_INSTANCES(
-:144: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #144: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:186:
+ .instances = &I915_PW_INSTANCES(
-:153: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #153: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:192:
+ .instances = &I915_PW_INSTANCES(
-:182: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #182: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:199:
+ .instances = &I915_PW_INSTANCES(
-:208: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #208: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:211:
+ .instances = &I915_PW_INSTANCES(
-:227: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #227: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:258:
+ .instances = &I915_PW_INSTANCES(
-:241: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #241: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:269:
+ .instances = &I915_PW_INSTANCES(
-:249: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #249: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:274:
+ .instances = &I915_PW_INSTANCES(
-:279: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #279: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:335:
+ .instances = &I915_PW_INSTANCES(
-:289: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #289: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:342:
+ .instances = &I915_PW_INSTANCES(
-:305: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #305: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:352:
+ .instances = &I915_PW_INSTANCES(
-:319: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #319: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:360:
+ .instances = &I915_PW_INSTANCES(
-:328: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #328: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:366:
+ .instances = &I915_PW_INSTANCES(
-:344: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #344: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:376:
+ .instances = &I915_PW_INSTANCES(
-:345: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #345: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:377:
+ I915_PW("DDI_IO_A_E", &skl_pwdoms_ddi_io_a_e, .hsw.idx = SKL_PW_CTL_IDX_DDI_A_E),
-:388: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #388: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:428:
+ .instances = &I915_PW_INSTANCES(
-:398: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #398: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:435:
+ .instances = &I915_PW_INSTANCES(
-:413: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #413: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:444:
+ .instances = &I915_PW_INSTANCES(
-:422: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #422: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:450:
+ .instances = &I915_PW_INSTANCES(
-:438: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #438: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:460:
+ .instances = &I915_PW_INSTANCES(
-:468: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #468: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:534:
+ .instances = &I915_PW_INSTANCES(
-:478: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #478: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:541:
+ .instances = &I915_PW_INSTANCES(
-:493: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #493: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:550:
+ .instances = &I915_PW_INSTANCES(
-:502: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #502: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:556:
+ .instances = &I915_PW_INSTANCES(
-:534: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #534: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:566:
+ .instances = &I915_PW_INSTANCES(
-:593: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #593: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:579:
+ .instances = &I915_PW_INSTANCES(
-:615: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #615: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:687:
+ .instances = &I915_PW_INSTANCES(
-:625: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #625: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:694:
+ .instances = &I915_PW_INSTANCES(
-:640: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #640: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:703:
+ .instances = &I915_PW_INSTANCES(
-:649: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #649: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:709:
+ .instances = &I915_PW_INSTANCES(
-:663: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #663: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:717:
+ .instances = &I915_PW_INSTANCES(
-:719: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #719: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:727:
+ .instances = &I915_PW_INSTANCES(
-:735: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #735: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:737:
+ .instances = &I915_PW_INSTANCES(
-:795: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #795: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:747:
+ .instances = &I915_PW_INSTANCES(
-:796: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #796: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:748:
+ I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT1),
-:797: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #797: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:749:
+ I915_PW("AUX_TBT2", &icl_pwdoms_aux_tbt2, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT2),
-:798: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #798: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:750:
+ I915_PW("AUX_TBT3", &icl_pwdoms_aux_tbt3, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT3),
-:799: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #799: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:751:
+ I915_PW("AUX_TBT4", &icl_pwdoms_aux_tbt4, .hsw.idx = ICL_PW_CTL_IDX_AUX_TBT4),
-:837: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #837: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:756:
+ .instances = &I915_PW_INSTANCES(
-:857: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #857: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:873:
+ .instances = &I915_PW_INSTANCES(
-:867: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #867: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:880:
+ .instances = &I915_PW_INSTANCES(
-:882: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #882: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:889:
+ .instances = &I915_PW_INSTANCES(
-:891: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #891: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:895:
+ .instances = &I915_PW_INSTANCES(
-:905: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #905: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:903:
+ .instances = &I915_PW_INSTANCES(
-:945: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #945: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:913:
+ .instances = &I915_PW_INSTANCES(
-:949: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #949: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:917:
+ I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:950: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #950: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:918:
+ I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:951: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #951: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:919:
+ I915_PW("DDI_IO_TC3", &tgl_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3),
-:952: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #952: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:920:
+ I915_PW("DDI_IO_TC4", &tgl_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4),
-:953: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #953: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:921:
+ I915_PW("DDI_IO_TC5", &tgl_pwdoms_ddi_io_tc5, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC5),
-:954: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #954: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:922:
+ I915_PW("DDI_IO_TC6", &tgl_pwdoms_ddi_io_tc6, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC6),
-:1004: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1004: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:926:
+ .instances = &I915_PW_INSTANCES(
-:1100: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1100: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:932:
+ .instances = &I915_PW_INSTANCES(
-:1104: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1104: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:936:
+ I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:1105: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1105: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:937:
+ I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:1106: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1106: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:938:
+ I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
-:1107: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1107: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:939:
+ I915_PW("AUX_USBC4", &tgl_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4),
-:1108: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1108: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:940:
+ I915_PW("AUX_USBC5", &tgl_pwdoms_aux_usbc5, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC5),
-:1109: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1109: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:941:
+ I915_PW("AUX_USBC6", &tgl_pwdoms_aux_usbc6, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC6),
-:1120: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1120: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:945:
+ .instances = &I915_PW_INSTANCES(
-:1121: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1121: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:946:
+ I915_PW("AUX_TBT1", &tgl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1),
-:1122: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1122: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:947:
+ I915_PW("AUX_TBT2", &tgl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2),
-:1123: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1123: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:948:
+ I915_PW("AUX_TBT3", &tgl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3),
-:1124: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1124: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:949:
+ I915_PW("AUX_TBT4", &tgl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4),
-:1125: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1125: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:950:
+ I915_PW("AUX_TBT5", &tgl_pwdoms_aux_tbt5, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT5),
-:1126: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #1126: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:951:
+ I915_PW("AUX_TBT6", &tgl_pwdoms_aux_tbt6, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT6),
-:1164: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1164: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:956:
+ .instances = &I915_PW_INSTANCES(
-:1178: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1178: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:964:
+ .instances = &I915_PW_INSTANCES(
-:1198: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1198: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1030:
+ .instances = &I915_PW_INSTANCES(
-:1208: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1208: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1037:
+ .instances = &I915_PW_INSTANCES(
-:1223: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1223: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1046:
+ .instances = &I915_PW_INSTANCES(
-:1232: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1232: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1052:
+ .instances = &I915_PW_INSTANCES(
-:1248: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1248: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1062:
+ .instances = &I915_PW_INSTANCES(
-:1286: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1286: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1070:
+ .instances = &I915_PW_INSTANCES(
-:1289: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1289: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1073:
+ I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:1290: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1290: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1074:
+ I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:1300: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1300: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1078:
+ .instances = &I915_PW_INSTANCES(
-:1303: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1303: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1081:
+ I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:1304: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1304: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1082:
+ I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:1344: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1344: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1122:
+ .instances = &I915_PW_INSTANCES(
-:1354: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1354: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1129:
+ .instances = &I915_PW_INSTANCES(
-:1369: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1369: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1138:
+ .instances = &I915_PW_INSTANCES(
-:1378: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1378: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1144:
+ .instances = &I915_PW_INSTANCES(
-:1392: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1392: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1152:
+ .instances = &I915_PW_INSTANCES(
-:1408: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1408: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1162:
+ .instances = &I915_PW_INSTANCES(
-:1411: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1411: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1165:
+ I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:1412: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1412: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1166:
+ I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:1454: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1454: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1170:
+ .instances = &I915_PW_INSTANCES(
-:1457: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1457: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1173:
+ I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:1458: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #1458: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1174:
+ I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:1486: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1486: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1178:
+ .instances = &I915_PW_INSTANCES(
-:1500: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1500: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1186:
+ .instances = &I915_PW_INSTANCES(
-:1520: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1520: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1323:
+ .instances = &I915_PW_INSTANCES(
-:1530: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1530: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1330:
+ .instances = &I915_PW_INSTANCES(
-:1545: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1545: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1339:
+ .instances = &I915_PW_INSTANCES(
-:1554: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1554: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1345:
+ .instances = &I915_PW_INSTANCES(
-:1569: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1569: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1354:
+ .instances = &I915_PW_INSTANCES(
-:1583: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1583: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1362:
+ .instances = &I915_PW_INSTANCES(
-:1597: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1597: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1370:
+ .instances = &I915_PW_INSTANCES(
-:1611: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1611: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1378:
+ .instances = &I915_PW_INSTANCES(
-:1625: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1625: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1386:
+ .instances = &I915_PW_INSTANCES(
-:1629: WARNING:LONG_LINE: line length of 115 exceeds 100 columns #1629: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1390:
+ I915_PW("DDI_IO_D_XELPD", &xelpd_pwdoms_ddi_io_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_D),
-:1630: WARNING:LONG_LINE: line length of 115 exceeds 100 columns #1630: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1391:
+ I915_PW("DDI_IO_E_XELPD", &xelpd_pwdoms_ddi_io_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_DDI_E),
-:1631: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #1631: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1392:
+ I915_PW("DDI_IO_TC1", &xelpd_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:1632: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #1632: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1393:
+ I915_PW("DDI_IO_TC2", &xelpd_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:1633: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #1633: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1394:
+ I915_PW("DDI_IO_TC3", &xelpd_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3),
-:1634: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #1634: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1395:
+ I915_PW("DDI_IO_TC4", &xelpd_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4),
-:1708: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1708: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1399:
+ .instances = &I915_PW_INSTANCES(
-:1712: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #1712: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1403:
+ I915_PW("AUX_D_XELPD", &xelpd_pwdoms_aux_d_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_D),
-:1713: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #1713: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1404:
+ I915_PW("AUX_E_XELPD", &xelpd_pwdoms_aux_e_xelpd, .hsw.idx = XELPD_PW_CTL_IDX_AUX_E),
-:1714: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1714: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1405:
+ I915_PW("AUX_USBC1", &xelpd_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:1715: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1715: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1406:
+ I915_PW("AUX_USBC2", &xelpd_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:1716: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1716: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1407:
+ I915_PW("AUX_USBC3", &xelpd_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
-:1717: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #1717: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1408:
+ I915_PW("AUX_USBC4", &xelpd_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4),
-:1796: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1796: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1413:
+ .instances = &I915_PW_INSTANCES(
-:1797: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #1797: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1414:
+ I915_PW("AUX_TBT1", &xelpd_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1),
-:1798: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #1798: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1415:
+ I915_PW("AUX_TBT2", &xelpd_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2),
-:1799: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #1799: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1416:
+ I915_PW("AUX_TBT3", &xelpd_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3),
-:1800: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #1800: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1417:
+ I915_PW("AUX_TBT4", &xelpd_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4),
-:1861: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1861: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1442:
+#define for_each_power_well_instance(_desc_list, _desc_count, _desc, _inst) \
+ for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
+ for ((_inst) = (_desc)->instances->list; \
+ (_inst) - (_desc)->instances->list < (_desc)->instances->count; \
+ (_inst)++)
-:1861: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc_list' - possible side-effects? #1861: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1442:
+#define for_each_power_well_instance(_desc_list, _desc_count, _desc, _inst) \
+ for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
+ for ((_inst) = (_desc)->instances->list; \
+ (_inst) - (_desc)->instances->list < (_desc)->instances->count; \
+ (_inst)++)
-:1861: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc' - possible side-effects? #1861: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1442:
+#define for_each_power_well_instance(_desc_list, _desc_count, _desc, _inst) \
+ for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
+ for ((_inst) = (_desc)->instances->list; \
+ (_inst) - (_desc)->instances->list < (_desc)->instances->count; \
+ (_inst)++)
-:1861: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_inst' - possible side-effects? #1861: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1442:
+#define for_each_power_well_instance(_desc_list, _desc_count, _desc, _inst) \
+ for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
+ for ((_inst) = (_desc)->instances->list; \
+ (_inst) - (_desc)->instances->list < (_desc)->instances->count; \
+ (_inst)++)
total: 2 errors, 47 warnings, 81 checks, 2190 lines checked 54d94c5e16ca drm/i915: Allow platforms to share power well descriptors -:34: CHECK:LINE_SPACING: Please don't use multiple blank lines #34: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:48:
+
+
-:516: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #516: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1397:
+#define for_each_power_well_instance_in_desc_list(_desc_list, _desc_count, _desc, _inst) \
for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
for ((_inst) = (_desc)->instances->list; \
(_inst) - (_desc)->instances->list < (_desc)->instances->count; \
(_inst)++)
-:516: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc_list' - possible side-effects? #516: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1397:
+#define for_each_power_well_instance_in_desc_list(_desc_list, _desc_count, _desc, _inst) \
for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
for ((_inst) = (_desc)->instances->list; \
(_inst) - (_desc)->instances->list < (_desc)->instances->count; \
(_inst)++)
-:516: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc' - possible side-effects? #516: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1397:
+#define for_each_power_well_instance_in_desc_list(_desc_list, _desc_count, _desc, _inst) \
for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
for ((_inst) = (_desc)->instances->list; \
(_inst) - (_desc)->instances->list < (_desc)->instances->count; \
(_inst)++)
-:516: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_inst' - possible side-effects? #516: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1397:
+#define for_each_power_well_instance_in_desc_list(_desc_list, _desc_count, _desc, _inst) \
for ((_desc) = (_desc_list); (_desc) - (_desc_list) < (_desc_count); (_desc)++) \
for ((_inst) = (_desc)->instances->list; \
(_inst) - (_desc)->instances->list < (_desc)->instances->count; \
(_inst)++)
-:522: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_desc_list' - possible side-effects? #522: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1403:
+#define for_each_power_well_instance(_desc_list, _desc_count, _descs, _desc, _inst) \
+ for ((_descs) = (_desc_list); \
+ (_descs) - (_desc_list) < (_desc_count); \
+ (_descs)++) \
+ for_each_power_well_instance_in_desc_list((_descs)->list, (_descs)->count, \
+ (_desc), (_inst))
-:522: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_descs' - possible side-effects? #522: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1403:
+#define for_each_power_well_instance(_desc_list, _desc_count, _descs, _desc, _inst) \
+ for ((_descs) = (_desc_list); \
+ (_descs) - (_desc_list) < (_desc_count); \
+ (_descs)++) \
+ for_each_power_well_instance_in_desc_list((_descs)->list, (_descs)->count, \
+ (_desc), (_inst))
total: 1 errors, 0 warnings, 6 checks, 512 lines checked 798a9aaa18aa drm/i915: Simplify the DG1 power well descriptors 54ecde785331 drm/i915: Sanitize the ADL-S power well definition -:30: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #30: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:905:
+ .instances = &I915_PW_INSTANCES(
-:38: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #38: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:913:
+ .instances = &I915_PW_INSTANCES(
total: 0 errors, 0 warnings, 2 checks, 123 lines checked0e72b222f3a4 drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform 9b8d6c1b2a83 drm/i915: Remove the aliasing of power domain enum values 7ab4396c103b drm/i915: Remove the ICL specific TBT power domains d8a03fa8d6d8 drm/i915: Remove duplicate DDI/AUX power domain mappings -:101: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#101: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:936:
+ I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1),
-:102: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #102: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:937:
+ I915_PW("AUX_TBT2", &icl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2),
-:103: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #103: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:938:
+ I915_PW("AUX_TBT3", &icl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3),
-:104: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #104: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:939:
+ I915_PW("AUX_TBT4", &icl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4),
-:158: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #158: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1321:
+ I915_PW("DDI_IO_TC1", &tgl_pwdoms_ddi_io_tc1, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC1),
-:159: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #159: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1322:
+ I915_PW("DDI_IO_TC2", &tgl_pwdoms_ddi_io_tc2, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC2),
-:160: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #160: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1323:
+ I915_PW("DDI_IO_TC3", &tgl_pwdoms_ddi_io_tc3, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC3),
-:161: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #161: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1324:
+ I915_PW("DDI_IO_TC4", &tgl_pwdoms_ddi_io_tc4, .hsw.idx = TGL_PW_CTL_IDX_DDI_TC4),
-:176: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #176: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1334:
+ I915_PW("AUX_USBC1", &tgl_pwdoms_aux_usbc1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC1),
-:177: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #177: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1335:
+ I915_PW("AUX_USBC2", &tgl_pwdoms_aux_usbc2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC2),
-:178: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #178: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1336:
+ I915_PW("AUX_USBC3", &tgl_pwdoms_aux_usbc3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC3),
-:179: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #179: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1337:
+ I915_PW("AUX_USBC4", &tgl_pwdoms_aux_usbc4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TC4),
-:189: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #189: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1343:
+ I915_PW("AUX_TBT1", &icl_pwdoms_aux_tbt1, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT1),
-:190: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #190: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1344:
+ I915_PW("AUX_TBT2", &icl_pwdoms_aux_tbt2, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT2),
-:191: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #191: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1345:
+ I915_PW("AUX_TBT3", &icl_pwdoms_aux_tbt3, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT3),
-:192: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #192: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1346:
+ I915_PW("AUX_TBT4", &icl_pwdoms_aux_tbt4, .hsw.idx = TGL_PW_CTL_IDX_AUX_TBT4),
total: 0 errors, 16 warnings, 0 checks, 166 lines checked 848def81a9f0 drm/i915: Remove the XELPD specific AUX and DDI power domains -:148: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #148: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1313:
+ I915_PW("DDI_IO_D", &icl_pwdoms_ddi_io_d, .hsw.idx = XELPD_PW_CTL_IDX_DDI_D),
-:149: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #149: FILE: drivers/gpu/drm/i915/display/intel_display_power_map.c:1314:
+ I915_PW("DDI_IO_E", &icl_pwdoms_ddi_io_e, .hsw.idx = XELPD_PW_CTL_IDX_DDI_E),
total: 0 errors, 2 warnings, 0 checks, 121 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c (rev2)
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c (rev2)
URL : https://patchwork.freedesktop.org/series/102719/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c (rev2)
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c (rev2)
URL : https://patchwork.freedesktop.org/series/102719/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11504 -> Patchwork_102719v2
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_102719v2 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_102719v2, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/index.html
Participating hosts (47 -> 44)
------------------------------
Additional (1): bat-adlm-1
Missing (4): bat-rpls-1 fi-bsw-cyan fi-bdw-samus fi-tgl-u2
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102719v2:
### IGT changes ###
#### Warnings ####
* igt@runner@aborted:
- fi-kbl-8809g: [FAIL][1] ([i915#2722]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/fi-kbl-8809g/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/fi-kbl-8809g/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@core_hotunplug@unbind-rebind:
- {bat-adlm-1}: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/bat-adlm-1/igt@[email protected]
* igt@gem_exec_suspend@basic-s0@lmem0:
- {bat-dg2-8}: [DMESG-WARN][4] ([i915#5193]) -> [DMESG-WARN][5] +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/bat-dg2-8/igt@gem_exec_suspend@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/bat-dg2-8/igt@gem_exec_suspend@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- {bat-dg2-9}: [DMESG-WARN][6] ([i915#5193]) -> [DMESG-WARN][7] +4 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/bat-dg2-9/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/bat-dg2-9/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_102719v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: [PASS][8] -> [INCOMPLETE][9] ([i915#5127])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][10] ([i915#4785]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/fi-hsw-4770/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/fi-hsw-4770/igt@i915_selftest@[email protected]
- fi-snb-2600: [INCOMPLETE][12] ([i915#3921]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/fi-snb-2600/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/fi-snb-2600/igt@i915_selftest@[email protected]
* igt@kms_busy@basic@modeset:
- {bat-adlp-6}: [DMESG-WARN][14] ([i915#3576]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/bat-adlp-6/igt@kms_busy@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/bat-adlp-6/igt@kms_busy@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#5193]: https://gitlab.freedesktop.org/drm/intel/issues/5193
[i915#5329]: https://gitlab.freedesktop.org/drm/intel/issues/5329
Build changes
-------------
* Linux: CI_DRM_11504 -> Patchwork_102719v2
CI-20190529: 20190529
CI_DRM_11504: 64c052dc4fd1f39ef083b217434f140ed0feca5e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6437: ea0144ed6ccb66b977f204b4d53b6062ed1cc8bc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102719v2: 64c052dc4fd1f39ef083b217434f140ed0feca5e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
fda1ed6e3aeb drm/i915: Remove the XELPD specific AUX and DDI power domains 07a447393b6f drm/i915: Remove duplicate DDI/AUX power domain mappings 0a58f10cc730 drm/i915: Remove the ICL specific TBT power domainsd5066e6cd62a drm/i915: Remove the aliasing of power domain enum values 21fd986a4dcf drm/i915: Sanitize the port -> DDI/AUX power domain mapping for each platform b95eac8c6156 drm/i915: Sanitize the ADL-S power well definition8f7b1de654e2 drm/i915: Simplify the DG1 power well descriptors72ec8ac4067d drm/i915: Allow platforms to share power well descriptors 59ffc4b34d13 drm/i915: Simplify power well definitions by adding power well instances 042b1e2f086d drm/i915: Convert the u64 power well domains mask to a bitmap 3767837a9bc7 drm/i915: Convert the power well descriptor domain mask to an array of domains 76a12e6576f1 drm/i915: Sanitize the power well namese02a794c1a9c drm/i915: Rename the power domain names to end with pipes/ports cac3baef54ce drm/i915: Move the HSW power well flags to a common bitfield b857512a4116 drm/i915: Move the dg2 fixed_enable_delay power well param to a common bitfield aaacf15efff5 drm/i915: Move the power domain->well mappings to intel_display_power_map.c f9a4f2960d4e drm/i915: Unexport the for_each_power_well() macros4d5c4c3b6475 drm/i915: Move per-platform power well hooks to intel_display_power_well.c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c (rev2)
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c (rev2)
URL : https://patchwork.freedesktop.org/series/102719/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11504_full -> Patchwork_102719v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_102719v2_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_102719v2_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 11)
------------------------------
Missing (1): shard-rkl
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102719v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl6/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_102719v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@kms:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#232])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglb7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb5/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-skl: [PASS][5] -> [TIMEOUT][6] ([i915#3063])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl4/igt@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglb6/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-wb-prw-default:
- shard-snb: [PASS][9] -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-snb4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-snb6/igt@[email protected]
* igt@gem_lmem_swapping@heavy-random:
- shard-skl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl2/igt@[email protected]
* igt@gen7_exec_parse@basic-offset:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271]) +46 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl2/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][14] -> [FAIL][15] ([i915#454])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb5/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][16] -> [DMESG-WARN][17] ([i915#180]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-apl4/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl3/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][18] -> [FAIL][19] ([i915#2521])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl2/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl6/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#5286])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3777]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][22] ([i915#3743]) +4 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl10/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [PASS][23] -> [DMESG-WARN][24] ([i915#118])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk9/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][25] ([fdo#110723])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +7 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl9/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][27] ([i915#3689] / [i915#3886])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109278] / [i915#3886])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#3689])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109284] / [fdo#111827]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-glk: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl2/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +23 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl5/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#1063])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109278] / [fdo#109279]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][37] -> [FAIL][38] ([i915#2346])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk9/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
- shard-glk: [PASS][39] -> [FAIL][40] ([i915#5160])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk9/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [PASS][41] -> [FAIL][42] ([i915#79])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk2/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [PASS][43] -> [FAIL][44] ([i915#2122])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl1/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-skl: NOTRUN -> [INCOMPLETE][45] ([i915#3701])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][46] -> [DMESG-WARN][47] ([i915#180]) +5 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl1/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-glk: NOTRUN -> [SKIP][48] ([fdo#109271]) +7 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109280]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#109280] / [fdo#111825])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-edp-1-pipe-a:
- shard-skl: NOTRUN -> [FAIL][51] ([i915#1188])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl7/igt@kms_hdr@[email protected]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#533]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][53] ([fdo#108145] / [i915#265])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-skl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl8/igt@[email protected]
* igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format:
- shard-iclb: [PASS][55] -> [SKIP][56] ([i915#5176]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb8/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html
* igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format:
- shard-iclb: [PASS][57] -> [INCOMPLETE][58] ([i915#1982] / [i915#5395])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb1/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][60] -> [SKIP][61] ([fdo#109441])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][62] ([i915#132] / [i915#3467])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109441])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-a:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271]) +271 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@kms_scaling_modes@[email protected]
* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#112283])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@perf_pmu@[email protected]
* igt@prime_udl:
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109291])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@prime_udl.html
* igt@syncobj_timeline@transfer-timeline-point:
- shard-apl: NOTRUN -> [DMESG-FAIL][67] ([i915#5098])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl7/igt@[email protected]
* igt@sysfs_clients@fair-1:
- shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2994])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]
* igt@sysfs_clients@recycle:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#2994])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@[email protected]
* igt@sysfs_clients@sema-10:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2994]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl8/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-tglb: [FAIL][71] ([i915#2846]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglb7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb5/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- {shard-tglu}: [FAIL][73] ([i915#2842]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglu-5/igt@gem_exec_fair@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglu-8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][75] ([i915#2842]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-apl6/igt@gem_exec_fair@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [FAIL][77] ([i915#2842]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl3/igt@gem_exec_fair@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-iclb: [FAIL][79] ([i915#2842]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb1/igt@gem_exec_fair@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][81] ([i915#2849]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb6/igt@gem_exec_fair@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-uc-set-default:
- shard-snb: [SKIP][83] ([fdo#109271]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-snb6/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-snb5/igt@[email protected]
* igt@gem_softpin@allocator-evict-all-engines:
- shard-glk: [FAIL][85] ([i915#4171]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk2/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][87] ([i915#5566] / [i915#716]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk2/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][89] ([i915#5566] / [i915#716]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl3/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl10/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-glk: [FAIL][91] ([i915#2346]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk3/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk4/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [FAIL][93] ([i915#79]) -> [PASS][94] +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk3/igt@kms_flip@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk8/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][95] ([i915#180]) -> [PASS][96] +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-apl6/igt@kms_flip@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl7/igt@kms_flip@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-none:
- {shard-tglu}: [FAIL][97] ([i915#3957]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglu-1/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglu-2/igt@[email protected]
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][99] ([fdo#109441]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb1/igt@kms_psr@psr2_cursor_render.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [DMESG-WARN][101] ([i915#5614]) -> [SKIP][102] ([i915#4525])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb1/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][103] ([i915#4525]) -> [DMESG-WARN][104] ([i915#5614]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb5/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb1/igt@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][105] ([i915#2851]) -> [FAIL][106] ([i915#2842])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk8/igt@gem_exec_fair@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk8/igt@gem_exec_fair@[email protected]
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][107] ([i915#658]) -> [SKIP][108] ([i915#2920])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb6/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][109] ([fdo#111068] / [i915#658]) -> [SKIP][110] ([i915#2920]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb6/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [FAIL][111] ([i915#4148]) -> [SKIP][112] ([fdo#109642] / [fdo#111068] / [i915#658]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb1/igt@kms_psr2_su@page_flip-nv12.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92]) -> ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl1/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl3/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl6/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl7/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl7/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl3/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl7/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl6/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl1/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2851]: https://gitlab.freedesktop.org/drm/intel/issues/2851
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3957]: https://gitlab.freedesktop.org/drm/intel/issues/3957
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4148]: https://gitlab.freedesktop.org/drm/intel/issues/4148
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076
[i915#5098]: https://gitlab.freedesktop.org/drm/intel/issues/5098
[i915#5160]: https://gitlab.freedesktop.org/drm/intel/issues/5160
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5395]: https://gitlab.freedesktop.org/drm/intel/issues/5395
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_11504 -> Patchwork_102719v2
CI-20190529: 20190529
CI_DRM_11504: 64c052dc4fd1f39ef083b217434f140ed0feca5e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6437: ea0144ed6ccb66b977f204b4d53b6062ed1cc8bc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102719v2: 64c052dc4fd1f39ef083b217434f140ed0feca5e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/index.html
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to intel_display_power_well.c (rev2)
Hi Lakshmi,
Quoted 35 lines · Patchwork
== Series Details ==
Series: series starting with [CI,v2,01/18] drm/i915: Move per-platform power well hooks to
intel_display_power_well.c(rev2)
URL : https://patchwork.freedesktop.org/series/102719/
State : failure== Summary ==
CI Bug Log - changes from
CI_DRM_11504_full->Patchwork_102719v2_full
====================================================Summary
-------**FAILURE**
Serious unknown changes coming with
Patchwork_102719v2_fullabsolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
Patchwork_102719v2_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.Participating hosts (12 -> 11)
------------------------------Missing (1): shard-rkl
Possible new issues
-------------------Here are the unknown changes that may have been introduced in
Patchwork_102719v2_full:
Quoted 8 lines
### IGT changes ###
#### Possible regressions ####
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl6/igt@[email protected]
The issue looks unrelated, the changes should not affect the behavior and checking the order/dependencies of enabled/disabled power wells in the above logs confirms this.
It's probably the general issue affecting all S3 suspend tests on all the SKL shard machines (all of those are the same/similar model afaik) vs. the BAT SKL machines without any trace of this problem (fi-skl-6700k2, fi-skl-guc).
One previous instance of the same issue is at:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11487/shard-skl7/igt@[email protected]
One theory is that the machines don't support S3 at all or well (they only support S0ix) or that some other peripheral causes the problem. I'll try to borrow one of these systems and check out this.
Quoted 488 lines
Known issues
------------Here are the changes found in
Patchwork_102719v2_fullthat come from known issues:### IGT changes ###
#### Issues hit ####
* igt@gem_eio@kms:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#232])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglb7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb5/igt@[email protected]* igt@gem_eio@unwedge-stress:
- shard-skl: [PASS][5] -> [TIMEOUT][6] ([i915#3063])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl4/igt@[email protected]* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglb6/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb6/igt@gem_exec_fair@[email protected]* igt@gem_exec_flush@basic-wb-prw-default:
- shard-snb: [PASS][9] -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-snb4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-snb6/igt@[email protected]* igt@gem_lmem_swapping@heavy-random:
- shard-skl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@[email protected]* igt@gem_lmem_swapping@heavy-verify-random:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl2/igt@[email protected]* igt@gen7_exec_parse@basic-offset:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271]) +46 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl2/igt@[email protected]* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][14] -> [FAIL][15] ([i915#454])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb5/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][16] -> [DMESG-WARN][17] ([i915#180]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-apl4/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl3/igt@[email protected]* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][18] -> [FAIL][19] ([i915#2521])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl2/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl6/igt@[email protected]* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#5286])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3777]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][22] ([i915#3743]) +4 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl10/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html* igt@kms_big_fb@y-tiled-32bpp-rotate-0:
- shard-glk: [PASS][23] -> [DMESG-WARN][24] ([i915#118])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk9/igt@[email protected]* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][25] ([fdo#110723])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +7 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl9/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][27] ([i915#3689] / [i915#3886])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109278] / [i915#3886])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#3689])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs.html* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109284] / [fdo#111827]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-glk: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl2/igt@[email protected]* igt@kms_color_chamelium@pipe-d-degamma:
- shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +23 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl5/igt@[email protected]* igt@kms_content_protection@uevent:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#1063])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@[email protected]* igt@kms_cursor_crc@pipe-b-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109278] / [fdo#109279]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [PASS][37] -> [FAIL][38] ([i915#2346])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk9/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]* igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
- shard-glk: [PASS][39] -> [FAIL][40] ([i915#5160])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk9/igt@[email protected]* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [PASS][41] -> [FAIL][42] ([i915#79])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk2/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk3/igt@kms_flip@[email protected]* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [PASS][43] -> [FAIL][44] ([i915#2122])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl1/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl6/igt@kms_flip@[email protected]* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-skl: NOTRUN -> [INCOMPLETE][45] ([i915#3701])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][46] -> [DMESG-WARN][47] ([i915#180]) +5 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl1/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-glk: NOTRUN -> [SKIP][48] ([fdo#109271]) +7 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109280]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-plflip-blt.html* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#109280] / [fdo#111825])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@[email protected]* igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-edp-1-pipe-a:
- shard-skl: NOTRUN -> [FAIL][51] ([i915#1188])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl7/igt@kms_hdr@[email protected]* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#533]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@[email protected]* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][53] ([fdo#108145] / [i915#265])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl7/igt@[email protected]* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-skl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl8/igt@[email protected]* igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format:
- shard-iclb: [PASS][55] -> [SKIP][56] ([i915#5176]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb8/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html* igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format:
- shard-iclb: [PASS][57] -> [INCOMPLETE][58] ([i915#1982] / [i915#5395])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb1/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@kms_plane_scaling@scaler-with-pixel-format-unity-scaling@pipe-b-edp-1-scaler-with-pixel-format.html* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#658]) +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@[email protected]* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][60] -> [SKIP][61] ([fdo#109441])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][62] ([i915#132] / [i915#3467])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@kms_psr@psr2_sprite_plane_onoff.html* igt@kms_psr@psr2_sprite_render:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109441])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@kms_psr@psr2_sprite_render.html* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-a:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271]) +271 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl3/igt@kms_scaling_modes@[email protected]* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#112283])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@perf_pmu@[email protected]* igt@prime_udl:
- shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109291])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@prime_udl.html* igt@syncobj_timeline@transfer-timeline-point:
- shard-apl: NOTRUN -> [DMESG-FAIL][67] ([i915#5098])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl7/igt@[email protected]* igt@sysfs_clients@fair-1:
- shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2994])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]* igt@sysfs_clients@recycle:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#2994])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb1/igt@[email protected]* igt@sysfs_clients@sema-10:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2994]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl8/igt@[email protected]#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-tglb: [FAIL][71] ([i915#2846]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglb7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglb5/igt@[email protected]* igt@gem_exec_fair@basic-none-share@rcs0:
- {shard-tglu}: [FAIL][73] ([i915#2842]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglu-5/igt@gem_exec_fair@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglu-8/igt@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][75] ([i915#2842]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-apl6/igt@gem_exec_fair@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl3/igt@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [FAIL][77] ([i915#2842]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl3/igt@gem_exec_fair@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl6/igt@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-iclb: [FAIL][79] ([i915#2842]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb1/igt@gem_exec_fair@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb8/igt@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][81] ([i915#2849]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb6/igt@gem_exec_fair@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb7/igt@gem_exec_fair@[email protected]* igt@gem_exec_flush@basic-uc-set-default:
- shard-snb: [SKIP][83] ([fdo#109271]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-snb6/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-snb5/igt@[email protected]* igt@gem_softpin@allocator-evict-all-engines:
- shard-glk: [FAIL][85] ([i915#4171]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk2/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][87] ([i915#5566] / [i915#716]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk2/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk6/igt@[email protected]* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][89] ([i915#5566] / [i915#716]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-skl3/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-skl10/igt@[email protected]* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-glk: [FAIL][91] ([i915#2346]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk3/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk4/igt@[email protected]* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [FAIL][93] ([i915#79]) -> [PASS][94] +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk3/igt@kms_flip@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk8/igt@kms_flip@[email protected]* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][95] ([i915#180]) -> [PASS][96] +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-apl6/igt@kms_flip@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-apl7/igt@kms_flip@[email protected]* igt@kms_plane_lowres@pipe-a-tiling-none:
- {shard-tglu}: [FAIL][97] ([i915#3957]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-tglu-1/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-tglu-2/igt@[email protected]* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][99] ([fdo#109441]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb1/igt@kms_psr@psr2_cursor_render.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@kms_psr@psr2_cursor_render.html#### Warnings ####
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [DMESG-WARN][101] ([i915#5614]) -> [SKIP][102] ([i915#4525])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb1/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb3/igt@[email protected]* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][103] ([i915#4525]) -> [DMESG-WARN][104] ([i915#5614]) +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb5/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb1/igt@[email protected]* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][105] ([i915#2851]) -> [FAIL][106] ([i915#2842])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-glk8/igt@gem_exec_fair@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-glk8/igt@gem_exec_fair@[email protected]* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][107] ([i915#658]) -> [SKIP][108] ([i915#2920])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb6/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@[email protected]* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][109] ([fdo#111068] / [i915#658]) -> [SKIP][110] ([i915#2920]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb6/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb2/igt@[email protected]* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [FAIL][111] ([i915#4148]) -> [SKIP][112] ([fdo#109642] / [fdo#111068] / [i915#658]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-iclb1/igt@kms_psr2_su@page_flip-nv12.html* igt@runner@aborted:
- shard-kbl: ([FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92]) -> ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl1/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl3/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl6/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl7/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl7/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl4/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11504/shard-kbl3/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl7/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl6/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl3/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl4/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl1/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/shard-kbl6/igt@[email protected]{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2851]: https://gitlab.freedesktop.org/drm/intel/issues/2851
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3957]: https://gitlab.freedesktop.org/drm/intel/issues/3957
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4148]: https://gitlab.freedesktop.org/drm/intel/issues/4148
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5076]: https://gitlab.freedesktop.org/drm/intel/issues/5076
[i915#5098]: https://gitlab.freedesktop.org/drm/intel/issues/5098
[i915#5160]: https://gitlab.freedesktop.org/drm/intel/issues/5160
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5395]: https://gitlab.freedesktop.org/drm/intel/issues/5395
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92Build changes
-------------* Linux:
CI_DRM_11504->Patchwork_102719v2CI-20190529: 20190529
CI_DRM_11504:64c052dc4fd1f39ef083b217434f140ed0feca5e@git://anongit.freedesktop.org/gfx-ci/linux
IGT_6437:ea0144ed6ccb66b977f204b4d53b6062ed1cc8bc@ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102719v2:64c052dc4fd1f39ef083b217434f140ed0feca5e@git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509:fdc5a4ca11124ab8413c7988896eec4c97336694@git://anongit.freedesktop.org/piglit== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102719v2/index.html