: sched/fair: Revise comment about lb decision matrix
PATCH RESEND 1/1 : sched/fair: Revise comment about lb decision matrix
If busiest group type is group_misfit_task, the local group type must be group_has_spare according to below code in update_sd_pick_busiest():
if (sgs->group_type == group_misfit_task &&
(!capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) ||
sds->local_stat.group_type != group_has_spare))
return false;group type imbalanced and overloaded and fully_busy are filtered in here. misfit and asym are filtered before in update_sg_lb_stats(). So, change the decision matrix to:
busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
has_spare nr_idle balanced N/A N/A balanced balanced fully_busy nr_idle nr_idle N/A N/A balanced balanced misfit_task force N/A N/A N/A *N/A* *N/A* asym_packing force force N/A N/A force force imbalanced force force N/A N/A force force overloaded force force N/A N/A force avg_load
---
v1 changelog:
(1) Send to MAINTAINERS/REVIEWS get from ./scripts/get_maintainer.pl suggested by Dietmar Eggemann.
(2) Based on v5.18-rc2
v1->v2 changelog:
(1) Add Reviewed-by from Vincent Guittot.
(2) This behavior has changed with
cad68e552e77 ("sched/fair: Consider misfit tasks when load-balancing") and the matrix has not changed.
Add the related people of commit cad68e552e77 to the cc list.
kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
@@ -9495,7 +9495,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s* busiest \ local has_spare fully_busy misfit asym imbalanced overloaded * has_spare nr_idle balanced N/A N/A balanced balanced * fully_busy nr_idle nr_idle N/A N/A balanced balanced -* misfit_task force N/A N/A N/A force force +* misfit_task force N/A N/A N/A N/A N/A * asym_packing force force N/A N/A force force * imbalanced force force N/A N/A force force * overloaded force force N/A N/A force avg_load
Signature · 1 line
2.35.2
[tip: sched/core] sched/fair: Revise comment about lb decision matrix
The following commit has been merged into the sched/core branch of tip:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: a658353167bf2ea6052cee071dbcc13e0f229dc9 Gitweb: https://git.kernel.org/tip/a658353167bf2ea6052cee071dbcc13e0f229dc9 Author: Tao Zhou <[email protected]> AuthorDate: Fri, 15 Apr 2022 17:55:04 +08:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Fri, 22 Apr 2022 12:14:08 +02:00
sched/fair: Revise comment about lb decision matrix
If busiest group type is group_misfit_task, the local group type must be group_has_spare according to below code in update_sd_pick_busiest():
if (sgs->group_type == group_misfit_task &&
(!capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) ||
sds->local_stat.group_type != group_has_spare))
return false;group type imbalanced and overloaded and fully_busy are filtered in here. misfit and asym are filtered before in update_sg_lb_stats(). So, change the decision matrix to:
busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
has_spare nr_idle balanced N/A N/A balanced balanced fully_busy nr_idle nr_idle N/A N/A balanced balanced misfit_task force N/A N/A N/A *N/A* *N/A* asym_packing force force N/A N/A force force imbalanced force force N/A N/A force force overloaded force force N/A N/A force avg_load
--- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
@@ -9496,7 +9496,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s* busiest \ local has_spare fully_busy misfit asym imbalanced overloaded * has_spare nr_idle balanced N/A N/A balanced balanced * fully_busy nr_idle nr_idle N/A N/A balanced balanced -* misfit_task force N/A N/A N/A force force +* misfit_task force N/A N/A N/A N/A N/A * asym_packing force force N/A N/A force force * imbalanced force force N/A N/A force force * overloaded force force N/A N/A force avg_load