Skip to contentSkip to conversation

rapidio: Remove redundant variable tmp

PATCH New Colin Ian King 1 participant 1 message Apr 18, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rapidio: Remove redundant variable tmp

Variable tmp is being assigned a value that is never read, the variable is redundant and can be removed.

Cleans up clang scan build warning:
drivers/rapidio/rio-scan.c:561:10: warning: Although the value stored to 'tmp' is used in the enclosing expression, the value is never actually read from 'tmp' [deadcode.DeadStores]

---
 drivers/rapidio/rio-scan.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/rapidio/rio-scan.c +1 -3
index 19b0c33f4a62..5256e76ab29c 100644
@@ -524,7 +524,6 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
 {
 	struct rio_dev *rdev;
 	u32 regval;
-	int tmp;
 
 	if (rio_mport_chk_dev_access(port,
 			RIO_ANY_DESTID(port->sys_size), hopcount)) {
@@ -558,8 +557,7 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
 	rio_mport_write_config_32(port, RIO_ANY_DESTID(port->sys_size),
 				  hopcount,
 				  RIO_HOST_DID_LOCK_CSR, port->host_deviceid);
-	while ((tmp = rio_get_host_deviceid_lock(port, hopcount))
-	       < port->host_deviceid) {
+	while (rio_get_host_deviceid_lock(port, hopcount) < port->host_deviceid) {
 		/* Delay a bit */
 		mdelay(1);
 		/* Attempt to acquire device lock again */
Signature · 1 line
2.35.1