Skip to contentSkip to conversation

RDMA/rxe: Fix "Replace mr by rkey in responder resources"

PATCH Applied Bob Pearson 3 participants 5 messages Apr 18, 2022 – Apr 20, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 RDMA/rxe: Fix "Replace mr by rkey in responder resources"

The rping benchmark fails on long runs. The root cause of this failure has been traced to a failure to compute a nonzero value of mr in rare situations.

Fix this failure by correctly handling the computation of mr in read_reply() in rxe_resp.c in the replay flow.

Fixes 8a1a0be894da ("RDMA/rxe: Replace mr by rkey in responder resources")

---
v2
Renamed commit
Changed fixes line to correctly ID the bug
Added a link to the reported mr == NULL issue

 drivers/infiniband/sw/rxe/rxe_resp.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/infiniband/sw/rxe/rxe_resp.c +8 -2
index e2653a8721fe..2e627685e804 100644
@@ -734,8 +734,14 @@ static enum resp_states read_reply(struct rxe_qp *qp,
 	}
 
 	if (res->state == rdatm_res_state_new) {
-		mr = qp->resp.mr;
-		qp->resp.mr = NULL;
+		if (!res->replay) {
+			mr = qp->resp.mr;
+			qp->resp.mr = NULL;
+		} else {
+			mr = rxe_recheck_mr(qp, res->read.rkey);
+			if (!mr)
+				return RESPST_ERR_RKEY_VIOLATION;
+		}
 
 		if (res->read.resid <= mtu)
 			opcode = IB_OPCODE_RC_RDMA_READ_RESPONSE_ONLY;

base-commit: 98c8026331ceabe1df579940b81eec75eb49cdd9

Signature · 1 line
2.32.0
maintainer
#1 lore raw
Quoted 10 lines · Bob Pearson

The rping benchmark fails on long runs. The root cause of this failure has been traced to a failure to compute a nonzero value of mr in rare situations.

Fix this failure by correctly handling the computation of mr in read_reply() in rxe_resp.c in the replay flow.

Fixes 8a1a0be894da ("RDMA/rxe: Replace mr by rkey in responder resources")
Quoted 8 lines

---
v2
Renamed commit
Changed fixes line to correctly ID the bug
Added a link to the reported mr == NULL issue

 drivers/infiniband/sw/rxe/rxe_resp.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

I'm confused, does this one replace this patch:

https://lore.kernel.org/all/[email protected]/

?

It has the same title but is completely different

Jason

#2 lore raw
Quoted 5 lines

I'm confused, does this one replace this patch:
https://lore.kernel.org/all/[email protected]/
?
It has the same title but is completely different
Jason

This is a new bug. It needs a better title. Is the old one still hanging around or was it accepted upstream? We could call this "Fix read_reply in rxe_resp.c" or anything else that works for you.

maintainer Applied
#3 lore raw
In reply to Bob Pearson
Quoted 10 lines · Bob Pearson

The rping benchmark fails on long runs. The root cause of this failure has been traced to a failure to compute a nonzero value of mr in rare situations.

Fix this failure by correctly handling the computation of mr in read_reply() in rxe_resp.c in the replay flow.

Fixes 8a1a0be894da ("RDMA/rxe: Replace mr by rkey in responder resources")
Quoted 8 lines

---
v2
Renamed commit
Changed fixes line to correctly ID the bug
Added a link to the reported mr == NULL issue

 drivers/infiniband/sw/rxe/rxe_resp.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Applied to for-rc, thanks

Jason

#4 lore raw

thanks

-----Original Message-----
From: Jason Gunthorpe <[email protected]>
Sent: Wednesday, April 20, 2022 10:53 AM
To: Bob Pearson <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH for-next v2] RDMA/rxe: Fix "Replace mr by rkey in responder resources"

Quoted 13 lines · Bob Pearson

The rping benchmark fails on long runs. The root cause of this failure has been traced to a failure to compute a nonzero value of mr in rare situations.

Fix this failure by correctly handling the computation of mr in read_reply() in rxe_resp.c in the replay flow.

Fixes 8a1a0be894da ("RDMA/rxe: Replace mr by rkey in responder

resources")
Link:
https://lore.kernel.org/linux-rdma/1a9a9190-368d-3442-0a62-443b1a6c120
[email protected]/

Quoted 8 lines

---
v2
Renamed commit
Changed fixes line to correctly ID the bug
Added a link to the reported mr == NULL issue

 drivers/infiniband/sw/rxe/rxe_resp.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Applied to for-rc, thanks

Jason