arm: boards: Add support for MYIR MYD-AM335X Development Board

The MYD-AM335X Development Board designed by MYIR is a high-performance ARM Evaluation Module (EVM) using the MYC-AM335X CPU module as the core controller board. It is based on up to 1GHz Texas Instruments (TI) Sitara AM335x family of ARM Cortex-A8 Microprocessors (MPUs) that deliver high DMIPs at a low cost while also delivering optional 3D graphics acceleration and key peripherals.

Signed-off-by Alexander Shiyan <[email protected]>

---
 arch/arm/boards/Makefile                      |   1 +
 arch/arm/boards/myirtech-x335x/Makefile       |   3 +
 arch/arm/boards/myirtech-x335x/board.c        |  44 +++++++
 .../defaultenv-myirtech-x335x/boot/nand       |   4 +
 .../defaultenv-myirtech-x335x/nv/boot.default |   1 +
 .../nv/linux.bootargs.console                 |   1 +
 arch/arm/boards/myirtech-x335x/lowlevel.c     | 113 ++++++++++++++++++
 arch/arm/configs/am335x_mlo_defconfig         |   1 +
 .../arm/configs/myirtech_am335x_myd_defconfig | 109 +++++++++++++++++
 arch/arm/dts/Makefile                         |   1 +
 arch/arm/dts/am335x-myirtech-myd.dts          |  23 ++++
 arch/arm/mach-omap/Kconfig                    |   6 +
 .../arm/mach-omap/include/mach/am33xx-clock.h |   1 +
 .../mach-omap/include/mach/am33xx-silicon.h   |   2 +
 images/Makefile.am33xx                        |   8 ++
 15 files changed, 318 insertions(+)
 create mode 100644 arch/arm/boards/myirtech-x335x/Makefile
 create mode 100644 arch/arm/boards/myirtech-x335x/board.c
 create mode 100644 arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/boot/nand
 create mode 100644 arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/nv/boot.default
 create mode 100644 arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/nv/linux.bootargs.console
 create mode 100644 arch/arm/boards/myirtech-x335x/lowlevel.c
 create mode 100644 arch/arm/configs/myirtech_am335x_myd_defconfig
 create mode 100644 arch/arm/dts/am335x-myirtech-myd.dts

arch/arm/boards/Makefile +1 -0

index 75e15cbda4..d303999614 100644
@@ -77,6 +77,7 @@ obj-$(CONFIG_MACH_MB7707)			+= module-mb7707/
 obj-$(CONFIG_MACH_MIOA701)			+= mioa701/
 obj-$(CONFIG_MACH_MX23EVK)			+= freescale-mx23-evk/
 obj-$(CONFIG_MACH_MX28EVK)			+= freescale-mx28-evk/
+obj-$(CONFIG_MACH_MYIRTECH_X335X)		+= myirtech-x335x/
 obj-$(CONFIG_MACH_NESO)				+= guf-neso/
 obj-$(CONFIG_MACH_NETGEAR_RN104)		+= netgear-rn104/
 obj-$(CONFIG_MACH_NETGEAR_RN2120)		+= netgear-rn2120/

arch/arm/boards/myirtech-x335x/Makefile new file +3 -0

new file mode 100644
index 0000000000..05d9fc7bc3
@@ -0,0 +1,3 @@
+lwl-y					+= lowlevel.o
+obj-y					+= board.o
+bbenv-$(CONFIG_DEFAULT_ENVIRONMENT)	+= defaultenv-myirtech-x335x

arch/arm/boards/myirtech-x335x/board.c new file +5 -0

new file mode 100644
index 0000000000..b5af651254
@@ -0,0 +1,44 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/* SPDX-FileCopyrightText: Alexander Shiyan <[email protected]> */
+
+#include <bootsource.h>
+#include <common.h>

arch/arm/boards/myirtech-x335x/board.c new file +29 -0

+
+static __init int myir_devices_init(void)
+{
+	if (!of_machine_is_compatible("myir,myc-am335x"))
+		return 0;
+
+	am33xx_register_ethaddr(0, 0);
+	am33xx_register_ethaddr(1, 1);
+
+	switch (bootsource_get()) {
+	case BOOTSOURCE_MMC:
+		omap_set_bootmmc_devname("mmc0");
+		break;
+	case BOOTSOURCE_NAND:
+		omap_set_barebox_part(&myir_barebox_part);
+		break;
+	default:
+		break;
+	}
+
+	if (IS_ENABLED(CONFIG_DEFAULT_ENVIRONMENT))
+		defaultenv_append_directory(defaultenv_myirtech_x335x);
+
+	if (IS_ENABLED(CONFIG_SHELL_NONE))
+		return am33xx_of_register_bootdevice();
+
+	return 0;
+}
+coredevice_initcall(myir_devices_init);

arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/boot/nand new file +4 -0

new file mode 100644
index 0000000000..aca093eebb
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+global.bootm.image="/dev/nand0.system.ubi.kernel"
+global.linux.bootargs.dyn.root="ubi.mtd=system ubi.block=0,root ro"

arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/nv/boot.default new file +1 -0

new file mode 100644
index 0000000000..026a25cc7e
@@ -0,0 +1 @@
+nand

arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/nv/linux.bootargs.console new file +0 -0

new file mode 100644
index 0000000000..4310fdd693

Quoted 8 lines

The MYD-AM335X Development Board designed by MYIR is a high-performance ARM Evaluation Module (EVM) using the MYC-AM335X CPU module as the core controller board. It is based on up to 1GHz Texas Instruments (TI) Sitara AM335x family of ARM Cortex-A8 Microprocessors (MPUs) that deliver high DMIPs at a low cost while also delivering optional 3D graphics acceleration and key peripherals.

Signed-off-by Alexander Shiyan <[email protected]>

arch/arm/boards/myirtech-x335x/board.c line 15

Quoted 4 lines

arch/arm/boards/myirtech-x335x/board.c new file +4 -0

+static struct omap_barebox_part myir_barebox_part = {
+     .nand_offset = SZ_128K,
+     .nand_size = SZ_512K,
+};

Isn't this a bit too small? Putting a barebox into 128k seems very ambicous.

arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/nv/linux.bootargs.console line 1

Quoted 3 lines

+++ b/arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/nv/linux.bootargs.console

arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/nv/linux.bootargs.console new file +1 -0

@@ -0,0 +1 @@
+console=ttyS0,115200n8 earlyprintk

The console= part shouldn't be needed. barebox should add a console= parameter matching the current barebox console automatically.

I wouldn't add the earlyprintk by default. It might break booting when the kernel is not exactly configured for your board. Anyway, that's personal taste.

arch/arm/configs/myirtech_am335x_myd_defconfig

Quoted 1 line

arch/arm/configs/myirtech_am335x_myd_defconfig +0 -0

Do you need this config? I rather prefer to add the board to some existing config, omap_defconfig in this case.

чт, 21 апр. 2022 г. в 10:35, Sascha Hauer <[email protected]>:

Quoted 10 lines · Alexander Shiyan

Quoted 8 lines

The MYD-AM335X Development Board designed by MYIR is a high-performance ARM Evaluation Module (EVM) using the MYC-AM335X CPU module as the core controller board. It is based on up to 1GHz Texas Instruments (TI) Sitara AM335x family of ARM Cortex-A8 Microprocessors (MPUs) that deliver high DMIPs at a low cost while also delivering optional 3D graphics acceleration and key peripherals.

Signed-off-by Alexander Shiyan <[email protected]>

...

Quoted 7 lines

arch/arm/boards/myirtech-x335x/board.c line 15

Quoted 4 lines

arch/arm/boards/myirtech-x335x/board.c new file +4 -0

+static struct omap_barebox_part myir_barebox_part = {
+     .nand_offset = SZ_128K,
+     .nand_size = SZ_512K,
+};

Isn't this a bit too small? Putting a barebox into 128k seems very ambicous.

The boot image (MLO) should not exceed 128 KB in size, so I think this should be enough.
In any case this size is already specified for the boot partition in kernel DTS for this board. :)

Quoted 20 lines

чт, 21 апр. 2022 г. в 10:35, Sascha Hauer <[email protected]>:

Quoted 10 lines · Alexander Shiyan

Quoted 8 lines

The MYD-AM335X Development Board designed by MYIR is a high-performance ARM Evaluation Module (EVM) using the MYC-AM335X CPU module as the core controller board. It is based on up to 1GHz Texas Instruments (TI) Sitara AM335x family of ARM Cortex-A8 Microprocessors (MPUs) that deliver high DMIPs at a low cost while also delivering optional 3D graphics acceleration and key peripherals.

Signed-off-by Alexander Shiyan <[email protected]>

...

Quoted 7 lines

arch/arm/boards/myirtech-x335x/board.c line 15

Quoted 4 lines

arch/arm/boards/myirtech-x335x/board.c new file +4 -0

+static struct omap_barebox_part myir_barebox_part = {
+     .nand_offset = SZ_128K,
+     .nand_size = SZ_512K,
+};

Isn't this a bit too small? Putting a barebox into 128k seems very ambicous.

Quoted 4 lines

The boot image (MLO) should not exceed 128 KB in size, so I think this should be enough.
In any case this size is already specified for the boot partition in kernel DTS for this board. :)

Oh, I accidently misread nand_size as SZ_128K. Indeed it's SZ_512K which is small, but sufficient. Anyway, the BBU code assumes 4 eraseblocks for the four MLO images. That would be a nand_offset of SZ_512K also, which would then also match the upstream device tree for the board:

&nand0 {
        partition@0 {
                label = "MLO";
                reg = <0x00000 0x20000>;
        };

        partition@20000 {
                label = "boot";
                reg = <0x20000 0x80000>;
        };
};

512k is still very small nowadays. The images built with omap_defconfig are just a bit smaller than that.

чт, 21 апр. 2022 г. в 11:30, Sascha Hauer <[email protected]>:

Quoted 43 lines · Alexander Shiyan

Quoted 20 lines

чт, 21 апр. 2022 г. в 10:35, Sascha Hauer <[email protected]>:

Quoted 10 lines · Alexander Shiyan

Quoted 8 lines

The MYD-AM335X Development Board designed by MYIR is a high-performance ARM Evaluation Module (EVM) using the MYC-AM335X CPU module as the core controller board. It is based on up to 1GHz Texas Instruments (TI) Sitara AM335x family of ARM Cortex-A8 Microprocessors (MPUs) that deliver high DMIPs at a low cost while also delivering optional 3D graphics acceleration and key peripherals.

Signed-off-by Alexander Shiyan <[email protected]>

...

Quoted 7 lines

arch/arm/boards/myirtech-x335x/board.c line 15

Quoted 4 lines

arch/arm/boards/myirtech-x335x/board.c new file +4 -0

+static struct omap_barebox_part myir_barebox_part = {
+     .nand_offset = SZ_128K,
+     .nand_size = SZ_512K,
+};

Isn't this a bit too small? Putting a barebox into 128k seems very ambicous.

Quoted 4 lines

The boot image (MLO) should not exceed 128 KB in size, so I think this should be enough.
In any case this size is already specified for the boot partition in kernel DTS for this board. :)

Oh, I accidently misread nand_size as SZ_128K. Indeed it's SZ_512K which is small, but sufficient. Anyway, the BBU code assumes 4 eraseblocks for the four MLO images. That would be a nand_offset of SZ_512K also, which would then also match the upstream device tree for the board:

&nand0 {
        partition@0 {
                label = "MLO";
                reg = <0x00000 0x20000>;
        };

        partition@20000 {
                label = "boot";
                reg = <0x20000 0x80000>;
        };
};

Quoted 2 lines

512k is still very small nowadays. The images built with omap_defconfig are just a bit smaller than that.

Do you prefer that we fix this in the local overlay now, or leave it as is until kernel DTS upstream changes?

Quoted 4 lines

чт, 21 апр. 2022 г. в 11:30, Sascha Hauer <[email protected]>:

Quoted 3 lines · Alexander Shiyan

Quoted 2 lines

чт, 21 апр. 2022 г. в 10:35, Sascha Hauer <[email protected]>:

Quoted 1 line · Alexander Shiyan

Quoted 11 lines

Quoted 11 lines

&nand0 {
        partition@0 {
                label = "MLO";
                reg = <0x00000 0x20000>;
        };

        partition@20000 {
                label = "boot";
                reg = <0x20000 0x80000>;
        };
};

Do it locally for now. BTW you used a legacy binding here. Nowadays the partitions are under a partitions node with compatible "fixed-partitions".