Skip to contentSkip to conversation

automake: Drop redundant 'u' flag in ARFLAGS

PATCH In review Andrei Gherzan 2 participants 3 messages Apr 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 automake: Drop redundant 'u' flag in ARFLAGS

From: Andrei Gherzan <[email protected]>

---
 .../automake/0001-Drop-ar-u-argument.patch    | 32 +++++++++++++++++++
 .../automake/automake_1.16.5.bb               |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch
meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch new file +32 -0
new file mode 100644
index 0000000000..260c51f517
@@ -0,0 +1,32 @@
+From bed646918bc67e9e2151ccbda03aae34717821fe Mon Sep 17 00:00:00 2001
+From: Andrei Gherzan <[email protected]>
+Date: Wed, 20 Apr 2022 14:57:14 +0200
+Subject: [PATCH] Drop ar 'u' argument
+
+binutils/ar is configured in deterministic mode by default making the
+'u' argument irrelevant while leading to warning massages similar to:
+
+| ar: `u' modifier ignored since `D' is the default (see `U')
+
+Upstream-Status: Pending
+Signed-off-by: Andrei Gherzan <[email protected]>
+---
+ bin/automake.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/bin/automake.in b/bin/automake.in
+index 92bcebe..0f2b84b 100644
+--- a/bin/automake.in
++++ b/bin/automake.in
+@@ -2678,7 +2678,7 @@ sub handle_libraries ()
+     }
+ 
+   define_variable ('AR', 'ar', INTERNAL);
+-  define_variable ('ARFLAGS', 'cru', INTERNAL);
++  define_variable ('ARFLAGS', 'cr', INTERNAL);
+   define_verbose_tagvar ('AR');
+ 
+   foreach my $pair (@liblist)
+-- 
+2.25.1
+
meta/recipes-devtools/automake/automake_1.16.5.bb +1 -0
index ba5ce7b9bb..469fcd69f7 100644
@@ -25,6 +25,7 @@ SRC_URI += "\
            file://new_rt_path_for_test-driver.patch \
            file://0001-automake-Add-default-libtool_tag-to-cppasm.patch \
            file://0001-build-fix-race-in-parallel-builds.patch \
+           file://0001-Drop-ar-u-argument.patch \
            "
 
 SRC_URI[sha256sum] = "07bd24ad08a64bc17250ce09ec56e921d6343903943e99ccf63bbf0705e34605"
Signature · 1 line
2.25.1
#1 lore raw
Quoted 16 lines · Andrei Gherzan

From: Andrei Gherzan <[email protected]>

---
 .../automake/0001-Drop-ar-u-argument.patch    | 32 +++++++++++++++++++
 .../automake/automake_1.16.5.bb               |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch
meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch new file +0 -0
new file mode 100644
index 0000000000..260c51f517

meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch line 10

Quoted 10 lines
meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch new file +10 -0
@@ -0,0 +1,32 @@
+From bed646918bc67e9e2151ccbda03aae34717821fe Mon Sep 17 00:00:00 2001
+From: Andrei Gherzan <[email protected]>
+Date: Wed, 20 Apr 2022 14:57:14 +0200
+Subject: [PATCH] Drop ar 'u' argument
+
+binutils/ar is configured in deterministic mode by default making the
+'u' argument irrelevant while leading to warning massages similar to:
+
+| ar: `u' modifier ignored since `D' is the default (see `U')
+

this is perhaps due to the way we build binutils and I am fine with removing -u here but
I think the patch is OE specific. While you are here can you add -D explicitly, because we
do have option to use llvm ar and it would help those distributions to create reproducible archives too.

Quoted 46 lines
meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch new file +22 -0
+Upstream-Status: Pending
+Signed-off-by: Andrei Gherzan <[email protected]>
+---
+ bin/automake.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/bin/automake.in b/bin/automake.in
+index 92bcebe..0f2b84b 100644
+--- a/bin/automake.in
++++ b/bin/automake.in
+@@ -2678,7 +2678,7 @@ sub handle_libraries ()
+     }
+
+   define_variable ('AR', 'ar', INTERNAL);
+-  define_variable ('ARFLAGS', 'cru', INTERNAL);
++  define_variable ('ARFLAGS', 'cr', INTERNAL);
+   define_verbose_tagvar ('AR');
+
+   foreach my $pair (@liblist)
+--
+2.25.1
+
meta/recipes-devtools/automake/automake_1.16.5.bb +1 -1
index ba5ce7b9bb..469fcd69f7 100644
@@ -25,6 +25,7 @@ SRC_URI += "\
            file://new_rt_path_for_test-driver.patch \
            file://0001-automake-Add-default-libtool_tag-to-cppasm.patch \
            file://0001-build-fix-race-in-parallel-builds.patch \
+           file://0001-Drop-ar-u-argument.patch \
            "
 
 SRC_URI[sha256sum] = "07bd24ad08a64bc17250ce09ec56e921d6343903943e99ccf63bbf0705e34605"
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164702): https://lists.openembedded.org/g/openembedded-core/message/164702
Mute This Topic: https://lists.openembedded.org/mt/90586101/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 26 lines · Khem Raj
Quoted 25 lines · Andrei Gherzan

From: Andrei Gherzan <[email protected]>

---
 .../automake/0001-Drop-ar-u-argument.patch    | 32 +++++++++++++++++++
 .../automake/automake_1.16.5.bb               |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch
meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch new file +9 -0
new file mode 100644
index 0000000000..260c51f517
@@ -0,0 +1,32 @@
+From bed646918bc67e9e2151ccbda03aae34717821fe Mon Sep 17 00:00:00 2001
+From: Andrei Gherzan <[email protected]>
+Date: Wed, 20 Apr 2022 14:57:14 +0200
+Subject: [PATCH] Drop ar 'u' argument
+
+binutils/ar is configured in deterministic mode by default making the
+'u' argument irrelevant while leading to warning massages similar to:
+
+| ar: `u' modifier ignored since `D' is the default (see `U')
Quoted 8 lines

meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch line 10

Quoted 1 line
meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch new file +1 -0
+

this is perhaps due to the way we build binutils and I am fine with removing -u here but
I think the patch is OE specific. While you are here can you add -D explicitly, because we
do have option to use llvm ar and it would help those distributions to create reproducible archives too.

Agreed. I'll send v2.

Andrei