Skip to contentSkip to conversation

drm/amd/display: Fix memory leak in dcn21_clock_source_create

PATCH Applied Miaoqian Lin 2 participants 2 messages Apr 21, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/display: Fix memory leak in dcn21_clock_source_create

When dcn20_clk_src_construct() fails, we need to release clk_src.

Fixes 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)")
---
 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +1 -0
index 3fe4bfbb98a0..faab59508d82 100644
@@ -997,6 +997,7 @@ static struct clock_source *dcn21_clock_source_create(
 		return &clk_src->base;
 	}
 
+	kfree(clk_src);
 	BREAK_TO_DEBUGGER();
 	return NULL;
 }
Signature · 1 line
2.17.1
Applied
#1 lore raw

Applied. Thanks!

Alex

Quoted 24 lines · Miaoqian Lin

When dcn20_clk_src_construct() fails, we need to release clk_src.

Fixes 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)")
---
 drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c +1 -1
index 3fe4bfbb98a0..faab59508d82 100644
@@ -997,6 +997,7 @@ static struct clock_source *dcn21_clock_source_create(
                return &clk_src->base;
        }
 
+       kfree(clk_src);
        BREAK_TO_DEBUGGER();
        return NULL;
 }
--

2.17.1