target/xtensa: use tcg_constant_* where possible
cover target/xtensa: use tcg_constant_* where possible
Hello,
this series replaces tcg_const_* with tcg_constant_* in the xtensa front end.
Max Filippov (6):
target/xtensa: use tcg_contatnt_* for numeric literals target/xtensa: use tcg_constant_* for exceptions target/xtensa: use tcg_constant_* for TLB opcodes target/xtensa: use tcg_constant_* for numbered special registers target/xtensa: use tcg_constant_* for FPU conversion opcodes target/xtensa: use tcg_constant_* for remaining opcodes
target/xtensa/translate.c | 130 ++++++++++++-------------------------- 1 file changed, 39 insertions(+), 91 deletions(-)
Signature · 1 line
2.30.2
PATCH 1/6 target/xtensa: use tcg_contatnt_* for numeric literals
Replace tcg_const_* for numeric literals with tcg_constant_*.
--- target/xtensa/translate.c | 28 +++++++++------------------- 1 file changed, 9 insertions(+), 19 deletions(-)
target/xtensa/translate.c +9 -19
@@ -306,16 +306,14 @@ static void gen_right_shift_sar(DisasContext *dc, TCGv_i32 sa)static void gen_left_shift_sar (DisasContext *dc,TCGv_i32 sa) { -TCGv_i32 tmp =tcg_const_i32 (32 );if (!dc->sar_m32_allocated) { dc->sar_m32 =tcg_temp_local_new_i32 (); dc->sar_m32_allocated = true; }tcg_gen_andi_i32 (dc->sar_m32, sa,0x1f ); -tcg_gen_sub_i32 (cpu_SR[SAR ], tmp, dc->sar_m32); +tcg_gen_sub_i32 (cpu_SR[SAR ],tcg_constant_i32 (32 ), dc->sar_m32); dc->sar_5bit = false; dc->sar_m32_5bit = true; -tcg_temp_free (tmp); }static void gen_exception (DisasContext *dc,int excp)
@@ -1957,11 +1955,10 @@ static void translate_mov(DisasContext *dc, const OpcodeArg arg[],static void translate_movcond (DisasContext *dc,const OpcodeArg arg[],const uint32_t par[]) { -TCGv_i32 zero =tcg_const_i32 (0 ); +TCGv_i32 zero =tcg_constant_i32 (0 );tcg_gen_movcond_i32 (par[0 ], arg[0 ].out, arg[2 ].in, zero, arg[1 ].in, arg[0 ].in); -tcg_temp_free (zero); } static void translate_movi(DisasContext *dc, const OpcodeArg arg[],
@@ -1973,7 +1970,7 @@ static void translate_movi(DisasContext *dc, const OpcodeArg arg[],static void translate_movp (DisasContext *dc,const OpcodeArg arg[],const uint32_t par[]) { -TCGv_i32 zero =tcg_const_i32 (0 ); +TCGv_i32 zero =tcg_constant_i32 (0 );TCGv_i32 tmp =tcg_temp_new_i32 ();tcg_gen_andi_i32 (tmp, arg[2 ].in,1 << arg[2 ].imm);
@@ -1981,7 +1978,6 @@ static void translate_movp(DisasContext *dc, const OpcodeArg arg[], arg[0 ].out, tmp, zero, arg[1].in, arg[0].in);tcg_temp_free (tmp); -tcg_temp_free (zero); } static void translate_movsp(DisasContext *dc, const OpcodeArg arg[],
@@ -6444,7 +6440,7 @@ static void translate_compare_d(DisasContext *dc, const OpcodeArg arg[], [COMPARE_OLE] = gen_helper_ole_d, [COMPARE_ULE] = gen_helper_ule_d, }; -TCGv_i32 zero =tcg_const_i32 (0 ); +TCGv_i32 zero =tcg_constant_i32 (0 );TCGv_i32 res =tcg_temp_new_i32 ();TCGv_i32 set_br =tcg_temp_new_i32 ();TCGv_i32 clr_br =tcg_temp_new_i32 ();
@@ -6456,7 +6452,6 @@ static void translate_compare_d(DisasContext *dc, const OpcodeArg arg[],tcg_gen_movcond_i32 (TCG_COND_NE , arg[0 ].out, res, zero, set_br, clr_br); -tcg_temp_free (zero);tcg_temp_free (res);tcg_temp_free (set_br);tcg_temp_free (clr_br);
@@ -6476,7 +6471,7 @@ static void translate_compare_s(DisasContext *dc, const OpcodeArg arg[], [COMPARE_ULE] = gen_helper_ule_s, };OpcodeArg arg32[3 ]; -TCGv_i32 zero =tcg_const_i32 (0 ); +TCGv_i32 zero =tcg_constant_i32 (0 );TCGv_i32 res =tcg_temp_new_i32 ();TCGv_i32 set_br =tcg_temp_new_i32 ();TCGv_i32 clr_br =tcg_temp_new_i32 ();
@@ -6490,7 +6485,6 @@ static void translate_compare_s(DisasContext *dc, const OpcodeArg arg[], arg[0 ].out, res, zero, set_br, clr_br);put_f32_i2 (arg, arg32,1 ,2 ); -tcg_temp_free (zero);tcg_temp_free (res);tcg_temp_free (set_br);tcg_temp_free (clr_br);
@@ -6666,14 +6660,13 @@ static void translate_mov_s(DisasContext *dc, const OpcodeArg arg[],static void translate_movcond_d (DisasContext *dc,const OpcodeArg arg[],const uint32_t par[]) { -TCGv_i64 zero =tcg_const_i64 (0 ); +TCGv_i64 zero =tcg_constant_i64 (0 );TCGv_i64 arg2 =tcg_temp_new_i64 ();tcg_gen_ext_i32_i64 (arg2, arg[2 ].in);tcg_gen_movcond_i64 (par[0 ], arg[0 ].out, arg2, zero, arg[1 ].in, arg[0 ].in); -tcg_temp_free_i64 (zero);tcg_temp_free_i64 (arg2); }
@@ -6681,12 +6674,11 @@ static void translate_movcond_s(DisasContext *dc, const OpcodeArg arg[], const uint32_t par[]) {if (arg[0 ].num_bits ==32 ) { -TCGv_i32 zero =tcg_const_i32 (0 ); +TCGv_i32 zero =tcg_constant_i32 (0 );tcg_gen_movcond_i32 (par[0 ], arg[0 ].out, arg[2 ].in, zero, arg[1 ].in, arg[0 ].in); -tcg_temp_free (zero); }else {translate_movcond_d (dc, arg, par); }
@@ -6695,7 +6687,7 @@ static void translate_movcond_s(DisasContext *dc, const OpcodeArg arg[],static void translate_movp_d (DisasContext *dc,const OpcodeArg arg[],const uint32_t par[]) { -TCGv_i64 zero =tcg_const_i64 (0 ); +TCGv_i64 zero =tcg_constant_i64 (0 );TCGv_i32 tmp1 =tcg_temp_new_i32 ();TCGv_i64 tmp2 =tcg_temp_new_i64 ();
@@ -6704,7 +6696,6 @@ static void translate_movp_d(DisasContext *dc, const OpcodeArg arg[],tcg_gen_movcond_i64 (par[0 ], arg[0 ].out, tmp2, zero, arg[1 ].in, arg[0 ].in); -tcg_temp_free_i64 (zero);tcg_temp_free_i32 (tmp1);tcg_temp_free_i64 (tmp2); }
@@ -6713,7 +6704,7 @@ static void translate_movp_s(DisasContext *dc, const OpcodeArg arg[], const uint32_t par[]) {if (arg[0 ].num_bits ==32 ) { -TCGv_i32 zero =tcg_const_i32 (0 ); +TCGv_i32 zero =tcg_constant_i32 (0 );TCGv_i32 tmp =tcg_temp_new_i32 ();tcg_gen_andi_i32 (tmp, arg[2 ].in,1 << arg[2 ].imm);
@@ -6721,7 +6712,6 @@ static void translate_movp_s(DisasContext *dc, const OpcodeArg arg[], arg[0 ].out, tmp, zero, arg[1].in, arg[0].in);tcg_temp_free (tmp); -tcg_temp_free (zero); }else {translate_movp_d (dc, arg, par); }
Signature · 1 line
2.30.2
Re: [PATCH 1/6] target/xtensa: use tcg_contatnt_* for numeric literals
Quoted 6 lines · Max Filippov
Replace tcg_const_* for numeric literals with tcg_constant_*.
Signed-off-by Max Filippov<[email protected]>--- target/xtensa/translate.c | 28 +++++++++------------------- 1 file changed, 9 insertions(+), 19 deletions(-)
r~
PATCH 2/6 target/xtensa: use tcg_constant_* for exceptions
In reply to Max FilippovException number, exception cause and debug cause codes are small numbers, use tcg_contant_* for them.
--- target/xtensa/translate.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
target/xtensa/translate.c +3 -9
@@ -318,18 +318,14 @@ static void gen_left_shift_sar(DisasContext *dc, TCGv_i32 sa)static void gen_exception (DisasContext *dc,int excp) { -TCGv_i32 tmp =tcg_const_i32 (excp); -gen_helper_exception (cpu_env, tmp); -tcg_temp_free (tmp); +gen_helper_exception (cpu_env,tcg_constant_i32 (excp)); }static void gen_exception_cause (DisasContext *dc,uint32_t cause) {TCGv_i32 tpc =tcg_const_i32 (dc->pc); -TCGv_i32 tcause =tcg_const_i32 (cause); -gen_helper_exception_cause (cpu_env, tpc, tcause); +gen_helper_exception_cause (cpu_env, tpc,tcg_constant_i32 (cause));tcg_temp_free (tpc); -tcg_temp_free (tcause);if (cause ==ILLEGAL_INSTRUCTION_CAUSE || cause ==SYSCALL_CAUSE ) { dc->base.is_jmp =DISAS_NORETURN ;
@@ -339,10 +335,8 @@ static void gen_exception_cause(DisasContext *dc, uint32_t cause)static void gen_debug_exception (DisasContext *dc,uint32_t cause) {TCGv_i32 tpc =tcg_const_i32 (dc->pc); -TCGv_i32 tcause =tcg_const_i32 (cause); -gen_helper_debug_exception (cpu_env, tpc, tcause); +gen_helper_debug_exception (cpu_env, tpc,tcg_constant_i32 (cause));tcg_temp_free (tpc); -tcg_temp_free (tcause);if (cause & (DEBUGCAUSE_IB |DEBUGCAUSE_BI |DEBUGCAUSE_BN )) { dc->base.is_jmp =DISAS_NORETURN ; }
Signature · 1 line
2.30.2
Re: [PATCH 2/6] target/xtensa: use tcg_constant_* for exceptions
Quoted 7 lines · Max Filippov
Exception number, exception cause and debug cause codes are small numbers, use tcg_contant_* for them.
Signed-off-by Max Filippov<[email protected]>--- target/xtensa/translate.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
r~
PATCH 3/6 target/xtensa: use tcg_constant_* for TLB opcodes
In reply to Max Filippovdtlb is a boolean flag, use tcg_constant_* for it.
--- target/xtensa/translate.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
target/xtensa/translate.c +4 -8
@@ -1710,10 +1710,9 @@ static void translate_itlb(DisasContext *dc, const OpcodeArg arg[], const uint32_t par[]) {#ifndef CONFIG_USER_ONLY -TCGv_i32 dtlb =tcg_const_i32 (par[0 ]); +TCGv_i32 dtlb =tcg_constant_i32 (par[0 ]);gen_helper_itlb (cpu_env, arg[0 ].in, dtlb); -tcg_temp_free (dtlb);#endif }
@@ -2050,11 +2049,10 @@ static void translate_ptlb(DisasContext *dc, const OpcodeArg arg[], const uint32_t par[]) {#ifndef CONFIG_USER_ONLY -TCGv_i32 dtlb =tcg_const_i32 (par[0 ]); +TCGv_i32 dtlb =tcg_constant_i32 (par[0 ]);tcg_gen_movi_i32 (cpu_pc, dc->pc);gen_helper_ptlb (arg[0 ].out, cpu_env, arg[1 ].in, dtlb); -tcg_temp_free (dtlb);#endif }
@@ -2253,10 +2251,9 @@ static void translate_rtlb(DisasContext *dc, const OpcodeArg arg[], gen_helper_rtlb0, gen_helper_rtlb1, }; -TCGv_i32 dtlb =tcg_const_i32 (par[0 ]); +TCGv_i32 dtlb =tcg_constant_i32 (par[0 ]); helper[par[1 ]](arg[0 ].out, cpu_env, arg[1 ].in, dtlb); -tcg_temp_free (dtlb);#endif }
@@ -2564,10 +2561,9 @@ static void translate_wtlb(DisasContext *dc, const OpcodeArg arg[], const uint32_t par[]) {#ifndef CONFIG_USER_ONLY -TCGv_i32 dtlb =tcg_const_i32 (par[0 ]); +TCGv_i32 dtlb =tcg_constant_i32 (par[0 ]);gen_helper_wtlb (cpu_env, arg[0 ].in, arg[1 ].in, dtlb); -tcg_temp_free (dtlb);#endif }
Signature · 1 line
2.30.2
Re: [PATCH 3/6] target/xtensa: use tcg_constant_* for TLB opcodes
Quoted 6 lines · Max Filippov
dtlb is a boolean flag, use tcg_constant_* for it.
Signed-off-by Max Filippov<[email protected]>--- target/xtensa/translate.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
r~
PATCH 4/6 target/xtensa: use tcg_constant_* for numbered special registers
In reply to Max FilippovNumbered special registers are small arrays of consecutive SRs. Use tcg_constant_* for the SR index.
--- target/xtensa/translate.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-)
target/xtensa/translate.c +4 -12
@@ -2615,15 +2615,13 @@ static void translate_wsr_ccompare(DisasContext *dc, const OpcodeArg arg[], {#ifndef CONFIG_USER_ONLY uint32_t id = par[0 ] -CCOMPARE ; -TCGv_i32 tmp =tcg_const_i32 (id);assert (id < dc->config->nccompare);if (tb_cflags (dc->base.tb) &CF_USE_ICOUNT ) {gen_io_start (); }tcg_gen_mov_i32 (cpu_SR[par[0 ]], arg[0 ].in); -gen_helper_update_ccompare (cpu_env, tmp); -tcg_temp_free (tmp); +gen_helper_update_ccompare (cpu_env,tcg_constant_i32 (id));#endif }
@@ -2643,11 +2641,9 @@ static void translate_wsr_dbreaka(DisasContext *dc, const OpcodeArg arg[], {#ifndef CONFIG_USER_ONLY unsigned id = par[0 ] -DBREAKA ; -TCGv_i32 tmp =tcg_const_i32 (id);assert (id < dc->config->ndbreak); -gen_helper_wsr_dbreaka (cpu_env, tmp, arg[0 ].in); -tcg_temp_free (tmp); +gen_helper_wsr_dbreaka (cpu_env,tcg_constant_i32 (id), arg[0 ].in);#endif }
@@ -2656,11 +2652,9 @@ static void translate_wsr_dbreakc(DisasContext *dc, const OpcodeArg arg[], {#ifndef CONFIG_USER_ONLY unsigned id = par[0 ] -DBREAKC ; -TCGv_i32 tmp =tcg_const_i32 (id);assert (id < dc->config->ndbreak); -gen_helper_wsr_dbreakc (cpu_env, tmp, arg[0 ].in); -tcg_temp_free (tmp); +gen_helper_wsr_dbreakc (cpu_env,tcg_constant_i32 (id), arg[0 ].in);#endif }
@@ -2669,11 +2663,9 @@ static void translate_wsr_ibreaka(DisasContext *dc, const OpcodeArg arg[], {#ifndef CONFIG_USER_ONLY unsigned id = par[0 ] -IBREAKA ; -TCGv_i32 tmp =tcg_const_i32 (id);assert (id < dc->config->nibreak); -gen_helper_wsr_ibreaka (cpu_env, tmp, arg[0 ].in); -tcg_temp_free (tmp); +gen_helper_wsr_ibreaka (cpu_env,tcg_constant_i32 (id), arg[0 ].in);#endif }
Signature · 1 line
2.30.2
Re: [PATCH 4/6] target/xtensa: use tcg_constant_* for numbered special registers
Quoted 7 lines · Max Filippov
Numbered special registers are small arrays of consecutive SRs. Use tcg_constant_* for the SR index.
Signed-off-by Max Filippov<[email protected]>--- target/xtensa/translate.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-)
r~
PATCH 5/6 target/xtensa: use tcg_constant_* for FPU conversion opcodes
In reply to Max FilippovFPU conversion opcodes pass scale (range 0..15) and rounding mode to their helpers. Use tcg_constant_* for them.
--- target/xtensa/translate.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-)
target/xtensa/translate.c +6 -12
@@ -6515,20 +6515,19 @@ static void translate_const_s(DisasContext *dc, const OpcodeArg arg[],static void translate_float_d (DisasContext *dc,const OpcodeArg arg[],const uint32_t par[]) { -TCGv_i32 scale =tcg_const_i32 (-arg[2 ].imm); +TCGv_i32 scale =tcg_constant_i32 (-arg[2 ].imm);if (par[0 ]) {gen_helper_uitof_d (arg[0 ].out, cpu_env, arg[1 ].in, scale); }else {gen_helper_itof_d (arg[0 ].out, cpu_env, arg[1 ].in, scale); } -tcg_temp_free (scale); }static void translate_float_s (DisasContext *dc,const OpcodeArg arg[],const uint32_t par[]) { -TCGv_i32 scale =tcg_const_i32 (-arg[2 ].imm); +TCGv_i32 scale =tcg_constant_i32 (-arg[2 ].imm);OpcodeArg arg32[1 ];get_f32_o1 (arg, arg32,0 );
@@ -6538,14 +6537,13 @@ static void translate_float_s(DisasContext *dc, const OpcodeArg arg[],gen_helper_itof_s (arg32[0 ].out, cpu_env, arg[1 ].in, scale); }put_f32_o1 (arg, arg32,0 ); -tcg_temp_free (scale); }static void translate_ftoi_d (DisasContext *dc,const OpcodeArg arg[],const uint32_t par[]) { -TCGv_i32 rounding_mode =tcg_const_i32 (par[0 ]); -TCGv_i32 scale =tcg_const_i32 (arg[2 ].imm); +TCGv_i32 rounding_mode =tcg_constant_i32 (par[0 ]); +TCGv_i32 scale =tcg_constant_i32 (arg[2 ].imm);if (par[1 ]) { gen_helper_ftoui_d(arg[0].out, cpu_env, arg[1].in,
@@ -6554,15 +6552,13 @@ static void translate_ftoi_d(DisasContext *dc, const OpcodeArg arg[],gen_helper_ftoi_d (arg[0 ].out, cpu_env, arg[1 ].in, rounding_mode, scale); } -tcg_temp_free (rounding_mode); -tcg_temp_free (scale); }static void translate_ftoi_s (DisasContext *dc,const OpcodeArg arg[],const uint32_t par[]) { -TCGv_i32 rounding_mode =tcg_const_i32 (par[0 ]); -TCGv_i32 scale =tcg_const_i32 (arg[2 ].imm); +TCGv_i32 rounding_mode =tcg_constant_i32 (par[0 ]); +TCGv_i32 scale =tcg_constant_i32 (arg[2 ].imm);OpcodeArg arg32[2 ];get_f32_i1 (arg, arg32,1 );
@@ -6574,8 +6570,6 @@ static void translate_ftoi_s(DisasContext *dc, const OpcodeArg arg[], rounding_mode, scale); }put_f32_i1 (arg, arg32,1 ); -tcg_temp_free (rounding_mode); -tcg_temp_free (scale); } static void translate_ldsti(DisasContext *dc, const OpcodeArg arg[],
Signature · 1 line
2.30.2
Re: [PATCH 5/6] target/xtensa: use tcg_constant_* for FPU conversion opcodes
Quoted 7 lines · Max Filippov
FPU conversion opcodes pass scale (range 0..15) and rounding mode to their helpers. Use tcg_constant_* for them.
Signed-off-by Max Filippov<[email protected]>--- target/xtensa/translate.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-)
r~
PATCH 6/6 target/xtensa: use tcg_constant_* for remaining opcodes
In reply to Max Filippov- gen_brcondi passes immediate field (less than 32 different possible values) to the helper;
- gen_callw_slot uses callinc (1..3);
- translate_entry passes stack register number (0..15) to the helper;
- gen_check_exclusive passes boolean to the helper;
- translate_ssai passes immediate shift amount (0..31) to the helper;
- gen_waiti passes immediate (0..15) to the helper;
use tcg_constant_* for the constants listed above. Fold gen_waiti body into the translate_waiti as it's the only user.
--- target/xtensa/translate.c | 44 ++++++++++++--------------------------- 1 file changed, 13 insertions(+), 31 deletions(-)
target/xtensa/translate.c +13 -31
@@ -406,11 +406,8 @@ static void gen_jumpi(DisasContext *dc, uint32_t dest, int slot)static void gen_callw_slot (DisasContext *dc,int callinc,TCGv_i32 dest,int slot) { -TCGv_i32 tcallinc =tcg_const_i32 (callinc); -tcg_gen_deposit_i32 (cpu_SR[PS ], cpu_SR[PS ], - tcallinc,PS_CALLINC_SHIFT ,PS_CALLINC_LEN ); -tcg_temp_free (tcallinc); +tcg_constant_i32 (callinc),PS_CALLINC_SHIFT ,PS_CALLINC_LEN );tcg_gen_movi_i32 (cpu_R[callinc <<2 ], (callinc <<30 ) | (dc->base.pc_next &0x3fffffff ));gen_jump_slot (dc, dest, slot);
@@ -456,9 +453,7 @@ static void gen_brcond(DisasContext *dc, TCGCond cond,static void gen_brcondi (DisasContext *dc,TCGCond cond,TCGv_i32 t0,uint32_t t1,uint32_t addr) { -TCGv_i32 tmp =tcg_const_i32 (t1); -gen_brcond (dc, cond, t0, tmp, addr); -tcg_temp_free (tmp); +gen_brcond (dc, cond, t0,tcg_constant_i32 (t1), addr); } static uint32_t test_exceptions_sr(DisasContext *dc, const OpcodeArg arg[],
@@ -543,21 +538,6 @@ static MemOp gen_load_store_alignment(DisasContext *dc, MemOp mop,return mop; } -#ifndef CONFIG_USER_ONLY -static void gen_waiti (DisasContext *dc,uint32_t imm4) -{ -TCGv_i32 pc =tcg_const_i32 (dc->base.pc_next); -TCGv_i32 intlevel =tcg_const_i32 (imm4); - -if (tb_cflags (dc->base.tb) &CF_USE_ICOUNT ) { -gen_io_start (); - } -gen_helper_waiti (cpu_env, pc, intlevel); -tcg_temp_free (pc); -tcg_temp_free (intlevel); -} -#endif -static bool gen_window_check (DisasContext *dc,uint32_t mask) {unsigned r =31 -clz32 (mask);
@@ -1663,11 +1643,10 @@ static void translate_entry(DisasContext *dc, const OpcodeArg arg[], const uint32_t par[]) {TCGv_i32 pc =tcg_const_i32 (dc->pc); -TCGv_i32 s =tcg_const_i32 (arg[0 ].imm); +TCGv_i32 s =tcg_constant_i32 (arg[0 ].imm);TCGv_i32 imm =tcg_const_i32 (arg[1 ].imm);gen_helper_entry (cpu_env, pc, s, imm);tcg_temp_free (imm); -tcg_temp_free (s);tcg_temp_free (pc); }
@@ -1749,11 +1728,10 @@ static void gen_check_exclusive(DisasContext *dc, TCGv_i32 addr, bool is_write) {if (!option_enabled (dc,XTENSA_OPTION_MPU )) {TCGv_i32 tpc =tcg_const_i32 (dc->pc); -TCGv_i32 write =tcg_const_i32 (is_write); -gen_helper_check_exclusive (cpu_env, tpc, addr, write); +gen_helper_check_exclusive (cpu_env, tpc, addr, +tcg_constant_i32 (is_write));tcg_temp_free (tpc); -tcg_temp_free (write); } }#endif
@@ -2517,9 +2495,7 @@ static void translate_ssa8l(DisasContext *dc, const OpcodeArg arg[],static void translate_ssai (DisasContext *dc,const OpcodeArg arg[],const uint32_t par[]) { -TCGv_i32 tmp =tcg_const_i32 (arg[0 ].imm); -gen_right_shift_sar (dc, tmp); -tcg_temp_free (tmp); +gen_right_shift_sar (dc,tcg_constant_i32 (arg[0 ].imm)); } static void translate_ssl(DisasContext *dc, const OpcodeArg arg[],
@@ -2553,7 +2529,13 @@ static void translate_waiti(DisasContext *dc, const OpcodeArg arg[], const uint32_t par[]) {#ifndef CONFIG_USER_ONLY -gen_waiti (dc, arg[0 ].imm); +TCGv_i32 pc =tcg_const_i32 (dc->base.pc_next); + +if (tb_cflags (dc->base.tb) &CF_USE_ICOUNT ) { +gen_io_start (); + } +gen_helper_waiti (cpu_env, pc,tcg_constant_i32 (arg[0 ].imm)); +tcg_temp_free (pc);#endif }
Signature · 1 line
2.30.2
Re: [PATCH 6/6] target/xtensa: use tcg_constant_* for remaining opcodes
target/xtensa/translate.c static void translate_waiti(DisasContext *dc, const OpcodeArg arg[], · line 2538
Quoted 7 lines · Max Filippov
target/xtensa/translate.c +7
-0+TCGv_i32 pc =tcg_const_i32 (dc->base.pc_next); + +if (tb_cflags (dc->base.tb) &CF_USE_ICOUNT ) { +gen_io_start (); + } +gen_helper_waiti (cpu_env, pc,tcg_constant_i32 (arg[0 ].imm)); +tcg_temp_free (pc);
Missed conversion to tcg_constant_i32 for pc.
Otherwise,
r~