Skip to contentSkip to conversation

drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran

PATCH In review David Yu 2 participants 2 messages Apr 22, 2022

Subsystems (2)
lore
Share & tools
lore

David Yu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran

Load ta fw during psp_init_sriov_microcode to enable XGMI

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -1
index f6527aa19238..895251f42853 100644
@@ -275,7 +275,8 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
 		ret = psp_init_cap_microcode(psp, "sienna_cichlid");
 		break;
 	case IP_VERSION(13, 0, 2):
-		ret = psp_init_cap_microcode(psp, "aldebaran");
+		ret = psp_init_ta_microcode(psp, "aldebaran");
+		ret &= psp_init_cap_microcode(psp, "aldebaran");
 		break;
 	default:
 		BUG();
Signature · 1 line
2.25.1
#1 lore raw

[AMD Official Use Only]

Please add some more info in the description to explain why we need to add TA in SRIOV guest .

Regard
Shaoyun.liu

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of David Yu
Sent: Friday, April 22, 2022 10:58 AM
To: [email protected]
Cc: Yu, David <[email protected]>
Subject: [PATCH] drm/amdgpu: Ta fw needs to be loaded for SRIOV aldebaran

Load ta fw during psp_init_sriov_microcode to enable XGMI

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -1
index f6527aa19238..895251f42853 100644
@@ -275,7 +275,8 @@ static int psp_init_sriov_microcode(struct psp_context *psp)
 		ret = psp_init_cap_microcode(psp, "sienna_cichlid");
 		break;
 	case IP_VERSION(13, 0, 2):
-		ret = psp_init_cap_microcode(psp, "aldebaran");
+		ret = psp_init_ta_microcode(psp, "aldebaran");
+		ret &= psp_init_cap_microcode(psp, "aldebaran");
 		break;
 	default:
 		BUG();
Signature · 1 line
2.25.1