drm/radeon: change cac_weights_* to static
Subsystems (2)
PATCH 1/1 drm/radeon: change cac_weights_* to static
Sparse reports these issues
si_dpm.c:332:26: warning: symbol 'cac_weights_pitcairn' was not declared. Should it be static? si_dpm.c:1088:26: warning: symbol 'cac_weights_oland' was not declared. Should it be static?
Both of these variables are only used in si_dpm.c. Single file variables should be static, so change their storage-class specifiers to static.
--- drivers/gpu/drm/radeon/si_dpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/si_dpm.c +2 -2
@@ -329,7 +329,7 @@ static const struct si_dte_data dte_data_malta = true }; -struct si_cac_config_reg cac_weights_pitcairn[] = +static struct si_cac_config_reg cac_weights_pitcairn[] = { {0x0 ,0x0000ffff ,0 ,0x8a ,SISLANDS_CACCONFIG_CGIND }, {0x0 ,0xffff0000 ,16 ,0x0 ,SISLANDS_CACCONFIG_CGIND },
@@ -1085,7 +1085,7 @@ static const struct si_dte_data dte_data_venus_pro = true }; -struct si_cac_config_reg cac_weights_oland[] = +static struct si_cac_config_reg cac_weights_oland[] = { {0x0 ,0x0000ffff ,0 ,0x82 ,SISLANDS_CACCONFIG_CGIND }, {0x0 ,0xffff0000 ,16 ,0x4F ,SISLANDS_CACCONFIG_CGIND },
Signature · 1 line
2.27.0
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 38 lines · Tom Rix
Sparse reports these issues
si_dpm.c:332:26: warning: symbol 'cac_weights_pitcairn' was not declared. Should it be static? si_dpm.c:1088:26: warning: symbol 'cac_weights_oland' was not declared. Should it be static?Both of these variables are only used in
si_dpm.c. Single file variables should be static, so change their storage-class specifiers to static.Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/radeon/si_dpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/radeon/si_dpm.c +2
-3@@ -329,7 +329,7 @@ static const struct si_dte_data dte_data_malta = true }; -struct si_cac_config_reg cac_weights_pitcairn[] = +static struct si_cac_config_reg cac_weights_pitcairn[] = { {0x0 ,0x0000ffff ,0 ,0x8a ,SISLANDS_CACCONFIG_CGIND }, {0x0 ,0xffff0000 ,16 ,0x0 ,SISLANDS_CACCONFIG_CGIND },@@ -1085,7 +1085,7 @@ static const struct si_dte_data dte_data_venus_pro = true }; -struct si_cac_config_reg cac_weights_oland[] = +static struct si_cac_config_reg cac_weights_oland[] = { {0x0 ,0x0000ffff ,0 ,0x82 ,SISLANDS_CACCONFIG_CGIND }, {0x0 ,0xffff0000 ,16 ,0x4F ,SISLANDS_CACCONFIG_CGIND }, --2.27.0