Skip to contentSkip to conversation

xtensa: enable ARCH_HAS_DEBUG_VM_PGTABLE

PATCH In review Max Filippov 2 participants 5 messages Apr 25, 2022 – Apr 29, 2022

Subsystems (2)
lore
Share & tools
lore

Max Filippov

author maintainer
#0 lore raw

PATCH 1/1 xtensa: enable ARCH_HAS_DEBUG_VM_PGTABLE

xtensa kernels successfully build and run with CONFIG_DEBUG_VM_PGTABLE=y, enable arch support for it.

---
 Documentation/features/debug/debug-vm-pgtable/arch-support.txt | 2 +-
 arch/xtensa/Kconfig                                            | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Documentation/features/debug/debug-vm-pgtable/arch-support.txt +1 -1
index 83eafe1a7f68..ff21a83abe62 100644
@@ -27,5 +27,5 @@
     |       sparc: | TODO |
     |          um: | TODO |
     |         x86: |  ok  |
-    |      xtensa: | TODO |
+    |      xtensa: |  ok  |
     -----------------------
arch/xtensa/Kconfig +1 -0
index 2ed897299f19..903b910ebc10 100644
@@ -4,6 +4,7 @@ config XTENSA
 	select ARCH_32BIT_OFF_T
 	select ARCH_HAS_BINFMT_FLAT if !MMU
 	select ARCH_HAS_CURRENT_STACK_POINTER
+	select ARCH_HAS_DEBUG_VM_PGTABLE
 	select ARCH_HAS_DMA_PREP_COHERENT if MMU
 	select ARCH_HAS_SYNC_DMA_FOR_CPU if MMU
 	select ARCH_HAS_SYNC_DMA_FOR_DEVICE if MMU
Signature · 1 line
2.30.2
#1 lore raw

Hi Max,

Thanks for the patch. Just wondering if you ran with different config options (which might impact test case selection) on/off during testing ?

- Anshuman

Quoted 32 lines · Max Filippov

xtensa kernels successfully build and run with CONFIG_DEBUG_VM_PGTABLE=y, enable arch support for it.

---
 Documentation/features/debug/debug-vm-pgtable/arch-support.txt | 2 +-
 arch/xtensa/Kconfig                                            | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Documentation/features/debug/debug-vm-pgtable/arch-support.txt +1 -1
index 83eafe1a7f68..ff21a83abe62 100644
@@ -27,5 +27,5 @@
     |       sparc: | TODO |
     |          um: | TODO |
     |         x86: |  ok  |
-    |      xtensa: | TODO |
+    |      xtensa: |  ok  |
     -----------------------
arch/xtensa/Kconfig +1 -0
index 2ed897299f19..903b910ebc10 100644
@@ -4,6 +4,7 @@ config XTENSA
 	select ARCH_32BIT_OFF_T
 	select ARCH_HAS_BINFMT_FLAT if !MMU
 	select ARCH_HAS_CURRENT_STACK_POINTER
+	select ARCH_HAS_DEBUG_VM_PGTABLE
 	select ARCH_HAS_DMA_PREP_COHERENT if MMU
 	select ARCH_HAS_SYNC_DMA_FOR_CPU if MMU
 	select ARCH_HAS_SYNC_DMA_FOR_DEVICE if MMU
author maintainer
#2 lore raw

Anshuman,

Quoted 2 lines · Anshuman Khandual

Thanks for the patch. Just wondering if you ran with different config options (which might impact test case selection) on/off during testing ?

I went through the code in the mm/debug_vm_pgtable.c and saw that most variations are related to the huge page support which xtensa doesn't have. I've tested it with and without CMA.
I haven't found anything else interesting that I could tweak -- have I missed anything?

Signature · 2 lines
Thanks.
-- Max
#3 lore raw
Quoted 4 lines · Max Filippov

Anshuman,

On Mon, Apr 25, 2022 at 11:07 PM Anshuman Khandual <[email protected]> wrote:

Quoted 8 lines
Quoted 2 lines

Thanks for the patch. Just wondering if you ran with different config options (which might impact test case selection) on/off during testing ?

I went through the code in the mm/debug_vm_pgtable.c and saw that most variations are related to the huge page support which xtensa doesn't have. I've tested it with and without CMA.
I haven't found anything else interesting that I could tweak -- have I missed anything?

I dont think so, but thanks for confirming.

Reviewed-by on v1 1/1
#4 lore raw
In reply to Max Filippov
Quoted 4 lines · Max Filippov

xtensa kernels successfully build and run with CONFIG_DEBUG_VM_PGTABLE=y, enable arch support for it.

Quoted 28 lines
---
 Documentation/features/debug/debug-vm-pgtable/arch-support.txt | 2 +-
 arch/xtensa/Kconfig                                            | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Documentation/features/debug/debug-vm-pgtable/arch-support.txt +1 -1
index 83eafe1a7f68..ff21a83abe62 100644
@@ -27,5 +27,5 @@
     |       sparc: | TODO |
     |          um: | TODO |
     |         x86: |  ok  |
-    |      xtensa: | TODO |
+    |      xtensa: |  ok  |
     -----------------------
arch/xtensa/Kconfig +1 -0
index 2ed897299f19..903b910ebc10 100644
@@ -4,6 +4,7 @@ config XTENSA
 	select ARCH_32BIT_OFF_T
 	select ARCH_HAS_BINFMT_FLAT if !MMU
 	select ARCH_HAS_CURRENT_STACK_POINTER
+	select ARCH_HAS_DEBUG_VM_PGTABLE
 	select ARCH_HAS_DMA_PREP_COHERENT if MMU
 	select ARCH_HAS_SYNC_DMA_FOR_CPU if MMU
 	select ARCH_HAS_SYNC_DMA_FOR_DEVICE if MMU