Skip to contentSkip to conversation

dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible

PATCH Applied Rob Herring 3 participants 4 messages Apr 26, 2022 – May 2, 2022

Subsystems (4)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH v2 1/1 dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible

The samsung,s524ad0xd1 compatible is in use, but not documented. According to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible with the 24c128. As the schema requires a fallback compatible to the corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.

---
v2:
- Fix the example in samsung,s3c2410-i2c.yaml

 Documentation/devicetree/bindings/eeprom/at24.yaml            | 4 +++-
 .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml          | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/eeprom/at24.yaml +3 -1
index 6b61a8cf6137..d14e0accbda8 100644
@@ -120,7 +120,9 @@ properties:
           - const: giantec,gt24c32a
           - const: atmel,24c32
       - items:
-          - const: renesas,r1ex24128
+          - enum:
+              - renesas,r1ex24128
+              - samsung,s524ad0xd1
           - const: atmel,24c128
 
   label:
Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml +1 -1
index c26230518957..3d5782deb97d 100644
@@ -123,7 +123,7 @@ examples:
         samsung,i2c-slave-addr = <0x66>;
 
         eeprom@50 {
-            compatible = "samsung,s524ad0xd1";
+            compatible = "samsung,s524ad0xd1", "atmel,24c128";
             reg = <0x50>;
         };
     };
Signature · 1 line
2.34.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · Rob Herring

The samsung,s524ad0xd1 compatible is in use, but not documented. According to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible with the 24c128. As the schema requires a fallback compatible to the corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.

---
v2:
- Fix the example in samsung,s3c2410-i2c.yaml

There is still a DTS to fix. I assume you leave it for volunteers, so I'll send a patch for it.

Best regards,
Krzysztof

Acked-by on v2 1/1
#2 lore raw
In reply to Rob Herring
Quoted 6 lines · Rob Herring

The samsung,s524ad0xd1 compatible is in use, but not documented. According to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible with the 24c128. As the schema requires a fallback compatible to the corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.

Quoted 6 lines

---
v2:
- Fix the example in samsung,s3c2410-i2c.yaml

 Documentation/devicetree/bindings/eeprom/at24.yaml            | 4 +++-

For at24 part:

Quoted 34 lines
 .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml          | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/eeprom/at24.yaml +3 -1
index 6b61a8cf6137..d14e0accbda8 100644
@@ -120,7 +120,9 @@ properties:
           - const: giantec,gt24c32a
           - const: atmel,24c32
       - items:
-          - const: renesas,r1ex24128
+          - enum:
+              - renesas,r1ex24128
+              - samsung,s524ad0xd1
           - const: atmel,24c128
 
   label:
Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml +1 -2
index c26230518957..3d5782deb97d 100644
@@ -123,7 +123,7 @@ examples:
         samsung,i2c-slave-addr = <0x66>;
 
         eeprom@50 {
-            compatible = "samsung,s524ad0xd1";
+            compatible = "samsung,s524ad0xd1", "atmel,24c128";
             reg = <0x50>;
         };
     };
--

2.34.1

author maintainer Applied
#3 lore raw
In reply to Rob Herring
Quoted 5 lines · Rob Herring

The samsung,s524ad0xd1 compatible is in use, but not documented. According to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible with the 24c128. As the schema requires a fallback compatible to the corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.

Quoted 9 lines

---
v2:
- Fix the example in samsung,s3c2410-i2c.yaml

 Documentation/devicetree/bindings/eeprom/at24.yaml            | 4 +++-
 .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml          | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

Applied, thanks!