Skip to contentSkip to conversation

lpfc: Remove redundant lpfc_sli_prep_wqe() call

PATCH Applied James Smart 2 participants 2 messages Apr 27, 2022 – May 4, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lpfc: Remove redundant lpfc_sli_prep_wqe() call

Prior patch added a call to lpfc_sli_prep_wqe prior to lpfc_sli_issue_iocb. This call should not have been added as prep_wqe is called within the issue_iocb routine. So it's called twice now.

Remove the redundant prep call.

Fixes 31a59f75702f ("scsi: lpfc: SLI path split: Refactor Abort paths")
---
 drivers/scsi/lpfc/lpfc_sli.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/lpfc/lpfc_sli.c +0 -2
index 71e7d209bd0b..a0ef1fede3cc 100644
@@ -18690,13 +18690,11 @@ lpfc_sli4_seq_abort_rsp(struct lpfc_vport *vport,
 	       phba->sli4_hba.rpi_ids[ndlp->nlp_rpi]);
 	bf_set(wqe_cmnd, &icmd->generic.wqe_com, CMD_XMIT_BLS_RSP64_CX);
 
-
 	/* Xmit CT abts response on exchange <xid> */
 	lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS,
 			 "1200 Send BLS cmd x%x on oxid x%x Data: x%x\n",
 			 ctiocb->abort_rctl, oxid, phba->link_state);
 
-	lpfc_sli_prep_wqe(phba, ctiocb);
 	rc = lpfc_sli_issue_iocb(phba, LPFC_ELS_RING, ctiocb, 0);
 	if (rc == IOCB_ERROR) {
 		lpfc_printf_vlog(vport, KERN_ERR, LOG_TRACE_EVENT,
Signature · 1 line
2.26.2
#1 lore raw
Quoted 8 lines · James Smart

Prior patch added a call to lpfc_sli_prep_wqe prior to lpfc_sli_issue_iocb. This call should not have been added as prep_wqe is called within the issue_iocb routine. So it's called twice now.

Remove the redundant prep call.

[...]

Applied to 5.19/scsi-queue, thanks!

[1/1] lpfc: Remove redundant lpfc_sli_prep_wqe() call

      https://git.kernel.org/mkp/scsi/c/c2024e3b33ee
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering