Skip to contentSkip to conversation

dt-bindings: pinctrl: Allow values for drive-push-pull and drive-open-drain

PATCH Applied Rob Herring 1 participant 2 messages Apr 29, 2022 – May 4, 2022

Subsystems (3)
Device tree bindings GPIO Pin control
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: pinctrl: Allow values for drive-push-pull and drive-open-drain

A few platforms, at91 and tegra, use drive-push-pull and drive-open-drain with a 0 or 1 value. There's not really a need for values as '1' should be equivalent to no value (it wasn't treated that way) and drive-push-pull disabled is equivalent to drive-open-drain. So dropping the value can't be done without breaking existing OSs. As we don't want new cases, mark the case with values as deprecated.

Cc Arnd Bergmann <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Nicolas Ferre <[email protected]>
Cc Claudiu Beznea <[email protected]>
Signed-off-by Rob Herring <[email protected]>
---
 .../devicetree/bindings/pinctrl/pincfg-node.yaml     | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml +10 -2
index 4b22a9e3a447..f5a121311f61 100644
@@ -52,11 +52,19 @@ properties:
       hardware supporting it the pull strength in Ohm.
 
   drive-push-pull:
-    type: boolean
+    oneOf:
+      - type: boolean
+      - $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [ 0, 1 ]
+        deprecated: true
     description: drive actively high and low
 
   drive-open-drain:
-    type: boolean
+    oneOf:
+      - type: boolean
+      - $ref: /schemas/types.yaml#/definitions/uint32
+        const: 1    # No known cases of 0
+        deprecated: true
     description: drive with open drain
 
   drive-open-source:
Signature · 1 line
2.34.1
author maintainer Applied
#1 lore raw
Quoted 13 lines · Rob Herring

A few platforms, at91 and tegra, use drive-push-pull and drive-open-drain with a 0 or 1 value. There's not really a need for values as '1' should be equivalent to no value (it wasn't treated that way) and drive-push-pull disabled is equivalent to drive-open-drain. So dropping the value can't be done without breaking existing OSs. As we don't want new cases, mark the case with values as deprecated.

Cc Arnd Bergmann <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Jonathan Hunter <[email protected]>
Cc Nicolas Ferre <[email protected]>
Cc Claudiu Beznea <[email protected]>
Signed-off-by Rob Herring <[email protected]>
Quoted 4 lines
---
 .../devicetree/bindings/pinctrl/pincfg-node.yaml     | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Applied, thanks!