Skip to contentSkip to conversation

tools/power x86_energy_perf_policy: close opened file

PATCH New Tom Rix 1 participant 1 message Apr 30, 2022

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 tools/power x86_energy_perf_policy: close opened file

The cppcheck reports this issue x86_energy_perf_policy.c:1244]: (error) Resource leak: fp

When a file is opened with fopen it should be closed with fclose. So close it.

Fixes 4beec1d75196 ("tools/power x86_energy_perf_policy: support HWP.EPP")
---
 tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 1 +
 1 file changed, 1 insertion(+)
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c +1 -0
index 5fd9e594079c..0ed9ae66236d 100644
@@ -1239,6 +1239,7 @@ unsigned int get_pkg_num(int cpu)
 
 	fp = fopen_or_die(pathname, "r");
 	retval = fscanf(fp, "%d\n", &pkg);
+	fclose(fp);
 	if (retval != 1)
 		errx(1, "%s: failed to parse", pathname);
 	return pkg;
Signature · 1 line
2.27.0