gpio: pca953x: update irq_stat even when irq is not enabled (irq_mask not set).
PATCH 1/1 gpio: pca953x: update irq_stat even when irq is not enabled (irq_mask not set).
From: Puyou Lu <[email protected]>
When one port's input state get inverted (eg. from low to hight) after pca953x_irq_setup but before setting irq_mask (by some other driver such as "gpio-keys"), the next inversion of this port (eg. from hight to low) will not triggered any more (because irq_stat is not updated at the first time). Issue should be fixed after this commit.
--- drivers/gpio/gpio-pca953x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-pca953x.c +2 -2
@@ -762,11 +762,11 @@ static bool pca953x_irq_pending(struct pca953x_chip *chip, unsigned long *pendinbitmap_xor (cur_stat, new_stat, old_stat, gc->ngpio);bitmap_and (trigger, cur_stat, chip->irq_mask, gc->ngpio); +bitmap_copy (chip->irq_stat, new_stat, gc->ngpio); +if (bitmap_empty (trigger, gc->ngpio))return false; -bitmap_copy (chip->irq_stat, new_stat, gc->ngpio); -bitmap_and (cur_stat, chip->irq_trig_fall, old_stat, gc->ngpio);bitmap_and (old_stat, chip->irq_trig_raise, new_stat, gc->ngpio);bitmap_or (new_stat, old_stat, cur_stat, gc->ngpio);
Signature · 1 line
2.17.1
Quoted 33 lines · Puyou Lu
From: Puyou Lu <[email protected]>
When one port's input state get inverted (eg. from low to hight) after
pca953x_irq_setupbut before settingirq_mask(by some other driver such as "gpio-keys"), the next inversion of this port (eg. from hight to low) will not triggered any more (becauseirq_statis not updated at the first time). Issue should be fixed after this commit.Signed-off-by Puyou Lu <[email protected]>--- drivers/gpio/gpio-pca953x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpio/gpio-pca953x.c +2
-3@@ -762,11 +762,11 @@ static bool pca953x_irq_pending(struct pca953x_chip *chip, unsigned long *pendinbitmap_xor (cur_stat, new_stat, old_stat, gc->ngpio);bitmap_and (trigger, cur_stat, chip->irq_mask, gc->ngpio); +bitmap_copy (chip->irq_stat, new_stat, gc->ngpio); +if (bitmap_empty (trigger, gc->ngpio))return false; -bitmap_copy (chip->irq_stat, new_stat, gc->ngpio); -bitmap_and (cur_stat, chip->irq_trig_fall, old_stat, gc->ngpio);bitmap_and (old_stat, chip->irq_trig_raise, new_stat, gc->ngpio);bitmap_or (new_stat, old_stat, cur_stat, gc->ngpio); --
Quoted 2 lines
2.17.1
This needs to Cc stable and a fixes tag.
Bart