Skip to contentSkip to conversation

ARM: mvebu: x530: set MPP55 to gpio

PATCH In review Chris Packham 2 participants 3 messages May 2, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mvebu: x530: set MPP55 to gpio

MPP55 is used as a reset connected to the L3 switch chip. This doesn't matter for u-boot as it doesn't use the L3 switch but it is useful to be able to toggle the switch in/out of reset for the OS.

---
I sent this out a while back but it was part of a series that has been dropped for the time being. There's not reason to hold this change up behind the other so I'm sending it as a standalong change.

 board/alliedtelesis/x530/x530.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/alliedtelesis/x530/x530.c +1 -1
index c0ec2afa3011..cbf4533e78de 100644
@@ -93,7 +93,7 @@ int board_early_init_f(void)
 	writel(0x55550550, MVEBU_MPP_BASE + 0x0c);
 	writel(0x55555555, MVEBU_MPP_BASE + 0x10);
 	writel(0x00100565, MVEBU_MPP_BASE + 0x14);
-	writel(0x40000000, MVEBU_MPP_BASE + 0x18);
+	writel(0x00000000, MVEBU_MPP_BASE + 0x18);
 	writel(0x00004444, MVEBU_MPP_BASE + 0x1c);
 
 	return 0;
Signature · 1 line
2.36.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Chris Packham

MPP55 is used as a reset connected to the L3 switch chip. This doesn't matter for u-boot as it doesn't use the L3 switch but it is useful to be able to toggle the switch in/out of reset for the OS.

Thanks,
Stefan

Quoted 4 lines

---
I sent this out a while back but it was part of a series that has been dropped for the time being. There's not reason to hold this change up behind the other so I'm sending it as a standalong change.

Good.

Quoted 9 lines
  board/alliedtelesis/x530/x530.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
board/alliedtelesis/x530/x530.c +0 -0
index c0ec2afa3011..cbf4533e78de 100644

board/alliedtelesis/x530/x530.c int board_early_init_f(void) · line 99

Quoted 8 lines
board/alliedtelesis/x530/x530.c +1 -1
@@ -93,7 +93,7 @@ int board_early_init_f(void)
  	writel(0x55550550, MVEBU_MPP_BASE + 0x0c);
  	writel(0x55555555, MVEBU_MPP_BASE + 0x10);
  	writel(0x00100565, MVEBU_MPP_BASE + 0x14);
-	writel(0x40000000, MVEBU_MPP_BASE + 0x18);
+	writel(0x00000000, MVEBU_MPP_BASE + 0x18);
  	writel(0x00004444, MVEBU_MPP_BASE + 0x1c);
 
  	return 0;

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
In reply to Chris Packham
Quoted 9 lines · Chris Packham

MPP55 is used as a reset connected to the L3 switch chip. This doesn't matter for u-boot as it doesn't use the L3 switch but it is useful to be able to toggle the switch in/out of reset for the OS.

---
I sent this out a while back but it was part of a series that has been dropped for the time being. There's not reason to hold this change up behind the other so I'm sending it as a standalong change.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 8 lines
  board/alliedtelesis/x530/x530.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
board/alliedtelesis/x530/x530.c +0 -0
index c0ec2afa3011..cbf4533e78de 100644

board/alliedtelesis/x530/x530.c int board_early_init_f(void) · line 99

Quoted 8 lines
board/alliedtelesis/x530/x530.c +1 -1
@@ -93,7 +93,7 @@ int board_early_init_f(void)
  	writel(0x55550550, MVEBU_MPP_BASE + 0x0c);
  	writel(0x55555555, MVEBU_MPP_BASE + 0x10);
  	writel(0x00100565, MVEBU_MPP_BASE + 0x14);
-	writel(0x40000000, MVEBU_MPP_BASE + 0x18);
+	writel(0x00000000, MVEBU_MPP_BASE + 0x18);
  	writel(0x00004444, MVEBU_MPP_BASE + 0x1c);
 
  	return 0;

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]