drm/msm: Limit command submission when no IOMMU
PATCH 1/1 drm/msm: Limit command submission when no IOMMU
From: Rob Clark <[email protected]>
Running the GPU without an IOMMU is not really a supported (or sane) configuration. Yet it can be useful during SoC bringup (ie. if the iommu driver doesn't work yet).
Lets limit it to users who already have /dev/mem access, to avoid the chance that a user accidentially configures kernel without IOMMU support.
--- drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/msm/msm_gem_submit.c +5 -0
@@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; +if (unlikely (!ctx->aspace) && !capable (CAP_SYS_RAWIO )) { +DRM_ERROR_RATELIMITED ("IOMMU support or CAP_SYS_RAWIO required!\n" ); +return -EPERM ; + } +/* for now, we just have 3d pipe.. eventually this would need to * be more clever to dispatch to appropriate gpu module: */
Signature · 1 line
2.35.1
Am Montag, dem 02.05.2022 um 10:29 -0700 schrieb Rob Clark:
Quoted 9 lines
From: Rob Clark <[email protected]>
Running the GPU without an IOMMU is not really a supported (or sane) configuration. Yet it can be useful during SoC bringup (ie. if the iommu driver doesn't work yet).
Lets limit it to users who already have
/dev/memaccess, to avoid the chance that a user accidentially configures kernel without IOMMU support.
I haven't followed MSM too closely, so ctx->aspace may also include the GPU MMU, but if this really only includes the IOMMU (as the commit message implies) then this breaks Freedreno on i.MX5.
Regards,
Lucas
Quoted 22 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/gpu/drm/msm/msm_gem_submit.c +5
-0@@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; +if (unlikely (!ctx->aspace) && !capable (CAP_SYS_RAWIO )) { +DRM_ERROR_RATELIMITED ("IOMMU support or CAP_SYS_RAWIO required!\n" ); +return -EPERM ; + } +/* for now, we just have 3d pipe.. eventually this would need to * be more clever to dispatch to appropriate gpu module: */
Quoted 8 lines · Lucas Stach
Am Montag, dem 02.05.2022 um 10:29 -0700 schrieb Rob Clark:
Quoted 6 lines
From: Rob Clark <[email protected]>
Running the GPU without an IOMMU is not really a supported (or sane) configuration. Yet it can be useful during SoC bringup (ie. if the iommu driver doesn't work yet).
Quoted 7 lines
Quoted 3 lines
Lets limit it to users who already have
/dev/memaccess, to avoid the chance that a user accidentially configures kernel without IOMMU support.I haven't followed MSM too closely, so
ctx->aspacemay also include the GPU MMU, but if this really only includes the IOMMU (as the commit message implies) then this breaks Freedreno on i.MX5.
it includes the gpu mmu, so a2xx should be fine.
BR,
-R
Quoted 27 lines
Regards,
LucasQuoted 22 lines
Signed-off-by Rob Clark <[email protected]>--- drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/gpu/drm/msm/msm_gem_submit.c +5
-0@@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; +if (unlikely (!ctx->aspace) && !capable (CAP_SYS_RAWIO )) { +DRM_ERROR_RATELIMITED ("IOMMU support or CAP_SYS_RAWIO required!\n" ); +return -EPERM ; + } +/* for now, we just have 3d pipe.. eventually this would need to * be more clever to dispatch to appropriate gpu module: */
Quoted 11 lines · Rob Clark
From: Rob Clark <[email protected]>
Running the GPU without an IOMMU is not really a supported (or sane) configuration. Yet it can be useful during SoC bringup (ie. if the iommu driver doesn't work yet).
Lets limit it to users who already have
/dev/memaccess, to avoid the chance that a user accidentially configures kernel without IOMMU support.Signed-off-by Rob Clark <[email protected]>
Quoted 20 lines
--- drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/gpu/drm/msm/msm_gem_submit.c +5
-0@@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,if (args->pad)return -EINVAL ; +if (unlikely (!ctx->aspace) && !capable (CAP_SYS_RAWIO )) { +DRM_ERROR_RATELIMITED ("IOMMU support or CAP_SYS_RAWIO required!\n" ); +return -EPERM ; + } +/* for now, we just have 3d pipe.. eventually this would need to * be more clever to dispatch to appropriate gpu module: */
Signature · 2 lines
With best wishes Dmitry