Skip to contentSkip to conversation

cmd: mvebu: Hide bubt specific options when bubt is disabled

PATCH In review Pali Rohár 2 participants 3 messages May 3, 2022 – May 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: mvebu: Hide bubt specific options when bubt is disabled

CONFIG_MVEBU_NAND_BOOT, CONFIG_MVEBU_SPI_BOOT, CONFIG_MVEBU_MMC_BOOT and CONFIG_MVEBU_UBOOT_DFLT_NAME are unused when CONFIG_CMD_MVEBU_BUBT is not enabled. So hide them.

---
 cmd/mvebu/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
cmd/mvebu/Kconfig +4 -0
index ac8b0afd20e5..39963db82c98 100644
@@ -9,6 +9,8 @@ config CMD_MVEBU_BUBT
 	  For details about bubt command please see the documentation
 	  in doc/mvebu/cmd/bubt.txt
 
+if CMD_MVEBU_BUBT
+
 choice
 	prompt "Flash for image"
 	default MVEBU_SPI_BOOT
@@ -49,6 +51,8 @@ config MVEBU_UBOOT_DFLT_NAME
 	  This option should contain a default file name to be used with
 	  MVEBU "bubt" command if the source file name is omitted
 
+endif
+
 config CMD_MVEBU_COMPHY_RX_TRAINING
 	bool "mvebu_comphy_rx_training"
 	depends on ARMADA_8K
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Pali Rohár

CONFIG_MVEBU_NAND_BOOT, CONFIG_MVEBU_SPI_BOOT, CONFIG_MVEBU_MMC_BOOT and CONFIG_MVEBU_UBOOT_DFLT_NAME are unused when CONFIG_CMD_MVEBU_BUBT is not enabled. So hide them.

Thanks,
Stefan

Quoted 18 lines
---
  cmd/mvebu/Kconfig | 4 ++++
  1 file changed, 4 insertions(+)
cmd/mvebu/Kconfig +2 -0
index ac8b0afd20e5..39963db82c98 100644
@@ -9,6 +9,8 @@ config CMD_MVEBU_BUBT
  	  For details about bubt command please see the documentation
  	  in doc/mvebu/cmd/bubt.txt
 
+if CMD_MVEBU_BUBT
+
  choice
  	prompt "Flash for image"
  	default MVEBU_SPI_BOOT

cmd/mvebu/Kconfig config MVEBU_UBOOT_DFLT_NAME · line 58

Quoted 8 lines
cmd/mvebu/Kconfig +2 -0
@@ -49,6 +51,8 @@ config MVEBU_UBOOT_DFLT_NAME
  	  This option should contain a default file name to be used with
  	  MVEBU "bubt" command if the source file name is omitted
 
+endif
+
  config CMD_MVEBU_COMPHY_RX_TRAINING
  	bool "mvebu_comphy_rx_training"
  	depends on ARMADA_8K

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
In reply to Pali Rohár
Quoted 5 lines · Pali Rohár

CONFIG_MVEBU_NAND_BOOT, CONFIG_MVEBU_SPI_BOOT, CONFIG_MVEBU_MMC_BOOT and CONFIG_MVEBU_UBOOT_DFLT_NAME are unused when CONFIG_CMD_MVEBU_BUBT is not enabled. So hide them.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 18 lines
---
  cmd/mvebu/Kconfig | 4 ++++
  1 file changed, 4 insertions(+)
cmd/mvebu/Kconfig +2 -0
index ac8b0afd20e5..39963db82c98 100644
@@ -9,6 +9,8 @@ config CMD_MVEBU_BUBT
  	  For details about bubt command please see the documentation
  	  in doc/mvebu/cmd/bubt.txt
 
+if CMD_MVEBU_BUBT
+
  choice
  	prompt "Flash for image"
  	default MVEBU_SPI_BOOT

cmd/mvebu/Kconfig config MVEBU_UBOOT_DFLT_NAME · line 58

Quoted 8 lines
cmd/mvebu/Kconfig +2 -0
@@ -49,6 +51,8 @@ config MVEBU_UBOOT_DFLT_NAME
  	  This option should contain a default file name to be used with
  	  MVEBU "bubt" command if the source file name is omitted
 
+endif
+
  config CMD_MVEBU_COMPHY_RX_TRAINING
  	bool "mvebu_comphy_rx_training"
  	depends on ARMADA_8K

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]