Skip to contentSkip to conversation

KVM: VMX: Fix build error on claim of vmx_get_pid_table_order()

PATCH In review Zeng Guang 2 participants 2 messages May 4, 2022

Subsystems (3)
lore
Share & tools
lore

Zeng Guang

author
#0 lore raw

PATCH 1/1 KVM: VMX: Fix build error on claim of vmx_get_pid_table_order()

Change function claim to static.
Report warning: no previous prototype for 'vmx_get_pid_table_order' [-Wmissing-prototypes].

Fixes 101c99f6506d ("KVM: VMX: enable IPI virtualization")

---
Paolo, could you please merge this fix into commit 101c99f6506d ("KVM:
VMX: enable IPI virtualization") in kvm/queue? Sorry for such mistake.

 arch/x86/kvm/vmx/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/vmx/vmx.c +1 -1
index bb09fc9a7e55..2065babb2c9c 100644
@@ -4402,7 +4402,7 @@ static u32 vmx_secondary_exec_control(struct vcpu_vmx *vmx)
 	return exec_control;
 }
 
-int vmx_get_pid_table_order(struct kvm *kvm)
+static int vmx_get_pid_table_order(struct kvm *kvm)
 {
 	return get_order(kvm->arch.max_vcpu_ids * sizeof(*to_kvm_vmx(kvm)->pid_table));
 }
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 19 lines · Zeng Guang

Change function claim to static.
Report warning: no previous prototype for 'vmx_get_pid_table_order' [-Wmissing-prototypes].

Fixes 101c99f6506d ("KVM: VMX: enable IPI virtualization")

---
Paolo, could you please merge this fix into commit 101c99f6506d ("KVM:
VMX: enable IPI virtualization") in kvm/queue? Sorry for such mistake.

  arch/x86/kvm/vmx/vmx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/vmx/vmx.c +0 -0
index bb09fc9a7e55..2065babb2c9c 100644

arch/x86/kvm/vmx/vmx.c static u32 vmx_secondary_exec_control(struct vcpu_vmx *vmx) · line 4408

Quoted 8 lines
arch/x86/kvm/vmx/vmx.c +1 -1
@@ -4402,7 +4402,7 @@ static u32 vmx_secondary_exec_control(struct vcpu_vmx *vmx)
  	return exec_control;
  }
 
-int vmx_get_pid_table_order(struct kvm *kvm)
+static int vmx_get_pid_table_order(struct kvm *kvm)
  {
  	return get_order(kvm->arch.max_vcpu_ids * sizeof(*to_kvm_vmx(kvm)->pid_table));
  }

Yup, done.

Paolo