Skip to contentSkip to conversation

am62xx: Upgrade ATF to get LP support

PATCH In review Ryan Eatmon 2 participants 4 messages May 5, 2022

lore
Share & tools
lore
#0 lore raw

v3 cover am62xx: Upgrade ATF to get LP support

This series upgrades ATF to current master which is 2.6+. This gets much needed AM62 Low power mode feature.

Changes in v3:
* Fixed the build flag patch as commented by Denys Dmytriyenko Changes in v2:
* Fixed the build flag patch as provided by Nishanth Menon
* updated RFC patch sent earlier to move from ti-atf-next to ti-atf

Nishanth Menon (1):
conf/machine: am62xx: Update build flag for low power mode

Praneeth Bajjuri (1):
trusted-firmware-a: upgrade to v2.6+

 conf/machine/include/am62xx.inc                              | 2 ++
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH v3 1/2 trusted-firmware-a: upgrade to v2.6+

From: Praneeth Bajjuri <[email protected]>

upgrade arm-trusted-firmare to master which is currently v2.6+

This upgrade picks up am62x low power mode feature.

---
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend +2 -2
index b84da1f3..80b1d664 100644
@@ -1,8 +1,8 @@
-PV_k3 = "2.5"
+PV_k3 = "2.6"
 LIC_FILES_CHKSUM_k3 = "file://license.rst;md5=1dd070c98a281d18d9eefd938729b031"
 BRANCH_k3 = "ti-atf"
 SRC_URI_k3 = "git://git.ti.com/atf/arm-trusted-firmware.git;branch=${BRANCH};name=tfa"
-SRCREV_tfa_k3 = "0693f356eb2a25adf8758d98058120bed082cc73"
+SRCREV_tfa_k3 = "6541aa24f834daa80da701e0054dfe3a16cda0ce"
 COMPATIBLE_MACHINE_k3 = "k3"
 TFA_BUILD_TARGET_k3 = "all"
 TFA_INSTALL_TARGET_k3 = "bl31"
Signature · 1 line
2.17.1
#2 lore raw

PATCH v3 2/2 conf/machine: am62xx: Update build flag for low power mode

In reply to Ryan Eatmon

From: Nishanth Menon <[email protected]>

Update build flag for arm-trusted-firmware to include low power mode support

K3_PM_SYSTEM_SUSPEND is added in arm-trusted-firmware now which enables low power mode support for am62xx.

---
 conf/machine/include/am62xx.inc                              | 2 ++
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 1 +
 2 files changed, 3 insertions(+)
conf/machine/include/am62xx.inc +2 -0
index e8823dd2..ff857b97 100644
@@ -6,6 +6,8 @@ MACHINE_FEATURES += "screen touchscreen"
 SERIAL_CONSOLES = "115200;ttyS2"
 SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
 
+TFA_K3_SYSTEM_SUSPEND = "1"
+
 # AM62 supports multi-certificate images, use the same
 IMAGE_BOOT_FILES = "${IMAGE_BOOT_FILES_MULTI_CERT}"
 
recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend +1 -0
index 80b1d664..68bfa899 100644
@@ -9,6 +9,7 @@ TFA_INSTALL_TARGET_k3 = "bl31"
 TFA_SPD_k3 = "opteed"
 
 EXTRA_OEMAKE_append_k3 = "${@ 'K3_USART=' + d.getVar('TFA_K3_USART') if d.getVar('TFA_K3_USART') else ''}"
+EXTRA_OEMAKE_append_k3 = "${@ 'K3_PM_SYSTEM_SUSPEND=' + d.getVar('TFA_K3_SYSTEM_SUSPEND') if d.getVar('TFA_K3_SYSTEM_SUSPEND') else ''}"
 
 do_compile_append_am65xx-hs-evm() {
 	export TI_SECURE_DEV_PKG=${TI_SECURE_DEV_PKG}
Signature · 1 line
2.17.1
#3 lore raw

Re: [meta-ti][dunfell][PATCH v3 2/2] conf/machine: am62xx: Update build flag for low power mode

Quoted 21 lines · Ryan Eatmon via lists.yoctoproject.org

From: Nishanth Menon <[email protected]>

Update build flag for arm-trusted-firmware to include low power mode support

K3_PM_SYSTEM_SUSPEND is added in arm-trusted-firmware now which enables low power mode support for am62xx.

---
 conf/machine/include/am62xx.inc                              | 2 ++
 recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend | 1 +
 2 files changed, 3 insertions(+)
conf/machine/include/am62xx.inc +0 -0
index e8823dd2..ff857b97 100644

conf/machine/include/am62xx.inc MACHINE_FEATURES += "screen touchscreen" · line 9

Quoted 4 lines
conf/machine/include/am62xx.inc +1 -0
@@ -6,6 +6,8 @@ MACHINE_FEATURES += "screen touchscreen"
 SERIAL_CONSOLES = "115200;ttyS2"
 SERIAL_CONSOLES_CHECK = "${SERIAL_CONSOLES}"
 
+TFA_K3_SYSTEM_SUSPEND = "1"

Might want to keep this TFA_ variable together with the other TFA_BOARD being set futher down in the file, to avoid scattering them all over...

Otherwise looks good to me.

Quoted 18 lines
conf/machine/include/am62xx.inc +1 -0
+
 # AM62 supports multi-certificate images, use the same
 IMAGE_BOOT_FILES = "${IMAGE_BOOT_FILES_MULTI_CERT}"
 
recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend +1 -0
index 80b1d664..68bfa899 100644
@@ -9,6 +9,7 @@ TFA_INSTALL_TARGET_k3 = "bl31"
 TFA_SPD_k3 = "opteed"
 
 EXTRA_OEMAKE_append_k3 = "${@ 'K3_USART=' + d.getVar('TFA_K3_USART') if d.getVar('TFA_K3_USART') else ''}"
+EXTRA_OEMAKE_append_k3 = "${@ 'K3_PM_SYSTEM_SUSPEND=' + d.getVar('TFA_K3_SYSTEM_SUSPEND') if d.getVar('TFA_K3_SYSTEM_SUSPEND') else ''}"
 
 do_compile_append_am65xx-hs-evm() {
 	export TI_SECURE_DEV_PKG=${TI_SECURE_DEV_PKG}
Signature · 1 line
2.17.1