Random cleanup patches
cover Random cleanup patches
This patch series contains random cleanups that I made while studying the code.
Bernhard Beschow (11):
hw/rtc/mc146818rtc: Inline isa_connect_gpio_out() and remove it
hw: Reuse TYPE_I8042 define
hw/audio/cs4231a: Const'ify global tables
hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro hw/i386/pc: Unexport functions used only internally hw/i386/pc: Remove orphan declarations
hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() accel/tcg/cpu-exec: Unexport dump_drift_info() accel/tcg: Inline dump_opcount_info() and remove it docs/devel: Fix link to developer mailing lists
accel/tcg/cpu-exec.c | 4 ++-- accel/tcg/translate-all.c | 5 ----- docs/devel/submitting-a-patch.rst | 6 +++--- hw/audio/cs4231a.c | 8 ++++---- hw/i386/pc.c | 17 +++++++++++++---- hw/isa/isa-bus.c | 6 ------ hw/net/fsl_etsec/etsec.c | 23 ----------------------- hw/net/fsl_etsec/etsec.h | 7 ------- hw/ppc/e500.c | 1 - hw/rtc/mc146818rtc.c | 3 ++- hw/sparc64/sun4u.c | 2 +- include/exec/cpu-all.h | 3 --- include/hw/i386/pc.h | 14 -------------- include/hw/isa/isa.h | 1 - 14 files changed, 25 insertions(+), 75 deletions(-)
Signature · 1 line
2.36.0
PATCH 1/11 hw/rtc/mc146818rtc: Inline isa_connect_gpio_out() and remove it
Commit 250263033c5343012b2cd6f01210ffb5b908a159 'isa: introduce wrapper isa_connect_gpio_out' introduced it in 2016. Since then, its only user remained mc146818rtc. Remove this one-off solution.
--- hw/isa/isa-bus.c | 6 ------ hw/rtc/mc146818rtc.c | 3 ++- include/hw/isa/isa.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-)
hw/isa/isa-bus.c +0 -6
@@ -85,12 +85,6 @@ qemu_irq isa_get_irq(ISADevice *dev, unsigned isairq)return isabus->irqs[isairq]; } -void isa_connect_gpio_out (ISADevice *isadev,int gpioirq,unsigned isairq) -{ -qemu_irq irq =isa_get_irq (isadev, isairq); -qdev_connect_gpio_out (DEVICE (isadev), gpioirq, irq); -} -void isa_bus_dma (ISABus *bus,IsaDma *dma8,IsaDma *dma16) {assert (bus && dma8 && dma16);
hw/rtc/mc146818rtc.c +2 -1
@@ -972,7 +972,8 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)if (intercept_irq) {qdev_connect_gpio_out (dev,0 , intercept_irq); }else { -isa_connect_gpio_out (isadev,0 , s->isairq); +qemu_irq irq =isa_get_irq (isadev, s->isairq); +qdev_connect_gpio_out (dev,0 , irq); } object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(isadev),
include/hw/isa/isa.h +0 -1
@@ -90,7 +90,6 @@ ISABus *isa_bus_new(DeviceState *dev, MemoryRegion *address_space, MemoryRegion *address_space_io, Error **errp);void isa_bus_irqs (ISABus *bus,qemu_irq *irqs);qemu_irq isa_get_irq (ISADevice *dev,unsigned isairq); -void isa_connect_gpio_out (ISADevice *isadev,int gpioirq,unsigned isairq);void isa_bus_dma (ISABus *bus,IsaDma *dma8,IsaDma *dma16);IsaDma *isa_get_dma (ISABus *bus,int nchan);MemoryRegion *isa_address_space (ISADevice *dev);
Signature · 1 line
2.36.0
Re: [PATCH 01/11] hw/rtc/mc146818rtc: Inline isa_connect_gpio_out() and remove it
Quoted 10 lines · Bernhard Beschow
Commit
250263033c5343012b2cd6f01210ffb5b908a159'isa: introduce wrapperisa_connect_gpio_out' introduced it in 2016. Since then, its only user remained mc146818rtc. Remove this one-off solution.Signed-off-by Bernhard Beschow <[email protected]>--- hw/isa/isa-bus.c | 6 ------ hw/rtc/mc146818rtc.c | 3 ++- include/hw/isa/isa.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-)
Re: [PATCH 01/11] hw/rtc/mc146818rtc: Inline isa_connect_gpio_out() and remove it
In reply to Bernhard BeschowQuoted 47 lines · Bernhard Beschow
Commit
250263033c5343012b2cd6f01210ffb5b908a159'isa: introduce wrapperisa_connect_gpio_out' introduced it in 2016. Since then, its only user remained mc146818rtc. Remove this one-off solution.Signed-off-by Bernhard Beschow <[email protected]>--- hw/isa/isa-bus.c | 6 ------ hw/rtc/mc146818rtc.c | 3 ++- include/hw/isa/isa.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-)hw/isa/isa-bus.c +0
-6@@ -85,12 +85,6 @@ qemu_irq isa_get_irq(ISADevice *dev, unsigned isairq)return isabus->irqs[isairq]; } -void isa_connect_gpio_out (ISADevice *isadev,int gpioirq,unsigned isairq) -{ -qemu_irq irq =isa_get_irq (isadev, isairq); -qdev_connect_gpio_out (DEVICE (isadev), gpioirq, irq); -} -void isa_bus_dma (ISABus *bus,IsaDma *dma8,IsaDma *dma16) {assert (bus && dma8 && dma16);hw/rtc/mc146818rtc.c +2
-1@@ -972,7 +972,8 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)if (intercept_irq) {qdev_connect_gpio_out (dev,0 , intercept_irq); }else { -isa_connect_gpio_out (isadev,0 , s->isairq); +qemu_irq irq =isa_get_irq (isadev, s->isairq); +qdev_connect_gpio_out (dev,0 , irq); } object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(isadev),include/hw/isa/isa.h +0
-0
include/hw/isa/isa.h ISABus *isa_bus_new(DeviceState *dev, MemoryRegion *address_space, · line 95
Quoted 7 lines
include/hw/isa/isa.h +0
-1@@ -90,7 +90,6 @@ ISABus *isa_bus_new(DeviceState *dev, MemoryRegion *address_space, MemoryRegion *address_space_io, Error **errp);void isa_bus_irqs (ISABus *bus,qemu_irq *irqs);qemu_irq isa_get_irq (ISADevice *dev,unsigned isairq); -void isa_connect_gpio_out (ISADevice *isadev,int gpioirq,unsigned isairq);void isa_bus_dma (ISABus *bus,IsaDma *dma8,IsaDma *dma16);IsaDma *isa_get_dma (ISABus *bus,int nchan);MemoryRegion *isa_address_space (ISADevice *dev);
Hi Bernhard,
I've been tinkering again with trying to improve QEMU's ISA implementation to use gpios, and actually I believe as per the comment in isa-bus.c that isa_connect_gpio_out() will be the preferred way to wire up ISA devices. So really we should be trying to use this function more rather than removing it.
BTW if you are interested in helping to work on ISA bus improvements, I can certainly come up with a TODO list of useful tasks :)
ATB,
Mark.
Re: [PATCH 01/11] hw/rtc/mc146818rtc: Inline isa_connect_gpio_out() and remove it
Am 11. Mai 2022 10:24:58 UTC schrieb Mark Cave-Ayland <[email protected]>:
Quoted 48 lines · Bernhard Beschow
Quoted 47 lines
Commit
250263033c5343012b2cd6f01210ffb5b908a159'isa: introduce wrapperisa_connect_gpio_out' introduced it in 2016. Since then, its only user remained mc146818rtc. Remove this one-off solution.Signed-off-by Bernhard Beschow <[email protected]>--- hw/isa/isa-bus.c | 6 ------ hw/rtc/mc146818rtc.c | 3 ++- include/hw/isa/isa.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-)hw/isa/isa-bus.c +0
-5@@ -85,12 +85,6 @@ qemu_irq isa_get_irq(ISADevice *dev, unsigned isairq)return isabus->irqs[isairq]; } -void isa_connect_gpio_out(ISADevice *isadev, int gpioirq, unsigned isairq) -{ -qemu_irq irq =isa_get_irq (isadev, isairq); -qdev_connect_gpio_out (DEVICE (isadev), gpioirq, irq); -} -void isa_bus_dma (ISABus *bus,IsaDma *dma8,IsaDma *dma16) {assert (bus && dma8 && dma16);hw/rtc/mc146818rtc.c +2
-1@@ -972,7 +972,8 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)if (intercept_irq) {qdev_connect_gpio_out (dev,0 , intercept_irq); }else { -isa_connect_gpio_out (isadev,0 , s->isairq); +qemu_irq irq =isa_get_irq (isadev, s->isairq); +qdev_connect_gpio_out (dev,0 , irq); } object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(isadev),include/hw/isa/isa.h +0
-0@@ -90,7 +90,6 @@ ISABus *isa_bus_new(DeviceState *dev, MemoryRegion *address_space, MemoryRegion *address_space_io, Error **errp);
Quoted 8 lines
include/hw/isa/isa.h ISABus *isa_bus_new(DeviceState *dev, MemoryRegion *address_space, · line 95
Quoted 6 lines
include/hw/isa/isa.h +0
-1void isa_bus_irqs (ISABus *bus,qemu_irq *irqs);qemu_irq isa_get_irq (ISADevice *dev,unsigned isairq); -void isa_connect_gpio_out (ISADevice *isadev,int gpioirq,unsigned isairq);void isa_bus_dma (ISABus *bus,IsaDma *dma8,IsaDma *dma16);IsaDma *isa_get_dma (ISABus *bus,int nchan);MemoryRegion *isa_address_space (ISADevice *dev);Hi Bernhard,
Hi Mark,
Quoted 3 lines
I've been tinkering again with trying to improve QEMU's ISA implementation to use gpios, and actually I believe as per the comment in
isa-bus.cthatisa_connect_gpio_out()will be the preferred way to wire up ISA devices. So really we should be trying to use this function more rather than removing it.BTW if you are interested in helping to work on ISA bus improvements, I can certainly come up with a TODO list of useful tasks :)
Yes, that'd be great!
As expressed earlier [1] I'd like to remove the isabus global in isa-bus.c. Meanwhile, I implemented a POC [2]. While the result seems to work for the PC and Malta boards, some of the changes required don't seem quite clean. So yeah, I'd be interested in the bigger picture regarding ISA improvements and would like to help out as time permits, too.
Best regards,
Bernhard
[1] https://lists.nongnu.org/archive/html/qemu-devel/2022-03/msg05955.html
[2] https://github.com/shentok/qemu/commits/isa
Quoted 4 lines
ATB,
Mark.
PATCH 2/11 hw: Reuse TYPE_I8042 define
In reply to Bernhard BeschowTYPE_I8042 is exported, so reuse it for consistency.
--- hw/i386/pc.c | 4 ++-- hw/sparc64/sun4u.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
hw/i386/pc.c +2 -2
@@ -1042,7 +1042,7 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl,return ; } - i8042 =isa_create_simple (isa_bus,"i8042" ); + i8042 =isa_create_simple (isa_bus,TYPE_I8042 );if (!no_vmport) {isa_create_simple (isa_bus,TYPE_VMPORT ); vmmouse =isa_try_new ("vmmouse" );
@@ -1050,7 +1050,7 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl, vmmouse =NULL ; }if (vmmouse) { -object_property_set_link (OBJECT (vmmouse),"i8042" ,OBJECT (i8042), +object_property_set_link (OBJECT (vmmouse),TYPE_I8042 ,OBJECT (i8042), &error_abort);isa_realize_and_unref (vmmouse, isa_bus, &error_fatal); }
hw/sparc64/sun4u.c +1 -1
@@ -334,7 +334,7 @@ static void ebus_realize(PCIDevice *pci_dev, Error **errp)parallel_hds_isa_init (s->isa_bus,MAX_PARALLEL_PORTS );/* Keyboard */ -isa_create_simple (s->isa_bus,"i8042" ); +isa_create_simple (s->isa_bus,TYPE_I8042 );/* Floppy */ for (i =0 ; i <MAX_FD ; i++) {
Signature · 1 line
2.36.0
Re: [PATCH 02/11] hw: Reuse TYPE_I8042 define
Quoted 7 lines · Bernhard Beschow
TYPE_I8042is exported, so reuse it for consistency.Signed-off-by Bernhard Beschow <[email protected]>--- hw/i386/pc.c | 4 ++-- hw/sparc64/sun4u.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
PATCH 3/11 hw/audio/cs4231a: Const'ify global tables
In reply to Bernhard BeschowThe tables contain spcifically crafted constants for algorithms, so make them immutable.
--- hw/audio/cs4231a.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
hw/audio/cs4231a.c +4 -4
@@ -84,7 +84,7 @@ struct CSState {int transferred;int aci_counter;SWVoiceOut *voice; -int16_t *tab; +const int16_t *tab; };#define MODE2 (1 << 6)
@@ -142,13 +142,13 @@ enum {Capture_Lower_Base_Count }; -static int freqs[2 ][8 ] = { +static const int freqs[2 ][8 ] = { {8000 ,16000 ,27420 ,32000 ,-1 ,-1 ,48000 ,9000 }, {5510 ,11025 ,18900 ,22050 ,37800 ,44100 ,33075 ,6620 } };/* Tables courtesy http://hazelware.luggle.com/tutorials/mulawcompression.html */ -static int16_t MuLawDecompressTable[256 ] = +static const int16_t MuLawDecompressTable[256 ] = {-32124 ,-31100 ,-30076 ,-29052 ,-28028 ,-27004 ,-25980 ,-24956 ,-23932 ,-22908 ,-21884 ,-20860 ,-19836 ,-18812 ,-17788 ,-16764 ,
@@ -184,7 +184,7 @@ static int16_t MuLawDecompressTable[256] =56 ,48 ,40 ,32 ,24 ,16 ,8 ,0 }; -static int16_t ALawDecompressTable[256 ] = +static const int16_t ALawDecompressTable[256 ] = {-5504 ,-5248 ,-6016 ,-5760 ,-4480 ,-4224 ,-4992 ,-4736 , -7552, -7296, -8064, -7808, -6528, -6272, -7040, -6784,
Signature · 1 line
2.36.0
Re: [PATCH 03/11] hw/audio/cs4231a: Const'ify global tables
Quoted 7 lines · Bernhard Beschow
The tables contain spcifically crafted constants for algorithms, so make them immutable.
Signed-off-by Bernhard Beschow <[email protected]>--- hw/audio/cs4231a.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
PATCH 4/11 hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro
In reply to Bernhard BeschowThe macro seems to be used only internally, so remove it.
--- hw/i386/pc.c | 9 +++++++++ include/hw/i386/pc.h | 8 -------- 2 files changed, 9 insertions(+), 8 deletions(-)
hw/i386/pc.c +9 -0
@@ -95,6 +95,15 @@#include "trace.h" #include CONFIG_DEVICES +/* +* Helper for setting model-id for CPU models that changed model-id +* depending on QEMU versions up to QEMU 2.4. +*/ +#define PC_CPU_MODEL_IDS (v) \ + { "qemu32-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ + { "qemu64-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ + { "athlon-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, }, +GlobalProperty pc_compat_7_0[] = {};const size_t pc_compat_7_0_len =G_N_ELEMENTS (pc_compat_7_0);
include/hw/i386/pc.h +0 -8
@@ -289,14 +289,6 @@ extern const size_t pc_compat_1_5_len;extern GlobalProperty pc_compat_1_4[];extern const size_t pc_compat_1_4_len; -/* Helper for setting model-id for CPU models that changed model-id -* depending on QEMU versions up to QEMU 2.4. -*/ -#define PC_CPU_MODEL_IDS (v) \ - { "qemu32-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ - { "qemu64-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, },\ - { "athlon-" TYPE_X86_CPU, "model-id", "QEMU Virtual CPU version " v, }, -#define DEFINE_PC_MACHINE (suffix, namestr, initfn, optsfn) \ static void pc_machine_##suffix##_class_init(ObjectClass *oc, void *data) \ { \
Signature · 1 line
2.36.0
PATCH 5/11 hw/i386/pc: Unexport functions used only internally
In reply to Bernhard Beschow--- hw/i386/pc.c | 4 ++-- include/hw/i386/pc.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-)
hw/i386/pc.c +2 -2
@@ -569,7 +569,7 @@ static const char * const fdc_container_path[] = {* Locate the FDC at IO address 0x3f0, in order to configure the CMOS registers * and ACPI objects. */ -ISADevice *pc_find_fdc0 (void ) +static ISADevice *pc_find_fdc0 (void ) {int i;Object *container;
@@ -713,7 +713,7 @@ static const int ne2000_io[NE2000_NB_MAX] = { 0x300, 0x320, 0x340, 0x360, 0x280, 0x380 };static const int ne2000_irq[NE2000_NB_MAX ] = {9 ,10 ,11 ,3 ,4 ,5 }; -void pc_init_ne2k_isa (ISABus *bus,NICInfo *nd) +static void pc_init_ne2k_isa (ISABus *bus,NICInfo *nd) {static int nb_ne2k =0 ;
include/hw/i386/pc.h +0 -3
@@ -168,7 +168,6 @@ void pc_basic_device_init(struct PCMachineState *pcms,ISADevice **rtc_state, bool create_fdctrl, uint32_t hpet_irqs); -void pc_init_ne2k_isa (ISABus *bus,NICInfo *nd);void pc_cmos_init (PCMachineState *pcms,BusState *ide0,BusState *ide1,ISADevice *s);
@@ -179,8 +178,6 @@ typedef void (*cpu_set_smm_t)(int smm, void *arg);void pc_i8259_create (ISABus *isa_bus,qemu_irq *i8259_irqs); -ISADevice *pc_find_fdc0 (void ); -/* port92.c */ #define PORT92_A20_LINE "a20"
Signature · 1 line
2.36.0
Re: [PATCH 05/11] hw/i386/pc: Unexport functions used only internally
Quoted 5 lines · Bernhard Beschow
Signed-off-by Bernhard Beschow <[email protected]>--- hw/i386/pc.c | 4 ++-- include/hw/i386/pc.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-)
PATCH 6/11 hw/i386/pc: Remove orphan declarations
In reply to Bernhard Beschow--- include/hw/i386/pc.h | 3 --- 1 file changed, 3 deletions(-)
include/hw/i386/pc.h +0 -3
@@ -172,9 +172,6 @@ void pc_cmos_init(PCMachineState *pcms, BusState *ide0, BusState *ide1, ISADevice *s);void pc_nic_init (PCMachineClass *pcmc,ISABus *isa_bus,PCIBus *pci_bus); -void pc_pci_device_init (PCIBus *pci_bus); - -typedef void (*cpu_set_smm_t )(int smm,void *arg);void pc_i8259_create (ISABus *isa_bus,qemu_irq *i8259_irqs);
Signature · 1 line
2.36.0
PATCH 7/11 hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE
In reply to Bernhard BeschowCommit 28290f37e20cda27574f15be9e9499493e3d0fe8 'PPC: E500: Generate device tree on reset' improved device tree generation and made BINARY_DEVICE_TREE_FILE obsolete.
--- hw/ppc/e500.c | 1 - 1 file changed, 1 deletion(-)
hw/ppc/e500.c +0 -1
@@ -47,7 +47,6 @@#include "hw/irq.h" #define EPAPR_MAGIC (0x45504150) -#define BINARY_DEVICE_TREE_FILE "mpc8544ds.dtb"#define DTC_LOAD_PAD 0x1800000#define DTC_PAD_MASK 0xFFFFF#define DTB_MAX_SIZE (8 * MiB)
Signature · 1 line
2.36.0
Re: [PATCH 07/11] hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE
Quoted 6 lines · Bernhard Beschow
Commit
28290f37e20cda27574f15be9e9499493e3d0fe8'PPC: E500: Generate device tree on reset' improved device tree generation and madeBINARY_DEVICE_TREE_FILEobsolete.Signed-off-by Bernhard Beschow <[email protected]>---
Quoted 15 lines
hw/ppc/e500.c | 1 - 1 file changed, 1 deletion(-)hw/ppc/e500.c +0
-1@@ -47,7 +47,6 @@#include "hw/irq.h" #define EPAPR_MAGIC (0x45504150) -#define BINARY_DEVICE_TREE_FILE "mpc8544ds.dtb"#define DTC_LOAD_PAD 0x1800000#define DTC_PAD_MASK 0xFFFFF#define DTB_MAX_SIZE (8 * MiB)
PATCH 8/11 hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create()
In reply to Bernhard Beschowetsec_create() wraps qdev API which is outdated. It is also unused, so remove it.
--- hw/net/fsl_etsec/etsec.c | 23 ----------------------- hw/net/fsl_etsec/etsec.h | 7 ------- 2 files changed, 30 deletions(-)
hw/net/fsl_etsec/etsec.c +0 -23
@@ -443,26 +443,3 @@ static void etsec_register_types(void) }type_init (etsec_register_types) - -DeviceState *etsec_create(hwaddr base, -MemoryRegion * mr, -NICInfo * nd, -qemu_irq tx_irq, -qemu_irq rx_irq, -qemu_irq err_irq) -{ -DeviceState *dev; - - dev =qdev_new ("eTSEC" ); -qdev_set_nic_properties (dev, nd); -sysbus_realize_and_unref (SYS_BUS_DEVICE (dev), &error_fatal); - -sysbus_connect_irq (SYS_BUS_DEVICE (dev),0 , tx_irq); -sysbus_connect_irq (SYS_BUS_DEVICE (dev),1 , rx_irq); -sysbus_connect_irq (SYS_BUS_DEVICE (dev),2 , err_irq); - -memory_region_add_subregion (mr, base, -SYS_BUS_DEVICE (dev)->mmio[0 ].memory); - -return dev; -}
hw/net/fsl_etsec/etsec.h +0 -7
@@ -155,13 +155,6 @@ OBJECT_DECLARE_SIMPLE_TYPE(eTSEC, ETSEC_COMMON)#define eTSEC_TRANSMIT 1#define eTSEC_RECEIVE 2 -DeviceState *etsec_create (hwaddr base, -MemoryRegion *mr, -NICInfo *nd, -qemu_irq tx_irq, -qemu_irq rx_irq, -qemu_irq err_irq); -void etsec_update_irq (eTSEC *etsec);void etsec_walk_tx_ring (eTSEC *etsec,int ring_nbr);
Signature · 1 line
2.36.0
Re: [PATCH 08/11] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create()
Quoted 8 lines · Bernhard Beschow
etsec_create()wraps qdev API which is outdated. It is also unused, so remove it.Signed-off-by Bernhard Beschow <[email protected]>--- hw/net/fsl_etsec/etsec.c | 23 ----------------------- hw/net/fsl_etsec/etsec.h | 7 ------- 2 files changed, 30 deletions(-)
PATCH 9/11 accel/tcg/cpu-exec: Unexport dump_drift_info()
In reply to Bernhard BeschowCommit 3a841ab53f165910224dc4bebabf1a8f1d04200c 'qapi: introduce x-query-jit QMP command' basically moved the only function using dump_drift_info() to cpu-exec.c. Therefore, dump_drift_info() doesn't need to be exported any longer.
--- accel/tcg/cpu-exec.c | 2 +- include/exec/cpu-all.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-)
accel/tcg/cpu-exec.c +1 -1
@@ -1048,7 +1048,7 @@ void tcg_exec_unrealizefn(CPUState *cpu)#ifndef CONFIG_USER_ONLY -void dump_drift_info (GString *buf) +static void dump_drift_info (GString *buf) {if (!icount_enabled ()) {return ;
include/exec/cpu-all.h +0 -2
@@ -419,8 +419,6 @@ static inline bool tlb_hit(target_ulong tlb_addr, target_ulong addr) }#ifdef CONFIG_TCG -/* accel/tcg/cpu-exec.c */ -void dump_drift_info (GString *buf);/* accel/tcg/translate-all.c */ void dump_exec_info (GString *buf);void dump_opcount_info (GString *buf);
Signature · 1 line
2.36.0
PATCH 10/11 accel/tcg: Inline dump_opcount_info() and remove it
In reply to Bernhard Beschowdump_opcount_info() is a one-line wrapper around tcg_dump_op_count() which is also exported. So use the latter directly.
--- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 5 ----- include/exec/cpu-all.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-)
accel/tcg/cpu-exec.c +1 -1
@@ -1091,7 +1091,7 @@ HumanReadableText *qmp_x_query_opcount(Error **errp)return NULL ; } -dump_opcount_info (buf); +tcg_dump_op_count (buf);return human_readable_text_from_str (buf); }
accel/tcg/translate-all.c +0 -5
@@ -2124,11 +2124,6 @@ void dump_exec_info(GString *buf) tcg_dump_info(buf); } -void dump_opcount_info (GString *buf) -{ -tcg_dump_op_count (buf); -} -#else /* CONFIG_USER_ONLY */ void cpu_interrupt (CPUState *cpu,int mask)
include/exec/cpu-all.h +0 -1
@@ -421,7 +421,6 @@ static inline bool tlb_hit(target_ulong tlb_addr, target_ulong addr)#ifdef CONFIG_TCG /* accel/tcg/translate-all.c */ void dump_exec_info (GString *buf); -void dump_opcount_info (GString *buf);#endif /* CONFIG_TCG */ #endif /* !CONFIG_USER_ONLY */
Signature · 1 line
2.36.0
PATCH 11/11 docs/devel: Fix link to developer mailing lists
In reply to Bernhard BeschowAmmends commit 9f73de8df0335c9387f4ee39e207a65a1615676f 'docs: rSTify the "SubmitAPatch" wiki'.
--- docs/devel/submitting-a-patch.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
docs/devel/submitting-a-patch.rst +3 -3
@@ -18,9 +18,9 @@ one-shot fix, the bare minimum we ask is that: <http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297>`__ policy.) ``git commit -s`` or ``git format-patch -s`` will add one. - All contributions to QEMU must be **sent as patches** to the - qemu-devel `mailing list <MailingLists>`__. Patch contributions - should not be posted on the bug tracker, posted on forums, or - externally hosted and linked to. (We have other mailing lists too, + qemu-devel `mailing list <https://wiki.qemu.org/Contribute/MailingLists>`__. + Patch contributions should not be posted on the bug tracker, posted on + forums, or externally hosted and linked to. (We have other mailing lists too, but all patches must go to qemu-devel, possibly with a Cc: to another list.) ``git send-email`` (`step-by-step setup guide <https://git-send-email.io/>`__ and `hints and
Signature · 1 line
2.36.0
Quoted 14 lines · Bernhard Beschow
This patch series contains random cleanups that I made while studying the code.
Bernhard Beschow (11):
hw/rtc/mc146818rtc: Inlineisa_connect_gpio_out()and remove it
hw: ReuseTYPE_I8042define
hw/audio/cs4231a: Const'ify global tables
hw/i386/pc: UnexportPC_CPU_MODEL_IDSmacro hw/i386/pc: Unexport functions used only internally hw/i386/pc: Remove orphan declarations
hw/ppc/e500: Remove unusedBINARY_DEVICE_TREE_FILEhw/net/fsl_etsec/etsec: Remove obsolete and unusedetsec_create()accel/tcg/cpu-exec: Unexportdump_drift_info()accel/tcg: Inlinedump_opcount_info()and remove it docs/devel: Fix link to developer mailing lists
pc changes looks like trivial tree material.
Quoted 21 lines
accel/tcg/cpu-exec.c | 4 ++-- accel/tcg/translate-all.c | 5 ----- docs/devel/submitting-a-patch.rst | 6 +++--- hw/audio/cs4231a.c | 8 ++++---- hw/i386/pc.c | 17 +++++++++++++---- hw/isa/isa-bus.c | 6 ------ hw/net/fsl_etsec/etsec.c | 23 ----------------------- hw/net/fsl_etsec/etsec.h | 7 ------- hw/ppc/e500.c | 1 - hw/rtc/mc146818rtc.c | 3 ++- hw/sparc64/sun4u.c | 2 +- include/exec/cpu-all.h | 3 --- include/hw/i386/pc.h | 14 -------------- include/hw/isa/isa.h | 1 - 14 files changed, 25 insertions(+), 75 deletions(-)Signature · 1 line
2.36.0