RFC: net: fec: get rid of CONFIG_FEC_MXC_MDIO_BASE
Subsystems (2)
PATCH 1/1 RFC: net: fec: get rid of CONFIG_FEC_MXC_MDIO_BASE
A number of IMX8Q boards using FEC configure the address of the ethernet controller via defconfig as there are two FEC controllers in the SoC.
Now that the FEC driver uses DM the register address should be coming from device-tree.
Remove the hard coded config and while at it remove the unused CONFIG_FEC_MXC_SHARE_MDIO.
This is an RFC as I do not have the affected boards to test with and would want to see a Tested-By from someone with each board. I am attempting to clean up some ugliness in the FEC driver. There appears to be multiple constructs to deal with shared MDIO busses when DM_MDIO should be the right solution for that.
--- configs/apalis-imx8_defconfig | 2 -- configs/cgtqmx8_defconfig | 2 -- configs/colibri-imx8x_defconfig | 2 -- configs/deneb_defconfig | 2 -- configs/giedi_defconfig | 2 -- configs/imx8qm_mek_defconfig | 2 -- configs/imx8qm_rom7720_a1_4G_defconfig | 2 -- configs/imx8qxp_mek_defconfig | 2 -- configs/o4-imx6ull-nano_defconfig | 2 -- drivers/net/Kconfig | 11 ----------- drivers/net/fec_mxc.c | 5 ----- 11 files changed, 34 deletions(-)
configs/apalis-imx8_defconfig +0 -2
@@ -56,8 +56,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ90X1=y CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=y
configs/cgtqmx8_defconfig +0 -2
@@ -72,8 +72,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=y
configs/colibri-imx8x_defconfig +0 -2
@@ -54,8 +54,6 @@ CONFIG_PHYLIB=y CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_MICREL=y CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=y
configs/deneb_defconfig +0 -2
@@ -94,8 +94,6 @@ CONFIG_MV88E61XX_CPU_PORT=5 CONFIG_MV88E61XX_PHY_PORTS=0x7 CONFIG_MV88E61XX_FIXED_PORTS=0x0 CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B050000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=y
configs/giedi_defconfig +0 -2
@@ -94,8 +94,6 @@ CONFIG_MV88E61XX_CPU_PORT=5 CONFIG_MV88E61XX_PHY_PORTS=0x7 CONFIG_MV88E61XX_FIXED_PORTS=0x0 CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B050000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=y
configs/imx8qm_mek_defconfig +0 -2
@@ -73,8 +73,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=y
configs/imx8qm_rom7720_a1_4G_defconfig +0 -2
@@ -68,8 +68,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=y
configs/imx8qxp_mek_defconfig +0 -2
@@ -74,8 +74,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=y
configs/o4-imx6ull-nano_defconfig +0 -2
@@ -45,8 +45,6 @@ CONFIG_PHYLIB=y CONFIG_PHY_SMSC=y CONFIG_DM_ETH=y CONFIG_DM_ETH_PHY=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x020b4000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=y
drivers/net/Kconfig +0 -11
@@ -326,17 +326,6 @@ config ETHOC help This MAC is present in OpenRISC and Xtensa XTFPGA boards. -config FEC_MXC_SHARE_MDIO - bool "Share the MDIO bus for FEC controller" - depends on FEC_MXC - -config FEC_MXC_MDIO_BASE - hex "MDIO base address for the FEC controller" - depends on FEC_MXC_SHARE_MDIO - help - This specifies the MDIO registers base address. It is used when - two FEC controllers share MDIO bus. - config FEC_MXC bool "FEC Ethernet controller" depends on MX28 || MX5 || MX6 || MX7 || IMX8 || IMX8M || IMX8ULP || VF610
drivers/net/fec_mxc.c +0 -5
@@ -1233,12 +1233,7 @@ static int fecmxc_probe(struct udevice *dev)if (!bus) { dm_mii_bus = false; -#ifdef CONFIG_FEC_MXC_MDIO_BASE - bus =fec_get_miibus ((ulong )CONFIG_FEC_MXC_MDIO_BASE , -dev_seq (dev)); -#else bus =fec_get_miibus ((ulong )priv->eth,dev_seq (dev)); -#endif }if (!bus) { ret = -ENOMEM ;
Signature · 1 line
2.17.1
Hello Tim,
Your patch looks good, and I'm pleased to verify it. But I don't have access to the o4-imx6ull-nano board.
06.05.22 01:12, Tim Harvey пише:
Quoted 184 lines
A number of IMX8Q boards using FEC configure the address of the ethernet controller via defconfig as there are two FEC controllers in the SoC.
Now that the FEC driver uses DM the register address should be coming from device-tree.
Remove the hard coded config and while at it remove the unused
CONFIG_FEC_MXC_SHARE_MDIO.This is an RFC as I do not have the affected boards to test with and would want to see a Tested-By from someone with each board. I am attempting to clean up some ugliness in the FEC driver. There appears to be multiple constructs to deal with shared MDIO busses when
DM_MDIOshould be the right solution for that.Signed-off-by Tim Harvey <[email protected]>Cc Marcel Ziswiler <[email protected]> (maintainer:Apalis iMX8)Cc Oliver Graute <[email protected]> (maintainer:i.MX8QM CGTQMX8 BOARD)Cc Anatolij Gustschin <[email protected]> (maintainer:CAPRICORN BOARD)Cc Peng Fan <[email protected]> (maintainer:i.MX8QM MEK BOARD)Cc Fabio Estevam <[email protected]> (maintainer:i.MX8QXP MEK BOARD)Cc Oleh Kravchenko <[email protected]> (maintainer:OUT4-IMX6ULL-NANO BOARD)Cc Joe Hershberger <[email protected]> (maintainer:NETWORK)Cc Ramon Fried <[email protected]> (maintainer:NETWORK)--- configs/apalis-imx8_defconfig | 2 -- configs/cgtqmx8_defconfig | 2 -- configs/colibri-imx8x_defconfig | 2 -- configs/deneb_defconfig | 2 -- configs/giedi_defconfig | 2 -- configs/imx8qm_mek_defconfig | 2 -- configs/imx8qm_rom7720_a1_4G_defconfig | 2 -- configs/imx8qxp_mek_defconfig | 2 -- configs/o4-imx6ull-nano_defconfig | 2 -- drivers/net/Kconfig | 11 ----------- drivers/net/fec_mxc.c | 5 ----- 11 files changed, 34 deletions(-)configs/apalis-imx8_defconfig +0
-2@@ -56,8 +56,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ90X1=y CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/cgtqmx8_defconfig +0
-2@@ -72,8 +72,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/colibri-imx8x_defconfig +0
-2@@ -54,8 +54,6 @@ CONFIG_PHYLIB=y CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_MICREL=y CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/deneb_defconfig +0
-2@@ -94,8 +94,6 @@ CONFIG_MV88E61XX_CPU_PORT=5 CONFIG_MV88E61XX_PHY_PORTS=0x7 CONFIG_MV88E61XX_FIXED_PORTS=0x0 CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B050000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/giedi_defconfig +0
-2@@ -94,8 +94,6 @@ CONFIG_MV88E61XX_CPU_PORT=5 CONFIG_MV88E61XX_PHY_PORTS=0x7 CONFIG_MV88E61XX_FIXED_PORTS=0x0 CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B050000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/imx8qm_mek_defconfig +0
-2@@ -73,8 +73,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/imx8qm_rom7720_a1_4G_defconfig +0
-2@@ -68,8 +68,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/imx8qxp_mek_defconfig +0
-2@@ -74,8 +74,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/o4-imx6ull-nano_defconfig +0
-2@@ -45,8 +45,6 @@ CONFIG_PHYLIB=y CONFIG_PHY_SMSC=y CONFIG_DM_ETH=y CONFIG_DM_ETH_PHY=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x020b4000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=ydrivers/net/Kconfig +0
-11@@ -326,17 +326,6 @@ config ETHOC help This MAC is present in OpenRISC and Xtensa XTFPGA boards. -config FEC_MXC_SHARE_MDIO - bool "Share the MDIO bus for FEC controller" - depends on FEC_MXC - -config FEC_MXC_MDIO_BASE - hex "MDIO base address for the FEC controller" - depends on FEC_MXC_SHARE_MDIO - help - This specifies the MDIO registers base address. It is used when - two FEC controllers share MDIO bus. - config FEC_MXC bool "FEC Ethernet controller" depends on MX28 || MX5 || MX6 || MX7 || IMX8 || IMX8M || IMX8ULP || VF610drivers/net/fec_mxc.c +0
-0@@ -1233,12 +1233,7 @@ static int fecmxc_probe(struct udevice *dev)if (!bus) {
drivers/net/fec_mxc.c static int fecmxc_probe(struct udevice *dev) · line 1239
Quoted 10 lines
drivers/net/fec_mxc.c +0
-5dm_mii_bus = false; -#ifdef CONFIG_FEC_MXC_MDIO_BASE - bus =fec_get_miibus ((ulong )CONFIG_FEC_MXC_MDIO_BASE , -dev_seq (dev)); -#else bus =fec_get_miibus ((ulong )priv->eth,dev_seq (dev)); -#endif }if (!bus) { ret = -ENOMEM ;
Quoted 189 lines · Oleh Kravchenko
Hello Tim,
Your patch looks good, and I'm pleased to verify it. But I don't have access to the o4-imx6ull-nano board.06.05.22 01:12, Tim Harvey пише:
Quoted 183 lines
A number of IMX8Q boards using FEC configure the address of the ethernet controller via defconfig as there are two FEC controllers in the SoC.
Now that the FEC driver uses DM the register address should be coming from device-tree.
Remove the hard coded config and while at it remove the unused
CONFIG_FEC_MXC_SHARE_MDIO.This is an RFC as I do not have the affected boards to test with and would want to see a Tested-By from someone with each board. I am attempting to clean up some ugliness in the FEC driver. There appears to be multiple constructs to deal with shared MDIO busses when
DM_MDIOshould be the right solution for that.Signed-off-by Tim Harvey <[email protected]>Cc Marcel Ziswiler <[email protected]> (maintainer:Apalis iMX8)Cc Oliver Graute <[email protected]> (maintainer:i.MX8QM CGTQMX8 BOARD)Cc Anatolij Gustschin <[email protected]> (maintainer:CAPRICORN BOARD)Cc Peng Fan <[email protected]> (maintainer:i.MX8QM MEK BOARD)Cc Fabio Estevam <[email protected]> (maintainer:i.MX8QXP MEK BOARD)Cc Oleh Kravchenko <[email protected]> (maintainer:OUT4-IMX6ULL-NANO BOARD)Cc Joe Hershberger <[email protected]> (maintainer:NETWORK)Cc Ramon Fried <[email protected]> (maintainer:NETWORK)--- configs/apalis-imx8_defconfig | 2 -- configs/cgtqmx8_defconfig | 2 -- configs/colibri-imx8x_defconfig | 2 -- configs/deneb_defconfig | 2 -- configs/giedi_defconfig | 2 -- configs/imx8qm_mek_defconfig | 2 -- configs/imx8qm_rom7720_a1_4G_defconfig | 2 -- configs/imx8qxp_mek_defconfig | 2 -- configs/o4-imx6ull-nano_defconfig | 2 -- drivers/net/Kconfig | 11 ----------- drivers/net/fec_mxc.c | 5 ----- 11 files changed, 34 deletions(-)configs/apalis-imx8_defconfig +0
-2@@ -56,8 +56,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ90X1=y CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/cgtqmx8_defconfig +0
-2@@ -72,8 +72,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/colibri-imx8x_defconfig +0
-2@@ -54,8 +54,6 @@ CONFIG_PHYLIB=y CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_MICREL=y CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/deneb_defconfig +0
-2@@ -94,8 +94,6 @@ CONFIG_MV88E61XX_CPU_PORT=5 CONFIG_MV88E61XX_PHY_PORTS=0x7 CONFIG_MV88E61XX_FIXED_PORTS=0x0 CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B050000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/giedi_defconfig +0
-2@@ -94,8 +94,6 @@ CONFIG_MV88E61XX_CPU_PORT=5 CONFIG_MV88E61XX_PHY_PORTS=0x7 CONFIG_MV88E61XX_FIXED_PORTS=0x0 CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B050000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/imx8qm_mek_defconfig +0
-2@@ -73,8 +73,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/imx8qm_rom7720_a1_4G_defconfig +0
-2@@ -68,8 +68,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/imx8qxp_mek_defconfig +0
-2@@ -74,8 +74,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/o4-imx6ull-nano_defconfig +0
-2@@ -45,8 +45,6 @@ CONFIG_PHYLIB=y CONFIG_PHY_SMSC=y CONFIG_DM_ETH=y CONFIG_DM_ETH_PHY=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x020b4000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=ydrivers/net/Kconfig +0
-11@@ -326,17 +326,6 @@ config ETHOC help This MAC is present in OpenRISC and Xtensa XTFPGA boards. -config FEC_MXC_SHARE_MDIO - bool "Share the MDIO bus for FEC controller" - depends on FEC_MXC - -config FEC_MXC_MDIO_BASE - hex "MDIO base address for the FEC controller" - depends on FEC_MXC_SHARE_MDIO - help - This specifies the MDIO registers base address. It is used when - two FEC controllers share MDIO bus. - config FEC_MXC bool "FEC Ethernet controller" depends on MX28 || MX5 || MX6 || MX7 || IMX8 || IMX8M || IMX8ULP || VF610drivers/net/fec_mxc.c +0
-0@@ -1233,12 +1233,7 @@ static int fecmxc_probe(struct udevice *dev)
Quoted 13 lines
drivers/net/fec_mxc.c static int fecmxc_probe(struct udevice *dev) · line 1239
Quoted 11 lines
drivers/net/fec_mxc.c +0
-5if (!bus) { dm_mii_bus = false; -#ifdef CONFIG_FEC_MXC_MDIO_BASE - bus =fec_get_miibus ((ulong )CONFIG_FEC_MXC_MDIO_BASE , -dev_seq (dev)); -#else bus =fec_get_miibus ((ulong )priv->eth,dev_seq (dev)); -#endif }if (!bus) { ret = -ENOMEM ;Reviewed-by Oleh Kravchenko <[email protected]>
Thanks Oleh. Do you know someone that does have a o4-imx6ull-nano board to test with?
Marcel, Fabio, Anatolij and Oliver, can you review and test your boards with this?
Best Regards,
Tim
Hi Tim,
On Wed, 11 May 2022 13:39:59 -0700
Tim Harvey [email protected] wrote:
...
Quoted 7 lines
Quoted 1 line
Reviewed-by Oleh Kravchenko <[email protected]>Thanks Oleh. Do you know someone that does have a o4-imx6ull-nano board to test with?
Marcel, Fabio, Anatolij and Oliver, can you review and test your boards with this?
I do not have a working i.MX8QXP MEK board any more and can not test. Maybe Peng could test it?
--
Anatolij
Quoted 196 lines · Tim Harvey
A number of IMX8Q boards using FEC configure the address of the ethernet controller via defconfig as there are two FEC controllers in the SoC.
Now that the FEC driver uses DM the register address should be coming from device-tree.
Remove the hard coded config and while at it remove the unused
CONFIG_FEC_MXC_SHARE_MDIO.This is an RFC as I do not have the affected boards to test with and would want to see a Tested-By from someone with each board. I am attempting to clean up some ugliness in the FEC driver. There appears to be multiple constructs to deal with shared MDIO busses when
DM_MDIOshould be the right solution for that.Signed-off-by Tim Harvey <[email protected]>Cc Marcel Ziswiler <[email protected]> (maintainer:Apalis iMX8)Cc Oliver Graute <[email protected]> (maintainer:i.MX8QM CGTQMX8 BOARD)Cc Anatolij Gustschin <[email protected]> (maintainer:CAPRICORN BOARD)Cc Peng Fan <[email protected]> (maintainer:i.MX8QM MEK BOARD)Cc Fabio Estevam <[email protected]> (maintainer:i.MX8QXP MEK BOARD)Cc Oleh Kravchenko <[email protected]> (maintainer:OUT4-IMX6ULL-NANO BOARD)Cc Joe Hershberger <[email protected]> (maintainer:NETWORK)Cc Ramon Fried <[email protected]> (maintainer:NETWORK)--- configs/apalis-imx8_defconfig | 2 -- configs/cgtqmx8_defconfig | 2 -- configs/colibri-imx8x_defconfig | 2 -- configs/deneb_defconfig | 2 -- configs/giedi_defconfig | 2 -- configs/imx8qm_mek_defconfig | 2 -- configs/imx8qm_rom7720_a1_4G_defconfig | 2 -- configs/imx8qxp_mek_defconfig | 2 -- configs/o4-imx6ull-nano_defconfig | 2 -- drivers/net/Kconfig | 11 ----------- drivers/net/fec_mxc.c | 5 ----- 11 files changed, 34 deletions(-)configs/apalis-imx8_defconfig +0
-2@@ -56,8 +56,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_MICREL=y CONFIG_PHY_MICREL_KSZ90X1=y CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/cgtqmx8_defconfig +0
-2@@ -72,8 +72,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/colibri-imx8x_defconfig +0
-2@@ -54,8 +54,6 @@ CONFIG_PHYLIB=y CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_MICREL=y CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/deneb_defconfig +0
-2@@ -94,8 +94,6 @@ CONFIG_MV88E61XX_CPU_PORT=5 CONFIG_MV88E61XX_PHY_PORTS=0x7 CONFIG_MV88E61XX_FIXED_PORTS=0x0 CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B050000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/giedi_defconfig +0
-2@@ -94,8 +94,6 @@ CONFIG_MV88E61XX_CPU_PORT=5 CONFIG_MV88E61XX_PHY_PORTS=0x7 CONFIG_MV88E61XX_FIXED_PORTS=0x0 CONFIG_DM_ETH=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B050000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/imx8qm_mek_defconfig +0
-2@@ -73,8 +73,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/imx8qm_rom7720_a1_4G_defconfig +0
-2@@ -68,8 +68,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/imx8qxp_mek_defconfig +0
-2@@ -74,8 +74,6 @@ CONFIG_PHY_ADDR_ENABLE=y CONFIG_PHY_ATHEROS=y CONFIG_DM_ETH=y CONFIG_PHY_GIGE=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x5B040000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=yconfigs/o4-imx6ull-nano_defconfig +0
-2@@ -45,8 +45,6 @@ CONFIG_PHYLIB=y CONFIG_PHY_SMSC=y CONFIG_DM_ETH=y CONFIG_DM_ETH_PHY=y -CONFIG_FEC_MXC_SHARE_MDIO=y -CONFIG_FEC_MXC_MDIO_BASE=0x020b4000 CONFIG_FEC_MXC=y CONFIG_MII=y CONFIG_PINCTRL=ydrivers/net/Kconfig +0
-11@@ -326,17 +326,6 @@ config ETHOC help This MAC is present in OpenRISC and Xtensa XTFPGA boards. -config FEC_MXC_SHARE_MDIO - bool "Share the MDIO bus for FEC controller" - depends on FEC_MXC - -config FEC_MXC_MDIO_BASE - hex "MDIO base address for the FEC controller" - depends on FEC_MXC_SHARE_MDIO - help - This specifies the MDIO registers base address. It is used when - two FEC controllers share MDIO bus. - config FEC_MXC bool "FEC Ethernet controller" depends on MX28 || MX5 || MX6 || MX7 || IMX8 || IMX8M || IMX8ULP || VF610drivers/net/fec_mxc.c +0
-6@@ -1233,12 +1233,7 @@ static int fecmxc_probe(struct udevice *dev)if (!bus) { dm_mii_bus = false; -#ifdef CONFIG_FEC_MXC_MDIO_BASE - bus =fec_get_miibus ((ulong )CONFIG_FEC_MXC_MDIO_BASE , -dev_seq (dev)); -#else bus =fec_get_miibus ((ulong )priv->eth,dev_seq (dev)); -#endif }if (!bus) { ret = -ENOMEM ; --
Quoted 2 lines
2.17.1