Skip to contentSkip to conversation

drm/amdkfd: Return true/false (not 1/0) from bool functions

PATCH Applied Yang Li 2 participants 4 messages May 5, 2022 – May 6, 2022

Subsystems (3)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 2/2 drm/amdkfd: Return true/false (not 1/0) from bool functions

Return boolean values ("true" or "false") instead of 1 or 0 from bool functions. This fixes the following warnings from coccicheck:

./drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c:244:9-10: WARNING:
return of 0/1 in function 'event_interrupt_isr_v11' with return type bool

---
 drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c +3 -3
index c3919aaa76e6..1431f0961769 100644
@@ -241,14 +241,14 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
 	if (/*!KFD_IRQ_IS_FENCE(client_id, source_id) &&*/
 	    (vmid < dev->vm_info.first_vmid_kfd ||
 	    vmid > dev->vm_info.last_vmid_kfd))
-		return 0;
+		return false;
 
 	pasid = SOC15_PASID_FROM_IH_ENTRY(ih_ring_entry);
 	context_id0 = SOC15_CONTEXT_ID0_FROM_IH_ENTRY(ih_ring_entry);
 
 	if ((source_id == SOC15_INTSRC_CP_END_OF_PIPE) &&
 	    (context_id0 & AMDGPU_FENCE_MES_QUEUE_FLAG))
-		return 0;
+		return false;
 
 	pr_debug("client id 0x%x, source id %d, vmid %d, pasid 0x%x. raw data:\n",
 		 client_id, source_id, vmid, pasid);
@@ -258,7 +258,7 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
 
 	/* If there is no valid PASID, it's likely a bug */
 	if (WARN_ONCE(pasid == 0, "Bug: No PASID in KFD interrupt"))
-		return 0;
+		return false;
 
 	/* Interrupt types we care about: various signals and faults.
 	 * They will be forwarded to a work queue (see below).
Signature · 1 line
2.20.1.7.g153144c
author
#1 lore raw

PATCH 1/2 drm/amdgpu/gfx11: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:1222:2-3: Unneeded semicolon

---
 drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c +1 -1
index 184bf554acca..d2ab325e40b4 100644
@@ -1219,7 +1219,7 @@ static void gfx_v11_0_parse_rlc_toc(struct amdgpu_device *adev, void *rlc_toc)
 		rlc_autoload_info[ucode->id].size = ucode->size * 4;
 
 		ucode++;
-	};
+	}
 }
 
 static uint32_t gfx_v11_0_calc_toc_total_size(struct amdgpu_device *adev)
Signature · 1 line
2.20.1.7.g153144c
Reviewed-by on v1 2/2
#2 lore raw
In reply to Yang Li

Series is:

Quoted 47 lines · Yang Li

Return boolean values ("true" or "false") instead of 1 or 0 from bool functions. This fixes the following warnings from coccicheck:

./drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c:244:9-10: WARNING:
return of 0/1 in function 'event_interrupt_isr_v11' with return type bool

---
 drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c +3 -4
index c3919aaa76e6..1431f0961769 100644
@@ -241,14 +241,14 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
        if (/*!KFD_IRQ_IS_FENCE(client_id, source_id) &&*/
            (vmid < dev->vm_info.first_vmid_kfd ||
            vmid > dev->vm_info.last_vmid_kfd))
-               return 0;
+               return false;
 
        pasid = SOC15_PASID_FROM_IH_ENTRY(ih_ring_entry);
        context_id0 = SOC15_CONTEXT_ID0_FROM_IH_ENTRY(ih_ring_entry);
 
        if ((source_id == SOC15_INTSRC_CP_END_OF_PIPE) &&
            (context_id0 & AMDGPU_FENCE_MES_QUEUE_FLAG))
-               return 0;
+               return false;
 
        pr_debug("client id 0x%x, source id %d, vmid %d, pasid 0x%x. raw data:\n",
                 client_id, source_id, vmid, pasid);
@@ -258,7 +258,7 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
 
        /* If there is no valid PASID, it's likely a bug */
        if (WARN_ONCE(pasid == 0, "Bug: No PASID in KFD interrupt"))
-               return 0;
+               return false;
 
        /* Interrupt types we care about: various signals and faults.
         * They will be forwarded to a work queue (see below).
--

2.20.1.7.g153144c

Applied
#3 lore raw

Applied. Thanks!

Quoted 52 lines · Alex Deucher

Series is:

Quoted 47 lines · Yang Li

Return boolean values ("true" or "false") instead of 1 or 0 from bool functions. This fixes the following warnings from coccicheck:

./drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c:244:9-10: WARNING:
return of 0/1 in function 'event_interrupt_isr_v11' with return type bool

---
 drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c +3 -4
index c3919aaa76e6..1431f0961769 100644
@@ -241,14 +241,14 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
        if (/*!KFD_IRQ_IS_FENCE(client_id, source_id) &&*/
            (vmid < dev->vm_info.first_vmid_kfd ||
            vmid > dev->vm_info.last_vmid_kfd))
-               return 0;
+               return false;
 
        pasid = SOC15_PASID_FROM_IH_ENTRY(ih_ring_entry);
        context_id0 = SOC15_CONTEXT_ID0_FROM_IH_ENTRY(ih_ring_entry);
 
        if ((source_id == SOC15_INTSRC_CP_END_OF_PIPE) &&
            (context_id0 & AMDGPU_FENCE_MES_QUEUE_FLAG))
-               return 0;
+               return false;
 
        pr_debug("client id 0x%x, source id %d, vmid %d, pasid 0x%x. raw data:\n",
                 client_id, source_id, vmid, pasid);
@@ -258,7 +258,7 @@ static bool event_interrupt_isr_v11(struct kfd_dev *dev,
 
        /* If there is no valid PASID, it's likely a bug */
        if (WARN_ONCE(pasid == 0, "Bug: No PASID in KFD interrupt"))
-               return 0;
+               return false;
 
        /* Interrupt types we care about: various signals and faults.
         * They will be forwarded to a work queue (see below).
--

2.20.1.7.g153144c