Skip to contentSkip to conversation

drm/tegra: gem: Do not try to dereference ERR_PTR()

PATCH New Thierry Reding 1 participant 1 message May 6, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tegra: gem: Do not try to dereference ERR_PTR()

From: Thierry Reding <[email protected]>

When mapping the DMA-BUF attachment fails, map->sgt will be an ERR_PTR- encoded error code and the cleanup code would try to free that memory, which obviously would fail.

Zero out that pointer after extracting the error code when this happens so that kfree() can do the right thing.

---
 drivers/gpu/drm/tegra/gem.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/tegra/gem.c +1 -0
index 0063403ab5e1..7c7dd84e6db8 100644
@@ -88,6 +88,7 @@ static struct host1x_bo_mapping *tegra_bo_pin(struct device *dev, struct host1x_
 		if (IS_ERR(map->sgt)) {
 			dma_buf_detach(buf, map->attach);
 			err = PTR_ERR(map->sgt);
+			map->sgt = NULL;
 			goto free;
 		}
 
Signature · 1 line
2.35.1