lpfc: Fix split code for FLOGI on FCoE
Subsystems (2)
PATCH 1/1 lpfc: Fix split code for FLOGI on FCoE
The refactoring code converted context information from SLI-3 to SLI-4. The conversion for the SLI-4 bit field tried to use the old (hacky) sli3 high/low bit settings. Needless to say, it was incorrect.
Explicitly set the context field to type FCFI and set it in the wqe. SLI-4 is now a proper bit field so no need for the shifting/anding.
--- drivers/scsi/lpfc/lpfc_els.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_els.c +1 -1
@@ -1317,7 +1317,7 @@ lpfc_issue_els_flogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,if (bf_get (lpfc_sli_intf_if_type, &phba->sli4_hba.sli_intf) ==LPFC_SLI_INTF_IF_TYPE_0 ) {/* FLOGI needs to be 3 for WQE FCFI */ - ct = ((SLI4_CT_FCFI >>1 ) &1 ) | (SLI4_CT_FCFI &1 ); + ct =SLI4_CT_FCFI ;bf_set (wqe_ct, &wqe->els_req.wqe_com, ct);/* Set the fcfi to the fcfi we registered with */
Signature · 1 line
2.26.2
Martin K. Petersen
AppliedQuoted 8 lines · James Smart
The refactoring code converted context information from SLI-3 to SLI-4. The conversion for the SLI-4 bit field tried to use the old (hacky) sli3 high/low bit settings. Needless to say, it was incorrect.
Explicitly set the context field to type FCFI and set it in the wqe. SLI-4 is now a proper bit field so no need for the shifting/anding.
[...]
Applied to 5.18/scsi-fixes, thanks!
[1/1] lpfc: Fix split code for FLOGI on FCoE
https://git.kernel.org/mkp/scsi/c/cc28fac16ab7
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering