sh: cast away __iomem to remove sparse warning

LKP reported a sparse warning in arch/sh/kernel/crash_dump.c during a kdump patchset reviewing:
https://lore.kernel.org/all/[email protected]/T/#u

../arch/sh/kernel/crash_dump.c:23:36: sparse: warning: incorrect type in argument 1 (different address spaces)
../arch/sh/kernel/crash_dump.c:23:36: sparse: expected void const *addr
../arch/sh/kernel/crash_dump.c:23:36: sparse: got void [noderef] __iomem *

This warning happened when __iomem pointer is passed into fucntion which doesn't expect it. Casting away the __iomem can fix it.

Reported-by kernel test robot <[email protected]>

Signed-off-by Baoquan He <[email protected]>

---
 arch/sh/kernel/crash_dump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/sh/kernel/crash_dump.c +1 -1

index 19ce6a950aac..52d1d54eb6b1 100644
@@ -20,7 +20,7 @@ ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn,
 		return 0;
 
 	vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE);
-	csize = copy_to_iter(vaddr + offset, csize, iter);
+	csize = copy_to_iter((const void __force *)vaddr + offset, csize, iter);
 	iounmap(vaddr);
 
 	return csize;

Signature · 1 line

2.34.1

Hi,

Quoted 10 lines · Baoquan He

LKP reported a sparse warning in arch/sh/kernel/crash_dump.c during a kdump patchset reviewing:
https://lore.kernel.org/all/[email protected]/T/#u

../arch/sh/kernel/crash_dump.c:23:36: sparse: warning: incorrect type in argument 1 (different address spaces)
../arch/sh/kernel/crash_dump.c:23:36: sparse: expected void const *addr
../arch/sh/kernel/crash_dump.c:23:36: sparse: got void [noderef] __iomem *

This warning happened when __iomem pointer is passed into fucntion which doesn't expect it. Casting away the __iomem can fix it.

This warning was reported by lkp during one patchset posted and reviewing. Since it's not related to the patchset, I just sent it separately so that later code change on arch/sh/kernel/crash_dump.c won't trigger the lkp warning again.

[PATCH v5 RESEND 0/3] Convert vmcore to use an iov_iter
https://lore.kernel.org/all/[email protected]/T/#u

Now the above patchset has been merged into linus's tree, please consider taking this patch.

Thanks
Baoquan

Quoted 3 lines

Reported-by kernel test robot <[email protected]>

Signed-off-by Baoquan He <[email protected]>

Quoted 24 lines · Baoquan He

Hi,

Quoted 10 lines · Baoquan He

LKP reported a sparse warning in arch/sh/kernel/crash_dump.c during a kdump patchset reviewing:
https://lore.kernel.org/all/[email protected]/T/#u

../arch/sh/kernel/crash_dump.c:23:36: sparse: warning: incorrect type in argument 1 (different address spaces)
../arch/sh/kernel/crash_dump.c:23:36: sparse: expected void const *addr
../arch/sh/kernel/crash_dump.c:23:36: sparse: got void [noderef] __iomem *

This warning happened when __iomem pointer is passed into fucntion which doesn't expect it. Casting away the __iomem can fix it.

This warning was reported by lkp during one patchset posted and reviewing. Since it's not related to the patchset, I just sent it separately so that later code change on arch/sh/kernel/crash_dump.c won't trigger the lkp warning again.

[PATCH v5 RESEND 0/3] Convert vmcore to use an iov_iter
https://lore.kernel.org/all/[email protected]/T/#u

Now the above patchset has been merged into linus's tree, please consider taking this patch.

Tested-by Rob Landley <[email protected]>

I guess SuperH arch has been in status of no maintenance, however some generic code change may involve correspondant ARCH change so that we have to touch arch/sh/.

Hi!

Quoted 3 lines · Baoquan He

I guess SuperH arch has been in status of no maintenance, however some generic code change may involve correspondant ARCH change so that we have to touch arch/sh/.

It is actually actively maintained by Rich Felker but he is often slow to respond at the moment. I have already offered Rich my help and maybe we can work something out that I can help him with the maintenance.