Skip to contentSkip to conversation

nfs: fix broken handling of the softreval mount option

PATCH New Dan Aloni 1 participant 1 message May 8, 2022

Subsystems (2)
lore
Share & tools
lore

Dan Aloni

author
#0 lore raw

PATCH 1/1 nfs: fix broken handling of the softreval mount option

Turns out that ever since this mount option was added, passing softreval in NFS mount options cancelled all other flags while not affecting the underlying flag NFS_MOUNT_SOFTREVAL.

Fixes c74dfe97c104 ("NFS: Add mount option 'softreval'")
---
 fs/nfs/fs_context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/fs_context.c +1 -1
index e2d59bb5e6bb..9a16897e8dc6 100644
@@ -517,7 +517,7 @@ static int nfs_fs_context_parse_param(struct fs_context *fc,
 		if (result.negated)
 			ctx->flags &= ~NFS_MOUNT_SOFTREVAL;
 		else
-			ctx->flags &= NFS_MOUNT_SOFTREVAL;
+			ctx->flags |= NFS_MOUNT_SOFTREVAL;
 		break;
 	case Opt_posix:
 		if (result.negated)
Signature · 1 line
2.23.0