Skip to contentSkip to conversation

selftests-clarify-common-error-when-running-gup_test.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message May 10, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: selftests: clarify common error when running gup_test
has been removed from the -mm tree. Its filename was
selftests-clarify-common-error-when-running-gup_test.patch

This patch was dropped because it was merged into mm-stable

------------------------------------------------------
From: Joel Savitz <[email protected]>
Subject: selftests: clarify common error when running gup_test

The gup_test binary will fail showing only the output of perror("open") in the case that /sys/kernel/debug/gup_test is not found. This will almost always be due to CONFIG_GUP_TEST not being set, which enables compilation of a kernel that provides this file.

Add a short error message to clarify this failure and point the user to the solution.

---

 tools/testing/selftests/vm/gup_test.c |    2 ++
 1 file changed, 2 insertions(+)
tools/testing/selftests/vm/gup_test.c renamed from tools/testing/selftests/vm/gup_test.c~selftests-clarify-common-error-when-running-gup_test +2 -0
@@ -21,6 +21,8 @@
 #define FOLL_WRITE	0x01	/* check pte is writable */
 #define FOLL_TOUCH	0x02	/* mark page accessed */
 
+#define GUP_TEST_FILE "/sys/kernel/debug/gup_test"
+
 static unsigned long cmd = GUP_FAST_BENCHMARK;
 static int gup_fd, repeats = 1;
 static unsigned long size = 128 * MB;

_

Patches currently in -mm which might be from [email protected] are