Skip to contentSkip to conversation

proc-fix-dentry-inode-overinstantiating-under-proc-pid-net.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message May 10, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled

     Subject: proc: fix dentry/inode overinstantiating under /proc/${pid}/net

has been removed from the -mm tree. Its filename was
proc-fix-dentry-inode-overinstantiating-under-proc-pid-net.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Alexey Dobriyan <[email protected]>
Subject: proc: fix dentry/inode overinstantiating under /proc/${pid}/net

When a process exits, /proc/${pid}, and /proc/${pid}/net dentries are flushed. However some leaf dentries like /proc/${pid}/net/arp_cache aren't. That's because respective PDEs have proc_misc_d_revalidate() hook which returns 1 and leaves dentries/inodes in the LRU.

Force revalidation/lookup on everything under /proc/${pid}/net by inheriting proc_net_dentry_ops.

[[email protected]: coding-style cleanups]
Fixes c6c75deda813 ("proc: fix lookup in /proc/net subdirectories after setns(2)")
Cc Al Viro <[email protected]>

---

 fs/proc/generic.c  |    3 +++
 fs/proc/proc_net.c |    3 +++
 2 files changed, 6 insertions(+)
fs/proc/generic.c renamed from fs/proc/generic.c~proc-fix-dentry-inode-overinstantiating-under-proc-pid-net +3 -0
@@ -448,6 +448,9 @@ static struct proc_dir_entry *__proc_cre
 	proc_set_user(ent, (*parent)->uid, (*parent)->gid);
 
 	ent->proc_dops = &proc_misc_dentry_ops;
+	/* Revalidate everything under /proc/${pid}/net */
+	if ((*parent)->proc_dops == &proc_net_dentry_ops)
+		pde_force_lookup(ent);
 
 out:
 	return ent;
fs/proc/proc_net.c renamed from fs/proc/proc_net.c~proc-fix-dentry-inode-overinstantiating-under-proc-pid-net +3 -0
@@ -376,6 +376,9 @@ static __net_init int proc_net_ns_init(s
 
 	proc_set_user(netd, uid, gid);
 
+	/* Seed dentry revalidation for /proc/${pid}/net */
+	pde_force_lookup(netd);
+
 	err = -EEXIST;
 	net_statd = proc_net_mkdir(net, "stat", netd);
 	if (!net_statd)

_

Patches currently in -mm which might be from [email protected] are

elf-uapi-fixup-elf_st_type-definition.patch