ls1028a: hdp: Add config support for HDP firmware loading
PATCH 1/1 ls1028a: hdp: Add config support for HDP firmware loading
From: Alison Wang <[email protected]>
This patch adds config support for HDP firmware loading on LS1028A.
--- board/freescale/ls1028a/ls1028a.c | 7 ++++++- configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 2 ++ configs/ls1028aqds_tfa_defconfig | 2 ++ configs/ls1028ardb_tfa_SECURE_BOOT_defconfig | 2 ++ configs/ls1028ardb_tfa_defconfig | 2 ++ 5 files changed, 14 insertions(+), 1 deletion(-)
board/freescale/ls1028a/ls1028a.c +6 -1
@@ -1,6 +1,6 @@// SPDX-License-Identifier: GPL-2.0+ /* -* Copyright 2019, 2021 NXP +* Copyright 2019-2022 NXP */ #include <common.h>
@@ -328,3 +328,8 @@ int checkboard(void) return 0; }#endif + +void *video_hw_init (void ) +{ +return NULL ; +}
configs/ls1028aqds_tfa_SECURE_BOOT_defconfig +2 -0
@@ -98,3 +98,5 @@ CONFIG_WDT_SP805=y CONFIG_RSA=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_EFI_LOADER_BOUNCE_BUFFER=y +CONFIG_VIDEO=y +CONFIG_VIDEO_LS_HDP_LOAD=y
configs/ls1028aqds_tfa_defconfig +2 -0
@@ -103,3 +103,5 @@ CONFIG_WDT=y CONFIG_WDT_SP805=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_EFI_LOADER_BOUNCE_BUFFER=y +CONFIG_VIDEO=y +CONFIG_VIDEO_LS_HDP_LOAD=y
configs/ls1028ardb_tfa_SECURE_BOOT_defconfig +2 -0
@@ -92,3 +92,5 @@ CONFIG_WDT_SP805=y CONFIG_RSA=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_EFI_LOADER_BOUNCE_BUFFER=y +CONFIG_VIDEO=y +CONFIG_VIDEO_LS_HDP_LOAD=y
configs/ls1028ardb_tfa_defconfig +2 -0
@@ -101,3 +101,5 @@ CONFIG_WDT=y CONFIG_WDT_SP805=y CONFIG_OF_LIBFDT_OVERLAY=y CONFIG_EFI_LOADER_BOUNCE_BUFFER=y +CONFIG_VIDEO=y +CONFIG_VIDEO_LS_HDP_LOAD=y
Signature · 1 line
2.25.1
Quoted 3 lines
From: Alison Wang <[email protected]>
This patch adds config support for HDP firmware loading on LS1028A.
FWIW, I really don't like this as this is just for a downstream kernel. For the upstream kernel the firmware should be loaded by the kernel itself. But unfortunately, there is no development there. (I have some half baked patches though and can confirm, that firmware loading is working from linux). Instead of this I'd like to see some work to support the DP PHY in upstream linux as this is really the last missing piece to get graphics working.
Now this is purely board related code, so it is probably fine. But in the past the handling of purly downstream stuff was removed from upstream u-boot anyway in favor of the upstream method. i.e. fixup of the ls1028a-gpu node.
-michael
Quoted 5 lines · Michael Walle
Quoted 3 lines
From: Alison Wang <[email protected]>
This patch adds config support for HDP firmware loading on LS1028A.
FWIW, I really don't like this as this is just for a downstream kernel.
This => what? I only see a config option. I searched the list and the source code for CONFIG_VIDEO_LS_HDP_LOAD and I don't see any user...
Quoted 1 line
For the upstream kernel the firmware should be loaded by the kernel itself.
In principle I agree.
Quoted 5 lines
But unfortunately, there is no development there. (I have some half baked patches though and can confirm, that firmware loading is working from linux). Instead of this I'd like to see some work to support the DP PHY in upstream linux as this is really the last missing piece to get graphics working.
It is? What did I miss?
Quoted 6 lines
Now this is purely board related code, so it is probably fine. But in the past the handling of purly downstream stuff was removed from upstream u-boot anyway in favor of the upstream method. i.e. fixup of the ls1028a-gpu node.
-michael
Am 2022-05-10 19:47, schrieb Vladimir Oltean:
Quoted 9 lines · Michael Walle
Quoted 5 lines
Quoted 3 lines
From: Alison Wang <[email protected]>
This patch adds config support for HDP firmware loading on LS1028A.
FWIW, I really don't like this as this is just for a downstream kernel.
This => what? I only see a config option. I searched the list and the source code for
CONFIG_VIDEO_LS_HDP_LOADand I don't see any user...
You are right, I didn't actually notice that. The whole loading thing
[1] is missing.
Quoted 11 lines
Quoted 1 line
For the upstream kernel the firmware should be loaded by the kernel itself.
In principle I agree.
Quoted 5 lines
But unfortunately, there is no development there. (I have some half baked patches though and can confirm, that firmware loading is working from linux). Instead of this I'd like to see some work to support the DP PHY in upstream linux as this is really the last missing piece to get graphics working.
It is? What did I miss?
I don't know? etnaviv is working [2 and more], mesa will be working soon [3]. mali-dp500 should have been working all the time. So only the output path is missing. If you are interested, this [4] is my take on the support, which is actually working. But I haven't found any time to look at it again. And I'm missing any documentation, so most information was found out by educated guesses and comparing to the downstream driver. I'd greatly appreciate any help ;)
[1] https://source.codeaurora.org/external/qoriq/qoriq-components/u-boot/tree/drivers/video/nxp/layerscape?h=integration
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/etnaviv?id=12495f4eb298963565e0bdd37d8096ab1136d89f
[3] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9255
[4] https://github.com/mwalle/linux/tree/feature-cdns-phy
-michael