Skip to contentSkip to conversation

ALSA: wavefront: Proper check of get_user() error

PATCH New Takashi Iwai 1 participant 1 message May 10, 2022 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: wavefront: Proper check of get_user() error

The antient ISA wavefront driver reads its sample patch data (uploaded over an ioctl) via __get_user() with no good reason; likely just for some performance optimizations in the past. Let's change this to the standard get_user() and the error check for handling the fault case properly.

---
 sound/isa/wavefront/wavefront_synth.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
sound/isa/wavefront/wavefront_synth.c +2 -1
index 69cbc79fbb71..2aaaa6807174 100644
@@ -1094,7 +1094,8 @@ wavefront_send_sample (snd_wavefront_t *dev,
 
 			if (dataptr < data_end) {
 		
-				__get_user (sample_short, dataptr);
+				if (get_user(sample_short, dataptr))
+					return -EFAULT;
 				dataptr += skip;
 		
 				if (data_is_unsigned) { /* GUS ? */
Signature · 1 line
2.31.1