media: imx214: Fix the error handling in imx214_probe()
PATCH 1/1 media: imx214: Fix the error handling in imx214_probe()
The driver should disable regulators when fails to probe.
--- drivers/media/i2c/imx214.c | 1 + 1 file changed, 1 insertion(+)
drivers/media/i2c/imx214.c +1 -0
@@ -1076,6 +1076,7 @@ static int imx214_probe(struct i2c_client *client)mutex_destroy (&imx214->mutex);v4l2_ctrl_handler_free (&imx214->ctrls);pm_runtime_disable (imx214->dev); +regulator_bulk_disable (IMX214_NUM_SUPPLIES , imx214->supplies);return ret; }
Signature · 1 line
2.25.1
Ricardo Ribalda Delgado
maintainerHi Zheyu
Do you have seen this issue in a real hardware? The device enters idle state unconditionally after power_on during probe.
Quoted 23 lines · Zheyu Ma
The driver should disable regulators when fails to probe.
Signed-off-by Zheyu Ma <[email protected]>--- drivers/media/i2c/imx214.c | 1 + 1 file changed, 1 insertion(+)drivers/media/i2c/imx214.c +1
-1@@ -1076,6 +1076,7 @@ static int imx214_probe(struct i2c_client *client)mutex_destroy (&imx214->mutex);v4l2_ctrl_handler_free (&imx214->ctrls);pm_runtime_disable (imx214->dev); +regulator_bulk_disable (IMX214_NUM_SUPPLIES , imx214->supplies);return ret; } --2.25.1
Quoted 7 lines · Ricardo Ribalda Delgado
Hi Zheyu
Do you have seen this issue in a real hardware? The device enters idle state unconditionally after
power_onduring probe.
Actually I didn't, I found the "bug" manually. Thanks for your reminder and sorry for the false alarm.
Zheyu Ma
Ricardo Ribalda Delgado
maintainerHi
Quoted 6 lines · Zheyu Ma
Quoted 3 lines · Ricardo Ribalda Delgado
Hi Zheyu
Quoted 7 lines
Quoted 4 lines
Do you have seen this issue in a real hardware? The device enters idle state unconditionally after
power_onduring probe.Actually I didn't, I found the "bug" manually. Thanks for your reminder and sorry for the false alarm.
Thank you for looking at the code :)
Quoted 2 lines
Zheyu Ma