Skip to contentSkip to conversation

media: imx214: Fix the error handling in imx214_probe()

PATCH In review Zheyu Ma 2 participants 4 messages May 10, 2022 – May 11, 2022

Subsystems (3)
lore
Share & tools
lore

Zheyu Ma

author
#0 lore raw

PATCH 1/1 media: imx214: Fix the error handling in imx214_probe()

The driver should disable regulators when fails to probe.

---
 drivers/media/i2c/imx214.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/i2c/imx214.c +1 -0
index 83c1737abeec..61eeaefd4298 100644
@@ -1076,6 +1076,7 @@ static int imx214_probe(struct i2c_client *client)
 	mutex_destroy(&imx214->mutex);
 	v4l2_ctrl_handler_free(&imx214->ctrls);
 	pm_runtime_disable(imx214->dev);
+	regulator_bulk_disable(IMX214_NUM_SUPPLIES, imx214->supplies);
 
 	return ret;
 }
Signature · 1 line
2.25.1
#1 lore raw

Hi Zheyu

Do you have seen this issue in a real hardware? The device enters idle state unconditionally after power_on during probe.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/imx214.c#n1008

Quoted 23 lines · Zheyu Ma

The driver should disable regulators when fails to probe.

---
 drivers/media/i2c/imx214.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/i2c/imx214.c +1 -1
index 83c1737abeec..61eeaefd4298 100644
@@ -1076,6 +1076,7 @@ static int imx214_probe(struct i2c_client *client)
        mutex_destroy(&imx214->mutex);
        v4l2_ctrl_handler_free(&imx214->ctrls);
        pm_runtime_disable(imx214->dev);
+       regulator_bulk_disable(IMX214_NUM_SUPPLIES, imx214->supplies);
 
        return ret;
 }
--

2.25.1

#3 lore raw

Hi

Quoted 6 lines · Zheyu Ma
Quoted 3 lines · Ricardo Ribalda Delgado

Hi Zheyu

Quoted 7 lines
Quoted 4 lines

Do you have seen this issue in a real hardware? The device enters idle state unconditionally after power_on during probe.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/imx214.c#n1008

Actually I didn't, I found the "bug" manually. Thanks for your reminder and sorry for the false alarm.

Thank you for looking at the code :)

Quoted 2 lines

Zheyu Ma