Skip to contentSkip to conversation

wxwidgets: enable to use private fonts

PATCH Superseded [email protected] 2 participants 5 messages May 11, 2022 – May 13, 2022

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 wxwidgets: enable to use private fonts

From: Kai Kang <[email protected]>

Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It allows application to use the font from the given file even if it is not globally installed on the system.

---
v2:
* use upper case 'ON' to align with others in oe

 meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +1 -0
index 6b57cb54c..b9b1dcf0d 100644
@@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
     -DwxUSE_LIBTIFF=sys \
     -DwxUSE_REGEX=builtin \
     -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
+    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \
 "
 EXTRA_OECMAKE:append:libc-musl = " \
     -DHAVE_LOCALE_T=OFF \
Signature · 1 line
2.17.1
#1 lore raw
Quoted 20 lines · kai

From: Kai Kang <[email protected]>

Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It allows application to use the font from the given file even if it is not globally installed on the system.

---
v2:
* use upper case 'ON' to align with others in oe

 meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +0 -0
index 6b57cb54c..b9b1dcf0d 100644

meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb EXTRA_OECMAKE += " \ · line 42

Quoted 4 lines
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +1 -0
@@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
     -DwxUSE_LIBTIFF=sys \
     -DwxUSE_REGEX=builtin \
     -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
+    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \

why not add it to the packageconfig setting itself ?

Quoted 15 lines
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +0 -1
 "
 EXTRA_OECMAKE:append:libc-musl = " \
     -DHAVE_LOCALE_T=OFF \
--

2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97033): https://lists.openembedded.org/g/openembedded-devel/message/97033
Mute This Topic: https://lists.openembedded.org/mt/91031050/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#2 lore raw
Quoted 15 lines · Khem Raj
Quoted 14 lines · kai

From: Kai Kang <[email protected]>

Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It allows application to use the font from the given file even if it is not globally installed on the system.

---
v2:
* use upper case 'ON' to align with others in oe

  meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
  1 file changed, 1 insertion(+)
Quoted 10 lines

meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb EXTRA_OECMAKE += " \ · line 42

Quoted 9 lines
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +1 -0
index 6b57cb54c..b9b1dcf0d 100644
@@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
      -DwxUSE_LIBTIFF=sys \
      -DwxUSE_REGEX=builtin \
      -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
+    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \

why not add it to the packageconfig setting itself ?

It is an useful feature for wxwidgets with gui, so I want it  to be enabled by default. And it requires pango to make it work.

I can see gtk3 depends on pango but qtbase doesn't. So only check 'gtk' here.

Regards,
Kai

Quoted 16 lines
Quoted 16 lines
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +0 -1
  "
  EXTRA_OECMAKE:append:libc-musl = " \
      -DHAVE_LOCALE_T=OFF \
--

2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97033): https://lists.openembedded.org/g/openembedded-devel/message/97033
Mute This Topic: https://lists.openembedded.org/mt/91031050/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 2 lines
Kai Kang
Wind River Linux
#3 lore raw
Quoted 27 lines · Kai
Quoted 15 lines · Khem Raj
Quoted 14 lines · kai

From: Kai Kang <[email protected]>

Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It allows application to use the font from the given file even if it is not globally installed on the system.

---
v2:
* use upper case 'ON' to align with others in oe

  meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
  1 file changed, 1 insertion(+)
Quoted 10 lines

meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb EXTRA_OECMAKE += " \ · line 42

Quoted 9 lines
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +1 -0
index 6b57cb54c..b9b1dcf0d 100644
@@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
      -DwxUSE_LIBTIFF=sys \
      -DwxUSE_REGEX=builtin \
      -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
+    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \

why not add it to the packageconfig setting itself ?

Quoted 4 lines

It is an useful feature for wxwidgets with gui, so I want it to be enabled by default. And it requires pango to make it work.

I can see gtk3 depends on pango but qtbase doesn't. So only check 'gtk'

I meant to do something like below instead of this patch.

PACKAGECONFIG[gtk] = "-DwxBUILD_TOOLKIT=gtk3 -DwxUSE_GUI=ON -DwxUSE_PRIVATE_FONTS=ON,,gtk+3,,,no_gui qt"

Quoted 26 lines

here.

Regards,
Kai

Quoted 8 lines
Quoted 8 lines
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +0 -1
  "
  EXTRA_OECMAKE:append:libc-musl = " \
      -DHAVE_LOCALE_T=OFF \
--

2.17.1

Quoted 8 lines
Quoted 8 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97033): https://lists.openembedded.org/g/openembedded-devel/message/97033
Mute This Topic: https://lists.openembedded.org/mt/91031050/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

--
Kai Kang
Wind River Linux

author
#4 lore raw
Quoted 27 lines · Khem Raj
Quoted 26 lines · Kai
Quoted 25 lines · Khem Raj
Quoted 19 lines · kai

From: Kai Kang <[email protected]>

Enable option wxUSE_PRIVATE_FONTS of wxwidgets if build with gtk. It allows application to use the font from the given file even if it is not globally installed on the system.

---
v2:
* use upper case 'ON' to align with others in oe

   meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb | 1 +
   1 file changed, 1 insertion(+)
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +0 -0
index 6b57cb54c..b9b1dcf0d 100644

meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb EXTRA_OECMAKE += " \ · line 42

Quoted 4 lines
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +1 -0
@@ -39,6 +39,7 @@ EXTRA_OECMAKE += " \
       -DwxUSE_LIBTIFF=sys \
       -DwxUSE_REGEX=builtin \
       -DwxPLATFORM_LIB_DIR=${@d.getVar('baselib').replace('lib', '')} \
+    ${@bb.utils.contains('PACKAGECONFIG', 'gtk', '-DwxUSE_PRIVATE_FONTS=ON', '', d)} \

why not add it to the packageconfig setting itself ?

Quoted 8 lines
Quoted 4 lines

It is an useful feature for wxwidgets with gui, so I want it to be enabled by default. And it requires pango to make it work.

I can see gtk3 depends on pango but qtbase doesn't. So only check 'gtk'

I meant to do something like below instead of this patch.

PACKAGECONFIG[gtk] = "-DwxBUILD_TOOLKIT=gtk3 -DwxUSE_GUI=ON -DwxUSE_PRIVATE_FONTS=ON,,gtk+3,,,no_gui qt"

OK. v3 will be sent.

Thanks,
Kai

Quoted 25 lines
Quoted 25 lines

here.

Regards,
Kai

Quoted 7 lines
Quoted 7 lines
meta-oe/recipes-extended/wxwidgets/wxwidgets_3.1.5.bb +0 -1
   "
   EXTRA_OECMAKE:append:libc-musl = " \
       -DHAVE_LOCALE_T=OFF \
--

2.17.1

Quoted 8 lines
Quoted 8 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97033): https://lists.openembedded.org/g/openembedded-devel/message/97033
Mute This Topic: https://lists.openembedded.org/mt/91031050/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

--
Kai Kang
Wind River Linux

Signature · 2 lines
Kai Kang
Wind River Linux