Cleanups and enablement for Quartz64-A
Subsystems (3)
PATCH 6/6 arm64: dts: rockchip: enable sfc controller on Quartz64 Model A
In reply to Peter GeisAdd the sfc controller binding for the Quartz64 Model A. This is not populated by default, so leave it disabled.
--- .../boot/dts/rockchip/rk3566-quartz64-a.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +16 -0
@@ -603,6 +603,22 @@ &sdmmc1 { status = "okay"; }; +&sfc { + pinctrl-0 = <&fspi_pins>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + + flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <24000000>; + spi-rx-bus-width = <4>; + spi-tx-bus-width = <1>; + }; +}; + /* spdif is exposed on con40 pin 18 */ &spdif { status = "okay";
Signature · 1 line
2.25.1
cover Cleanups and enablement for Quartz64-A
Good Morning,
The following patches clean up some dtbs_check warnings, fixup the Quartz64-A dts, and enable some additional functionality on the Quartz64-A.
With this series the only remaining dtbs_check warnings are due to unconverted bindings.
Patch 6 is dependent on:13e0ee34f39c arm64: dts: rockchip: add rk356x sfc support currently in linux-next.
Patches 1 and 2 add some missing bindings to the rk3568 cru. Patch 3 renames the bluetooth gpios on Quartz64-A. Patch 4 adds the fan gpio pinctrl on Quartz64-A.
Patch 5 enables sdr-104 on Quartz64-A.
Patch 6 adds the disabled by default sfc controller to Quartz64-A.
Peter Geis (6):
dt-binding: clock: Add missing rk3568 cru bindings
arm64: dts: rockchip: add clocks to rk356x cru
arm64: dts: rockchip: rename Quartz64-A bluetooth gpios
arm64: dts: rockchip: add Quartz64-A fan pinctrl
arm64: dts: rockchip: enable sdr-104 on sdmmc
arm64: dts: rockchip: enable sfc controller on Quartz64 Model A
.../bindings/clock/rockchip,rk3568-cru.yaml | 13 +++++++++ .../boot/dts/rockchip/rk3566-quartz64-a.dts | 29 +++++++++++++++++-- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 ++ 3 files changed, 42 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1
PATCH 2/6 arm64: dts: rockchip: add clocks to rk356x cru
The rk356x cru requires a 24m clock input to function. Add the clocks properties to the cru to clear some dtbs_check warnings.
--- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk356x.dtsi +2 -0
@@ -336,6 +336,8 @@ pmucru: clock-controller@fdd00000 { cru: clock-controller@fdd20000 { compatible = "rockchip,rk3568-cru"; reg = <0x0 0xfdd20000 0x0 0x1000>; + clocks = <&xin24m>; + clock-names = "xin24m"; #clock-cells = <1>; #reset-cells = <1>; assigned-clocks = <&cru PLL_GPLL>, <&pmucru PLL_PPLL>;
Signature · 1 line
2.25.1
PATCH 4/6 arm64: dts: rockchip: add Quartz64-A fan pinctrl
In reply to Peter GeisThe Quartz64 Model A fan is bound to a single gpio. Prevent pinctrl issues in the future by binding the pinctrl assignment for the gpio.
--- arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +8 -0
@@ -32,6 +32,8 @@ fan: gpio_fan { gpios = <&gpio0 RK_PD5 GPIO_ACTIVE_HIGH>; gpio-fan,speed-map = <0 0 4500 1>; + pinctrl-names = "default"; + pinctrl-0 = <&fan_en_h>; #cooling-cells = <2>; };
@@ -510,6 +512,12 @@ bt_wake_l: bt-wake-l { }; }; + fan { + fan_en_h: fan-en-h { + rockchip,pins = <0 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; + leds { work_led_enable_h: work-led-enable-h { rockchip,pins = <0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>;
Signature · 1 line
2.25.1
PATCH 1/6 dt-binding: clock: Add missing rk3568 cru bindings
In reply to Peter GeisThe rk3568 cru requires a clock input and a phandle to the grf node. Add these bindings to clear some dtbs_check warnings.
--- .../bindings/clock/rockchip,rk3568-cru.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)
Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.yaml +13 -0
@@ -34,6 +34,19 @@ properties: "#reset-cells": const: 1 + clocks: + maxItems: 1 + + clock-names: + const: xin24m + + rockchip,grf: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the syscon managing the "general register files" (GRF), + if missing pll rates are not changeable, due to the missing pll + lock status. + required: - compatible - reg
Signature · 1 line
2.25.1
PATCH 3/6 arm64: dts: rockchip: rename Quartz64-A bluetooth gpios
In reply to Peter GeisThe bluetooth binding for the Quartz64 Model A has incorrectly named host-wakeup and device-wakeup gpios. Rename them to clear some dtbs_check warnings.
--- arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +2 -2
@@ -638,8 +638,8 @@ bluetooth { compatible = "brcm,bcm43438-bt"; clocks = <&rk817 1>; clock-names = "lpo"; - device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>; - host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>; + device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>; + host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>; shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
Signature · 1 line
2.25.1
PATCH 5/6 arm64: dts: rockchip: enable sdr-104 on sdmmc
In reply to Peter GeisNow that we have working io-domain support, we can enable higher date rates on the sdmmc card.
Before:
Timing buffered disk reads: 68 MB in 3.08 seconds = 22.07 MB/sec
After:
Timing buffered disk reads: 188 MB in 3.02 seconds = 62.29 MB/sec
--- arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +1 -0
@@ -582,6 +582,7 @@ &sdmmc0 { disable-wp; pinctrl-names = "default"; pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>; + sd-uhs-sdr104; vmmc-supply = <&vcc3v3_sd>; vqmmc-supply = <&vccio_sd>; status = "okay";
Signature · 1 line
2.25.1
Re: [PATCH v1 1/6] dt-binding: clock: Add missing rk3568 cru bindings
In reply to Peter GeisQuoted 8 lines · Peter Geis
The rk3568 cru requires a clock input and a phandle to the grf node. Add these bindings to clear some
dtbs_checkwarnings.Signed-off-by Peter Geis <[email protected]>--- .../bindings/clock/rockchip,rk3568-cru.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)
Best regards,
Krzysztof
Quoted 10 lines · Peter Geis
Good Morning,
The following patches clean up some
dtbs_checkwarnings, fixup the Quartz64-A dts, and enable some additional functionality on the Quartz64-A.With this series the only remaining
dtbs_checkwarnings are due to unconverted bindings.[...]
Applied, thanks!
[1/6] dt-binding: clock: Add missing rk3568 cru bindings
commit: b21445db9818ccb9fa1c0ba81fd3705eb8d347e3
[2/6] arm64: dts: rockchip: add clocks to rk356x cru
commit: 70f679ad25d5f8d0076e283bd6c61e047c7af226
[3/6] arm64: dts: rockchip: rename Quartz64-A bluetooth gpios
commit: 650a1523756bb1e697f8927d2915cbbb92e83f8c
[4/6] arm64: dts: rockchip: add Quartz64-A fan pinctrl
commit: 82f4f0183e5d3b2d0a2af6c70ba16f86b5897ef9
[5/6] arm64: dts: rockchip: enable sdr-104 on sdmmc
commit: 6adce30701c810e11685911ca2114fbc0107120d
[6/6] arm64: dts: rockchip: enable sfc controller on Quartz64 Model A
commit: e5008be69a1947d4236ab3f73c939f9c2a9a6f80Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>
Re: [PATCH v1 6/6] arm64: dts: rockchip: enable sfc controller on Quartz64 Model A
In reply to Peter GeisQuoted 19 lines · Peter Geis
Add the sfc controller binding for the Quartz64 Model A. This is not populated by default, so leave it disabled.
Signed-off-by Peter Geis <[email protected]>--- .../boot/dts/rockchip/rk3566-quartz64-a.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +3
-0@@ -603,6 +603,22 @@ &sdmmc1 { status = "okay"; }; +&sfc { + pinctrl-0 = <&fspi_pins>; + pinctrl-names = "default";
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts &sdmmc1 { · line 618
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +10
-0+ #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + + flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <24000000>; + spi-rx-bus-width = <4>; + spi-tx-bus-width = <1>;
This isn't really a concern, just a comment. Did you test this with the spi-tx-bus-width of 4 by chance? While I did have to use 1 for my implementation (the Odroid Go Advance) the Rockchip engineer I worked with couldn't replicate the issue on his end and we ended up chalking my issues up to an implementation specific problem. I'm only commenting here because I don't want you to think that for this device the tx always has to be 1, of course if your implementation does have issues with a tx of 2 or 4 that's different...
Thank you.
Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +3
-0+ }; +}; + /* spdif is exposed on con40 pin 18 */ &spdif { status = "okay";Signature · 1 line
2.25.1
Re: [PATCH v1 6/6] arm64: dts: rockchip: enable sfc controller on Quartz64 Model A
Quoted 32 lines · Chris Morgan
Quoted 19 lines · Peter Geis
Add the sfc controller binding for the Quartz64 Model A. This is not populated by default, so leave it disabled.
Signed-off-by Peter Geis <[email protected]>--- .../boot/dts/rockchip/rk3566-quartz64-a.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +3
-0@@ -603,6 +603,22 @@ &sdmmc1 { status = "okay"; }; +&sfc { + pinctrl-0 = <&fspi_pins>; + pinctrl-names = "default";arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts &sdmmc1 { · line 618
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +10
-0+ #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + + flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <24000000>; + spi-rx-bus-width = <4>; + spi-tx-bus-width = <1>;
Quoted 8 lines
This isn't really a concern, just a comment. Did you test this with the spi-tx-bus-width of 4 by chance? While I did have to use 1 for my implementation (the Odroid Go Advance) the Rockchip engineer I worked with couldn't replicate the issue on his end and we ended up chalking my issues up to an implementation specific problem. I'm only commenting here because I don't want you to think that for this device the tx always has to be 1, of course if your implementation does have issues with a tx of 2 or 4 that's different...
Yes, and it was a data disaster. Looking into it I found all of the flash chips that I could find only support 4x RX 1x TX. Some didn't handle 4x RX terribly well either.
Quoted 12 lines
Thank you.
Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts +3
-1+ }; +}; + /* spdif is exposed on con40 pin 18 */ &spdif { status = "okay"; --2.25.1