Skip to contentSkip to conversation

casefold: Fix expansion of seqres variable

PATCH In review Gabriel Krisman Bertazi 2 participants 2 messages May 11, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 casefold: Fix expansion of seqres variable

seqres is not properly expanded on these error paths, causing a file called seqres.full to be created instead.

---
changes since v1:
- Add whitespace between variable and std redirection (chinner)

---
 common/casefold | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
common/casefold +2 -2
index 9172d818125a..d9126f4c59e6 100644
@@ -25,7 +25,7 @@ _require_scratch_casefold()
 		_notrun "$FSTYP does not support casefold feature"
 	fi
 
-	if ! _scratch_mkfs_casefold &>>seqres.full; then
+	if ! _scratch_mkfs_casefold &>> $seqres.full ; then
 		_notrun "$FSTYP userspace tools do not support casefold"
 	fi
 
@@ -33,7 +33,7 @@ _require_scratch_casefold()
 	# defined by the userspace tools.  This will fail if
 	# the userspace tool used a more recent encoding than the one
 	# supported in kernel space.
-	if ! _try_scratch_mount &>>seqres.full; then
+	if ! _try_scratch_mount &>> $seqres.full ; then
 		_notrun "kernel can't mount filesystem with the encoding set by userspace"
 	fi
 	_scratch_unmount
Signature · 1 line
2.36.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Gabriel Krisman Bertazi

seqres is not properly expanded on these error paths, causing a file called seqres.full to be created instead.

---

Quoted 31 lines

changes since v1:
- Add whitespace between variable and std redirection (chinner)

---
 common/casefold | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
common/casefold +2 -2
index 9172d818125a..d9126f4c59e6 100644
@@ -25,7 +25,7 @@ _require_scratch_casefold()
 		_notrun "$FSTYP does not support casefold feature"
 	fi
 
-	if ! _scratch_mkfs_casefold &>>seqres.full; then
+	if ! _scratch_mkfs_casefold &>> $seqres.full ; then
 		_notrun "$FSTYP userspace tools do not support casefold"
 	fi
 
@@ -33,7 +33,7 @@ _require_scratch_casefold()
 	# defined by the userspace tools.  This will fail if
 	# the userspace tool used a more recent encoding than the one
 	# supported in kernel space.
-	if ! _try_scratch_mount &>>seqres.full; then
+	if ! _try_scratch_mount &>> $seqres.full ; then
 		_notrun "kernel can't mount filesystem with the encoding set by userspace"
 	fi
 	_scratch_unmount
Signature · 1 line
2.36.1