fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment
PATCH 1/1 fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment
Add the description of @folio and remove @page in function kernel-doc comment to remove warnings found by running scripts/kernel-doc, which is caused by using 'make W=1'.
fs/jbd2/transaction.c:2149: warning: Function parameter or member 'folio' not described in 'jbd2_journal_try_to_free_buffers' fs/jbd2/transaction.c:2149: warning: Excess function parameter 'page' description in 'jbd2_journal_try_to_free_buffers'
--- fs/jbd2/transaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/jbd2/transaction.c +1 -1
@@ -2114,7 +2114,7 @@ __journal_try_to_free_buffer(journal_t *journal, struct buffer_head *bh)/** * jbd2_journal_try_to_free_buffers() - try to free page buffers. * @journal: journal for operation -* @page: to try and free +* @folio: Folio to detach data from. * * For all the buffers on this page, * if they are fully written out ordered data, move them onto BUF_CLEAN
Signature · 1 line
2.20.1.7.g153144c
Quoted 11 lines · Yang Li
Add the description of @folio and remove @page in function kernel-doc comment to remove warnings found by running
scripts/kernel-doc, which is caused by using 'make W=1'.
fs/jbd2/transaction.c:2149: warning: Function parameter or member 'folio' not described in 'jbd2_journal_try_to_free_buffers'fs/jbd2/transaction.c:2149: warning: Excess function parameter 'page' description in 'jbd2_journal_try_to_free_buffers'Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
OK, but isn't this on linux-next only? Because I don't see the 'folio' parameter in current Linus' tree yet.
Honza
Quoted 20 lines
--- fs/jbd2/transaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/jbd2/transaction.c +1
-1@@ -2114,7 +2114,7 @@ __journal_try_to_free_buffer(journal_t *journal, struct buffer_head *bh)/** * jbd2_journal_try_to_free_buffers() - try to free page buffers. * @journal: journal for operation -* @page: to try and free +* @folio: Folio to detach data from. * * For all the buffers on this page, * if they are fully written out ordered data, move them onto BUF_CLEAN Signature · 1 line
2.20.1.7.g153144c
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 10 lines · Yang Li
Add the description of @folio and remove @page in function kernel-doc comment to remove warnings found by running
scripts/kernel-doc, which is caused by using 'make W=1'.
fs/jbd2/transaction.c:2149: warning: Function parameter or member 'folio' not described in 'jbd2_journal_try_to_free_buffers'fs/jbd2/transaction.c:2149: warning: Excess function parameter 'page' description in 'jbd2_journal_try_to_free_buffers'[...]
Applied, thanks!
[1/1] fs: Fix jbd2_journal_try_to_free_buffers() kernel-doc comment
commit: 4f5bf12732fd78e225fc62b7c5c84d9032f8048a
Best regards,
Signature · 1 line
Theodore Ts'o <[email protected]>