Skip to contentSkip to conversation

dt-bindings: gpio: altera: correct interrupt-cells

PATCH In review Dinh Nguyen 2 participants 2 messages May 12, 2022 – May 13, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: gpio: altera: correct interrupt-cells

update documentation to correctly state the interrupt-cells to be 2.

Fixes 4fd9bbc6e071 ("drivers/gpio: Altera soft IP GPIO driver devicetree binding")
---
 Documentation/devicetree/bindings/gpio/gpio-altera.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/gpio/gpio-altera.txt +3 -2
index 146e554b3c67..2a80e272cd66 100644
@@ -9,8 +9,9 @@ Required properties:
   - The second cell is reserved and is currently unused.
 - gpio-controller : Marks the device node as a GPIO controller.
 - interrupt-controller: Mark the device node as an interrupt controller
-- #interrupt-cells : Should be 1. The interrupt type is fixed in the hardware.
+- #interrupt-cells : Should be 2. The interrupt type is fixed in the hardware.
   - The first cell is the GPIO offset number within the GPIO controller.
+  - The second cell is the interrupt trigger type and level flags.
 - interrupts: Specify the interrupt.
 - altr,interrupt-type: Specifies the interrupt trigger type the GPIO
   hardware is synthesized. This field is required if the Altera GPIO controller
@@ -38,6 +39,6 @@ gpio_altr: gpio@ff200000 {
 	altr,interrupt-type = <IRQ_TYPE_EDGE_RISING>;
 	#gpio-cells = <2>;
 	gpio-controller;
-	#interrupt-cells = <1>;
+	#interrupt-cells = <2>;
 	interrupt-controller;
 };
Signature · 1 line
2.25.1
#1 lore raw
Quoted 5 lines · Dinh Nguyen

update documentation to correctly state the interrupt-cells to be 2.

Fixes 4fd9bbc6e071 ("drivers/gpio: Altera soft IP GPIO driver devicetree binding")

(...)

Quoted 4 lines

-- #interrupt-cells : Should be 1. The interrupt type is fixed in the hardware. +- #interrupt-cells : Should be 2. The interrupt type is fixed in the hardware.
- The first cell is the GPIO offset number within the GPIO controller.
+ - The second cell is the interrupt trigger type and level flags.

So now this says (A) that the interrupt type is fixed in hardware, and (B) that you should specify it.

This is confusing, I think something is wrong?

Yours,
Linus Walleij