Skip to contentSkip to conversation

netlink_delinearize: release last register on exit

PATCH New Pablo Neira Ayuso 1 participant 1 message May 13, 2022 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 netlink_delinearize: release last register on exit

netlink_release_registers() does not release the expression in the last 32-bit register.

struct netlink_parse_ctx {
	...
        struct expr             *registers[MAX_REGS + 1];

This array is MAX_REGS + 1 (verdict register + 16 32-bit registers).

Fixes 371c3a0bc3c2 ("netlink_delinearize: release expressions in context registers")
---
 src/netlink_delinearize.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/netlink_delinearize.c +1 -1
index a1b00dee209a..068c3bba1159 100644
@@ -100,7 +100,7 @@ static void netlink_release_registers(struct netlink_parse_ctx *ctx)
 {
 	int i;
 
-	for (i = 0; i < MAX_REGS; i++)
+	for (i = 0; i <= MAX_REGS; i++)
 		expr_free(ctx->registers[i]);
 }
 
Signature · 1 line
2.30.2