Skip to contentSkip to conversation

usb: serial: io_ti: Adding Agilent E5805A support

PATCH Superseded Robert Eckelmann 2 participants 2 messages May 14, 2022 – May 17, 2022

Subsystems (3)
Documentation USB USB serial

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Robert Eckelmann

author
#0 lore raw

PATCH 1/1 usb: serial: io_ti: Adding Agilent E5805A support

Hello Johan,

Below is a small patch regarding the io_ti driver.
This patch enables the use of the Agilent E5805A USB-RS232(x4) adapter. It is a relabeled Inside Out Networks Edgeport with OEM USB-ID.

Signed-off-by Robert Eckelmann <[email protected]>
---
 Documentation/usb/usb-serial.rst | 4 ++++
 drivers/usb/serial/io_ti.c       | 2 ++
 drivers/usb/serial/io_usbvend.h  | 2 +-
 3 files changed, 7 insertions(+), 1 deletion(-)
Documentation/usb/usb-serial.rst +4 -0
index 69586aeb60bb..d9cfb6cb2d07 100644
@@ -412,6 +412,10 @@ Inside Out Networks Edgeport Driver
        - Edgeport/4 DIN
        - Edgeport/16 Dual
 
+  This dirver now also includes the Agilent E5805A usb-to-RS232 adapter device,
+  as this is a rebranded Edgeport device.
+
+
   For any questions or problems with this driver, please contact Greg
   Kroah-Hartman at [email protected]
drivers/usb/serial/io_ti.c +0 -0
index a7b3c15957ba..2810cefa628d 100644
@@ -166,6 +166,7 @@ static const struct usb_device_id edgeport_2port_id_table[] = {

	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_8S) },
	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416) },
	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416B) },
+	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_E5805A)},
	{ }

};

@@ -204,6 +205,7 @@ static const struct usb_device_id id_table_combined[] = {
	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_8S) },
	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416) },
	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416B) },
+	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_E5805A)},
	{ }

};

drivers/usb/serial/io_usbvend.h +1 -1
index 52cbc353051f..3be6bce15d97 100644
@@ -212,7 +212,7 @@
 //
 // Definitions for other product IDs
 #define ION_DEVICE_ID_MT4X56USB			0x1403	// OEM device
-
+#define ION_DEVICE_ID_E5805A			0x1A01  // OEM device (internals based on Edgeport/4?)
 
 #define	GENERATION_ID_FROM_USB_PRODUCT_ID(ProductId)				\

			((__u16) ((ProductId >> 8) & (ION_GENERATION_MASK)))

--
2.36.0

maintainer
#1 lore raw
Quoted 5 lines · Robert Eckelmann

Hello Johan,

Below is a small patch regarding the io_ti driver.
This patch enables the use of the Agilent E5805A USB-RS232(x4) adapter. It is a relabeled Inside Out Networks Edgeport with OEM USB-ID.

Thanks for the patch. Note that anything you write here in the body of the will end up in the git commit message so greetings etc. should go below the --- line.

Quoted 12 lines
Signed-off-by Robert Eckelmann <[email protected]>
---
 Documentation/usb/usb-serial.rst | 4 ++++
 drivers/usb/serial/io_ti.c       | 2 ++
 drivers/usb/serial/io_usbvend.h  | 2 +-
 3 files changed, 7 insertions(+), 1 deletion(-)
Documentation/usb/usb-serial.rst +0 -0
index 69586aeb60bb..d9cfb6cb2d07 100644

Documentation/usb/usb-serial.rst Inside Out Networks Edgeport Driver · line 415

Quoted 4 lines
Documentation/usb/usb-serial.rst +1 -0
@@ -412,6 +412,10 @@ Inside Out Networks Edgeport Driver
        - Edgeport/4 DIN
        - Edgeport/16 Dual
 
+  This dirver now also includes the Agilent E5805A usb-to-RS232 adapter device,

typo: dirver

Documentation/usb/usb-serial.rst Inside Out Networks Edgeport Driver · line 416

Quoted 1 line
Documentation/usb/usb-serial.rst +1 -0
+  as this is a rebranded Edgeport device.

But I don't we need to update the documentation here as the list isn't complete as is.

Actually this entry appears to be for the io_edgeport driver.

Quoted 30 lines
Documentation/usb/usb-serial.rst +2 -0
+
+
   For any questions or problems with this driver, please contact Greg
   Kroah-Hartman at [email protected]
drivers/usb/serial/io_ti.c +2 -0
index a7b3c15957ba..2810cefa628d 100644
@@ -166,6 +166,7 @@ static const struct usb_device_id edgeport_2port_id_table[] = {
 	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_8S) },
 	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416) },
 	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416B) },
+	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_E5805A)},
 	{ }
 };
 

@@ -204,6 +205,7 @@ static const struct usb_device_id id_table_combined[] = {
 	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_8S) },
 	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416) },
 	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416B) },
+	{ USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_E5805A)},
 	{ }
 };
drivers/usb/serial/io_usbvend.h +0 -0
index 52cbc353051f..3be6bce15d97 100644

drivers/usb/serial/io_usbvend.h line 215

Quoted 4 lines
drivers/usb/serial/io_usbvend.h +0 -1
@@ -212,7 +212,7 @@
 //
 // Definitions for other product IDs
 #define ION_DEVICE_ID_MT4X56USB			0x1403	// OEM device
-

Please keep the double newline separator.

drivers/usb/serial/io_usbvend.h line 215

Quoted 1 line
drivers/usb/serial/io_usbvend.h +1 -0
+#define ION_DEVICE_ID_E5805A			0x1A01  // OEM device (internals based on Edgeport/4?)

Just say "rebranded" here too?

Could you please also post the output of usb-devices (or lsusb -v) for this device for completeness?

drivers/usb/serial/io_usbvend.h line 217

Quoted 3 lines
drivers/usb/serial/io_usbvend.h +0 -0
 #define	GENERATION_ID_FROM_USB_PRODUCT_ID(ProductId)				\
 			((__u16) ((ProductId >> 8) & (ION_GENERATION_MASK)))

Johan