Skip to contentSkip to conversation

Fix a compilation issue of mmc-utils

PATCH In review [email protected] 3 participants 7 messages May 15, 2022 – May 17, 2022 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

cover Fix a compilation issue of mmc-utils

From: Ming Liu <[email protected]>

Update mmc-utils to the latest git hash to fix a compilation issue, which was observed on kirkstone when the kernel 5.4 is being used.

Alexander Kanavin (1):
mmc-utils: upgrade to latest revision

 meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 mmc-utils: upgrade to latest revision

From: Alexander Kanavin <[email protected]>

(cherry picked from commit d98b06c9c6f480de1e5167bfe8392e39300fc02c)
---
 meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/mmc/mmc-utils_git.bb +1 -1
index addefe9abf..3e611d1306 100644
@@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-only"
 LIC_FILES_CHKSUM = "file://mmc.c;beginline=1;endline=20;md5=fae32792e20f4d27ade1c5a762d16b7d"
 
 SRCBRANCH ?= "master"
-SRCREV = "4303889c8bd9a2357587eb6ebacecb70098a264d"
+SRCREV = "b7e4d5a6ae9942d26a11de9b05ae7d52c0802802"
 
 PV = "0.1+git${SRCPV}"
 
Signature · 1 line
2.25.1
#2 lore raw

Re: [OE-core] [kirkstone] [PATCH 1/1] mmc-utils: upgrade to latest revision

Quoted 11 lines · On Sun, 2022-05-15 at 14:43 +0200, [email protected] wrote:

From: Alexander Kanavin <[email protected]>

(cherry picked from commit d98b06c9c6f480de1e5167bfe8392e39300fc02c)
---
 meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Why does kirkstone need this though?

Cheers,

Richard

#7 lore raw

Re: [OE-core] [kirkstone] [PATCH 1/1] mmc-utils: upgrade to latest revision

In reply to a message not in the archive
Quoted 13 lines · Richard Purdie via lists.openembedded.org
Quoted 11 lines · On Sun, 2022-05-15 at 14:43 +0200, [email protected] wrote:

From: Alexander Kanavin <[email protected]>

(cherry picked from commit d98b06c9c6f480de1e5167bfe8392e39300fc02c)
---
 meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 1 line

Why does kirkstone need this though?

Sorry, you cc'd me on the patch but not the cover letter which meant this sorted badly in my mail folders but I noticed the cover letter now.

You mention a compile failure in the cover letter, it would probably be useful to give a little more info about the kind of compile failure given we've not seen this anywhere else?

Cheers,

Richard

author
#3 lore raw

Re: [OE-core] [kirkstone] [PATCH 1/1] mmc-utils: upgrade to latest revision

In reply to [email protected]

Hi, Richard:

Our products are based on LTS kirkstone, we found a build issue of mmc-utils, which has been fixed by
https://kernel.googlesource.com/pub/scm/utils/mmc/mmc-utils/+/0d493fb091b592bde6004a618c28f1c3619af1a4

this uplift only involves in two commits including the above fix:

```
b7e4d5a mmc-utils: Add General command CMD56 read support
0d493fb mmc-utils: Fix build error MMC_BLOCK_MAJOR undeclared
```

considering kirkstone mmc-utils recipe fetches mmc-utils master branch and does not stick to any release tag, so I think we can uplift mmc-utils to the latest rather than backport that fix to kirkstone.

//Ming Liu

<[email protected]> 於 2022年5月15日 週日 下午11:42寫道:

Quoted 19 lines · On Sun, 2022-05-15 at 14:43 +0200, [email protected] wrote:
Quoted 11 lines

From: Alexander Kanavin <[email protected]>

(cherry picked from commit d98b06c9c6f480de1e5167bfe8392e39300fc02c)
---
 meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Why does kirkstone need this though?

Cheers,

Richard

#4 lore raw

Re: [OE-core] [kirkstone] [PATCH 1/1] mmc-utils: upgrade to latest revision

Quoted 1 line · Ming Liu

Our products are based on LTS kirkstone, we found a build issue of mmc-utils, which has been fixed by https://kernel.googlesource.com/pub/scm/utils/mmc/mmc-utils/+/0d493fb091b592bde6004a618c28f1c3619af1a4

So this error only occurs if you are using a BSP with a 5.4 kernel? That would explain why I don't see this in my testing, since it uses only 5.10 and 5.15

BTW, for future kirkstone patches you should cc me instead of Richard since I am the kirkstone maintainer.

Quoted 8 lines

this uplift only involves in two commits including the above fix:

```
b7e4d5a mmc-utils: Add General command CMD56 read support
0d493fb mmc-utils: Fix build error MMC_BLOCK_MAJOR undeclared
```

considering kirkstone mmc-utils recipe fetches mmc-utils master branch and does not stick to any release tag, so I think we can uplift mmc-utils to the latest rather than backport that fix to kirkstone.

This seems reasonable to me. I will add this patch to my test queue and edit the commit message to include the above information.

Steve

Quoted 30 lines

<[email protected]> 於 2022年5月15日 週日 下午11:42寫道:

Quoted 14 lines · On Sun, 2022-05-15 at 14:43 +0200, [email protected] wrote:
Quoted 11 lines

From: Alexander Kanavin <[email protected]>

(cherry picked from commit d98b06c9c6f480de1e5167bfe8392e39300fc02c)
---
 meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines

Why does kirkstone need this though?

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#165665): https://lists.openembedded.org/g/openembedded-core/message/165665
Mute This Topic: https://lists.openembedded.org/mt/91117508/3620601
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#5 lore raw

Re: [OE-core] [kirkstone] [PATCH 1/1] mmc-utils: upgrade to latest revision

Yes, this only occurs on 5.4 kernel, will CC to you next time for kirkstone patches.

//Ming Liu

Steve Sakoman <[email protected]> 於 2022年5月16日 週一 下午4:29寫道:

Quoted 62 lines · Ming Liu
Quoted 2 lines

Our products are based on LTS kirkstone, we found a build issue of

mmc-utils, which has been fixed by
https://kernel.googlesource.com/pub/scm/utils/mmc/mmc-utils/+/0d493fb091b592bde6004a618c28f1c3619af1a4

So this error only occurs if you are using a BSP with a 5.4 kernel? That would explain why I don't see this in my testing, since it uses only 5.10 and 5.15

BTW, for future kirkstone patches you should cc me instead of Richard since I am the kirkstone maintainer.

Quoted 8 lines

this uplift only involves in two commits including the above fix:

```
b7e4d5a mmc-utils: Add General command CMD56 read support
0d493fb mmc-utils: Fix build error MMC_BLOCK_MAJOR undeclared
```

considering kirkstone mmc-utils recipe fetches mmc-utils master branch

and does not stick to any release tag, so I think we can uplift mmc-utils to the latest rather than backport that fix to kirkstone.

This seems reasonable to me. I will add this patch to my test queue and edit the commit message to include the above information.

Steve

Quoted 17 lines

<[email protected]> 於 2022年5月15日 週日 下午11:42寫道:

Quoted 16 lines · On Sun, 2022-05-15 at 14:43 +0200, [email protected] wrote:
Quoted 11 lines

From: Alexander Kanavin <[email protected]>

(cherry picked from commit d98b06c9c6f480de1e5167bfe8392e39300fc02c)
---
 meta/recipes-devtools/mmc/mmc-utils_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Why does kirkstone need this though?

Quoted 8 lines
Quoted 3 lines

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#165665):

https://lists.openembedded.org/g/openembedded-core/message/165665

Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/91117508/3620601
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [

[email protected]]

Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-