riscv: mm: init: make pt_ops_set_[early|late|fixmap] static
PATCH v2 1/1 riscv: mm: init: make pt_ops_set_[early|late|fixmap] static
These three functions are only used in init.c, so make them static. Fix W=1 warnings like below:
arch/riscv/mm/init.c:721:13: warning: no previous prototype for function 'pt_ops_set_early' [-Wmissing-prototypes]
void __init pt_ops_set_early(void)
^
---
since v1:
- collect Reviewed-by tag
- move out from the static key series as a separate patch
arch/riscv/mm/init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/riscv/mm/init.c +3 -3
@@ -849,7 +849,7 @@ static void __init create_fdt_early_page_table(pgd_t *pgdir, uintptr_t dtb_pa)* MMU is not enabled, the page tables are allocated directly using * early_pmd/pud/p4d and the address returned is the physical one. */ -void __init pt_ops_set_early (void ) +static void __init pt_ops_set_early (void ) { pt_ops.alloc_pte = alloc_pte_early; pt_ops.get_pte_virt = get_pte_virt_early;
@@ -871,7 +871,7 @@ void __init pt_ops_set_early(void)* Note that this is called with MMU disabled, hence kernel_mapping_pa_to_va, * but it will be used as described above. */ -void __init pt_ops_set_fixmap (void ) +static void __init pt_ops_set_fixmap (void ) { pt_ops.alloc_pte =kernel_mapping_pa_to_va ((uintptr_t )alloc_pte_fixmap); pt_ops.get_pte_virt =kernel_mapping_pa_to_va ((uintptr_t )get_pte_virt_fixmap);
@@ -889,7 +889,7 @@ void __init pt_ops_set_fixmap(void)* MMU is enabled and page table setup is complete, so from now, we can use * generic page allocation functions to setup page table. */ -void __init pt_ops_set_late (void ) +static void __init pt_ops_set_late (void ) { pt_ops.alloc_pte = alloc_pte_late; pt_ops.get_pte_virt = get_pte_virt_late;
Signature · 1 line
2.34.1
Quoted 55 lines · Jisheng Zhang
These three functions are only used in
init.c, so make them static. Fix W=1 warnings like below:
arch/riscv/mm/init.c:721:13: warning: no previous prototype for function 'pt_ops_set_early' [-Wmissing-prototypes]
void__initpt_ops_set_early(void)^Signed-off-by Jisheng Zhang <[email protected]>Reviewed-by Anup Patel <[email protected]>---
since v1:
- collect Reviewed-by tag
- move out from the static key series as a separate patcharch/riscv/mm/init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/riscv/mm/init.c +3
-4@@ -849,7 +849,7 @@ static void __init create_fdt_early_page_table(pgd_t *pgdir, uintptr_t dtb_pa)* MMU is not enabled, the page tables are allocated directly using * early_pmd/pud/p4d and the address returned is the physical one. */ -void __init pt_ops_set_early (void ) +static void __init pt_ops_set_early (void ) { pt_ops.alloc_pte = alloc_pte_early; pt_ops.get_pte_virt = get_pte_virt_early;@@ -871,7 +871,7 @@ void __init pt_ops_set_early(void)* Note that this is called with MMU disabled, hence kernel_mapping_pa_to_va, * but it will be used as described above. */ -void __init pt_ops_set_fixmap (void ) +static void __init pt_ops_set_fixmap (void ) { pt_ops.alloc_pte =kernel_mapping_pa_to_va ((uintptr_t )alloc_pte_fixmap); pt_ops.get_pte_virt =kernel_mapping_pa_to_va ((uintptr_t )get_pte_virt_fixmap);@@ -889,7 +889,7 @@ void __init pt_ops_set_fixmap(void)* MMU is enabled and page table setup is complete, so from now, we can use * generic page allocation functions to setup page table. */ -void __init pt_ops_set_late (void ) +static void __init pt_ops_set_late (void ) { pt_ops.alloc_pte = alloc_pte_late; pt_ops.get_pte_virt = get_pte_virt_late; --2.34.1
Quoted 4 lines
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Signature · 2 lines
Regards, Atish
Palmer Dabbelt
maintainerQuoted 42 lines · On Mon, 16 May 2022 07:32:04 PDT (-0700), [email protected] wrote:
These three functions are only used in
init.c, so make them static. Fix W=1 warnings like below:
arch/riscv/mm/init.c:721:13: warning: no previous prototype for function 'pt_ops_set_early' [-Wmissing-prototypes]
void__initpt_ops_set_early(void)^Signed-off-by Jisheng Zhang <[email protected]>Reviewed-by Anup Patel <[email protected]>---
since v1:
- collect Reviewed-by tag
- move out from the static key series as a separate patcharch/riscv/mm/init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/riscv/mm/init.c +2
-2@@ -849,7 +849,7 @@ static void __init create_fdt_early_page_table(pgd_t *pgdir, uintptr_t dtb_pa)* MMU is not enabled, the page tables are allocated directly using * early_pmd/pud/p4d and the address returned is the physical one. */ -void __init pt_ops_set_early (void ) +static void __init pt_ops_set_early (void ) { pt_ops.alloc_pte = alloc_pte_early; pt_ops.get_pte_virt = get_pte_virt_early;@@ -871,7 +871,7 @@ void __init pt_ops_set_early(void)* Note that this is called with MMU disabled, hence kernel_mapping_pa_to_va, * but it will be used as described above. */ -void __init pt_ops_set_fixmap (void ) +static void __init pt_ops_set_fixmap (void ) { pt_ops.alloc_pte =kernel_mapping_pa_to_va ((uintptr_t )alloc_pte_fixmap); pt_ops.get_pte_virt =kernel_mapping_pa_to_va ((uintptr_t )get_pte_virt_fixmap);
arch/riscv/mm/init.c void __init pt_ops_set_fixmap(void) · line 895
Quoted 8 lines
arch/riscv/mm/init.c +1
-1@@ -889,7 +889,7 @@ void __init pt_ops_set_fixmap(void)* MMU is enabled and page table setup is complete, so from now, we can use * generic page allocation functions to setup page table. */ -void __init pt_ops_set_late (void ) +static void __init pt_ops_set_late (void ) { pt_ops.alloc_pte = alloc_pte_late; pt_ops.get_pte_virt = get_pte_virt_late;
Thanks, this is on for-next.