scsi: qedf: remove redundant variable op
Subsystems (3)
PATCH 1/1 scsi: qedf: remove redundant variable op
The variable op is assigned a value and is never read. The variable is not used and is redundant, remove it.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/scsi/qedf/qedf_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/qedf/qedf_io.c +1 -2
@@ -804,7 +804,6 @@ static void qedf_trace_io(struct qedf_rport *fcport, struct qedf_ioreq *io_req,struct qedf_io_log *io_log;struct scsi_cmnd *sc_cmd = io_req->sc_cmd;unsigned long flags; -uint8_t op;spin_lock_irqsave (&qedf->io_trace_lock, flags);
@@ -813,7 +812,7 @@ static void qedf_trace_io(struct qedf_rport *fcport, struct qedf_ioreq *io_req, io_log->task_id = io_req->xid; io_log->port_id = fcport->rdata->ids.port_id; io_log->lun = sc_cmd->device->lun; - io_log->op = op = sc_cmd->cmnd[0 ]; + io_log->op = sc_cmd->cmnd[0 ]; io_log->lba[0 ] = sc_cmd->cmnd[2 ]; io_log->lba[1 ] = sc_cmd->cmnd[3 ]; io_log->lba[2 ] = sc_cmd->cmnd[4 ];
Signature · 1 line
2.35.1
Martin K. Petersen
AppliedColin,
Quoted 2 lines
The variable op is assigned a value and is never read. The variable is not used and is redundant, remove it.
Applied to 5.19/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 4 lines · Colin Ian King
The variable op is assigned a value and is never read. The variable is not used and is redundant, remove it.
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: qedf: remove redundant variable op
https://git.kernel.org/mkp/scsi/c/fc65df48c88e
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering