Skip to contentSkip to conversation

net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open

PATCH Applied Michael Trimarchi 3 participants 3 messages May 18, 2022 – May 19, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open

Make ndo_open less sensitive to memory pressure.

---
Change:
- Adjust the commit message addressing the comments in RFC version

---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/fec_main.c +1 -1
index 9f33ec838b52..09eb6ea9a584 100644
@@ -3076,7 +3076,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
 	rxq = fep->rx_queue[queue];
 	bdp = rxq->bd.base;
 	for (i = 0; i < rxq->bd.ring_size; i++) {
-		skb = netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE);
+		skb = __netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE, GFP_KERNEL);
 		if (!skb)
 			goto err_alloc;
 
Signature · 1 line
2.25.1
#2 lore raw
In reply to Michael Trimarchi
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Wed, 18 May 2022 08:20:07 +0200 you wrote:

Make ndo_open less sensitive to memory pressure.

---
Change:
- Adjust the commit message addressing the comments in RFC version

[...]

Here is the summary with links:
- net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open

    https://git.kernel.org/netdev/net-next/c/b885aab3d39d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html