Skip to contentSkip to conversation

scsi: qla1280: remove redundant variable toke

PATCH Applied Colin Ian King 2 participants 3 messages May 18, 2022 – May 24, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla1280: remove redundant variable toke

Variable toke is being assigned a value that is never read. The variable is redundant, remove it.

Cleans up clang scan build warning:
warning: Although the value stored to 'toke' is used in the enclosing expression, the value is never actually read from 'toke' [deadcode.DeadStores]

---
 drivers/scsi/qla1280.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/qla1280.c +1 -2
index 0ab595c0870a..1e7f4d138e06 100644
@@ -4037,7 +4037,6 @@ qla1280_setup(char *s)
 {
 	char *cp, *ptr;
 	unsigned long val;
-	int toke;
 
 	cp = s;
 
@@ -4052,7 +4051,7 @@ qla1280_setup(char *s)
 		} else
 			val = simple_strtoul(ptr, &ptr, 0);
 
-		switch ((toke = qla1280_get_token(cp))) {
+		switch (qla1280_get_token(cp)) {
 		case TOKEN_NVRAM:
 			if (!val)
 				driver_setup.no_nvram = 1;
Signature · 1 line
2.35.1
#1 lore raw

Colin,

Quoted 2 lines

Variable toke is being assigned a value that is never read. The variable is redundant, remove it.

Applied to 5.19/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Colin Ian King
Quoted 9 lines · Colin Ian King

Variable toke is being assigned a value that is never read. The variable is redundant, remove it.

Cleans up clang scan build warning:
warning: Although the value stored to 'toke' is used in the enclosing expression, the value is never actually read from 'toke' [deadcode.DeadStores]

[...]

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: qla1280: remove redundant variable toke

      https://git.kernel.org/mkp/scsi/c/c10ba0c961d3
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering