DG2 VRAM_SR Support
Subsystems (3)
cover DG2 VRAM_SR Support
This series add DG2 D3Cold VRAM_SR support.
TODO: GuC Interface state save/restore on VRAM_SR entry/exit.
Anshuman Gupta (7):
drm/i915/dgfx: OpRegion VRAM Self Refresh Support drm/i915/dg1: OpRegion PCON DG1 MBD config support drm/i915/dg2: DG2 MBD config drm/i915/dgfx: Add has_lmem_sr drm/i915/pcode: DGFX PCODE MBOX headers drm/i915/dgfx: Setup VRAM SR with D3COLD drm/i915/rpm: Enable D3Cold VRAM SR Support
drivers/gpu/drm/i915/display/intel_opregion.c | 85 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_opregion.h | 17 ++++ drivers/gpu/drm/i915/i915_driver.c | 28 ++++++ drivers/gpu/drm/i915/i915_drv.h | 17 ++++ drivers/gpu/drm/i915/i915_pci.c | 2 + drivers/gpu/drm/i915/i915_reg.h | 7 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + drivers/gpu/drm/i915/intel_pcode.c | 25 ++++++ drivers/gpu/drm/i915/intel_pcode.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 43 ++++++++++ drivers/gpu/drm/i915/intel_pm.h | 2 + drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +- 12 files changed, 228 insertions(+), 3 deletions(-)
Signature · 1 line
2.26.2
PATCH 1/7 drm/i915/dgfx: OpRegion VRAM Self Refresh Support
Intel DGFX cards provides a feature Video Ram Self Refrsh(VRSR). DGFX VRSR can be enabled with runtime suspend D3Cold flow and with opportunistic S0ix system wide suspend flow as well.
Without VRSR enablement i915 has to evict the lmem objects to system memory. Depending on some heuristics driver will evict lmem objects without VRSR.
VRSR feature requires Host BIOS support, VRSR will be enable/disable by HOST BIOS using ACPI OpRegion.
Adding OpRegion VRSR support in order to enable/disable VRSR on discrete cards.
BSpec: 53440
--- drivers/gpu/drm/i915/display/intel_opregion.c | 47 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_opregion.h | 11 +++++ 2 files changed, 57 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_opregion.c +46 -1
@@ -53,6 +53,9 @@#define MBOX_ASLE_EXT BIT(4)/* Mailbox #5 */ #define MBOX_BACKLIGHT BIT(5)/* Mailbox #2 (valid from v3.x) */ +#define PCON_DGFX_BIOS_SUPPORTS_VRSR BIT(11) +#define PCON_DGFX_BIOS_SUPPORTS_VRSR_FIELD_VALID BIT(12) +struct opregion_header {u8 signature[16 ];u32 size;
@@ -128,7 +131,8 @@ struct opregion_asle {u64 rvda;/* Physical (2.0) or relative from opregion (2.1+) * address of raw VBT data. */ u32 rvds;/* Size of raw vbt data */ -u8 rsvd[58 ]; +u8 vrsr;/* DGFX Video Ram Self Refresh */ +u8 rsvd[57 ]; } __packed;/* OpRegion mailbox #5: ASLE ext */
@@ -199,6 +203,9 @@ struct opregion_asle_ext {#define ASLE_PHED_EDID_VALID_MASK 0x3 +/* VRAM SR */ +#define ASLE_VRSR_ENABLE BIT(0) +/* Software System Control Interrupt (SWSCI) */ #define SWSCI_SCIC_INDICATOR (1 << 0)#define SWSCI_SCIC_MAIN_FUNCTION_SHIFT 1
@@ -919,6 +926,8 @@ int intel_opregion_setup(struct drm_i915_private *dev_priv) opregion->header->over.minor, opregion->header->over.revision); +drm_dbg (&dev_priv->drm,"OpRegion PCON values 0x%x\n" , opregion->header->pcon); + mboxes = opregion->header->mboxes;if (mboxes &MBOX_ACPI ) {drm_dbg (&dev_priv->drm,"Public ACPI methods supported\n" );
@@ -1232,3 +1241,39 @@ void intel_opregion_unregister(struct drm_i915_private *i915) opregion->vbt =NULL ; opregion->lid_state =NULL ; } + +/* +* intel_opregion_bios_supports_vram_sr() get HOST BIOS VRAM Self +* Refresh capability support. +* @i915: pointer to i915 device. +*/ +bool intel_opregion_bios_supports_vram_sr (struct drm_i915_private *i915) +{ +struct intel_opregion *opregion = &i915->opregion; + +if (!IS_DGFX (i915)) +return false; + +if (opregion->header->pcon &PCON_DGFX_BIOS_SUPPORTS_VRSR_FIELD_VALID ) +return opregion->header->pcon &PCON_DGFX_BIOS_SUPPORTS_VRSR ; +else +return false; +} + +/* +* intel_opregion_vram_sr() enable/disable VRAM Self Refresh. +* @i915: pointer to i915 device. +* @enable: Argument to enable/disable VRSR. +*/ +void intel_opregion_vram_sr (struct drm_i915_private *i915,bool enable) +{ +struct intel_opregion *opregion = &i915->opregion; + +if (drm_WARN (&i915->drm, !opregion->asle,"ASLE MAILBOX3 is not available\n" )) +return ; + +if (enable) + opregion->asle->vrsr |=ASLE_VRSR_ENABLE ; +else + opregion->asle->vrsr &= ~ASLE_VRSR_ENABLE ; +}
drivers/gpu/drm/i915/display/intel_opregion.h +11 -0
@@ -75,6 +75,8 @@ int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv, pci_power_t state);int intel_opregion_get_panel_type (struct drm_i915_private *dev_priv);struct edid *intel_opregion_get_edid (struct intel_connector *connector); +bool intel_opregion_bios_supports_vram_sr (struct drm_i915_private *i915); +void intel_opregion_vram_sr (struct drm_i915_private *i915,bool enable);#else /* CONFIG_ACPI*/
@@ -127,6 +129,15 @@ intel_opregion_get_edid(struct intel_connector *connector)return NULL ; } +static bool intel_opregion_bios_supports_vram_sr (struct drm_i915_private *i915) +{ +return false; +} + +static void intel_opregion_vram_sr (struct drm_i915_private *i915,bool enable) +{ +} +#endif /* CONFIG_ACPI */ #endif
Signature · 1 line
2.26.2
PATCH 2/7 drm/i915/dg1: OpRegion PCON DG1 MBD config support
In reply to Anshuman GuptaDGFX cards support both Add in Card(AIC) and Mother Board Down(MBD) configs. MBD config requires HOST BIOS GPIO toggling support in order to enable/disable VRAM SR using ACPI OpRegion.
i915 requires to check OpRegion PCON MBD Config bits to discover whether Gfx Card is MBD config before enabling VRSR.
BSpec: 53440
--- drivers/gpu/drm/i915/display/intel_opregion.c | 36 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_opregion.h | 6 ++++ 2 files changed, 42 insertions(+)
drivers/gpu/drm/i915/display/intel_opregion.c +36 -0
@@ -53,6 +53,8 @@#define MBOX_ASLE_EXT BIT(4)/* Mailbox #5 */ #define MBOX_BACKLIGHT BIT(5)/* Mailbox #2 (valid from v3.x) */ +#define PCON_DG1_MBD_CONFIG BIT(9) +#define PCON_DG1_MBD_CONFIG_FIELD_VALID BIT(10)#define PCON_DGFX_BIOS_SUPPORTS_VRSR BIT(11)#define PCON_DGFX_BIOS_SUPPORTS_VRSR_FIELD_VALID BIT(12)
@@ -1242,6 +1244,37 @@ void intel_opregion_unregister(struct drm_i915_private *i915) opregion->lid_state =NULL ; } +static bool intel_opregion_dg1_mbd_config (struct drm_i915_private *i915) +{ +struct intel_opregion *opregion = &i915->opregion; + +if (!IS_DG1 (i915)) +return false; + +if (opregion->header->pcon &PCON_DG1_MBD_CONFIG_FIELD_VALID ) +return opregion->header->pcon &PCON_DG1_MBD_CONFIG ; +else +return false; +} + +/** +* intel_opregion_vram_sr_required(). +* @i915 i915 device priv data. +* It returns a boolean whether opregion vram_sr support +* is required. +*/ +bool +intel_opregion_vram_sr_required (struct drm_i915_private *i915) +{ +if (!IS_DGFX (i915)) +return false; + +if (IS_DG1 (i915)) +return intel_opregion_dg1_mbd_config (i915); + +return false; +} +/* * intel_opregion_bios_supports_vram_sr() get HOST BIOS VRAM Self * Refresh capability support.
@@ -1269,6 +1302,9 @@ void intel_opregion_vram_sr(struct drm_i915_private *i915, bool enable) {struct intel_opregion *opregion = &i915->opregion; +if (!intel_opregion_vram_sr_required (i915)) +return ; +if (drm_WARN (&i915->drm, !opregion->asle,"ASLE MAILBOX3 is not available\n" ))return ;
drivers/gpu/drm/i915/display/intel_opregion.h +6 -0
@@ -77,6 +77,7 @@ int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv);struct edid *intel_opregion_get_edid (struct intel_connector *connector);bool intel_opregion_bios_supports_vram_sr (struct drm_i915_private *i915);void intel_opregion_vram_sr (struct drm_i915_private *i915,bool enable); +bool intel_opregion_vram_sr_required (struct drm_i915_private *i915);#else /* CONFIG_ACPI*/
@@ -138,6 +139,11 @@ static void intel_opregion_vram_sr(struct drm_i915_private *i915, bool enable) { } +static bool intel_opregion_vram_sr_required (struct drm_i915_private *i915) +{ +return false; +} +#endif /* CONFIG_ACPI */ #endif
Signature · 1 line
2.26.2
PATCH 3/7 drm/i915/dg2: DG2 MBD config
In reply to Anshuman GuptaAdd DG2 Motherboard Down Config check support.
BSpec: 44477
--- drivers/gpu/drm/i915/display/intel_opregion.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 9 +++++++++ 2 files changed, 11 insertions(+)
drivers/gpu/drm/i915/display/intel_opregion.c +2 -0
@@ -1271,6 +1271,8 @@ intel_opregion_vram_sr_required(struct drm_i915_private *i915)if (IS_DG1 (i915))return intel_opregion_dg1_mbd_config (i915); +else if (IS_DG2_MBD (i915)) +return true;return false; }
drivers/gpu/drm/i915/i915_drv.h +9 -0
@@ -1071,6 +1071,15 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)#define IS_DG2_G12 (dev_priv) \ IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G12) +/* +* FIXME: Need to define a new SUBPLATFORM INTEL_SUBPLATFORM_DG2_MBD +* for PCI id range 5690..5695, but G10, G11 SUBPLATFROM conflicts +* with those pci id range. +*/ +#define DG2_MBD_CONFIG_MASK GENMASK(7, 4) +#define DG2_MBD_CONFIG_VAL FIELD_PREP(DG2_MBD_CONFIG_MASK, 9) +#define IS_DG2_MBD (dev_priv) (IS_DG2(dev_priv) && \ + (INTEL_DEVID(dev_priv) & DG2_MBD_CONFIG_MASK) == DG2_MBD_CONFIG_VAL)#define IS_ADLS_RPLS (dev_priv) \ IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL)#define IS_ADLP_N (dev_priv) \
Signature · 1 line
2.26.2
Re: [Intel-gfx] [PATCH 3/7] drm/i915/dg2: DG2 MBD config
Quoted 30 lines · Anshuman Gupta
Add DG2 Motherboard Down Config check support.
BSpec: 44477
Cc Rodrigo Vivi <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- drivers/gpu/drm/i915/display/intel_opregion.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 9 +++++++++ 2 files changed, 11 insertions(+)drivers/gpu/drm/i915/display/intel_opregion.c +2
-0@@ -1271,6 +1271,8 @@ intel_opregion_vram_sr_required(struct drm_i915_private *i915)if (IS_DG1 (i915))return intel_opregion_dg1_mbd_config (i915); +else if (IS_DG2_MBD (i915)) +return true;return false; }drivers/gpu/drm/i915/i915_drv.h +0
-0@@ -1071,6 +1071,15 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, IS_SUBPLATFORM(dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G11)#define IS_DG2_G12 (dev_priv) \
drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private *i915, · line 1082
Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.h +9
-0IS_SUBPLATFORM (dev_priv,INTEL_DG2 ,INTEL_SUBPLATFORM_G12 ) +/* +* FIXME: Need to define a new SUBPLATFORM INTEL_SUBPLATFORM_DG2_MBD +* for PCI id range 5690..5695, but G10, G11 SUBPLATFROM conflicts +* with those pci id range. + */ +#define DG2_MBD_CONFIG_MASK GENMASK(7, 4) +#define DG2_MBD_CONFIG_VAL FIELD_PREP(DG2_MBD_CONFIG_MASK, 9) +#define IS_DG2_MBD (dev_priv) (IS_DG2(dev_priv) && \ + (INTEL_DEVID(dev_priv) & DG2_MBD_CONFIG_MASK) == DG2_MBD_CONFIG_VAL)
No. Please don't do *any* magic masking or comparison of PCI ID bits or bitfields.
BR,
Jani.
Quoted 3 lines
drivers/gpu/drm/i915/i915_drv.h +0
-0#define IS_ADLS_RPLS (dev_priv) \ IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S, INTEL_SUBPLATFORM_RPL)#define IS_ADLP_N (dev_priv) \
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Re: [Intel-gfx] [PATCH 3/7] drm/i915/dg2: DG2 MBD config
Quoted 58 lines
-----Original Message-----
From: Nikula, Jani <[email protected]>
Sent: Thursday, May 19, 2022 2:57 PM
To: Gupta, Anshuman <[email protected]>; intel- [email protected]
Cc: Nilawar, Badal <[email protected]>; Ewins, Jon <[email protected]>; Vivi, Rodrigo <[email protected]>; Deak, Imre <[email protected]>; Gupta, Anshuman <[email protected]>
Subject: Re: [PATCH 3/7] drm/i915/dg2: DG2 MBD configdrivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private
Quoted 31 lines · Anshuman Gupta
Add DG2 Motherboard Down Config check support.
BSpec: 44477
Cc Rodrigo Vivi <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- drivers/gpu/drm/i915/display/intel_opregion.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 9 +++++++++ 2 files changed, 11 insertions(+)drivers/gpu/drm/i915/display/intel_opregion.c +2
-0@@ -1271,6 +1271,8 @@ intel_opregion_vram_sr_required(struct drm_i915_private *i915)if (IS_DG1 (i915))return intel_opregion_dg1_mbd_config (i915); +else if (IS_DG2_MBD (i915)) +return true;return false;}
(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_drv.hindex10f273800645..c5ecc490dced100644drivers/gpu/drm/i915/i915_drv.h +0
-0@@ -1071,6 +1071,15 @@ IS_SUBPLATFORM(const struct drm_i915_private*i915,
drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private *i915, · line 1071
Quoted 1 line
drivers/gpu/drm/i915/i915_drv.h +0
-0IS_SUBPLATFORM (dev_priv,INTEL_DG2 ,INTEL_SUBPLATFORM_G11 )#define
drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private *i915,
Quoted 4 lines
drivers/gpu/drm/i915/i915_drv.h +2
-0IS_DG2_G12 (dev_priv) \IS_SUBPLATFORM (dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G12) +/* +* FIXME: Need to define a new SUBPLATFORM
INTEL_SUBPLATFORM_DG2_MBDdrivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private *i915,
Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.h +5
-0+* for PCI id range 5690..5695, but G10, G11 SUBPLATFROM conflicts +* with those pci id range. +*/ +#define DG2_MBD_CONFIG_MASK GENMASK(7, 4) +#define DG2_MBD_CONFIG_VAL FIELD_PREP(DG2_MBD_CONFIG_MASK, 9)
Quoted 7 lines
drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private · line 1082
Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +2
-0+#define IS_DG2_MBD (dev_priv) (IS_DG2(dev_priv) && \ + (INTEL_DEVID(dev_priv) &
DG2_MBD_CONFIG_MASK) ==drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private · line 1083
Quoted 1 line
drivers/gpu/drm/i915/i915_drv.h +1
-0+DG2_MBD_CONFIG_VAL)No. Please don't do *any* magic masking or comparison of PCI ID bits or bitfields.
Hi Matt,
We need to distinguish between DG2 NB MBD and rest such that i915 can figure out opregion vram_sr is requires for the DG2 platform. Could you please suggestion on that. Thanks,
Anshuman Gupta.
Quoted 11 lines
BR,
Jani.drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private · line 1085
Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +0
-0#define IS_ADLS_RPLS (dev_priv) \ IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S,
INTEL_SUBPLATFORM_RPL)Quoted 1 line
#define
IS_ADLP_N(dev_priv)\--
Jani Nikula, Intel Open Source Graphics Center
Re: [Intel-gfx] [PATCH 3/7] drm/i915/dg2: DG2 MBD config
Quoted 61 lines · Anshuman
Quoted 61 lines
-----Original Message-----
From: Nikula, Jani <[email protected]>
Sent: Thursday, May 19, 2022 2:57 PM
To: Gupta, Anshuman <[email protected]>; intel- [email protected]
Cc: Nilawar, Badal <[email protected]>; Ewins, Jon <[email protected]>; Vivi, Rodrigo <[email protected]>; Deak, Imre <[email protected]>; Gupta, Anshuman <[email protected]>
Subject: Re: [PATCH 3/7] drm/i915/dg2: DG2 MBD configdrivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private
Quoted 31 lines · Anshuman Gupta
Add DG2 Motherboard Down Config check support.
BSpec: 44477
Cc Rodrigo Vivi <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- drivers/gpu/drm/i915/display/intel_opregion.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 9 +++++++++ 2 files changed, 11 insertions(+)drivers/gpu/drm/i915/display/intel_opregion.c +2
-0@@ -1271,6 +1271,8 @@ intel_opregion_vram_sr_required(struct drm_i915_private *i915)if (IS_DG1 (i915))return intel_opregion_dg1_mbd_config (i915); +else if (IS_DG2_MBD (i915)) +return true;return false;}
(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_drv.hindex10f273800645..c5ecc490dced100644drivers/gpu/drm/i915/i915_drv.h +0
-0@@ -1071,6 +1071,15 @@ IS_SUBPLATFORM(const struct drm_i915_private*i915,
drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private *i915, · line 1071
Quoted 1 line
drivers/gpu/drm/i915/i915_drv.h +0
-0IS_SUBPLATFORM (dev_priv,INTEL_DG2 ,INTEL_SUBPLATFORM_G11 )#define
drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private *i915,
Quoted 4 lines
drivers/gpu/drm/i915/i915_drv.h +2
-0IS_DG2_G12 (dev_priv) \IS_SUBPLATFORM (dev_priv, INTEL_DG2, INTEL_SUBPLATFORM_G12) +/* +* FIXME: Need to define a new SUBPLATFORM
INTEL_SUBPLATFORM_DG2_MBDdrivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private *i915,
Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.h +5
-0+* for PCI id range 5690..5695, but G10, G11 SUBPLATFROM conflicts +* with those pci id range. +*/ +#define DG2_MBD_CONFIG_MASK GENMASK(7, 4) +#define DG2_MBD_CONFIG_VAL FIELD_PREP(DG2_MBD_CONFIG_MASK, 9)drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private · line 1082
Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +2
-0+#define IS_DG2_MBD (dev_priv) (IS_DG2(dev_priv) && \ + (INTEL_DEVID(dev_priv) &
DG2_MBD_CONFIG_MASK) ==
Quoted 8 lines
Quoted 4 lines
drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private · line 1083
Quoted 1 line
drivers/gpu/drm/i915/i915_drv.h +1
-0+DG2_MBD_CONFIG_VAL)No. Please don't do *any* magic masking or comparison of PCI ID bits or bitfields.
Hi Matt,
We need to distinguish between DG2 NB MBD and rest such that i915 can figure out opregionvram_sris requires for the DG2 platform. Could you please suggestion on that.
If you truly need to distinguish a specific sub-type of DG2, then creating a proper subplatform (with its own list of PCI IDs, matched in intel_device_info_subplatform_init() is the way to go. As far as I recall, it should be okay to have multiple subplatform bits set for a platform, so for example you can have both the G11 and a MBD subplatform bits set on a device and they can each be tested independently without interfering with each other.
I'm not too familiar with the feature you're working on here. Is there a way we can detect whether it's supported by querying the pcode? Or what happens if you send your pcode request on a platform that doesn't support it? Do you just get a regular error back so that the driver would know to give up and move on, or would it actually cause some kind of behavioral problem?
Matt
Quoted 13 lines
Thanks,
Anshuman Gupta.Quoted 11 lines
BR,
Jani.drivers/gpu/drm/i915/i915_drv.h IS_SUBPLATFORM(const struct drm_i915_private · line 1085
Quoted 2 lines
drivers/gpu/drm/i915/i915_drv.h +0
-0#define IS_ADLS_RPLS (dev_priv) \ IS_SUBPLATFORM(dev_priv, INTEL_ALDERLAKE_S,
INTEL_SUBPLATFORM_RPL)Quoted 1 line
#define
IS_ADLP_N(dev_priv)\--
Jani Nikula, Intel Open Source Graphics Center
Signature · 4 lines
Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation
PATCH 4/7 drm/i915/dgfx: Add has_lmem_sr
In reply to Anshuman GuptaAdd has_lmem_sr platform specific flag to know,
whether platform has VRAM self refresh support.
As of now both DG1 and DG2 client platforms supports VRAM self refresh with D3Cold but let it enable first on DG2 as primary lead platform for D3Cold support. Let it get enable on DG1 once this feature is stable.
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_pci.c | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 3 files changed, 4 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -1360,6 +1360,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_REGION (i915, i) (INTEL_INFO(i915)->memory_regions & (i))#define HAS_LMEM (i915) HAS_REGION(i915, REGION_LMEM) +#define HAS_LMEM_SR (i915) (INTEL_INFO(i915)->has_lmem_sr)/* * Platform has the dedicated compression control state for each lmem surfaces
drivers/gpu/drm/i915/i915_pci.c +2 -0
@@ -889,6 +889,7 @@ static const struct intel_device_info dg1_info = { DGFX_FEATURES, .graphics.rel =10 ,PLATFORM (INTEL_DG1 ), + .has_lmem_sr = 0, .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), .require_force_probe = 1, .platform_engine_mask =
@@ -1036,6 +1037,7 @@ static const struct intel_device_info xehpsdv_info = {static const struct intel_device_info dg2_info = {DG2_FEATURES ,XE_LPD_FEATURES , + .has_lmem_sr =1 , .display.cpu_transcoder_mask =BIT (TRANSCODER_A ) |BIT (TRANSCODER_B ) |BIT (TRANSCODER_C ) |BIT (TRANSCODER_D ), .require_force_probe =1 ,
drivers/gpu/drm/i915/intel_device_info.h +1 -0
@@ -151,6 +151,7 @@ enum intel_ppgtt_type {func (has_l3_ccs_read); \func (has_l3_dpf); \func (has_llc); \ +func (has_lmem_sr); \func (has_logical_ring_contexts); \func (has_mslices); \func (has_pooled_eu); \
Signature · 1 line
2.26.2
PATCH 5/7 drm/i915/pcode: DGFX PCODE MBOX headers
In reply to Anshuman GuptaDGFX uses similar PCODE MBOX interface as IGFX but uses distinct COMMAND and PARAM set of bit fields. Adding those headers Accordingly.
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -6735,6 +6735,9 @@#define GEN6_PCODE_MAILBOX _MMIO(0x138124)#define GEN6_PCODE_READY (1 << 31) +#define GEN6_PCODE_MB_PARAM2 REG_GENMASK(23, 16) +#define GEN6_PCODE_MB_PARAM1 REG_GENMASK(15, 8) +#define GEN6_PCODE_MB_COMMAND REG_GENMASK(7, 0)#define GEN6_PCODE_ERROR_MASK 0xFF#define GEN6_PCODE_SUCCESS 0x0#define GEN6_PCODE_ILLEGAL_CMD 0x1
Signature · 1 line
2.26.2
PATCH 6/7 drm/i915/dgfx: Setup VRAM SR with D3COLD
In reply to Anshuman GuptaSetup VRAM Self Refresh with D3COLD state.
VRAM Self Refresh will retain the context of VRAM, driver need to save any corresponding hardware state that needs to be restore on D3COLD exit, example PCI state.
--- drivers/gpu/drm/i915/i915_driver.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 7 +++++ drivers/gpu/drm/i915/i915_reg.h | 4 +++ drivers/gpu/drm/i915/intel_pcode.c | 25 +++++++++++++++++ drivers/gpu/drm/i915/intel_pcode.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 43 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_pm.h | 2 ++ 7 files changed, 84 insertions(+)
drivers/gpu/drm/i915/i915_driver.c +2 -0
@@ -633,6 +633,8 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)if (ret) goto err_msi; +intel_pm_vram_sr_setup (dev_priv); +/* * Fill the dram structure to get the system dram info. This will be * used for memory latency calculation.
drivers/gpu/drm/i915/i915_drv.h +7 -0
@@ -688,6 +688,13 @@ struct drm_i915_private {u32 bxt_phy_grc;u32 suspend_count; + +struct { +/* lock to protect vram_sr flags */ +struct mutex lock; +bool supported; + } vram_sr; +struct i915_suspend_saved_registers regfile;struct vlv_s0ix_state *vlv_s0ix_state;
drivers/gpu/drm/i915/i915_reg.h +4 -0
@@ -6803,11 +6803,15 @@#define DG1_PCODE_STATUS 0x7E#define DG1_UNCORE_GET_INIT_STATUS 0x0#define DG1_UNCORE_INIT_STATUS_COMPLETE 0x1 +#define DG1_PCODE_D3_VRAM_SR 0x71 +#define DG1_ENABLE_SR 0x1#define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23#define GEN6_PCODE_DATA _MMIO(0x138128)#define GEN6_PCODE_FREQ_IA_RATIO_SHIFT 8#define GEN6_PCODE_FREQ_RING_RATIO_SHIFT 16#define GEN6_PCODE_DATA1 _MMIO(0x13812C) +#define VRAM_CAPABILITY _MMIO(0x138144) +#define VRAM_SUPPORTED REG_BIT(0)/* IVYBRIDGE DPF */ #define GEN7_L3CDERRST1 (slice) _MMIO(0xB008 + (slice) * 0x200)/* L3CD Error Status 1 */
drivers/gpu/drm/i915/intel_pcode.c +25 -0
@@ -225,3 +225,28 @@ int intel_pcode_init(struct drm_i915_private *i915)return ret; } + +/** +* intel_pcode_enable_vram_sr - Enable pcode vram_sr. +* @dev_priv: i915 device +* +* This function triggers the required pcode flow to enable vram_sr. +* This function stictly need to call from rpm handlers, as i915 is +* transitioning to rpm idle/suspend, it doesn't require to grab +* rpm wakeref. +*/ +int intel_pcode_enable_vram_sr (struct drm_i915_private *i915) +{ +int ret =0 ; + +if (!HAS_LMEM_SR (i915)) +return ret; + + ret =snb_pcode_write (i915, +REG_FIELD_PREP (GEN6_PCODE_MB_COMMAND , +DG1_PCODE_D3_VRAM_SR ) | +REG_FIELD_PREP (GEN6_PCODE_MB_PARAM1 , +DG1_ENABLE_SR ),0 );/* no data needed for this cmd */ + +return ret; +}
drivers/gpu/drm/i915/intel_pcode.h +1 -0
@@ -20,5 +20,6 @@ int skl_pcode_request(struct drm_i915_private *i915, u32 mbox, u32 request, u32 reply_mask, u32 reply, int timeout_base_ms);int intel_pcode_init (struct drm_i915_private *i915); +int intel_pcode_enable_vram_sr (struct drm_i915_private *i915);#endif /* _INTEL_PCODE_H */
drivers/gpu/drm/i915/intel_pm.c +43 -0
49 lines not on this page · raw message
drivers/gpu/drm/i915/intel_pm.h +2 -0
@@ -31,6 +31,8 @@ int ilk_wm_max_level(const struct drm_i915_private *dev_priv);void intel_init_pm (struct drm_i915_private *dev_priv);void intel_init_clock_gating_hooks (struct drm_i915_private *dev_priv);void intel_pm_setup (struct drm_i915_private *dev_priv); +void intel_pm_vram_sr_setup (struct drm_i915_private *i915); +int intel_pm_vram_sr (struct drm_i915_private *i915,bool enable);void g4x_wm_get_hw_state (struct drm_i915_private *dev_priv);void vlv_wm_get_hw_state (struct drm_i915_private *dev_priv);void ilk_wm_get_hw_state (struct drm_i915_private *dev_priv);
Signature · 1 line
2.26.2
PATCH 7/7 drm/i915/rpm: Enable D3Cold VRAM SR Support
In reply to Anshuman GuptaIntel Client DGFX card supports D3Cold with two option. D3Cold-off zero watt, D3Cold-VRAM Self Refresh.
i915 requires to evict the lmem objects to smem in order to support D3Cold-Off, which increases i915 the suspend/resume latency. Enabling VRAM Self Refresh feature optimize the latency with additional power cost which required to retain the lmem.
Adding intel_runtime_idle (runtime_idle callback) to enable VRAM_SR, it will be used for policy to choose between D3Cold-off vs D3Cold-VRAM_SR.
Since we have introduced i915 runtime_idle callback.
It need to be warranted that Runtime PM Core invokes runtime_idle callback when runtime usages count becomes zero. That requires to use pm_runtime_put instead of pm_runtime_put_autosuspend.
--- drivers/gpu/drm/i915/i915_driver.c | 26 +++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +-- 2 files changed, 27 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_driver.c +26 -0
@@ -1541,6 +1541,31 @@ static int i915_pm_restore(struct device *kdev)return i915_pm_resume (kdev); } +static int intel_runtime_idle (struct device *kdev) +{ +struct drm_i915_private *dev_priv =kdev_to_i915 (kdev); +int ret =1 ; + +if (!HAS_LMEM_SR (dev_priv)) { +/*TODO: Prepare for D3Cold-Off */ + goto out; + } + +disable_rpm_wakeref_asserts (&dev_priv->runtime_pm); + + ret =intel_pm_vram_sr (dev_priv, true); +if (!ret) +drm_dbg (&dev_priv->drm,"VRAM Self Refresh enabled\n" ); + +enable_rpm_wakeref_asserts (&dev_priv->runtime_pm); + +out: +pm_runtime_mark_last_busy (kdev); +pm_runtime_autosuspend (kdev); + +return ret; +} +static int intel_runtime_suspend (struct device *kdev) {struct drm_i915_private *dev_priv =kdev_to_i915 (kdev);
@@ -1726,6 +1751,7 @@ const struct dev_pm_ops i915_pm_ops = { .restore = i915_pm_restore,/* S0ix (via runtime suspend) event handlers */ + .runtime_idle = intel_runtime_idle, .runtime_suspend = intel_runtime_suspend, .runtime_resume = intel_runtime_resume, };
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -2
@@ -492,8 +492,7 @@ static void __intel_runtime_pm_put(struct intel_runtime_pm *rpm,intel_runtime_pm_release (rpm, wakelock); -pm_runtime_mark_last_busy (kdev); -pm_runtime_put_autosuspend (kdev); +pm_runtime_put (kdev); }/**
Signature · 1 line
2.26.2
Re: [Intel-gfx] [PATCH 7/7] drm/i915/rpm: Enable D3Cold VRAM SR Support
Quoted 37 lines · Anshuman Gupta
Intel Client DGFX card supports D3Cold with two option. D3Cold-off zero watt, D3Cold-VRAM Self Refresh.
i915 requires to evict the lmem objects to smem in order to support D3Cold-Off, which increases i915 the suspend/resume latency. Enabling VRAM Self Refresh feature optimize the latency with additional power cost which required to retain the lmem.
Adding
intel_runtime_idle(runtime_idlecallback) to enableVRAM_SR, it will be used for policy to choose between D3Cold-off vs D3Cold-VRAM_SR.Since we have introduced i915
runtime_idlecallback.
It need to be warranted that Runtime PM Core invokesruntime_idlecallback when runtime usages count becomes zero. That requires to usepm_runtime_putinstead ofpm_runtime_put_autosuspend.Cc Rodrigo Vivi <[email protected]>Cc Chris Wilson <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- drivers/gpu/drm/i915/i915_driver.c | 26 +++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +-- 2 files changed, 27 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_driver.c +3
-0@@ -1541,6 +1541,31 @@ static int i915_pm_restore(struct device *kdev)return i915_pm_resume (kdev); } +static int intel_runtime_idle (struct device *kdev) +{ +struct drm_i915_private *dev_priv =kdev_to_i915 (kdev);
drivers/gpu/drm/i915/i915_driver.c static int i915_pm_restore(struct device *kdev) · line 1556
Quoted 10 lines
drivers/gpu/drm/i915/i915_driver.c +10
-0+int ret =1 ; + +if (!HAS_LMEM_SR (dev_priv)) { +/*TODO: Prepare for D3Cold-Off */ + goto out; + } + +disable_rpm_wakeref_asserts (&dev_priv->runtime_pm); + + ret =intel_pm_vram_sr (dev_priv, true)
I don't get why this idle callback is here. Why aren't you just calling that directly from the suspend handler?
Quoted 39 lines
drivers/gpu/drm/i915/i915_driver.c +13
-0+if (!ret) +drm_dbg (&dev_priv->drm,"VRAM Self Refresh enabled\n" ); + +enable_rpm_wakeref_asserts (&dev_priv->runtime_pm); + +out: +pm_runtime_mark_last_busy (kdev); +pm_runtime_autosuspend (kdev); + +return ret; +} +static int intel_runtime_suspend (struct device *kdev) {struct drm_i915_private *dev_priv =kdev_to_i915 (kdev);@@ -1726,6 +1751,7 @@ const struct dev_pm_ops i915_pm_ops = { .restore = i915_pm_restore,/* S0ix (via runtime suspend) event handlers */ + .runtime_idle = intel_runtime_idle, .runtime_suspend = intel_runtime_suspend, .runtime_resume = intel_runtime_resume, };drivers/gpu/drm/i915/intel_runtime_pm.c +1
-2@@ -492,8 +492,7 @@ static void __intel_runtime_pm_put(struct intel_runtime_pm *rpm,intel_runtime_pm_release (rpm, wakelock); -pm_runtime_mark_last_busy (kdev); -pm_runtime_put_autosuspend (kdev); +pm_runtime_put (kdev); }/** Signature · 1 line
2.26.2
Signature · 2 lines
Ville Syrjälä Intel
Re: [Intel-gfx] [PATCH 7/7] drm/i915/rpm: Enable D3Cold VRAM SR Support
Quoted 47 lines
-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, May 18, 2022 7:46 PM
To: Gupta, Anshuman <[email protected]>
Cc: [email protected]; Nikula, Jani <[email protected]>; Wilson, Chris P <[email protected]>; Vivi, Rodrigo <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915/rpm: Enable D3Cold VRAM SR SupportQuoted 34 lines · Anshuman Gupta
Intel Client DGFX card supports D3Cold with two option. D3Cold-off zero watt, D3Cold-VRAM Self Refresh.
i915 requires to evict the lmem objects to smem in order to support D3Cold-Off, which increases i915 the suspend/resume latency. Enabling VRAM Self Refresh feature optimize the latency with additional power cost which required to retain the lmem.
Adding
intel_runtime_idle(runtime_idlecallback) to enableVRAM_SR, it will be used for policy to choose between D3Cold-off vs D3Cold-VRAM_SR.Since we have introduced i915
runtime_idlecallback.
It need to be warranted that Runtime PM Core invokesruntime_idlecallback when runtime usages count becomes zero. That requires to usepm_runtime_putinstead ofpm_runtime_put_autosuspend.Cc Rodrigo Vivi <[email protected]>Cc Chris Wilson <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- drivers/gpu/drm/i915/i915_driver.c | 26 +++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +-- 2 files changed, 27 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_driver.c +0
-0@@ -1541,6 +1541,31 @@ static int i915_pm_restore(struct device *kdev)return i915_pm_resume (kdev); }
Quoted 15 lines
drivers/gpu/drm/i915/i915_driver.c static int i915_pm_restore(struct device *kdev)
Quoted 12 lines
drivers/gpu/drm/i915/i915_driver.c +12
-0+static int intel_runtime_idle (struct device *kdev) { +struct drm_i915_private *dev_priv =kdev_to_i915 (kdev); +int ret =1 ; + +if (!HAS_LMEM_SR (dev_priv)) { +/*TODO: Prepare for D3Cold-Off */ + goto out; + } + +disable_rpm_wakeref_asserts (&dev_priv->runtime_pm); + + ret =intel_pm_vram_sr (dev_priv, true)I don't get why this idle callback is here. Why aren't you just calling that directly from the suspend handler?
We will be having a D3Cold policy in future to decide between D3Cold-VRAM_SR and D3Cold-Off based upon lmem usages also we need to evict the lmem content if D3cold-off option is used. It will be better to keep it in separate runtime idle call back to prepare the actual suspend.
Thanks,
Anshuman Gupta.
Quoted 44 lines
Quoted 37 lines
drivers/gpu/drm/i915/i915_driver.c +13
-0+if (!ret) +drm_dbg (&dev_priv->drm,"VRAM Self Refresh enabled\n" ); + +enable_rpm_wakeref_asserts (&dev_priv->runtime_pm); + +out: +pm_runtime_mark_last_busy (kdev); +pm_runtime_autosuspend (kdev); + +return ret; +} +static int intel_runtime_suspend (struct device *kdev) { struct drm_i915_private *dev_priv = kdev_to_i915(kdev); @@ -1726,6 +1751,7 @@ const struct dev_pm_ops i915_pm_ops = { .restore = i915_pm_restore,drivers/gpu/drm/i915/i915_driver.c +1
-0/* S0ix (via runtime suspend) event handlers */ + .runtime_idle = intel_runtime_idle, .runtime_suspend = intel_runtime_suspend, .runtime_resume = intel_runtime_resume, }; diff --git
a/drivers/gpu/drm/i915/intel_runtime_pm.cb/drivers/gpu/drm/i915/intel_runtime_pm.c
index6ed5786bcd29..4dade7e8a795100644drivers/gpu/drm/i915/intel_runtime_pm.c +1
-2@@ -492,8 +492,7 @@ static void __intel_runtime_pm_put(structintel_runtime_pm *rpm,intel_runtime_pm_release (rpm ,wakelock ); -pm_runtime_mark_last_busy (kdev); -pm_runtime_put_autosuspend (kdev); +pm_runtime_put (kdev); }Quoted 3 lines
/**
--
2.26.2--
Ville Syrjälä
Intel
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DG2 VRAM_SR Support (rev2)
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: DG2 VRAM_SR Support (rev2)
URL : https://patchwork.freedesktop.org/series/104128/
State : warning
== Summary ==
Error: dim checkpatch failedee8880156960 drm/i915/dgfx: OpRegion VRAM Self Refresh Support 41f57c1513eb drm/i915/dg1: OpRegion PCON DG1 MBD config support b20625f7bd5e drm/i915/dg2: DG2 MBD config
-:40: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #40: FILE: drivers/gpu/drm/i915/i915_drv.h:1081:
+#define IS_DG2_MBD(dev_priv) (IS_DG2(dev_priv) && \
+ (INTEL_DEVID(dev_priv) & DG2_MBD_CONFIG_MASK) == DG2_MBD_CONFIG_VAL)
total: 0 errors, 0 warnings, 1 checks, 23 lines checked 0bcbc42282e2 drm/i915/dgfx: Add has_lmem_srb9322552deed drm/i915/pcode: DGFX PCODE MBOX headers 18499773956c drm/i915/dgfx: Setup VRAM SR with D3COLD
-:96: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #96: FILE: drivers/gpu/drm/i915/intel_pcode.c:247:
+ REG_FIELD_PREP(GEN6_PCODE_MB_COMMAND,
+ DG1_PCODE_D3_VRAM_SR) |
-:98: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #98: FILE: drivers/gpu/drm/i915/intel_pcode.c:249:
+ REG_FIELD_PREP(GEN6_PCODE_MB_PARAM1,
+ DG1_ENABLE_SR), 0); /* no data needed for this cmd */
total: 0 errors, 0 warnings, 2 checks, 127 lines checked f4732fb4b295 drm/i915/rpm: Enable D3Cold VRAM SR Support
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DG2 VRAM_SR Support (rev2)
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: DG2 VRAM_SR Support (rev2)
URL : https://patchwork.freedesktop.org/series/104128/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for DG2 VRAM_SR Support (rev2)
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: DG2 VRAM_SR Support (rev2)
URL : https://patchwork.freedesktop.org/series/104128/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11674 -> Patchwork_104128v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_104128v2 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_104128v2, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/index.html
Participating hosts (48 -> 46)
------------------------------
Additional (1): bat-dg2-8
Missing (3): bat-jsl-2 bat-dg2-9 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_104128v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_suspend@basic-s3-without-i915:
- fi-cml-u2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11674/fi-cml-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/fi-cml-u2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_104128v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: [PASS][3] -> [INCOMPLETE][4] ([i915#4418])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11674/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][5] -> [DMESG-FAIL][6] ([i915#4528])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11674/fi-pnv-d510/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/fi-pnv-d510/igt@i915_selftest@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-cfl-8109u: [PASS][7] -> [DMESG-WARN][8] ([i915#62]) +16 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11674/fi-cfl-8109u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/fi-cfl-8109u/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {fi-ehl-2}: [DMESG-WARN][9] ([i915#5122]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11674/fi-ehl-2/igt@gem_exec_suspend@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/fi-ehl-2/igt@gem_exec_suspend@[email protected]
* igt@i915_selftest@live@gt_mocs:
- {bat-rpls-1}: [DMESG-WARN][11] -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11674/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- fi-tgl-u2: [DMESG-WARN][13] ([i915#402]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11674/fi-tgl-u2/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/fi-tgl-u2/igt@kms_flip@[email protected]
* igt@kms_force_connector_basic@force-connector-state:
- {bat-adlp-6}: [DMESG-WARN][15] ([i915#3576]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11674/bat-adlp-6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/bat-adlp-6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5879]: https://gitlab.freedesktop.org/drm/intel/issues/5879
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#5950]: https://gitlab.freedesktop.org/drm/intel/issues/5950
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
Build changes
-------------
* Linux: CI_DRM_11674 -> Patchwork_104128v2
CI-20190529: 20190529
CI_DRM_11674: 3e53b0d858897e3c1e7c6a661219823df2326b77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6479: 78115aa8c8bcfc7784c7fc8dcaefcc2bce970b99 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_104128v2: 3e53b0d858897e3c1e7c6a661219823df2326b77 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
da724d5a9a3c drm/i915/rpm: Enable D3Cold VRAM SR Support 3bae421e329c drm/i915/dgfx: Setup VRAM SR with D3COLD c26b9211c670 drm/i915/pcode: DGFX PCODE MBOX headers a8385a259aa8 drm/i915/dgfx: Add has_lmem_sr 41465ef36210 drm/i915/dg2: DG2 MBD config 7a779189eee4 drm/i915/dg1: OpRegion PCON DG1 MBD config support ec60b5036c2b drm/i915/dgfx: OpRegion VRAM Self Refresh Support
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104128v2/index.html